Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Log Explorer] Show filter controls in compressed style #166440

Closed
weltenwort opened this issue Sep 14, 2023 · 2 comments · Fixed by #167402
Closed

[Log Explorer] Show filter controls in compressed style #166440

weltenwort opened this issue Sep 14, 2023 · 2 comments · Fixed by #167402
Assignees
Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

📓 Summary

The filter controls we prepend to the unified search bar in the log explorer use up a lot of vertical space and are higher than the filter pills to the right. We want to use EUI's compressed option for the form elements in the control group to reduce that vertical discrepancy.

image

✔️ Acceptance criteria

  • The filter controls are shown using the compressed style.

💡 Implementation hints

  • @weltenwort had to remove a css override on the height a while ago since it broke the alignment of the options list content.
  • This probably entails enhancing the controls plugin with a parameter to specify the compression.
@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@mohamedhamed-ahmed
Copy link
Contributor

After meeting with the Presentation team, we discussed the compressed flag we want to add to the control group in more detail as I found some issues in the component during implementation.

The outcome of the meeting is that it won't be possible to get this done with their current implementation of the control group renderer as they have some limitations there and the impact would be big to get this done and they didn't recommend that this gets implemented now. They are already working on refactoring the whole thing and after the refactoring, it would be much easier to add such functionality.

We came out with 2 solutions for now to achieve a similar effect.

  1. Either we make compressed the default style for the control group everywhere.
  2. Apply some CSS styles to achieve this, similar to what the security team is doing here.

The decision was that it would be better, more straightforward, with fewer side effects to go with solution 2 for now.

mohamedhamed-ahmed added a commit that referenced this issue Sep 27, 2023
closes #166440

This PR applies compressed style to the control group container.

<img width="699" alt="Screenshot 2023-09-27 at 14 44 51"
src="https://github.com/elastic/kibana/assets/11225826/7318c0aa-c00e-44e9-9d29-f2f0deb5b791">
@gbamparop gbamparop added Feature:LogsExplorer Logs Explorer feature and removed Feature:Logs UI Logs UI feature labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants