Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Log Explorer] Show only dataset name for the selector Uncategorized list #166247

Closed
tonyghiani opened this issue Sep 12, 2023 · 3 comments · Fixed by #166703
Closed

[Log Explorer] Show only dataset name for the selector Uncategorized list #166247

tonyghiani opened this issue Sep 12, 2023 · 3 comments · Fixed by #166703
Assignees
@mohamedhamed-ahmed
Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@tonyghiani
Copy link
Contributor

📓 Summary

With the implementation of #162061, we grouped together the dataset of the uncategorized entries.
We want now only the dataset to show up, not the index pattern.

Screenshot 2023-09-12 at 13 24 46

✔️ Acceptance criteria

  • For a given combination of type and dataset, only one "uncategorized" data stream entry is shown, which dataset name.
  • Selecting the entry of an "uncategorized" data stream creates a data view targeting ${type}-${dataset}-*, and render the selected dataset name.

🎨 Examples

  • logs-foo-* ➡️ foo
  • logs-bar-* ➡️ bar

💡 Implementation hints

Updating the implementation of the Dataset model when computing the list setting the title should do the work.
@tonyghiani tonyghiani added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@mohamedhamed-ahmed
Copy link
Contributor

For a given combination of type and dataset, only one "uncategorized" data stream entry is shown, which dataset name.

Could it happen that you get more than 1 combination for the same type and dataset?

@tonyghiani
Copy link
Contributor Author

For a given combination of type and dataset, only one "uncategorized" data stream entry is shown, which dataset name.

Could it happen that you get more than 1 combination for the same type and dataset?

It should not, the dataset is unique

@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this Sep 19, 2023
@mohamedhamed-ahmed mohamedhamed-ahmed mentioned this issue Sep 19, 2023
Merged
mohamedhamed-ahmed added a commit that referenced this issue Sep 20, 2023
@mohamedhamed-ahmed
[Log Explorer] Show only dataset name in dataset selector (#166703)
27056ca 
closes #166247

## 📝  Summary

This PR changes the display of datasets in the dataset selector so that
we only show the dataset name and not the whole index pattern.

ex: 

- `logs-foo-*` ➡️ `foo`
- `logs-bar-*` ➡️ `bar`

## ✅  Testing
1. Navigate to the observability log explorer
2. Click the dataset selector and choose Uncategorized
3. Observe how the datasets are represented

## 🎥 Demo


https://github.com/elastic/kibana/assets/11225826/8a6a1212-46d5-4ceb-bf38-cf13d1b3e555
@gbamparop gbamparop added Feature:LogsExplorer Logs Explorer feature and removed Feature:Logs UI Logs UI feature labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohamedhamed-ahmed mohamedhamed-ahmed

Labels
Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Log Explorer] Show only dataset name in dataset selector mohamedhamed-ahmed/kibana
4 participants
@gbamparop @mohamedhamed-ahmed @elasticmachine @tonyghiani