Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Log Explorer] Embedded Discover is not responsive #166243

Closed
tonyghiani opened this issue Sep 12, 2023 · 1 comment · Fixed by #166429
Closed

[Log Explorer] Embedded Discover is not responsive #166243

tonyghiani opened this issue Sep 12, 2023 · 1 comment · Fixed by #166429
Assignees
@tonyghiani
Labels
bug Fixes for quality problems that affect the customer experience Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@tonyghiani
Copy link
Contributor

📓 Summary

When visiting the Observability Log Explorer which embeds the Discover app, the page loses responsiveness to UI changes, including some elements being positioned out of the viewport.

This only affects consumers of the extracted DiscoverContainer component, the Discover app continues working as expected.

Current behaviour

not-responsive.mov

Expected behaviour

Screen.Recording.2023-09-12.at.12.58.02.mov
@tonyghiani tonyghiani added bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@tonyghiani tonyghiani self-assigned this Sep 13, 2023
@tonyghiani tonyghiani mentioned this issue Sep 14, 2023
Merged
tonyghiani added a commit that referenced this issue Sep 18, 2023
@tonyghiani @kibanamachine
[Log Explorer] Fix embedded Discover responsive view (#166429)
3cfd6b5 
## 📓 Summary

Closes #166243 

Removing the additional flex item for the DiscoverContainer restores the
auto resizing for the container to correctly keep the Discover content
responsive to viewport changes.


https://github.com/elastic/kibana/assets/34506779/645d0c66-fce3-4e98-9d8f-76548153f603

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
@weltenwort weltenwort mentioned this issue Sep 20, 2023
Closed
@gbamparop gbamparop mentioned this issue Sep 20, 2023
Closed
@gbamparop gbamparop added Feature:LogsExplorer Logs Explorer feature and removed Feature:Logs UI Logs UI feature labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyghiani tonyghiani

Labels
bug Fixes for quality problems that affect the customer experience Feature:LogsExplorer Logs Explorer feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs Explorer] Fix embedded Discover responsive view tonyghiani/kibana
3 participants
@gbamparop @elasticmachine @tonyghiani