Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we keep the prefill logic in the custom threshold rule? #165477

Closed
maryam-saeidi opened this issue Sep 1, 2023 · 3 comments
Closed

Should we keep the prefill logic in the custom threshold rule? #165477

maryam-saeidi opened this issue Sep 1, 2023 · 3 comments
Assignees
Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.11.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Sep 1, 2023

📝 Summary

While working on using searchConfiguration.query instead of query field, I noticed that we have some logic to set the query based on the metadata. Bena pointed out that this logic is used in the Metric threshold to prefill the component based on the Metric Explorer view information as shown below: (used in AlertFlyout)

image

image

Now the question is, do we need to keep this logic for the custom threshold?
If no, we need to remove this extra logic.
If yes, we need to see where this logic will be used, considering we also need to select the right data view.

✅ Acceptance Criteria

  • Discuss the usage of prefill logic with @katrin-freihofner and in case it is not needed, clean up the extra code from observability plugin.
@maryam-saeidi maryam-saeidi added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.11.0 labels Sep 1, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi
Copy link
Member Author

After a brief talk with Katrin, she said:
We will no longer use this logic to pre-fill information in the Metric Explorer view, but we want a similar functionality from the new Host view. About which field we want to prefill, we need to check this with the Infra team and @roshan-elastic

@maryam-saeidi
Copy link
Member Author

This logic is covered in #170295

@maryam-saeidi maryam-saeidi closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.11.0
Projects
None yet
Development

No branches or pull requests

4 participants