Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Response Ops][Task Manager] Can we remove the middleware hooks #163401

Open
ymao1 opened this issue Aug 8, 2023 · 1 comment
Open

[Response Ops][Task Manager] Can we remove the middleware hooks #163401

ymao1 opened this issue Aug 8, 2023 · 1 comment
Labels
Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented Aug 8, 2023

Task manager provides the ability to specify middleware hooks that modify the task instance at different points in its lifecycle. Specifically beforeSave that modifies the task instance before persisting it and beforeRun that modifies the task instance loaded from disk before running it. These hooks are currently only used in the task manager functional tests (and the only thing that they're testing is whether the hooks are called as expected). Can we remove them altogether?

@ymao1 ymao1 added Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Aug 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

No branches or pull requests

3 participants