Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Try to make it clear drilldows only available in dashboard #161469

Merged
merged 3 commits into from
Jul 11, 2023
Merged

[Docs] Try to make it clear drilldows only available in dashboard #161469

merged 3 commits into from
Jul 11, 2023

Conversation

amyjtechwriter
Copy link
Contributor

@amyjtechwriter amyjtechwriter commented Jul 7, 2023 •
edited by kibanamachine
Loading

Summary

Issue raised on Slack that it was a bit unclear on our docs page that to use drilldowns you had to embed your map in Dashboard, and can't be used from the Maps application.

Original:
Screenshot 2023-07-07 at 15 32 27

Updated:
Screenshot 2023-07-07 at 11 47 45

@amyjtechwriter amyjtechwriter requested a review from a team July 7, 2023 15:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Documentation preview:

kilfoyle
kilfoyle reviewed Jul 11, 2023
View reviewed changes
docs/maps/search.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle reviewed Jul 11, 2023
View reviewed changes
docs/maps/search.asciidoc Outdated Show resolved Hide resolved
kilfoyle
kilfoyle approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⛵
Just two super, super small suggestions.

amyjtechwriter and others added 2 commits July 11, 2023 14:49
@amyjtechwriter amyjtechwriter merged commit 811fb7c into elastic:main Jul 11, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 11, 2023
@amyjtechwriter
[Docs] Try to make it clear drilldows only available in dashboard (el…
64f0050 
…astic#161469)

## Summary

Issue [raised on
Slack](https://elastic.slack.com/archives/C0D8P2XK5/p1688661541837369)
that it was a bit unclear on our [docs
page](https://www.elastic.co/guide/en/kibana/8.8/maps-create-filter-from-map.html#maps-spatial-filters)
that to use drilldowns you had to embed your map in Dashboard, and can't
be used from the Maps application.

Original:
<img width="808" alt="Screenshot 2023-07-07 at 15 32 27"
src="https://github.com/elastic/kibana/assets/61687663/176e7f22-1bb3-4dd0-95d5-4a601487aa6b">

Updated:
<img width="843" alt="Screenshot 2023-07-07 at 11 47 45"
src="https://github.com/elastic/kibana/assets/61687663/4d33a39f-2cee-4097-b730-3b24d613c498">

---------

Co-authored-by: David Kilfoyle <[email protected]>
(cherry picked from commit 811fb7c)
@kibanamachine kibanamachine mentioned this pull request Jul 11, 2023
Open
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

29 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

Assignees
No one assigned
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.14.0 v7.15.0 v7.16.0 v7.17.0 v8.0.0 v8.1.0 v8.2.0 v8.3.0 v8.4.0 v8.5.0 v8.6.0 v8.7.0 v8.8.0 v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amyjtechwriter @elasticmachine @kibanamachine @kilfoyle