[Security Solution][Detection Engine] Risk score track intervals don't render correctly until re-rendered #160561
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Detection Rules
Security Solution rules and Detection Engine
fixed
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
Team:Detection Engine
Security Solution Detection Engine Area
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.9.0
v8.10.0
Comments
marshallmain
added
bug
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
e40pud
added a commit
that referenced
this issue
Jul 18, 2023
…on Rule Creation page (#161793) ## Summary Original ticket: #161456 These changes do workaround to display EuiRange component which is broken due to memoization (see more details in #160561 and elastic/eui#6846) Before the fix: <img width="435" alt="Screenshot 2023-07-12 at 19 06 01" src="https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f"> After the fix: <img width="426" alt="Screenshot 2023-07-12 at 19 05 46" src="https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7"> --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Vitalii Dmyterko <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jul 18, 2023
…on Rule Creation page (elastic#161793) ## Summary Original ticket: elastic#161456 These changes do workaround to display EuiRange component which is broken due to memoization (see more details in elastic#160561 and elastic/eui#6846) Before the fix: <img width="435" alt="Screenshot 2023-07-12 at 19 06 01" src="https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f"> After the fix: <img width="426" alt="Screenshot 2023-07-12 at 19 05 46" src="https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7"> --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Vitalii Dmyterko <[email protected]> (cherry picked from commit 731f587)
kibanamachine
added a commit
that referenced
this issue
Jul 18, 2023
…rlaid on Rule Creation page (#161793) (#162138) # Backport This will backport the following commits from `main` to `8.9`: - [[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161793)](#161793) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-18T12:36:07Z","message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161793)\n\n## Summary\r\n\r\nOriginal ticket: #161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Vitalii Dmyterko <[email protected]>","sha":"731f5879799b6d2e1e35a4c24cf6440fc60a631a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:cloud-deploy","Team:Detection Engine","v8.10.0","v8.9.1"],"number":161793,"url":"https://github.com/elastic/kibana/pull/161793","mergeCommit":{"message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161793)\n\n## Summary\r\n\r\nOriginal ticket: #161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Vitalii Dmyterko <[email protected]>","sha":"731f5879799b6d2e1e35a4c24cf6440fc60a631a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161793","number":161793,"mergeCommit":{"message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161793)\n\n## Summary\r\n\r\nOriginal ticket: #161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>\r\nCo-authored-by: Vitalii Dmyterko <[email protected]>","sha":"731f5879799b6d2e1e35a4c24cf6440fc60a631a"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this issue
Aug 1, 2023
…on Rule Creation page (elastic#161793) ## Summary Original ticket: elastic#161456 These changes do workaround to display EuiRange component which is broken due to memoization (see more details in elastic#160561 and elastic/eui#6846) Before the fix: <img width="435" alt="Screenshot 2023-07-12 at 19 06 01" src="https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f"> After the fix: <img width="426" alt="Screenshot 2023-07-12 at 19 05 46" src="https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7"> --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Vitalii Dmyterko <[email protected]>
|
@MadameSheema @vgomez-el this issue was fixed by these changes #161793 in 8.9. This one is a duplication of this ticket #161456. Closing this ticket per above. |
e40pud
added a commit
that referenced
this issue
Dec 12, 2023
…on Rule Creation page (#161456) (#172677) ## Summary Addresses #161456 These changes do workaround to display EuiRange component which is broken due to memoization (see more details in #160561 and elastic/eui#6846) The fix is to forcibly remove/add EuiRange component on About step activation. Before the fix: <img width="435" alt="Screenshot 2023-07-12 at 19 06 01" src="https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f"> After the fix: <img width="426" alt="Screenshot 2023-07-12 at 19 05 46" src="https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7">
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Dec 12, 2023
…on Rule Creation page (elastic#161456) (elastic#172677) ## Summary Addresses elastic#161456 These changes do workaround to display EuiRange component which is broken due to memoization (see more details in elastic#160561 and elastic/eui#6846) The fix is to forcibly remove/add EuiRange component on About step activation. Before the fix: <img width="435" alt="Screenshot 2023-07-12 at 19 06 01" src="https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f"> After the fix: <img width="426" alt="Screenshot 2023-07-12 at 19 05 46" src="https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7"> (cherry picked from commit 28d18e8)
kibanamachine
added a commit
that referenced
this issue
Dec 12, 2023
…erlaid on Rule Creation page (#161456) (#172677) (#173140) # Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)](#172677) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-12T10:29:50Z","message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nThe fix is to forcibly remove/add EuiRange component on About step\r\nactivation.\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">","sha":"28d18e89fba53cc1ca5d46bd0b5d0964d0a7c75a","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team: SecuritySolution","backport:prev-minor","Team:Detection Engine","v8.13.0"],"number":172677,"url":"https://github.com/elastic/kibana/pull/172677","mergeCommit":{"message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nThe fix is to forcibly remove/add EuiRange component on About step\r\nactivation.\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">","sha":"28d18e89fba53cc1ca5d46bd0b5d0964d0a7c75a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172677","number":172677,"mergeCommit":{"message":"[Security Solution] Default Risk score slide bar values are overlaid on Rule Creation page (#161456) (#172677)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/161456\r\n\r\nThese changes do workaround to display EuiRange component which is\r\nbroken due to memoization (see more details in\r\nhttps://github.com//issues/160561 and\r\nhttps://github.com/elastic/eui/issues/6846)\r\n\r\nThe fix is to forcibly remove/add EuiRange component on About step\r\nactivation.\r\n\r\nBefore the fix:\r\n\r\n<img width=\"435\" alt=\"Screenshot 2023-07-12 at 19 06 01\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/8deeb59a-712e-4990-9bda-cba31da8f23f\">\r\n\r\nAfter the fix:\r\n\r\n<img width=\"426\" alt=\"Screenshot 2023-07-12 at 19 05 46\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/7556cca0-d78b-453a-ac47-8a2cd3ef73d7\">","sha":"28d18e89fba53cc1ca5d46bd0b5d0964d0a7c75a"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After memoizing the create/edit rule form components in #159635 to fix performance issues, the risk score component interval labels render on top of each other until the user interacts with the risk score component in some way.
The EUI team has recommended not memoizing the component, but we should also look into isolating the problem and fixing the issue upstream in EUI when we have resources.
The text was updated successfully, but these errors were encountered: