Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Welcome page shown when dashboard with ad-hoc data view exists #159628

Closed
stephmilovic opened this issue Jun 13, 2023 · 6 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features good first issue low hanging fruit impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated papercut Small "burr" in the product that we should fix. SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@stephmilovic
Copy link
Contributor

Kibana version:
main/8.9

Elasticsearch version:
main/8.9

Original install method (e.g. download page, yum, from source, etc.):
Run es from snapshot and kibana locally

Describe the bug:

We have added behavior to install a dashboard when a certain type of connector is created: #159075

Starting with a fresh ES, no dashboards or data views. Creating the connector creates the dashboard. However, when we click the link to the dashboard from the connector, the dashboard app takes me to a "Welcome to Analytics! Add your data to get started, ..." empty page. Now add a data view on anything. After adding the data view, the link works, and the dashboard page shows the dashboard, instead of the "Welcome to Analytics" page.

Our GenAI Dashboard uses an ad-hoc data view.

Seems like that welcome page is driven off whether there are data views, but it should be based on whether there are dashboards. Can we please fix this?

Steps to reproduce:

  1. Starting with a fresh ES, no dashboards or data views
  2. Creating a GenAI connector
  3. Open the GenAI Connector edit view from a superuser account
  4. Click the link to the dashboard
  5. Notice Welcome page is shown

Expected behavior:
Dashboard should be shown

@stephmilovic stephmilovic added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 13, 2023
@kibanamachine kibanamachine added loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jun 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

ThomThomson commented Jun 14, 2023

You're correct that this logic is based on if there is a data view present. This is a shared UX component and a common pattern in other apps. This was added here based on this meta issue. I think that potentially rather than changing this to check if there are any Dashboards, the data view check should be extended to also check for ad-hoc data views.

@ThomThomson ThomThomson added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jul 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@ThomThomson
Copy link
Contributor

Reassigning to the shared UX team for now. Ideally this is something that could be fixed in the shared component!

@petrklapka petrklapka added the SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week label Jul 18, 2024
@petrklapka petrklapka added the good first issue low hanging fruit label Sep 18, 2024
@petrklapka petrklapka added the papercut Small "burr" in the product that we should fix. label Oct 17, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Oct 21, 2024
@kowalczyk-krzysztof
Copy link
Member

kowalczyk-krzysztof commented Oct 21, 2024

chrome_RTXiX2YvB3.mp4

I tried to reproduce the issue locally on latest main branch. Couldn't reproduce it as the navigation works properly. I also tried navigating out of Connectors page and going back there manually and the link still works. Same for the Dashboards -> OpenAI Token Usage flow.
It also works fine for Gemini and Amazon Bedrock (all GenAI related connectors). All tests were done on superuser account.

Closing the issue as it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features good first issue low hanging fruit impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated papercut Small "burr" in the product that we should fix. SharedUX/fix-it-week Bugs that have been groomed and queued up for the team's next fix it week Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

8 participants