Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fix Slack connector open API specifications #157026

Merged
merged 2 commits into from
May 8, 2023
Merged

[DOCS] Fix Slack connector open API specifications #157026

merged 2 commits into from
May 8, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented May 8, 2023 •
edited by kibanamachine
Loading

Summary

Relates to #153885

This PR fixes the following validation errors:

npx swagger-cli validate entrypoint.yaml
Error opening file "...kibana/x-pack/plugins/actions/docs/openapi/components/schemas/create_connector_request_slack.yaml" 
ENOENT: no such file or directory, open '...kibana/x-pack/plugins/actions/docs/openapi/components/schemas/create_connector_request_slack.yaml'
...
Error opening file "...kibana/x-pack/plugins/actions/docs/openapi/components/schemas/update_connector_request_slack.yaml" 
...
Error opening file "...kibana/x-pack/plugins/actions/docs/openapi/components/schemas/connector_response_properties_slack.yaml"

When I regenerated the API output files, it also picks up the change from #155392

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.8.0 v8.9.0 labels May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review May 8, 2023 18:06
@lcawl lcawl requested a review from a team as a code owner May 8, 2023 18:06
@lcawl lcawl enabled auto-merge (squash) May 8, 2023 18:07
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit d14ba92 into elastic:main May 8, 2023
@lcawl lcawl deleted the slack-connector-oas branch May 8, 2023 18:51
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.8 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.8:
- [RAM] Docs for slack improvements (#153885)

Manual backport

To create the backport manually run:

node scripts/backport --pr 157026

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to kibanamachine/kibana that referenced this pull request May 8, 2023
@lcawl
[DOCS] Fix Slack connector open API specifications (elastic#157026)
54ebd2b
@lcawl
Copy link
Contributor Author

lcawl commented May 8, 2023

Cherry-picked backport into #156794

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 25, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 157026 locally

8 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 157026 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 157026 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 157026 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 157026 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 157026 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 157026 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 157026 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 157026 locally

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guskovaue guskovaue guskovaue approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backported docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcawl @apmmachine @kibana-ci @kibanamachine @guskovaue @jbudz