Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Provide a way to customize height for the reporting #155400

Open
dej611 opened this issue Apr 20, 2023 · 2 comments
Open

[Reporting] Provide a way to customize height for the reporting #155400

dej611 opened this issue Apr 20, 2023 · 2 comments
Labels
discuss enhancement New value added to drive a business result Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@dej611
Copy link
Contributor

dej611 commented Apr 20, 2023

Describe the feature:

As identified by the investigation in #154894 (comment) reporting is ignoring any passed height size and use a 1200px which becomes an effective ~1086px min height on the final report.
Dashboard is less affected by this problem as usually there are few panels in it, but for some single visualization within the Lens editor (say a Metric or a Gauge) a smaller height can be useful.

Describe a specific use case for the feature:

@dej611 dej611 added enhancement New value added to drive a business result (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Apr 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan removed their assignment Sep 18, 2023
@tsullivan tsullivan added Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export and removed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels Aug 1, 2024
@tsullivan
Copy link
Member

tsullivan commented Oct 25, 2024

I'm not sure there is a way to solve this without fundamentally changing how screenshotting works.

Currently we only use the width parameter to set the width of the headless browser window when the report executes. But, we capture everything in the visualization's DOM element, even pixels that are "below the fold." Therefore the height field from the report job's layout parameters ends up not being used.

Basically, if a smaller height is needed, then the application would need to render the visualization using a smaller height somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New value added to drive a business result Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

4 participants