Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Field formatters] provide guidance to user on bit formatting #154188

Closed
Tracked by #163011
drewdaemon opened this issue Mar 31, 2023 · 7 comments · Fixed by #204346
Closed
Tracked by #163011

[Field formatters] provide guidance to user on bit formatting #154188

drewdaemon opened this issue Mar 31, 2023 · 7 comments · Fixed by #204346
Assignees
Labels
Feature:FieldFormatters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@drewdaemon
Copy link
Contributor

Describe the feature:
Right now, the way you specify a bit field format is by selecting bytes and creating a numeral.js pattern that specifies that what you really want is bits.

Screenshot 2023-03-27 at 18 06 56

Could we make this more clear by providing some copy around the input or some inline documentation?

@drewdaemon drewdaemon added Feature:FieldFormatters Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Mar 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@drewdaemon
Copy link
Contributor Author

cc @dej611 @stratoula for visibility

@kertal
Copy link
Member

kertal commented Apr 11, 2023

Maybe there could be a section to provide helpful examples? I assume you were working on something, could you care what was your use case? An actual example is always helpful, thx!

@drewdaemon
Copy link
Contributor Author

@kertal due to some requests around bit formatting on the Lens metric, we were evaluating adding a bit field formatter. We decided that wasn't high priority since you can already use the bytes formatter with a custom numeral.js format pattern.

However, it seemed like this workaround wasn't very clear from our UI (i.e. the user might look for a bits field formatter in the list). That's why we created this issue.

@kertal
Copy link
Member

kertal commented Apr 12, 2023

Maybe we should relabel it into something like Bits & Bytes

@drewdaemon
Copy link
Contributor Author

Maybe we should relabel it into something like Bits & Bytes

Not a bad idea.

@KOTungseth KOTungseth added loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Apr 13, 2023
@kertal kertal added the Icebox label Sep 23, 2024
@kertal kertal removed the Icebox label Oct 22, 2024
@ghudgins
Copy link
Contributor

I would suggest Bytes and Bits just so it's easier to find for returning user who is used to Bytes that we have today. can we go with this solution? @l-suarez any objections from the design side?

@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Dec 16, 2024
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Dec 19, 2024
…#204346)

## Summary

This PR updates the `title` of `Bytes` field to `Bytes and Bits` as
suggested in
elastic#154188 (comment)

Closes: elastic#154188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:FieldFormatters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants