Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APM plugin should add an Upgrade Assistant link only when UA is enabled #152704

Open
yuliacech opened this issue Mar 6, 2023 · 4 comments
Open

APM plugin should add an Upgrade Assistant link only when UA is enabled #152704

yuliacech opened this issue Mar 6, 2023 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Upgrade Assistant Team:APM All issues that need APM UI Team support Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

The APM plugin adds a link to Upgrade Assistant to the help menu (see here). The Upgrade Assistant can be hidden from the UI (without disabling the plugin) with the config xpack.upgrade_assistant.ui.enabled: false. We also plan to add a config to disable the plugin completely xpack.upgrade_assistant.enabled: false.
So the help link could lead to a hidden/disabled plugin. I think it should check if UA is available first before adding it.

Screenshot

Screenshot 2023-03-06 at 13 09 17
@yuliacech yuliacech added Team:APM All issues that need APM UI Team support Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant labels Mar 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@gbamparop gbamparop added the bug Fixes for quality problems that affect the customer experience label Mar 27, 2023
@rayafratkina
Copy link
Contributor

We are preparing UA for next major. Is this issue still relevant?

@alisonelizabeth
Copy link
Contributor

It looks like the code has moved, but the issue is still relevant.

See: https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/apm/public/components/shared/links/kibana.ts#L12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Upgrade Assistant Team:APM All issues that need APM UI Team support Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alisonelizabeth @gbamparop @yuliacech @elasticmachine @rayafratkina