[Security Solution] Build a package for CellActions component. #145663
Assignees
Labels
8.7 candidate
Team:Threat Hunting:Explore
Team:Threat Hunting
Security Solution Threat Hunting Team
technical debt
Improvement of the software architecture and operational architecture
Comments
YulNaumenko
added
technical debt
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
This was referenced Nov 18, 2022
6 tasks
machadoum
added a commit
that referenced
this issue
Jan 11, 2023
## Summary Create security solutions UI actions and register them. These actions will be used in a [follow-up PR](#148056). This PR is part of [UI actions refactor](#145663) effort ### Implementation details It creates `filter-in`, `filter-out`, `copy-to-clipboard`, `add-to-timeline`, and `show-top-n` security solution actions. We can't reuse actions used on embeddable because they have a different context interface, which makes `execute` and `isCompatible` implementations slightly different. But they do share code. This PR also creates and registers `filter-in` and `filter-out` actions for the timeline because the timeline doesn't use the global filter manager. Instead, it uses the filter manager that is inside the timeline store. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) Co-authored-by: kibanamachine <[email protected]>
YulNaumenko
changed the title
jennypavlova
pushed a commit
to jennypavlova/kibana
that referenced
this issue
Jan 13, 2023
## Summary Create security solutions UI actions and register them. These actions will be used in a [follow-up PR](elastic#148056). This PR is part of [UI actions refactor](elastic#145663) effort ### Implementation details It creates `filter-in`, `filter-out`, `copy-to-clipboard`, `add-to-timeline`, and `show-top-n` security solution actions. We can't reuse actions used on embeddable because they have a different context interface, which makes `execute` and `isCompatible` implementations slightly different. But they do share code. This PR also creates and registers `filter-in` and `filter-out` actions for the timeline because the timeline doesn't use the global filter manager. Instead, it uses the filter manager that is inside the timeline store. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) Co-authored-by: kibanamachine <[email protected]>
|
Resolved by #149057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to the Epic issue #144943
The goal of the current issue is to move
CellActionscomponent outside fromuiActionsplugin.This is possible now, after providing the ability to reference types from the plugins.
The text was updated successfully, but these errors were encountered: