-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Investigations][Analyzer] - Update analyzer snapshots #145620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelolo24
added
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting:Investigations
Security Solution Investigations Team
v8.6.0
v8.7.0
labels
Nov 17, 2022
michaelolo24
force-pushed
the
update-resolver-snapshots
branch
from
November 18, 2022 13:45
ba113df
to
8b8b786
Compare
michaelolo24
force-pushed
the
update-resolver-snapshots
branch
from
November 18, 2022 13:46
8b8b786
to
30ceb39
Compare
@elasticmachine merge upstream |
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
@michaelolo24 should we keep this PR open? It's now nearly 2 years old, do you think we will going to merge it one day? |
@michaelolo24 can we close this PR? |
1 similar comment
@michaelolo24 can we close this PR? |
yes. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting:Investigations
Security Solution Investigations Team
v8.6.0
v8.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
unskips: #144861
There were changes recently made to the analyzer
process_event_dot.tsx
anduse_cube_assets.ts
files in resolver as part of an EUI update. These changes introduced text style changes that can be seen in the snapshots associated with this PR. The text classeuiButton__text
is no longer valid, so the snapshots were updated to match the new text styling.https://github.com/elastic/kibana/pull/141279/files#diff-cecb552a872ae8cd7ea7db82f8a7526256e8095f5e08d92adc7307b4e4425eaf
https://github.com/elastic/kibana/pull/141279/files#diff-cc175e3ef6627e719a6042d5f5540b3d53e21d41bb654f63e78e4e5b831e093d