Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Investigations][Analyzer] - Update analyzer snapshots #145620

Closed

Conversation

michaelolo24
Copy link
Contributor

@michaelolo24 michaelolo24 commented Nov 17, 2022

Summary

unskips: #144861

There were changes recently made to the analyzer process_event_dot.tsx and use_cube_assets.ts files in resolver as part of an EUI update. These changes introduced text style changes that can be seen in the snapshots associated with this PR. The text class euiButton__text is no longer valid, so the snapshots were updated to match the new text styling.

https://github.com/elastic/kibana/pull/141279/files#diff-cecb552a872ae8cd7ea7db82f8a7526256e8095f5e08d92adc7307b4e4425eaf

https://github.com/elastic/kibana/pull/141279/files#diff-cc175e3ef6627e719a6042d5f5540b3d53e21d41bb654f63e78e4e5b831e093d

@michaelolo24 michaelolo24 added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.6.0 v8.7.0 labels Nov 17, 2022
@michaelolo24 michaelolo24 force-pushed the update-resolver-snapshots branch from ba113df to 8b8b786 Compare November 18, 2022 13:45
@michaelolo24 michaelolo24 force-pushed the update-resolver-snapshots branch from 8b8b786 to 30ceb39 Compare November 18, 2022 13:46
@michaelolo24
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Feb 9, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver handling of entity ids ancestors "after all" hook for "does not query for ancestors that have an empty string for the entity_id"
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver handling of entity ids ancestors does not query for ancestors that have an empty string for the entity_id
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver handling of entity ids children "after all" hook for "does not find children without a process entity_id"
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver handling of entity ids children does not find children without a process entity_id
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver handling of entity ids entity api "after all" hook for "excludes events that have an empty entity_id field"
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree ancestry and descendants returns all descendants and ancestors with the ancestry field
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree ancestry and descendants returns all descendants and ancestors without the ancestry field
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree ancestry and descendants returns all descendants and ancestors without the ancestry field and they should have the name field
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree ancestry events should return a single ancestry when two nodes a the same level and from same parent are requested
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree ancestry events should return a subset of the ancestors
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree ancestry events should return ancestors without the ancestry array
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree ancestry events should return the correct ancestor nodes for the tree
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree ancestry events should support returning multiple ancestor trees when multiple nodes are requested
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree descendant events returns a single generation of children
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree descendant events returns all descendants for the origin using the ancestry field
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree descendant events returns all descendants for the origin without using the ancestry field
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree descendant events should respect the time range specified and only return one descendant
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree descendant events should support returning multiple descendant trees when multiple nodes are requested
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree descendant events should support returning multiple descendant trees when multiple nodes are requested at different levels
  • [job] [logs] FTR Configs #39 / Endpoint plugin Resolver tests Resolver tree descendant events should support returning multiple descendant trees when multiple nodes are requested at different levels without ancestry field
  • [job] [logs] FTR Configs #33 / Fleet Endpoints EPM Endpoints installs package that has a prerelease version should bulk install the beta packages when prerelease is true
  • [job] [logs] FTR Configs #33 / Fleet Endpoints EPM Endpoints installs package that has a prerelease version should bulk install the beta packages when prerelease is true
  • [job] [logs] FTR Configs #33 / Fleet Endpoints EPM Endpoints installs package that has a prerelease version should bulk install the GA packages when prerelease is not set
  • [job] [logs] FTR Configs #33 / Fleet Endpoints EPM Endpoints installs package that has a prerelease version should bulk install the GA packages when prerelease is not set
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin when the user hovers over the primary button should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin when the user hovers over the primary button should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) when the user has moved their mouse off of the primary button (and onto the zoom controls.) should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) when the user has moved their mouse off of the primary button (and onto the zoom controls.) should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) when the user has moved their mouse off of the primary button (and onto the zoom controls.) when the user hovers over the first pill should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) when the user has moved their mouse off of the primary button (and onto the zoom controls.) when the user hovers over the first pill should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) when the user has moved their mouse off of the primary button (and onto the zoom controls.) when the user hovers over the first pill when the user clicks on the first pill should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: origin when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) when the user has moved their mouse off of the primary button (and onto the zoom controls.) when the user hovers over the first pill when the user clicks on the first pill should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: secondChild should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: secondChild should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) when the user has moved their mouse off of the primary button (and onto the zoom controls.) should render as expected
  • [job] [logs] FTR Configs #22 / Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) when the user has moved their mouse off of the primary button (and onto the zoom controls.) should render as expected

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti
Copy link
Contributor

@michaelolo24 should we keep this PR open? It's now nearly 2 years old, do you think we will going to merge it one day?

@PhilippeOberti
Copy link
Contributor

@michaelolo24 can we close this PR?

1 similar comment
@PhilippeOberti
Copy link
Contributor

@michaelolo24 can we close this PR?

@michaelolo24
Copy link
Contributor Author

@michaelolo24 can we close this PR?

yes. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.6.0 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants