[Security Solution][Alerts] change ownership for components used in rule create/edit #145420
Assignees
Labels
consider-next
refactoring
Team:Detection Engine
Security Solution Detection Engine Area
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.8.0
Comments
vitaliidm
added
refactoring
Team:Detections and Resp
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
vitaliidm
changed the title
yctercero
added
Team:Detection Engine
vitaliidm
added a commit
that referenced
this issue
Jan 8, 2024
…ate/edit form components (#173906) ## Summary - addresses #145420 - moves almost all of the components from `/x-pack/plugins/security_solution/public/detections/components/rules` to - `x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui/components` , **rule_creation_ui** components that used only in rule creation are placed here - `x-pack/plugins/security_solution/public/detection_engine/rule_creation/components` , **rule_creation** components that used also in another areas(details, or rule tables), placed here - some of the basic components, like `technical_preview_badge` or `severity_badge` moved to common area: `x-pack/plugins/security_solution/public/common/components` The rest of the components, used by rule-management team only, left `/x-pack/plugins/security_solution/public/detections/components/rules`. **rule_creation** and **rule_creation_ui** folders owned by detection-engine team ## Next steps? Since the main purpose of this PR to change codeownership of components, there are still quite a few places where different types are imported from `rule_creation_ui` folder. [For example](https://github.com/elastic/kibana/pull/173906/files#diff-4162e1e577d6b1891a6865ffea6950a9e8a04183e4ea345659bd04fd31ed135dR23). Type `FieldValueQueryBar` is imported in timeline component. With this refactoring, it becomes much easier to identify such imports and refactor it further in future --------- Co-authored-by: kibanamachine <[email protected]>
|
addressed in #173906 |
|
Further refactoring can be continued in https://github.com/elastic/security-team/issues/8363 |
delanni
pushed a commit
to delanni/kibana
that referenced
this issue
Jan 11, 2024
…ate/edit form components (elastic#173906) ## Summary - addresses elastic#145420 - moves almost all of the components from `/x-pack/plugins/security_solution/public/detections/components/rules` to - `x-pack/plugins/security_solution/public/detection_engine/rule_creation_ui/components` , **rule_creation_ui** components that used only in rule creation are placed here - `x-pack/plugins/security_solution/public/detection_engine/rule_creation/components` , **rule_creation** components that used also in another areas(details, or rule tables), placed here - some of the basic components, like `technical_preview_badge` or `severity_badge` moved to common area: `x-pack/plugins/security_solution/public/common/components` The rest of the components, used by rule-management team only, left `/x-pack/plugins/security_solution/public/detections/components/rules`. **rule_creation** and **rule_creation_ui** folders owned by detection-engine team ## Next steps? Since the main purpose of this PR to change codeownership of components, there are still quite a few places where different types are imported from `rule_creation_ui` folder. [For example](https://github.com/elastic/kibana/pull/173906/files#diff-4162e1e577d6b1891a6865ffea6950a9e8a04183e4ea345659bd04fd31ed135dR23). Type `FieldValueQueryBar` is imported in timeline component. With this refactoring, it becomes much easier to identify such imports and refactor it further in future --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Folder
public/detection_engine/rule_creation_uihas codeownership of alerts areaBut most of components and logic used there is located in
/x-pack/plugins/security_solution/public/detections/components/rules, which is@elastic/security-detections-response-rulesarea responsibility.Proposal
public/detection_engine/rule_creation_uito its folderor move them to common area
The text was updated successfully, but these errors were encountered: