Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise configuring-metricbeat documentation #139338

Open
matschaffer opened this issue Aug 24, 2022 · 3 comments
Open

Revise configuring-metricbeat documentation #139338

matschaffer opened this issue Aug 24, 2022 · 3 comments

Comments

@matschaffer
Copy link
Contributor

As called out on this forum post the configuring-metricbeat doc for elasticsearch is quite confusing.

  1. You shouldn't need to change any ES settings (except maybe to remove legacy settings)
  2. There's some disagreement between this doc and https://github.com/elastic/beats/blob/main/metricbeat/module/elasticsearch/_meta/docs.asciidoc regarding which nodes the LB should point to when running in scope: cluster

Also, internally we use scope: node, so I'm wondering if we should make that the recommended configuration.

I'm just guessing, but I think the original scope: cluster + non-master recommendation was made with the idea that we would try not to burden the master with monitoring info.

But the non-master would have to retrieve cluster information from the master internally to satisfy the request either way.

@matschaffer matschaffer added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring labels Aug 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@matschaffer
Copy link
Contributor Author

@DaveCTurner
Copy link

But the non-master would have to retrieve cluster information from the master internally to satisfy the request either way.

This is not correct. Most stats requests are peer-to-peer things that do not need to involve the master node, and for the ones which do involve the master node in some way we typically find ways to streamline that involvement in newer versions (see e.g. elastic/elasticsearch#101805). Even offloading the JSON rendering to other nodes can be valuable in large enough clusters.

Also, internally we use scope: node, so I'm wondering if we should make that the recommended configuration.

While I agree that we should internally use the configuration we recommend to others, we can solve that by either changing the recommendation or by changing the configuration we use internally. This isn't the place to discuss that, but ask me privately if you'd like more context :)

TLDR the recommendation to avoid sending stats requests to dedicated master nodes is as valid today as ever.

@smith smith added Team:Monitoring Stack Monitoring team and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants