-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboards] give embeddable a say in panel dimensions #136995
Comments
Pinging @elastic/kibana-presentation (Team:Presentation) |
Related to #136993 |
I could not agree more on this issue. 👍🏻 We should guide the users. Skaermoptagelse.2023-08-08.kl.15.56.37.mov |
Closing because embeddables can set their initial dimensions, but we don't want to set hard restrictions on panel size so our authors have the freedom to make any layout they choose. RE: 1x1 panels, we want to increase the minimum dimensions allowed for a panel to avoid this situation: #144753 and we will address this as part of our new layout engine work. |
@cqliu1 could you please provide specifics on this existing capability? |
@drewdaemon embeddable factories can add a The API may change in the new Embeddable system, but the base concept / capability will remain. |
Describe the feature:
Giving embeddables power to inform the containing panel's dimensions. The embeddable could supply
This could improve both appearance and accessibility. For example, if the Lens metric is created with the default panel size today, there is a great deal of distance between the label and the data. This is not true to the intent of the design and makes comprehension harder, especially for visually-impaired users.
#136567 adds a new API for embeddables to inform the panel of display preferences. This could be extended to panel dimensions.
Describe a specific use case for the feature:
Lens visualizations can look very wonky if they are at the wrong aspect ratio. This feature would
Related to #136993
The text was updated successfully, but these errors were encountered: