Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate core domain services to packages: Server-side deprecations service #135961

Closed
TinaHeiligers opened this issue Jul 7, 2022 · 2 comments · Fixed by #139789
Closed

Migrate core domain services to packages: Server-side deprecations service #135961

TinaHeiligers opened this issue Jul 7, 2022 · 2 comments · Fixed by #139789
Assignees
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@TinaHeiligers
Copy link
Contributor

Part of #134112
See #134137 for more context

Extract the Deprecations service/domain (src/core/server/deprecations) to packages.

Depends on:

  • http
  • saved_objects (route handler context, for the scoped client)
  • elasticsearch (route handler context, for the scoped client)

New packages:

@kbn/core-deprecations-common (public types shared between server & browser)
@kbn/core-deprecations-server
@kbn/core-deprecations-server-internal
@kbn/core-deprecations-server-mocks
?? @kbn/core-deprecations-common-internal (Only needed if we need to share internal implementations between browser and server)

Dependency analysis:

Core-services:

http:

import { InternalHttpServiceSetup } from '../http';

saved_objects (client contract)

import { SavedObjectsClientContract } from '../saved_objects/types';

elasticsearch (client)

import { IScopedClusterClient } from '../elasticsearch/client';

Other:

@kbn/i18n
@kbn/logging
@kbn/config
@kbn/core-base-server-internal
@kbn/utility-types (mocks)
@kbn/std

@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 7, 2022
@TinaHeiligers TinaHeiligers added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc EnableJiraSync labels Jul 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 7, 2022
@TinaHeiligers TinaHeiligers changed the title Migrate types to packages: Server-side deprecations service Migrate core domain services to packages: Server-side deprecations service Jul 8, 2022
@pgayvallet
Copy link
Contributor

#139305 had to migrate the public type of the deprecation domain, and already migrated the public type to @kbn/core-deprecations-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants