New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Add Previous Snooze button #128539

Merged

Zacqary merged 6 commits into elastic:main from Zacqary:128301-prev-snooze-ui

Mar 30, 2022

Contributor

Zacqary commented Mar 24, 2022 •

edited

Loading

Summary

Closes #128301

Adds storage of the previously selected snooze time to the Rules List. To test:

Snooze one rule
Open the snooze dialog for another rule. Ensure the Previous button is there, it shows the same time you just selected, and that it works.
Snooze another rule for a different length of time. Ensure that the Previous button shows this new time when you try to snooze another rule.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

Zacqary added 2 commits

March 24, 2022 15:20


          Add Previous snooze button

15b23c0


          Fix typo in i18n

de4094e

Zacqary added release_note:enhancement Team:ResponseOps Feature:Alerting/RulesManagement ci:deploy-cloud v8.2.0 labels

Zacqary marked this pull request as ready for review

March 28, 2022 18:49

Zacqary requested a review from a team as a code owner

March 28, 2022 18:49

Contributor

elasticmachine commented Mar 28, 2022

Pinging @elastic/response-ops (Team:ResponseOps)

Zacqary enabled auto-merge (squash)

March 28, 2022 18:49


          Merge remote-tracking branch 'upstream/main' into 128301-prev-snooze-ui

dd53840

JiaweiWu reviewed

View reviewed changes

Contributor

JiaweiWu left a comment

LGTM, just a some small comments, I'll let others approve :)

...plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list.tsx Outdated Show resolved Hide resolved

...iggers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.tsx Outdated Show resolved Hide resolved

Contributor

chrisronline commented Mar 28, 2022 •

edited

Loading

~~I'm confused by what this is doing. It just seems to show the current interval.~~

~~I'd expect it to show the one I set before - is that not the intended behavior?~~

Contributor

chrisronline commented Mar 29, 2022

Clarification on #128539 (comment)

I see now - it's to provide the last snooze duration for other rules - makes sense and disregard!

Contributor

chrisronline commented Mar 29, 2022

What if we didn't show the previous UI element if the unit time/interval is the same? It's a weird UX to me.

Maybe something like:


          Fix spacing and prevSnooze error handling

d100aa6

Contributor Author

Zacqary commented Mar 30, 2022

@mdefazio can you advise on @chrisronline's feedback?

What if we didn't show the previous UI element if the unit time/interval is the same? It's a weird UX to me.

Maybe something like:


          Merge upstream/main into Zacqary/128301-prev-snooze-ui

aa038e6

Zacqary force-pushed the 128301-prev-snooze-ui branch from 098a145 to aa038e6 Compare

March 30, 2022 16:27


          Disable previous snooze button if selected snooze is the same

f324e3f

Contributor Author

Zacqary commented Mar 30, 2022

I'm gonna just implement @chrisronline's UX suggestion because it's a simple one-line change, we can revert if we don't like it.

JiaweiWu approved these changes

View reviewed changes

Contributor

JiaweiWu left a comment

I think we should have a small unit test for the previous button, but other than that LGTM!

Zacqary merged commit 1851e1b into elastic:main

Collaborator

kibana-ci commented Mar 30, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	699.4KB	700.1KB	+735.0B

History

💚 Build #34180 succeeded dd53840
💚 Build #33689 succeeded de4094e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine added the backport missing label

Contributor

kibanamachine commented Apr 1, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128539 or prevent reminders by adding the backport:skip label.

Contributor

mdefazio commented Apr 4, 2022

Apologies for not reviewing this feedback earlier—was out on PTO. I like @chrisronline 's suggestion here!

Contributor

kibanamachine commented Apr 4, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128539 or prevent reminders by adding the backport:skip label.

Contributor

kibanamachine commented Jan 20, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

27 similar comments

Contributor

kibanamachine commented Jan 23, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jan 24, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jan 25, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jan 26, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jan 27, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jan 30, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jan 31, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Feb 1, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Feb 2, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Feb 3, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Feb 6, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Feb 7, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Feb 8, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Feb 9, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Dec 12, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Dec 24, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Dec 25, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Dec 27, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Dec 28, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Dec 30, 2023

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jan 3, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jan 7, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jan 8, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jan 9, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jan 13, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Jul 13, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

Contributor

kibanamachine commented Sep 2, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 128539 locally

cnasikas added backport:skip and removed backport missing labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip ci:cloud-deploy Feature:Alerting/RulesManagement release_note:enhancement Team:ResponseOps v8.2.0