Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix accessibility failures #126606

Open
MiriamAparicio opened this issue Mar 1, 2022 · 3 comments
Open

[APM] Fix accessibility failures #126606

MiriamAparicio opened this issue Mar 1, 2022 · 3 comments
Labels
a11y Accessibility issue obs-accessibilty A11Y issues in the Obs. solution. Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@MiriamAparicio
Copy link
Contributor

As part of adding A11y test for APM #104692, failures on APM need to be fixed

What is expected

Now we can see the errors logged when running the e2e with cypress, but the tests are not failing.
When accessibility violations are detected, tests will fail and an entry titled "A11Y ERROR!" will appear to the command log for each type of violation found (they will be above the failed assertion). Clicking on those will reveal more specifics about the error in the DevTools console.

image

  • Fix the failures, there are the same for all pages and test suites

  • Change the parameter skipFailures to false in checkA11y() in the e2e test
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 1, 2022
@MiriamAparicio MiriamAparicio added Team:APM All issues that need APM UI Team support and removed needs-team Issues missing a team label labels Mar 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@smith smith added technical debt Improvement of the software architecture and operational architecture Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@smith smith added obs-accessibilty A11Y issues in the Obs. solution. and removed Team:APM All issues that need APM UI Team support labels Oct 14, 2024
@alexwizp alexwizp added a11y Accessibility issue and removed Project:Accessibility labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y Accessibility issue obs-accessibilty A11Y issues in the Obs. solution. Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smith @elasticmachine @alexwizp @MiriamAparicio