-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Add setting to specify default environment #126091
Comments
Pinging @elastic/apm-ui (Team:apm) |
@sqren What happens if the user hasn't set a default environment? Are we setting it to IMO, I still think we need to figure this out in a more dynamic way or where we default to |
@chrisdistasio @alex-fedotyev are there any specific telemetry requirements you would want here? |
At this point, will we keep the |
Yes, All option stays. The idea is to make it possible for users to have a primary environment that they filter on by default.
As we discussed, the idea was to default to All environments (like today) if no default environment is specified. But I'm open to defaulting to a specific environment (eg. "production"). This would be a very user-facing change but it would also add value up front. |
@sqren, at what level is the setting set/persisted? is it at a global level; space level, service group level, user level? i imagine some users might desire a different default than their colleagues. @dannycroft from a telemetry perspective it would be good to know whether a customer has configured the setting and what the default has been configured to. cc: @alex-fedotyev |
Advanced settings are space level. User level would be great but that's a feature request for the kibana platform.
@dgieselaar is looking into adding telemetry around settings usage (if it's not already available) |
It's collected by default, but only for the default space. I'd say that's acceptable for us, thoughts? |
Great! Yeah, I'd say that's enough to get us started. |
Thanks @sqren. Do we have the ability in APM to persist a user setting as a cookie? So whatever setting I previously set will be the in-place setting next I log in? |
We use local storage in some places in APM to store minor view settings: show/hide advanced stats in correlations, if the user has dismissed the anomaly callout, and migration status for continuity between page refreshes. Also in service groups we use it to store group orientation (grid vs list). It's possble to persist selected environment here as well, however the list of selectable environments might change depending on time range, so it could still get into an state were we need to fall back to a default setting. |
Related to elastic/apm-server#4468
Related to: #126100
Currently the UI defaults to showing data across all environments. This creates a bad initial experience since mixing environments creates unexpected results. ML jobs are restricted to specific environments so won't show up in this case. Additionally querying across all environments can be very slow, if there are many environments with lots of data.
To solve this we should make it possible for users to specify a default environment.
TODO:
The text was updated successfully, but these errors were encountered: