-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs flyout enhancements for use on APM service logs view #125869
Comments
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
@cyrille-leclerc, thanks for illustrating the changes! I'd like to ask some questions to increase the clarity further:
Should the link just navigate to the log stream at the specific time or should it also open the fly-out? We don't yet have a stable link schema for the latter, but it could be added.
Since Discover requires an underlying data view this would only be available if the log source was configured to use a data view itself. Would that be acceptable?
The id is shown in the title of the flyout. What would make it "easier" to access if it was added to the table? |
Thank you very much @weltenwort for your detailed review of my requests.
I would like to link to a specific log message with "expanded view on this details". Today the way to visualize the details of a log message is the flyout so it would ideally be a link to the opened flyout. I am not a huge fan of the flyout because it prevents from inspecting multiple log lines in parallel. I have the same problem in our trace explorer, I would prefer our GUI to expand a fragment of the underlying screen rather than introducing a modal flyout.
I think so because configuring our logs explorer with a data view will be our recommended setup. Longer term, we should aim at supporting the same selection of underlying dataset in all screens. I think the ongoing search unification initiative (cc @jasonrhodes and @smith ) is our solution to make our GUIS more consistent.
I was searching for the By the way, why don't we reuse the Kibana Discover Flyout? |
Yes, it's quite obtrusive. But that change would warrant a separate design effort.
Yes, that sounds good.
I see. They must be explicitly merging the meta fields into the fly-out's field list. We could do that as well.
Because our fly-out is older than Discover's. Until Discover recently changed their rendering to the data grid they used to expand the details of the documents inline. I don't know if it is written in a way that we can re-use it and add special elements like the links to APM and Uptime. |
_id
_id
Please note that I added the following enhancements to this umbrella ticket:
💯 replacing the flyout by inlined details would be a big effort, broader than just this use case, not to be worked on for the moment but hopefully food for thoughts for our product design team (cc @katefarrar ) |
@weltenwort as discussed, I broke down this umbrella enhancement request in 5 sub tickets. |
nice, thank you! I'll ask any further refining questions on the individual issues |
_id
Closing this in favor of #134412. |
Describe the feature:
When troubleshooting and viewing a log entry from the "Log Entry Details" flyout of the Logs App, we want:
_id
field on log entry flyout #129607Example of Kibana Discover flyout (v8.1, new display)
The text was updated successfully, but these errors were encountered: