Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Rules do not support standalone clusters #125303

Open
neptunian opened this issue Feb 10, 2022 · 7 comments
Open

[Stack Monitoring] Rules do not support standalone clusters #125303

neptunian opened this issue Feb 10, 2022 · 7 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Stack Monitoring Team:Monitoring Stack Monitoring team

Comments

@neptunian
Copy link
Contributor

neptunian commented Feb 10, 2022

if a cluster_uuid has a value of '' or it does not exist, its considered a standalone cluster. We typically do not try to filter by the cluster_uuid if we are in the context of a standalone cluster. However alerts does not get standalone clusters when fetching clusters and then it proceeds to filter the rule query with the cluster ids that will never match this standalone cluster. Like the createQuery helper function that many other queries use, we should not include a filter for standalone clusters.

This was discovered in Logstash but I think Elasticsearch could be a standalone cluster.

@neptunian neptunian added bug Fixes for quality problems that affect the customer experience Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Feb 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@neptunian neptunian changed the title [Stack Monitoring] Rules do not support standalone clusters [Stack Monitoring] Rules do not support standalone clusters (Logstash) Feb 10, 2022
@neptunian neptunian changed the title [Stack Monitoring] Rules do not support standalone clusters (Logstash) [Stack Monitoring] Rules do not support standalone clusters Feb 11, 2022
@matschaffer
Copy link
Contributor

This has some intersection with #125401 where we aim to catalog/ensure more products can be monitored in "standalone" mode.

@matschaffer matschaffer self-assigned this Mar 8, 2022
@matschaffer
Copy link
Contributor

With #125401 open it's a little unclear which stack components I should be targeting. I'll start with logstash and https://github.com/elastic/kibana/blob/270adf49587db4f77dbe3c46f41f92e5d739b6c1/x-pack/plugins/monitoring/server/alerts/logstash_version_mismatch_rule.ts since I know that can run in standalone mode.

Could be once I see how to adapt that, it'll just work for all rules.

But given the lack of clarity on that, I think I'm going to call this a medium.

@matschaffer
Copy link
Contributor

Moving this back to ready to pick up some higher priority issues.

@matschaffer
Copy link
Contributor

matschaffer commented Mar 9, 2022

To "stash" my mental state on this one:

Logstash is easy to run in standalone mode and it has a rule for checking version mixing, so I did this to run 8.0.0 and 8.0.1 at the same time.

two_logstash_versions.zip

With that in hand I think we should be able to modify something in this space to handle standalone (uuid: '') as well

@matschaffer matschaffer removed their assignment Mar 9, 2022
@jasonrhodes
Copy link
Member

Everything about cluster_uuid = "" -> "standalone cluster" makes me feel nervous and queasy. I don't want to blow this issue up if there's an easy fix, though, so let's try to figure that out?

However alerts does not get standalone clusters when fetching clusters

@neptunian do you mind explaining what this means a little more? I'm having trouble understanding the issue here and it feels like this ticket is in a limbo state, a little bit.

@matschaffer
Copy link
Contributor

Everything about cluster_uuid = "" -> "standalone cluster" makes me feel nervous and queasy.

Me too, but unfortunately it's how things work today. ;)

export const standaloneClusterFilter = {
bool: {
should: [
{
term: {
cluster_uuid: {
value: '',

@smith smith added Team:Monitoring Stack Monitoring team and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Stack Monitoring Team:Monitoring Stack Monitoring team
Projects
None yet
Development

No branches or pull requests

5 participants