-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[field formatters] Unable to enter hex code for color formatter due to lack of rendering space #123527
Comments
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
@mattkime Can I look into this? |
@rushilp2311, sure! Go ahead :) |
Hi, @Dosant! I'm coming into this conversation a bit sideways, but I did have a quick thought regarding one possible way to address your color formatting spatial concerns. I've put together a quick little mockup below of that thought: I thought it may be better to save space by taking advantage of the fact that Let me know if this suggestion helps, or if you require additional support. Thanks! |
One way to save a bit more horizontal space would be to remove the switch for formatting and simply show 'Default'. This would likely mean having to move the switches for the other 2 options as well. (Probably need to include 'Off / On' after the switches as well. Doesn't fully solve the issue, but may save a bit more room and solve a UX bug as well. I def like the above suggestion to the color formatter—do we need to include the output example somewhere too? |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
hi is anyone still working on this? If not I'd like to contribute a PR as a community member. |
Hi @Dripcoding, Thanks for your interest in solving this issue! |
@jughosta I would move away from using the table component and favor using a card for each format definition. @MichaelMarcialis solution looks like a good starting point. I would try using a non-interactive card with a border to make it clear that each format definition is separate from subsequent definitions. Each card could have a row to show the inputs horizontally as in Michael's mock and another row below it to show the example of the applied color formatting and the delete icon. Let me know if that sounds reasonable to you. |
@Dripcoding Sounds good! Let's maybe start with a PoC for your suggestion before committing fully. Thanks! |
Note that #201676 only address the color picker portion of my suggestion. Additional suggestions such as taking the interface out of a table component, removing the example text outright, increasing the width of the regex input, etc. were not addressed. If those additional suggestions are desirable to include, please feel free to re-open. |
@MichaelMarcialis This issue was originally for the hex code issue specifically, but I think these improvements are worth tracking. I opened a dedicated issue for them here: #202620. |
The current field formatter color selector doesn't show the hex values -
...because they're hidden due to rendering constraints (modified via dev tools) -
The layout should be altered so the user can see and edit these values. Discovered on 7.15.2 and verified on main/8.1.
The text was updated successfully, but these errors were encountered: