Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Index Management] Provide more info than just "Bad Request" when retrying lifecycle step #118464

Closed
maltewhiite opened this issue Nov 12, 2021 · 10 comments · Fixed by #173620
Closed

[Index Management] Provide more info than just "Bad Request" when retrying lifecycle step #118464

maltewhiite opened this issue Nov 12, 2021 · 10 comments · Fixed by #173620
Assignees
@ElenaStoeva
Labels
Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@maltewhiite
Copy link

maltewhiite commented Nov 12, 2021 •
edited
Loading

Describe the feature:

Provide more info than just "Bad Request", when trying to "Retry lifecycle step" on indices with lifecycle errors.

I have no idea how to find out what is going wrong, when the only thing I am told is "Bad Request"

image

Describe a specific use case for the feature:

If a user is having issues figuring out why their ILM is going wrong and are retrying lifecycle steps, and they get "Bad Request", they should be provided more info than that, about what went wrong, so they can try to resolve the problem.
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 12, 2021
@maltewhiite
Copy link
Author

maltewhiite commented Nov 12, 2021 •
edited
Loading

I press "Retry lifecycle step" here:
image
And then it just says
image

@mshustov mshustov added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Nov 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 15, 2021
@cjcenizal
Copy link
Contributor

@maltewhiite Thanks for creating this issue! To help us understand what's occurring we need more information. Which version are you on? Are there steps that you can share that we can follow to reliably reproduce the error? Thanks.

@maltewhiite
Copy link
Author

@maltewhiite Thanks for creating this issue! To help us understand what's occurring we need more information. Which version are you on? Are there steps that you can share that we can follow to reliably reproduce the error? Thanks.

Which version of Elastic? Where can I see that?

@maltewhiite
Copy link
Author

I went from changing indices daily to changing to the 000001 method.
Then when I retry lifecycle step on all the old daily indices with the date in the name, they say "Bad Request".
I have reindexed those daily indices into the new 000001 indices, and then manually deleted them.
I am wondering why my indicy is now over 100gb, when it is supposed to roll-over at 50gb according to the defaults:
image
image

I opened this discuss.elastic thread about all my ILM issues. It has been a completely new thing to me, so I've had a lot of struggle with it. Never done anything like this before in my career.
https://discuss.elastic.co/t/ilm-delete-beat-data-after-30-days/288992/12

@cjcenizal
Copy link
Contributor

Do you a "Help" icon in the top right corner of the screen? You can click that to see version information.
image

@maltewhiite
Copy link
Author

image

@vonhutrong
Copy link

I have had the same issue.
Kibana version: 7.10.2
Reproduce steps:

  1. In Index Management, I opened an index that has Index lifecyle error

illegal_argument_exception: setting [index.lifecycle.rollover_alias] for index ... is empty or not defined

  1. Then go to the Edit settings tab of the index to set a value for rollover_alias
  2. Press the Manage button in the bottom right, then Retry lifecycle step
  3. Popup Bad Request shows up without any further information

@yuliacech yuliacech added the Feature:Index Management Index and index templates UI label Dec 8, 2023
@alisonelizabeth
Copy link
Contributor

@ElenaStoeva do you think this has been resolved by #162656?

@ElenaStoeva ElenaStoeva mentioned this issue Dec 19, 2023
Merged
@ElenaStoeva
Copy link
Contributor

@ElenaStoeva do you think this has been resolved by #162656?

That PR resolved the empty error toast from the index actions but it seems I missed to also fix the error toast from the extension actions (the "Retry lifecycle step" is one of the ILM extension actions) so I opened a small PR with a fix: #173620

ElenaStoeva added a commit that referenced this issue Dec 20, 2023
@ElenaStoeva
[Index Management] Fix empty error toast message from extension actio…
f0af2b9 
…ns (#173620)

Fixes #118464

Similar to #162656

## Summary

This PR fixes the empty error toast that appears from a failed extension
action.

For example, when the ILM extension action "Retry lifecycle step" fails,
it would display an empty error toast on cloud (or it would display "Bad
request" when running locally):


https://github.com/elastic/kibana/assets/59341489/37c3113a-4f2b-4157-ab0c-658c410349c8

With these changes, the error toast also displays the message:



https://github.com/elastic/kibana/assets/59341489/1f6df5c4-381f-4039-b5f3-746c5783bd2c




**How to test:**

For testing a failing "Retry lifecycle step" action, I followed the
instructions in this
[README](https://github.com/elastic/kibana/blob/main/x-pack/plugins/index_lifecycle_management/README.md)
file to create a lifecycle policy error.
The changes in this PR can be tested in its [CI Cloud
deployment](https://kibana-pr-173620.kb.us-west2.gcp.elastic-cloud.com:9243/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaStoeva ElenaStoeva

Labels
Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Index Management] Fix empty error toast message from extension actions ElenaStoeva/kibana
8 participants
@cjcenizal @mshustov @alisonelizabeth @yuliacech @vonhutrong @elasticmachine @ElenaStoeva @maltewhiite