[Alerting] Update internal API calls use new Alerting APIs

[ymao1]

There are still places in the code that call the legacy alerting APIs. Now that we are using telemetry to track usages of the legacy APIs, we should update to use the new ones so that the telemetry numbers are not thrown off.

kibana/x-pack/examples/alerting_example/public/components/view_alert.tsx

Lines 39 to 46 in 46bfe57

	useEffect(() => {
	if (!alert) {
	http.get(`${LEGACY_BASE_ALERT_API_PATH}/alert/${id}`).then(setAlert);
	}
	if (!alertState) {
	http.get(`${LEGACY_BASE_ALERT_API_PATH}/alert/${id}/state`).then(setAlertState);
	}
	}, [alert, alertState, http, id]);

kibana/x-pack/examples/alerting_example/public/components/view_astros_alert.tsx

Lines 45 to 52 in 46bfe57

	useEffect(() => {
	if (!alert) {
	http.get(`${LEGACY_BASE_ALERT_API_PATH}/alert/${id}`).then(setAlert);
	}
	if (!alertState) {
	http.get(`${LEGACY_BASE_ALERT_API_PATH}/alert/${id}/state`).then(setAlertState);
	}
	}, [alert, alertState, http, id]);

kibana/x-pack/plugins/alerting/public/alert_api.ts

Lines 16 to 37 in 46bfe57

	export async function loadAlertType({
	http,
	id,
	}: {
	http: HttpSetup;
	id: AlertType['id'];
	}): Promise<AlertType | undefined> {
	const alertTypes = (await http.get(
	`${LEGACY_BASE_ALERT_API_PATH}/list_alert_types`
	)) as AlertType[];
	return alertTypes.find((type) => type.id === id);
	}
	export async function loadAlert({
	http,
	alertId,
	}: {
	http: HttpSetup;
	alertId: string;
	}): Promise<Alert> {
	return await http.get(`${LEGACY_BASE_ALERT_API_PATH}/alert/${alertId}`);
	}

[elasticmachine]

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

[pmuellr]

Took another peek at uses of LEGACY_BASE_ALERT_API_PATH, and it appears the only changes we need are in the three files Ying referenced.

There is a reference in stack monitoring code though:

kibana/x-pack/plugins/monitoring/public/alerts/configuration.tsx

Lines 28 to 42 in b47e55c

	async function disableAlert() {
	setIsSaving(true);
	try {
	await Legacy.shims.http.post(`${LEGACY_BASE_ALERT_API_PATH}/alert/${alert.id}/_disable`);
	} catch (err) {
	Legacy.shims.toastNotifications.addDanger({
	title: i18n.translate('xpack.monitoring.alerts.panel.disableAlert.errorTitle', {
	defaultMessage: `Unable to disable rule`,
	}),
	text: err.message,
	});
	}
	setIsSaving(false);
	}
	async function enableAlert() {

I'm wondering if there's some chance we would need this for cross-version monitoring or something, but ... seems unlikely to me.

That code was changed by us :-) in PR #93977

I assume we can change this from the old URL to the new URL, @elastic/stack-monitoring ? I'd have made the change so they'd get notified anyway, so thought I'd ping a little ahead ...