Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[event log] add a millisecond version of kibana.task.schedule_delay to the schema #114343

Open
pmuellr opened this issue Oct 7, 2021 · 2 comments
Labels
discuss estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:EventLog response-ops-ec-backlog ResponseOps E&C backlog Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@pmuellr
Copy link
Member

pmuellr commented Oct 7, 2021

In PR Implement writing rule execution events to event_log #112286 we are starting to standardize on time units used within event log documents. ECS only defines one duration field - event.duration - which is in nanoseconds. But nanoseconds are a pain to deal with, especially since we typically only need millisecond or second precision.

Part of this "standardization" is to use the time unit as a suffix of the field name, e.g. _ms for millseconds, _s for seconds, etc.

In a prior PR, we added the event log field kibana.task.schedule_delay, which is measurement of task manager "drift" for the task execution. And it's stored in nanosecond units. Which would then mean we should probably start storing a field kibana.task.schedule_delay_ms in millsecond format. The question then is, if we want to use this field with old versions of the event log, how would we do that. Runtime field trickery?

If it's too hard to do this, it's probably not critical. We could always leave it as is, and then create a runtime field for the _ms version ...

This isn't a critical issue, but I thought it would be interesting to think about this one, as a somewhat practical exercise in figuring out the event log schema can be changed over time, for cases like this.

@pmuellr pmuellr added discuss Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:EventLog estimate:needs-research Estimated as too large and requires research to break down into workable issues labels Oct 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor

mikecote commented Oct 13, 2021

As a workaround, until this issue removes the pain points, you can modify the event log index pattern to convert nanoseconds to something else. This will only work when displaying the values in specific places (ex: discover), the pain points still exist on filters, etc.

Screen Shot 2021-10-13 at 12 52 28 PM

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@mikecote mikecote added the response-ops-ec-backlog ResponseOps E&C backlog label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:EventLog response-ops-ec-backlog ResponseOps E&C backlog Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

No branches or pull requests

4 participants