Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Investigate issue with incorrect type returned from getClustersSummary #103762

Open
neptunian opened this issue Jun 29, 2021 · 3 comments
Open

[Monitoring] Investigate issue with incorrect type returned from getClustersSummary #103762

neptunian opened this issue Jun 29, 2021 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Stack Monitoring Team:Monitoring Stack Monitoring team

Comments

@neptunian
Copy link
Contributor

neptunian commented Jun 29, 2021 •
edited
Loading

In #103718, the total number of ES nodes returned is a number, but when no nodes exist, its an object. The issue appears to occur in the code here. Since cluster.cluster_stats?.nodes?.count?.total does not exist on the standalone cluster which has no nodes, it tries the MB field cluster.elasticsearch?.cluster?.stats?.nodes?.count. Both are empty objects when no nodes exist. So we should account for that in getClustersSummary and also I think we need a better way to detect whether its legacy or metricbeat.

With legacy monitoring a cluster with nodes:
Screen Shot 2021-06-29 at 3 50 43 PM

With legacy monitoring a cluster with no nodes (error case):
Screen Shot 2021-06-29 at 3 55 19 PM
@neptunian neptunian added bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jun 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@neptunian neptunian changed the title [Monitoring] Investigate issue with incorrect type returned from ES [Monitoring] Investigate issue with incorrect type returned from getClustersSummary Jun 29, 2021
@alisonelizabeth alisonelizabeth removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Jun 30, 2021
@alisonelizabeth
Copy link
Contributor

This doesn't appear related to the stack management team so removing team label.

@smith smith added Team:Monitoring Stack Monitoring team and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Monitoring)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Stack Monitoring Team:Monitoring Stack Monitoring team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smith @neptunian @alisonelizabeth @elasticmachine