Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Stop displaying heap limit in relation to RSS for Kibana Memory Size #100408

Open
simianhacker opened this issue May 20, 2021 · 3 comments
Labels
enhancement New value added to drive a business result Feature:Stack Monitoring needs-refinement A reason and acceptance criteria need to be defined for this issue Team:Monitoring Stack Monitoring team

Comments

@simianhacker
Copy link
Member

On the Memory Size chart for Kibana, we display "Heap Limit" in relationship to "Memory Usage" (which is RSS). The problem with this is that the heap is a subset of RSS which will also lead to scenarios where the "Memory Usage" will go above "Heap Limit". We should probably have 2 charts, one with RSS and one with heap usage (in relation to limits).

Current Fields we are using:

  • Memory Usage - kibana_stats.process.memory.resident_set_size_in_bytes
  • Heap Limit - kibana_stats.process.memory.heap.size_limit

image

CC: @joshdover

@simianhacker simianhacker added enhancement New value added to drive a business result Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring labels May 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@ravikesarwani
Copy link
Contributor

If I understand correctly the SDH in 1483 didn't had the heap size limit set and hence was giving 1400 MB as the default limit value. In my instance in Elastic Cloud I see that we do set the heap size limit (I see heap.size_limit as 851,443,710 for a 1GB kibana instance).

Looks like 2 things I am thinking we change/improve here:

  • Add a line chart in the same visualization for Heap total (kibana_stats.process.memory.heap.total_in_bytes). This helps to compare it against heap size limit.
  • Modify the descriptions to make things more clear
    • Heap size limit (kibana_stats.process.memory.heap.size_limit): Max. old space size allocated
    • Heap total (kibana_stats.process.memory.heap.total_in_bytes): Total size of the allocated heap
    • Memory usage (kibana_stats.process.memory.resident_set_size_in_bytes): Resident set size that includes code segment, stack and heap

I am not too sure if there’s a real need to move Resident set size (RSS) in a separate graph since it shows additional memory being used and probably need to be looked in the context of allocated heap to know how much extra (in code segment and stack) is being used.

Thoughts?

@simianhacker simianhacker added the needs-refinement A reason and acceptance criteria need to be defined for this issue label May 27, 2021
@smith smith added Team:Monitoring Stack Monitoring team and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Monitoring)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Stack Monitoring needs-refinement A reason and acceptance criteria need to be defined for this issue Team:Monitoring Stack Monitoring team
Projects
None yet
Development

No branches or pull requests

4 participants