From f0f585697cd47362ad30f1ce5961ea297c049595 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Tue, 24 Sep 2024 02:24:39 +1000
Subject: [PATCH] [8.15] [ML][Rules] Fixes deletion in Check interval input for
 anomaly detection rule (#193420) (#193730)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ML][Rules] Fixes deletion in Check interval input for anomaly
detection rule (#193420)](https://github.com/elastic/kibana/pull/193420)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-23T14:27:01Z","message":"[ML][Rules]
Fixes deletion in Check interval input for anomaly detection rule
(#193420)\n\n## Summary\r\n\r\nIt was trying to parse `null`
values.\r\nAfter:\r\n\r\n![image](https://github.com/user-attachments/assets/82d24663-a895-4ad4-bc01-fb76b883bc66)\r\n\r\nFixes
[#190732](https://github.com/elastic/kibana/issues/190732)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"65b7bf9586480b522393905ff21324f473ee90ed","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","backport:prev-major"],"title":"[ML][Rules]
Fixes deletion in Check interval input for anomaly detection
rule","number":193420,"url":"https://github.com/elastic/kibana/pull/193420","mergeCommit":{"message":"[ML][Rules]
Fixes deletion in Check interval input for anomaly detection rule
(#193420)\n\n## Summary\r\n\r\nIt was trying to parse `null`
values.\r\nAfter:\r\n\r\n![image](https://github.com/user-attachments/assets/82d24663-a895-4ad4-bc01-fb76b883bc66)\r\n\r\nFixes
[#190732](https://github.com/elastic/kibana/issues/190732)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"65b7bf9586480b522393905ff21324f473ee90ed"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193420","number":193420,"mergeCommit":{"message":"[ML][Rules]
Fixes deletion in Check interval input for anomaly detection rule
(#193420)\n\n## Summary\r\n\r\nIt was trying to parse `null`
values.\r\nAfter:\r\n\r\n![image](https://github.com/user-attachments/assets/82d24663-a895-4ad4-bc01-fb76b883bc66)\r\n\r\nFixes
[#190732](https://github.com/elastic/kibana/issues/190732)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"65b7bf9586480b522393905ff21324f473ee90ed"}}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
---
 .../alerting/anomaly_detection_rule/config_validator.tsx   | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/x-pack/plugins/ml/public/alerting/anomaly_detection_rule/config_validator.tsx b/x-pack/plugins/ml/public/alerting/anomaly_detection_rule/config_validator.tsx
index 88b1502ac3b99..04e96546196bb 100644
--- a/x-pack/plugins/ml/public/alerting/anomaly_detection_rule/config_validator.tsx
+++ b/x-pack/plugins/ml/public/alerting/anomaly_detection_rule/config_validator.tsx
@@ -32,13 +32,15 @@ export const ConfigValidator: FC<ConfigValidatorProps> = React.memo(
   ({ jobConfigs = [], alertInterval, alertParams, alertNotifyWhen, maxNumberOfBuckets }) => {
     if (jobConfigs.length === 0) return null;
 
-    const alertIntervalInSeconds = parseInterval(alertInterval)!.asSeconds();
+    const alertIntervalInSeconds = parseInterval(alertInterval)?.asSeconds();
 
     const lookbackIntervalInSeconds =
       !!alertParams.lookbackInterval && parseInterval(alertParams.lookbackInterval)?.asSeconds();
 
     const isAlertIntervalTooHigh =
-      lookbackIntervalInSeconds && lookbackIntervalInSeconds < alertIntervalInSeconds;
+      lookbackIntervalInSeconds &&
+      alertIntervalInSeconds &&
+      lookbackIntervalInSeconds < alertIntervalInSeconds;
 
     const jobWithoutStartedDatafeed = jobConfigs
       .filter((job) => job.datafeed_config.state !== DATAFEED_STATE.STARTED)
@@ -49,6 +51,7 @@ export const ConfigValidator: FC<ConfigValidatorProps> = React.memo(
     const notifyWhenWarning =
       alertNotifyWhen === 'onActiveAlert' &&
       lookbackIntervalInSeconds &&
+      alertIntervalInSeconds &&
       alertIntervalInSeconds < lookbackIntervalInSeconds;
 
     const bucketSpanDuration = parseInterval(jobConfigs[0].analysis_config.bucket_span!);