From ee763fc266e704c89d7a507b06598bf6b8b95a28 Mon Sep 17 00:00:00 2001 From: Matthias Wilhelm Date: Tue, 30 Jan 2024 18:57:39 +0100 Subject: [PATCH] Rename saved search to Discover view --- api_docs/aiops.devdocs.json | 8 +-- api_docs/discover.devdocs.json | 6 +-- api_docs/discover.mdx | 2 +- ...rting_export_types_csv_common.devdocs.json | 4 +- api_docs/kbn_unified_data_table.devdocs.json | 4 +- api_docs/plugin_directory.mdx | 4 +- api_docs/saved_search.devdocs.json | 4 +- api_docs/saved_search.mdx | 2 +- api_docs/visualizations.devdocs.json | 6 +-- docs/CHANGELOG.asciidoc | 40 +++++++-------- .../copy_saved_objects.asciidoc | 2 +- docs/concepts/data-views.asciidoc | 2 +- docs/concepts/save-query.asciidoc | 4 +- docs/developer/plugin-list.asciidoc | 4 +- docs/discover/document-explorer.asciidoc | 2 +- docs/discover/save-search.asciidoc | 18 +++---- docs/discover/search-sessions.asciidoc | 2 +- docs/discover/search.asciidoc | 18 +++---- docs/management/advanced-options.asciidoc | 6 +-- docs/settings/reporting-settings.asciidoc | 4 +- docs/setup/configuring-reporting.asciidoc | 8 +-- .../user/dashboard/aggregation-based.asciidoc | 4 +- docs/user/dashboard/lens.asciidoc | 4 +- .../make-dashboards-interactive.asciidoc | 4 +- docs/user/dashboard/tsvb.asciidoc | 2 +- docs/user/management.asciidoc | 4 +- docs/user/ml/index.asciidoc | 6 +-- .../automating-report-generation.asciidoc | 4 +- docs/user/reporting/index.asciidoc | 20 ++++---- .../public/examples/finder/finder_app.tsx | 2 +- .../public/plugin.tsx | 4 +- legacy_rfcs/text/0013_search_sessions.md | 4 +- .../__fixtures__/ftr_report.xml | 2 +- .../add_messages_to_report.test.ts | 2 +- .../get_failures.test.ts | 6 +-- .../kbn-reporting/export_types/csv/csv_v2.ts | 2 +- .../export_types/csv_common/index.ts | 2 +- packages/kbn-unified-data-table/src/types.ts | 2 +- src/plugins/dashboard/public/plugin.tsx | 2 +- src/plugins/data/config.ts | 4 +- .../public/search/session/session_service.ts | 4 +- .../session/sessions_mgmt/components/main.tsx | 2 +- .../rollup_beta_warning.tsx | 2 +- .../header/__snapshots__/header.test.tsx.snap | 2 +- .../components/header/header.tsx | 2 +- src/plugins/discover/README.md | 4 +- src/plugins/discover/common/locator.test.ts | 4 +- src/plugins/discover/common/locator.ts | 2 +- src/plugins/discover/kibana.jsonc | 2 +- .../discover/public/__mocks__/saved_search.ts | 2 +- .../field_stats_table/field_stats_table.tsx | 6 +-- .../open_search_panel.test.tsx.snap | 2 +- .../top_nav/get_top_nav_badges.test.ts | 4 +- .../components/top_nav/get_top_nav_badges.tsx | 2 +- .../components/top_nav/get_top_nav_links.tsx | 2 +- .../top_nav/on_save_search.test.tsx | 2 +- .../components/top_nav/on_save_search.tsx | 6 +-- .../components/top_nav/open_search_panel.tsx | 2 +- .../application/main/hooks/use_url.test.ts | 10 ++-- .../discover_app_state_container.test.ts | 4 +- .../services/discover_app_state_container.ts | 4 +- .../discover_saved_search_container.test.ts | 32 ++++++------ .../discover_saved_search_container.ts | 50 +++++++++---------- .../main/services/discover_state.test.ts | 20 ++++---- .../main/services/discover_state.ts | 30 +++++------ .../main/services/load_saved_search.ts | 20 ++++---- .../main/utils/resolve_data_view.ts | 4 +- .../main/utils/update_saved_search.ts | 4 +- .../doc_table/doc_table_wrapper.tsx | 2 +- .../discover/public/embeddable/constants.ts | 4 +- .../get_discover_locator_params.test.ts | 2 +- .../saved_search_embeddable.test.ts | 20 ++++---- .../embeddable/saved_search_embeddable.tsx | 2 +- .../public/embeddable/saved_search_grid.scss | 2 +- .../embeddable/search_embeddable_factory.ts | 2 +- .../view_saved_search_action.test.ts | 8 +-- .../public/hooks/use_navigation_props.tsx | 2 +- .../restore_from_saved_search.test.ts | 2 +- .../discover/public/utils/get_sharing_data.ts | 2 +- .../locator/columns_from_locator.test.ts | 4 +- .../server/locator/columns_from_locator.ts | 2 +- .../server/locator/filters_from_locator.ts | 2 +- .../server/locator/query_from_locator.ts | 2 +- .../locator/searchsource_from_locator.test.ts | 10 ++-- .../locator/searchsource_from_locator.ts | 4 +- .../server/locator/title_from_locator.test.ts | 6 +-- .../server/locator/title_from_locator.ts | 6 +-- .../sample_data/register_sample_data.ts | 2 +- src/plugins/discover/server/ui_settings.ts | 4 +- .../feature_catalogue_registry.test.ts | 2 +- src/plugins/inspector/README.md | 2 +- .../helpers/build_saved_object.ts | 2 +- .../not_found_errors.test.tsx.snap | 10 ++-- .../object_view/components/header.test.tsx | 8 +-- .../components/not_found_errors.test.tsx | 2 +- .../components/not_found_errors.tsx | 2 +- src/plugins/saved_search/README.md | 4 +- .../common/expressions/kibana_context.ts | 2 +- .../common/saved_searches_url.test.ts | 2 +- .../common/service/get_saved_searches.test.ts | 4 +- .../common/service/get_saved_searches.ts | 4 +- .../service/saved_searches_utils.test.ts | 4 +- src/plugins/saved_search/common/types.ts | 4 +- src/plugins/saved_search/kibana.jsonc | 2 +- src/plugins/saved_search/public/plugin.ts | 10 ++-- .../check_for_duplicate_title.ts | 2 +- .../saved_search_attribute_service.test.ts | 8 +-- src/plugins/saved_search/server/plugin.ts | 2 +- .../saved_objects/search_migrations.test.ts | 4 +- .../components/sidebar/sidebar_title.tsx | 10 ++-- src/plugins/visualizations/common/locator.ts | 6 +-- .../public/embeddable/to_ast.ts | 2 +- .../visualize_embeddable_factory.test.ts | 2 +- .../saved_visualization_references.test.ts | 4 +- .../saved_visualization_references.ts | 4 +- .../visualizations/public/vis_types/types.ts | 2 +- .../public/visualize_app/types.ts | 2 +- .../utils/get_top_nav_config.tsx | 2 +- .../utils/get_visualization_instance.test.ts | 2 +- .../utils/use/use_editor_updates.test.ts | 4 +- .../use/use_linked_search_updates.test.ts | 2 +- .../utils/use/use_linked_search_updates.ts | 2 +- .../utils/use/use_saved_vis_instance.test.ts | 2 +- .../search_selection/search_selection.tsx | 6 +-- test/accessibility/apps/dashboard.ts | 2 +- test/accessibility/apps/discover.ts | 2 +- .../from_the_browser/loaded_dashboard.ts | 8 +-- .../dashboard/group1/embeddable_rendering.ts | 2 +- .../dashboard/group2/dashboard_filter_bar.ts | 2 +- .../dashboard/group2/dashboard_filtering.ts | 10 ++-- .../apps/dashboard/group3/dashboard_state.ts | 6 +-- .../dashboard/group3/dashboard_time_picker.ts | 8 +-- .../dashboard/group3/panel_context_menu.ts | 6 +-- .../apps/dashboard/group3/panel_replacing.ts | 6 +-- .../group5/data_shared_attributes.ts | 4 +- .../group5/saved_search_embeddable.ts | 6 +-- .../controls/common/time_slider.ts | 4 +- .../embeddable/_saved_search_embeddable.ts | 6 +-- .../apps/discover/group1/_discover.ts | 2 +- .../discover/group1/_discover_histogram.ts | 12 ++--- .../group1/_discover_histogram_breakdown.ts | 2 +- .../discover/group2/_data_grid_pagination.ts | 6 +-- .../discover/group2/_data_grid_sample_size.ts | 4 +- .../apps/discover/group3/_request_counts.ts | 12 ++--- .../discover/group3/_unsaved_changes_badge.ts | 14 +++--- .../apps/discover/group4/_adhoc_data_views.ts | 4 +- .../apps/discover/group4/_chart_hidden.ts | 2 +- .../_indexpattern_with_unmapped_fields.ts | 4 +- .../group4/_indexpattern_without_timefield.ts | 2 +- .../discover/group4/_runtime_fields_editor.ts | 2 +- .../discover/group4/_search_on_page_load.ts | 2 +- test/functional/apps/home/_sample_data.ts | 2 +- .../apps/management/_import_objects.ts | 12 ++--- .../management/_mgmt_import_saved_objects.ts | 2 +- ...t_objects_connected_to_saved_search.ndjson | 2 +- .../_import_objects_saved_search.ndjson | 2 +- .../_import_objects_with_saved_search.ndjson | 4 +- .../group3/_linked_saved_searches.ts | 16 +++--- .../ccs/dashboard/current/kibana.json | 6 +-- .../dashboard/current/kibana.json | 6 +-- .../kbn_archiver/managed_content.json | 4 +- test/functional/page_objects/discover_page.ts | 8 +-- .../services/dashboard/add_panel.ts | 2 +- .../test_suites/run_pipeline/esaggs.ts | 4 +- .../public/application/utils/search_utils.ts | 24 ++++----- .../change_point_detection_root.tsx | 2 +- .../log_categorization_app_state.tsx | 2 +- .../log_categorization_page.tsx | 4 +- .../log_rate_analysis_app_state.tsx | 2 +- .../log_rate_analysis_page.tsx | 4 +- .../aiops/public/hooks/use_data_source.tsx | 6 +-- .../alerting/docs/openapi/bundled.json | 4 +- .../alerting/docs/openapi/bundled.yaml | 10 ++-- .../create_siem_saved_query_rule_request.yaml | 5 +- .../i18n/functions/dict/saved_search.ts | 4 +- .../data_drift/data_drift_app_state.tsx | 4 +- .../data_drift/data_drift_page.tsx | 4 +- .../index_data_visualizer_view.tsx | 4 +- .../index_data_visualizer.tsx | 2 +- .../index_data_visualizer/locator/locator.ts | 2 +- .../utils/saved_search_utils.test.ts | 8 +-- .../utils/saved_search_utils.ts | 22 ++++---- .../fleet/dev_docs/integrations_overview.md | 2 +- .../integrations/sections/epm/constants.tsx | 2 +- x-pack/plugins/ml/common/constants/locator.ts | 2 +- .../contexts/ml/data_source_context.tsx | 6 +-- .../configuration_step_form.tsx | 2 +- .../configuration_step/use_saved_search.ts | 2 +- .../source_selection.test.tsx | 6 +-- .../source_selection/source_selection.tsx | 12 ++--- .../data_drift/index_patterns_picker.tsx | 6 +-- .../json_editor_flyout/json_editor_flyout.tsx | 2 +- .../components/data_view/change_data_view.tsx | 2 +- .../new_job/pages/index_or_search/page.tsx | 6 +-- .../jobs/new_job/pages/job_type/page.tsx | 4 +- .../jobs/new_job/pages/new_job/page.tsx | 4 +- .../new_job/pages/new_job/wizard_steps.tsx | 2 +- .../jobs/new_job/recognize/page.tsx | 4 +- .../jobs/new_job/utils/new_job_utils.test.ts | 8 +-- .../load_new_job_capabilities.ts | 6 +-- .../ml/public/locator/ml_locator.test.ts | 2 +- .../models/data_recognizer/data_recognizer.ts | 2 +- .../src/services/data_view_service.ts | 2 +- .../rollup/server/collectors/helpers.test.ts | 2 +- .../rollup/server/collectors/register.test.ts | 6 +-- .../rollup/server/collectors/register.ts | 6 +-- .../common/types/timeline/store.ts | 2 +- .../use_discover_in_timeline_actions.test.tsx | 12 ++--- .../use_discover_in_timeline_actions.tsx | 10 ++-- .../timeline/esql_tab_content/index.test.tsx | 8 +-- .../timeline/esql_tab_content/index.tsx | 6 +-- .../timeline/esql_tab_content/translations.ts | 2 +- .../esql_tab_content/utils/index.test.ts | 2 +- .../public/timelines/containers/api.test.ts | 8 +-- .../public/timelines/containers/api.ts | 6 +-- .../public/timelines/store/model.ts | 4 +- .../components/copy_mode_control.tsx | 2 +- .../schema/xpack_plugins.json | 6 +-- x-pack/plugins/transform/common/constants.ts | 2 +- .../use_search_items/use_search_items.ts | 4 +- .../step_define/step_define_form.tsx | 2 +- .../step_define/step_define_summary.tsx | 2 +- .../search_selection/search_selection.tsx | 4 +- x-pack/plugins/transform/readme.md | 4 +- .../serialization_helpers/build_input.js | 2 +- .../apps/aiops/log_rate_analysis.ts | 2 +- .../apps/canvas/embeddables/saved_search.ts | 14 +++--- .../apps/dashboard/group2/_async_dashboard.ts | 2 +- .../group2/dashboard_search_by_value.ts | 6 +-- .../reporting/__snapshots__/download_csv.snap | 10 ++-- .../group3/reporting/download_csv.ts | 10 ++-- .../dashboard/group3/reporting/screenshots.ts | 2 +- .../apps/discover/saved_search_embeddable.ts | 6 +-- .../apps/discover/saved_searches.ts | 4 +- .../saved_search_job.ts | 12 ++--- .../classification_creation_saved_search.ts | 12 ++--- ...outlier_detection_creation_saved_search.ts | 10 ++-- .../regression_creation_saved_search.ts | 10 ++-- .../apps/ml/data_visualizer/data_drift.ts | 6 +-- .../data_visualizer/index_data_visualizer.ts | 8 +-- .../index_data_visualizer_actions_panel.ts | 4 +- ...ex_data_visualizer_data_view_management.ts | 2 +- .../index_data_visualizer_filters.ts | 4 +- .../index_data_visualizer_random_sampler.ts | 2 +- .../ml/data_visualizer/index_test_data.ts | 8 +-- .../index_test_data_random_sampler.ts | 8 +-- .../runtime_mappings_saved_search/config.ts | 2 +- .../creation_saved_search.ts | 8 +-- .../runtime_mappings_saved_search/index.ts | 2 +- .../kbn_archiver/dashboard_view_mode.json | 2 +- .../kbn_archiver/reporting/ecommerce.json | 2 +- .../fixtures/kbn_archiver/reporting/logs.json | 6 +-- .../functional/services/ml/test_resources.ts | 10 ++-- .../index_data_visualizer_actions_panel.ts | 2 +- .../runtime_mappings_saved_search/config.ts | 2 +- .../__snapshots__/csv_v2.snap | 4 +- .../reporting_and_security/csv_v2.ts | 4 +- .../reporting_and_security/spaces.ts | 2 +- .../services/scenarios.ts | 2 +- .../functional/tests/discover_integration.ts | 6 +-- .../save_search_session_relative_time.ts | 2 +- .../session_searches_integration.ts | 2 +- .../investigations/timelines/creation.cy.ts | 4 +- .../discover_timeline_state_integration.cy.ts | 12 ++--- .../apps/ccs/ccs_discover.js | 2 +- .../apps/dashboard/dashboard_smoke_tests.ts | 2 +- .../fixtures/kbn_archiver/reporting/logs.json | 6 +-- .../embeddable/_saved_search_embeddable.ts | 6 +-- .../common/discover/group1/_discover.ts | 2 +- .../discover/group1/_discover_histogram.ts | 12 ++--- .../discover/group2/_adhoc_data_views.ts | 4 +- .../common/discover/group3/_request_counts.ts | 12 ++--- .../discover/group3/_unsaved_changes_badge.ts | 10 ++-- .../common/reporting/management.ts | 2 +- 274 files changed, 732 insertions(+), 733 deletions(-) diff --git a/api_docs/aiops.devdocs.json b/api_docs/aiops.devdocs.json index 6a4ad90613be7..44a122a9ff700 100644 --- a/api_docs/aiops.devdocs.json +++ b/api_docs/aiops.devdocs.json @@ -798,7 +798,7 @@ "tags": [], "label": "savedSearch", "description": [ - "The saved search to analyze." + "The discover view to analyze." ], "signature": [ { @@ -897,7 +897,7 @@ "tags": [], "label": "savedSearch", "description": [ - "The saved search to analyze." + "The discover view to analyze." ], "signature": [ { @@ -996,7 +996,7 @@ "tags": [], "label": "savedSearch", "description": [ - "The saved search to analyze." + "The discover view to analyze." ], "signature": [ { @@ -1512,4 +1512,4 @@ ], "objects": [] } -} \ No newline at end of file +} diff --git a/api_docs/discover.devdocs.json b/api_docs/discover.devdocs.json index b12e043f1a2b3..df115ca20b8f6 100644 --- a/api_docs/discover.devdocs.json +++ b/api_docs/discover.devdocs.json @@ -713,7 +713,7 @@ "tags": [], "label": "savedSearchState", "description": [ - "\nState of saved search, the saved object of Discover" + "\nState of discover view, the saved object of Discover" ], "signature": [ "DiscoverSavedSearchContainer" @@ -2457,7 +2457,7 @@ "tags": [], "label": "savedSearchId", "description": [ - "\nOptionally set saved search ID." + "\nOptionally set discover view ID." ], "signature": [ "string | undefined" @@ -2960,4 +2960,4 @@ ], "objects": [] } -} \ No newline at end of file +} diff --git a/api_docs/discover.mdx b/api_docs/discover.mdx index ba13bb821f80e..893a8b1eb6715 100644 --- a/api_docs/discover.mdx +++ b/api_docs/discover.mdx @@ -13,7 +13,7 @@ tags: ['contributor', 'dev', 'apidocs', 'kibana', 'discover'] --- import discoverObj from './discover.devdocs.json'; -This plugin contains the Discover application and the saved search embeddable. +This plugin contains the Discover application and the discover view embeddable. Contact [@elastic/kibana-data-discovery](https://github.com/orgs/elastic/teams/kibana-data-discovery) for questions regarding this plugin. diff --git a/api_docs/kbn_reporting_export_types_csv_common.devdocs.json b/api_docs/kbn_reporting_export_types_csv_common.devdocs.json index b8e38bafbb458..e88617ed1c744 100644 --- a/api_docs/kbn_reporting_export_types_csv_common.devdocs.json +++ b/api_docs/kbn_reporting_export_types_csv_common.devdocs.json @@ -425,7 +425,7 @@ "tags": [], "label": "JobParamsCsvFromSavedObject", "description": [ - "\nMakes title optional, as it can be derived from the saved search object" + "\nMakes title optional, as it can be derived from the discover view object" ], "signature": [ "CsvFromSavedObjectBase & Omit<", @@ -472,4 +472,4 @@ ], "objects": [] } -} \ No newline at end of file +} diff --git a/api_docs/kbn_unified_data_table.devdocs.json b/api_docs/kbn_unified_data_table.devdocs.json index d6e88999bd256..5d45e5b59d931 100644 --- a/api_docs/kbn_unified_data_table.devdocs.json +++ b/api_docs/kbn_unified_data_table.devdocs.json @@ -1806,7 +1806,7 @@ "tags": [], "label": "UnifiedDataTableSettings", "description": [ - "\nUser configurable state of data grid, persisted in saved search" + "\nUser configurable state of data grid, persisted in discover view" ], "path": "packages/kbn-unified-data-table/src/types.ts", "deprecated": false, @@ -2133,4 +2133,4 @@ } ] } -} \ No newline at end of file +} diff --git a/api_docs/plugin_directory.mdx b/api_docs/plugin_directory.mdx index 87a9fbc95800d..dc5b1a6c6e9e4 100644 --- a/api_docs/plugin_directory.mdx +++ b/api_docs/plugin_directory.mdx @@ -65,7 +65,7 @@ tags: ['contributor', 'dev', 'apidocs', 'kibana'] | | [@elastic/ml-ui](https://github.com/orgs/elastic/teams/ml-ui) | The Data Visualizer tools help you understand your data, by analyzing the metrics and fields in a log file or an existing Elasticsearch index. | 31 | 3 | 25 | 1 | | | [@elastic/obs-ux-logs-team](https://github.com/orgs/elastic/teams/obs-ux-logs-team) | This plugin introduces the concept of dataset quality, where users can easily get an overview on the datasets they have. | 8 | 0 | 8 | 2 | | | [@elastic/platform-deployment-management](https://github.com/orgs/elastic/teams/platform-deployment-management) | - | 12 | 0 | 10 | 3 | -| | [@elastic/kibana-data-discovery](https://github.com/orgs/elastic/teams/kibana-data-discovery) | This plugin contains the Discover application and the saved search embeddable. | 141 | 0 | 95 | 22 | +| | [@elastic/kibana-data-discovery](https://github.com/orgs/elastic/teams/kibana-data-discovery) | This plugin contains the Discover application and the discover view embeddable. | 141 | 0 | 95 | 22 | | | [@elastic/kibana-data-discovery](https://github.com/orgs/elastic/teams/kibana-data-discovery) | - | 37 | 0 | 35 | 2 | | | [@elastic/security-threat-hunting-investigations](https://github.com/orgs/elastic/teams/security-threat-hunting-investigations) | APIs used to assess the quality of data in Elasticsearch indexes | 2 | 0 | 0 | 0 | | | [@elastic/security-generative-ai](https://github.com/orgs/elastic/teams/security-generative-ai) | Server APIs for the Elastic AI Assistant | 41 | 0 | 27 | 0 | @@ -161,7 +161,7 @@ tags: ['contributor', 'dev', 'apidocs', 'kibana'] | | [@elastic/kibana-core](https://github.com/orgs/elastic/teams/kibana-core) | - | 161 | 0 | 147 | 2 | | | [@elastic/appex-sharedux](https://github.com/orgs/elastic/teams/appex-sharedux) | - | 87 | 0 | 81 | 3 | | | [@elastic/appex-sharedux](https://github.com/orgs/elastic/teams/appex-sharedux) | - | 104 | 0 | 56 | 1 | -| | [@elastic/kibana-data-discovery](https://github.com/orgs/elastic/teams/kibana-data-discovery) | This plugin contains the definition and helper methods around saved searches, used by discover and visualizations. | 78 | 0 | 77 | 3 | +| | [@elastic/kibana-data-discovery](https://github.com/orgs/elastic/teams/kibana-data-discovery) | This plugin contains the definition and helper methods around discover viewes, used by discover and visualizations. | 78 | 0 | 77 | 3 | | | [@elastic/appex-sharedux](https://github.com/orgs/elastic/teams/appex-sharedux) | - | 32 | 0 | 13 | 0 | | | [@elastic/kibana-reporting-services](https://github.com/orgs/elastic/teams/kibana-reporting-services) | Kibana Screenshotting Plugin | 32 | 0 | 8 | 4 | | searchprofiler | [@elastic/platform-deployment-management](https://github.com/orgs/elastic/teams/platform-deployment-management) | - | 0 | 0 | 0 | 0 | diff --git a/api_docs/saved_search.devdocs.json b/api_docs/saved_search.devdocs.json index 6298867af6c14..3df6fcb53ce35 100644 --- a/api_docs/saved_search.devdocs.json +++ b/api_docs/saved_search.devdocs.json @@ -424,7 +424,7 @@ "tags": [], "label": "SavedSearchPublicPluginStart", "description": [ - "\nSaved search plugin public Setup contract" + "\nDiscover view plugin public Setup contract" ], "path": "src/plugins/saved_search/public/plugin.ts", "deprecated": false, @@ -1724,4 +1724,4 @@ ], "objects": [] } -} \ No newline at end of file +} diff --git a/api_docs/saved_search.mdx b/api_docs/saved_search.mdx index fbc4c056ba038..397b3107297ae 100644 --- a/api_docs/saved_search.mdx +++ b/api_docs/saved_search.mdx @@ -13,7 +13,7 @@ tags: ['contributor', 'dev', 'apidocs', 'kibana', 'savedSearch'] --- import savedSearchObj from './saved_search.devdocs.json'; -This plugin contains the definition and helper methods around saved searches, used by discover and visualizations. +This plugin contains the definition and helper methods around discover viewes, used by discover and visualizations. Contact [@elastic/kibana-data-discovery](https://github.com/orgs/elastic/teams/kibana-data-discovery) for questions regarding this plugin. diff --git a/api_docs/visualizations.devdocs.json b/api_docs/visualizations.devdocs.json index 6cfb1b1d8445a..b88433db3d79f 100644 --- a/api_docs/visualizations.devdocs.json +++ b/api_docs/visualizations.devdocs.json @@ -2735,7 +2735,7 @@ "tags": [], "label": "linked", "description": [ - "\nFlag to determine if visualiztion is linked to the saved search" + "\nFlag to determine if visualiztion is linked to the discover view" ], "path": "src/plugins/visualizations/public/visualize_app/types.ts", "deprecated": false, @@ -5202,7 +5202,7 @@ "tags": [], "label": "requiresSearch", "description": [ - "\nThe flag is necessary for aggregation based visualizations.\nWhen \"true\", an additional step on the vis creation wizard will be provided\nwith the selection of a search source - an index pattern or a saved search." + "\nThe flag is necessary for aggregation based visualizations.\nWhen \"true\", an additional step on the vis creation wizard will be provided\nwith the selection of a search source - an index pattern or a discover view." ], "signature": [ "boolean | undefined" @@ -16410,4 +16410,4 @@ } ] } -} \ No newline at end of file +} diff --git a/docs/CHANGELOG.asciidoc b/docs/CHANGELOG.asciidoc index 5e5681047e938..a01d41fbe0527 100644 --- a/docs/CHANGELOG.asciidoc +++ b/docs/CHANGELOG.asciidoc @@ -180,8 +180,8 @@ Discover:: * Improves search for field names by handling spaces like wildcards ({kibana-pull}168381[#168381]). * Updates mapping conflict popover with types list ({kibana-pull}169855[#169855]). * On search source error, show 'view details' action that opens request in inspector ({kibana-pull}170790[#170790]). -* Adds an Unsaved changes label when in an unsaved state of saved search ({kibana-pull}169548[#169548]). -* Allows changing the current sample size and saving it with a saved search ({kibana-pull}157269[#157269]). +* Adds an Unsaved changes label when in an unsaved state of discover view ({kibana-pull}169548[#169548]). +* Allows changing the current sample size and saving it with a discover view ({kibana-pull}157269[#157269]). * Adds new sparse vector and dense vector icons ({kibana-pull}169493[#169493]). * Adds `sparse_vector` field support ({kibana-pull}168186[#168186]). Elastic Security:: @@ -621,12 +621,12 @@ Machine Learning:: * Trained model testing: only show indices with supported fields ({kibana-pull}166490[#166490]). * Alerts as data integration for Anomaly Detection rule type ({kibana-pull}166349[#166349]). * Data Frame Analytics Trained models: adds the ability to reindex after pipeline creation ({kibana-pull}166312[#166312]). -* Adds Create a data view button to index or saved search selector in ML pages and Transforms management ({kibana-pull}166668[#166668]). +* Adds Create a data view button to index or discover view selector in ML pages and Transforms management ({kibana-pull}166668[#166668]). * Improvements to UX of adding ML embeddables to a dashboard ({kibana-pull}165714[#165714]). * AIOps: Supports text fields in log rate analysis ({kibana-pull}165124[#165124]). * Data Frame Analytics creation wizard: adds ability to add custom URLs to jobs ({kibana-pull}164520[#164520]). Management:: -* Adds Create a data view button to index or saved search selector in ML pages and Transforms management ({kibana-pull}166668[#166668]). +* Adds Create a data view button to index or discover view selector in ML pages and Transforms management ({kibana-pull}166668[#166668]). * Improve loading behavior of Transforms list if stats request is slow or is not available ({kibana-pull}166320[#166320]). * Adds support for PATCH requests in Console ({kibana-pull}165634[#165634]). * Improves autocomplete to suggest knn in search query ({kibana-pull}165531[#165531]). @@ -740,7 +740,7 @@ For the Elastic Security 8.10.3 release information, refer to {security-guide}/r Dashboard:: * Fixes an error the panel descriptions weren't retrieved from the right method ({kibana-pull}166825[#166825]). Discover:: -* Soften saved search content management response `sort` schema ({kibana-pull}166886[#166886]). +* Soften discover view content management response `sort` schema ({kibana-pull}166886[#166886]). Elastic Security:: For the Elastic Security 8.10.3 release information, refer to {security-guide}/release-notes.html[_Elastic Security Solution Release Notes_]. Enterprise Search:: @@ -750,7 +750,7 @@ Fleet:: * Increase package install max timeout limit and add concurrency control to rollovers ({kibana-pull}166775[#166775]). * Fixes bulk action dropdown ({kibana-pull}166475[#166475]). Machine Learning:: -* AIOps: Fixes render loop when using a saved search ({kibana-pull}166934[#166934]). +* AIOps: Fixes render loop when using a discover view ({kibana-pull}166934[#166934]). Monitoring:: * Convert node roles into array ({kibana-pull}167628[#167628]). Observability:: @@ -2049,7 +2049,7 @@ Discover:: * Adds the ability to allow wildcards in field search {kibana-pull}155540[#155540] * Adds a loading indicator during Discover table updates {kibana-pull}155505[#155505] * Adds drag & drop capabilities for adding columns to the table {kibana-pull}153538[#153538] -* Adds a progress indicator when a saved search embeddable is updating {kibana-pull}152342[#152342] +* Adds a progress indicator when a discover view embeddable is updating {kibana-pull}152342[#152342] * Adds inline data fetching errors {kibana-pull}152311[#152311] * Adds a loading indicator for the classic table embeddable {kibana-pull}152072[#152072] * Adds the ability to suppress "Missing index" toasts {kibana-pull}149625[#149625] @@ -2176,7 +2176,7 @@ Discover:: * Adds the ability to exclude counter fields from Breakdown options {kibana-pull}155532[#155532] * Adds the ability to skip requests for the time series metric counter field {kibana-pull}154319[#154319] * Fixes KQL autocomplete suggestions, which now support IP-type fields when the `autocomplete:valueSuggestionMethod advanced setting is set to terms_enum {kibana-pull}154111[#154111] -* Fixes an issue where saved search "Manage searches" button was unable to apply the "search" type filter {kibana-pull}152565[#152565] +* Fixes an issue where discover view "Manage searches" button was unable to apply the "search" type filter {kibana-pull}152565[#152565] Elastic Security:: For the Elastic Security 8.8.0 release information, refer to {security-guide}/release-notes.html[_Elastic Security Solution Release Notes_]. @@ -2288,7 +2288,7 @@ Dashboard:: Improves controls flyout performance for data views with a large number of fields {kibana-pull}154004[#154004] Discover:: -Fixes aborted request handling in the saved search embeddable {kibana-pull}153822[#153822] +Fixes aborted request handling in the discover view embeddable {kibana-pull}153822[#153822] Elastic Security:: For the Elastic Security 8.7.1 release information, refer to {security-guide}/release-notes.html[_Elastic Security Solution Release Notes_]. @@ -3350,8 +3350,8 @@ APM:: * AWS lambda metrics api {kibana-pull}139041[#139041] Discover:: -* Adds support for storing time with saved searches {kibana-pull}138377[#138377] -* Enables tags for saved searches {kibana-pull}136162[#136162] +* Adds support for storing time with discover viewes {kibana-pull}138377[#138377] +* Enables tags for discover viewes {kibana-pull}136162[#136162] Elastic Security:: For the Elastic Security 8.5.0 release information, refer to {security-guide}/release-notes.html[_Elastic Security Solution Release Notes_]. @@ -3521,7 +3521,7 @@ Fixes pinned filters that backed up in Session Storage {kibana-pull}142262[#1422 Discover:: * Adds support for line breaks in Document explorer {kibana-pull}139449[#139449] * Cancelled request errors for embeddables are now hidden {kibana-pull}137690[#137690] -* Fixes legacy sort saved search stored in Dashboard saved objects {kibana-pull}137488[#137488] +* Fixes legacy sort discover view stored in Dashboard saved objects {kibana-pull}137488[#137488] * Fixes column width handling {kibana-pull}137445[#137445] Elastic Security:: @@ -3628,8 +3628,8 @@ Cases:: Fixes an issue where the recent cases widget shows cases from other solutions {kibana-pull}141221[#141221] Discover:: -* Fixes scrolling prevented by saved search embeddable on touch devices {kibana-pull}141718[#141718] -* Fixes columns management for saved search embeddable {kibana-pull}140799[#140799] +* Fixes scrolling prevented by discover view embeddable on touch devices {kibana-pull}141718[#141718] +* Fixes columns management for discover view embeddable {kibana-pull}140799[#140799] Elastic Security:: For the Elastic Security 8.4.3 release information, refer to {security-guide}/release-notes.html[_Elastic Security Solution Release Notes_]. @@ -3678,7 +3678,7 @@ Connectors:: The connectors table now uses "compatibility" rather than "availability" {kibana-pull}139024[#139024] Discover:: -Fixes saved search embeddable rendering {kibana-pull}140264[#140264] +Fixes discover view embeddable rendering {kibana-pull}140264[#140264] Elastic Security:: For the Elastic Security 8.4.2 release information, refer to {security-guide}/release-notes.html[_Elastic Security Solution Release Notes_]. @@ -4097,7 +4097,7 @@ Lens & Visualizations:: * Fixes internal links in *Vega* {kibana-pull}135890[#135890] * Do not set non-unique id for legend action popovers in *Lens* {kibana-pull}135656[#135656] * Fixes non-editable Lens panel when using prefix wildcard in *Lens* {kibana-pull}135654[#135654] -* Removes saved search references from all places on unlink in *Visualize* {kibana-pull}135628[#135628] +* Removes discover view references from all places on unlink in *Visualize* {kibana-pull}135628[#135628] * Fix multi-field top values for Heatmap visualizations in *Lens* {kibana-pull}135581[#135581] * Fixes styling issues in *Lens* {kibana-pull}135406[#135406] * Show badge for read-only in *Lens* {kibana-pull}135313[#135313] @@ -4114,7 +4114,7 @@ Lens & Visualizations:: Machine Learning:: * Lock the delete annotation button on click {kibana-pull}137306[#137306] -* Fixes globally pinned filters in Data visualizer and query search bar not clearing properly for saved searches {kibana-pull}136897[#136897] +* Fixes globally pinned filters in Data visualizer and query search bar not clearing properly for discover viewes {kibana-pull}136897[#136897] * Fixes overflow in start datafeed modal {kibana-pull}136292[#136292] * Fixes error in categorization wizard summary step {kibana-pull}134228[#134228] * Fixes flaky job selection on the Anomaly Explorer page {kibana-pull}137596[#137596] @@ -4658,7 +4658,7 @@ Machine Learning:: * Adds recognized modules links for Index data visualizer {kibana-pull}131342[#131342] * Anomaly Detection: Adds View in Maps item to Actions menu in the anomalies table {kibana-pull}131284[#131284] * Adding v3 modules for Security_Linux and Security_Windows and Deprecating v1 + v2 {kibana-pull}131166[#131166] -* Data Frame Analytics creation wizard: add support for filters in saved searches {kibana-pull}130744[#130744] +* Data Frame Analytics creation wizard: add support for filters in discover viewes {kibana-pull}130744[#130744] * Edit job selection on data frame analytics results and map pages {kibana-pull}130419[#130419] * Resizable/Collapsible Top Influencers section {kibana-pull}130018[#130018] @@ -5206,7 +5206,7 @@ Machine Learning:: * Fixes Single Metric Viewer chart failing to load if no points during calendar event {kibana-pull}130000[#130000] * Fixes Single Metric Viewer for jobs that haven't been run {kibana-pull}129063[#129063] * Fix outlier detection results exploration color legend display {kibana-pull}129058[#129058] -* Fixes new anomaly detection job from saved search with no query filter {kibana-pull}129022[#129022] +* Fixes new anomaly detection job from discover view with no query filter {kibana-pull}129022[#129022] * Fixes data frame analytics map saved object sync warning {kibana-pull}128876[#128876] * Adds error toast to Data visualizer when using unpopulated time field {kibana-pull}127196[#127196] @@ -5642,7 +5642,7 @@ Lens & Visualizations:: * AggConfigs: Make base id check more stable {kibana-pull}123367[#123367] * TSVB fix flickering {kibana-pull}122921[#122921] * Hide tooltips while dragging dimensions in *Lens* {kibana-pull}122198[#122198] -* Make sure saved search id is carried over to saved object {kibana-pull}121082[#121082] +* Make sure discover view id is carried over to saved object {kibana-pull}121082[#121082] * Paginate through index patterns {kibana-pull}120972[#120972] * Show generic error for invalid time shift string in *Lens* {kibana-pull}120077[#120077] * Improves column type detection in table for alignment in *Lens* {kibana-pull}120007[#120007] diff --git a/docs/api/spaces-management/copy_saved_objects.asciidoc b/docs/api/spaces-management/copy_saved_objects.asciidoc index 32f7480a39b87..fb21fb63783f8 100644 --- a/docs/api/spaces-management/copy_saved_objects.asciidoc +++ b/docs/api/spaces-management/copy_saved_objects.asciidoc @@ -8,7 +8,7 @@ experimental[] Copy saved objects between spaces. It also allows you to automatically copy related objects, so when you copy a `dashboard`, this can automatically copy over the -associated visualizations, {data-sources}, and saved searches, as required. +associated visualizations, {data-sources}, and discover viewes, as required. You can request to overwrite any objects that already exist in the target space if they share an ID, or you can use the <> to do this on a per-object basis. diff --git a/docs/concepts/data-views.asciidoc b/docs/concepts/data-views.asciidoc index 2eba42aed3051..4c97ea11c1153 100644 --- a/docs/concepts/data-views.asciidoc +++ b/docs/concepts/data-views.asciidoc @@ -166,7 +166,7 @@ clusters or indicies from cross-cluster search]. When you delete a {data-source}, you cannot recover the associated field formatters, runtime fields, source filters, and field popularity data. Deleting a {data-source} does not remove any indices or data documents from {es}. -WARNING: Deleting a {data-source} breaks all visualizations, saved searches, and other saved objects that reference the data view. +WARNING: Deleting a {data-source} breaks all visualizations, discover viewes, and other saved objects that reference the data view. . Open the main menu, and then click *Stack Management > Data Views*. diff --git a/docs/concepts/save-query.asciidoc b/docs/concepts/save-query.asciidoc index b249f7e9aea26..3123d8458e841 100644 --- a/docs/concepts/save-query.asciidoc +++ b/docs/concepts/save-query.asciidoc @@ -11,10 +11,10 @@ Save this query, and you can embed the search results in dashboards, use them as a foundation for building a visualization, and share them in a link or CVS form. -Saved queries are different than <>, +Saved queries are different than <>, which include the *Discover* configuration—selected columns in the document table, sort order, and {data-source}—in addition to the query. -Saved searches are primarily used for adding search results to a dashboard. +Discover view are primarily used for adding search results to a dashboard. [role="xpack"] ==== Read-only access diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc index fe9a0d40f5d23..6c2d3e697859f 100644 --- a/docs/developer/plugin-list.asciidoc +++ b/docs/developer/plugin-list.asciidoc @@ -95,7 +95,7 @@ This API doesn't support angular, for registering angular dev tools, bootstrap a |{kib-repo}blob/{branch}/src/plugins/discover/README.md[discover] -|Contains the Discover application and the saved search embeddable. +|Contains the Discover application and the discover view embeddable. |{kib-repo}blob/{branch}/src/plugins/embeddable/README.md[embeddable] @@ -300,7 +300,7 @@ oss plugins. |{kib-repo}blob/{branch}/src/plugins/saved_search/README.md[savedSearch] -|Contains the saved search saved object definition and helpers. +|Contains the discover view saved object definition and helpers. |{kib-repo}blob/{branch}/src/plugins/screenshot_mode/README.md[screenshotMode] diff --git a/docs/discover/document-explorer.asciidoc b/docs/discover/document-explorer.asciidoc index 071c9f9875028..775c72a055c56 100644 --- a/docs/discover/document-explorer.asciidoc +++ b/docs/discover/document-explorer.asciidoc @@ -44,7 +44,7 @@ In the pop-up, drag the column names to their new order. * To resize a column, drag the right edge of the column header until the column is the width that you want. + -Column widths are stored with a saved search. When you visualize saved searches on dashboards, the saved search appears the same as in **Discover**. +Column widths are stored with a discover view. When you visualize discover viewes on dashboards, the discover view appears the same as in **Discover**. [float] diff --git a/docs/discover/save-search.asciidoc b/docs/discover/save-search.asciidoc index 10abef2e4a1bb..2e55a0889551b 100644 --- a/docs/discover/save-search.asciidoc +++ b/docs/discover/save-search.asciidoc @@ -1,9 +1,9 @@ [[save-open-search]] == Save a search for reuse -A saved search is a convenient way to reuse a search +A discover view is a convenient way to reuse a search that you've created in *Discover*. -Saved searches are good for adding search results to a dashboard, +Discover view are good for adding search results to a dashboard, and can also serve as a foundation for building visualizations. [role="xpack"] @@ -18,18 +18,18 @@ image::discover/images/read-only-badge.png[Example of Discover's read only acces [float] === Save a search -By default, a saved search stores the query text, filters, and +By default, a discover view stores the query text, filters, and current view of *Discover*, including the columns and sort order in the document table, and the {data-source}. . Once you've created a search worth saving, click *Save* in the toolbar. . Enter a name for the search. . Optionally store <> and the time range with the search. . Click *Save*. -. To reload your search results in *Discover*, click *Open* in the toolbar, and select the saved search. +. To reload your search results in *Discover*, click *Open* in the toolbar, and select the discover view. + -If the saved search is associated with a different {data-source} than is currently -selected, opening the saved search changes the selected {data-source}. The query language -used for the saved search is also automatically selected. +If the discover view is associated with a different {data-source} than is currently +selected, opening the discover view changes the selected {data-source}. The query language +used for the discover view is also automatically selected. [float] === Duplicate a search @@ -46,5 +46,5 @@ used for the saved search is also automatically selected. . Open the main menu, and then click *Dashboard*. . Open or create the dashboard, then click *Edit*. . Click *Add from library*. -. From the *Types* dropdown, select *Saved search*. -. Select the saved search that you want to visualize, then click *X* to close the list. +. From the *Types* dropdown, select *Discover view*. +. Select the discover view that you want to visualize, then click *X* to close the list. diff --git a/docs/discover/search-sessions.asciidoc b/docs/discover/search-sessions.asciidoc index 663c4231c0718..73d6fdc55da73 100644 --- a/docs/discover/search-sessions.asciidoc +++ b/docs/discover/search-sessions.asciidoc @@ -50,7 +50,7 @@ image::images/search-session-awhile.png[Search Session indicator displaying the Once you save a search session, you can start a new search, navigate to a different application, or close the browser. -. To view your saved searches, open the main menu, and then click +. To view your discover viewes, open the main menu, and then click *Stack Management > Search Sessions*. For a saved or completed session, you can also open this view from the search sessions popup. diff --git a/docs/discover/search.asciidoc b/docs/discover/search.asciidoc index 4f4f8f5b48d10..ff0dc8f40418a 100644 --- a/docs/discover/search.asciidoc +++ b/docs/discover/search.asciidoc @@ -93,9 +93,9 @@ status:[400 TO 499] AND (extension:php OR extension:html) [[save-open-search]] === Save a search -A saved search persists your current view of Discover for later retrieval and reuse. You can reload a saved search into Discover, add it to a dashboard, and use it as the basis for a visualization. +A discover view persists your current view of Discover for later retrieval and reuse. You can reload a discover view into Discover, add it to a dashboard, and use it as the basis for a visualization. -A saved search includes the query text, filters, and optionally, the time filter. A saved search also includes the selected columns in the document table, the sort order, and the current index pattern. +A discover view includes the query text, filters, and optionally, the time filter. A discover view also includes the selected columns in the document table, the sort order, and the current index pattern. [role="xpack"] [[discover-read-only-access]] @@ -113,18 +113,18 @@ To save the current search: . Click *Save* in the toolbar. . Enter a name for the search and click *Save*. -To import, export, and delete saved searches, open the main menu, +To import, export, and delete discover viewes, open the main menu, then click *Stack Management > Saved Objects*. -==== Open a saved search -To load a saved search into Discover: +==== Open a discover view +To load a discover view into Discover: . Click *Open* in the toolbar. . Select the search you want to open. -If the saved search is associated with a different index pattern than is currently -selected, opening the saved search changes the selected index pattern. The query language -used for the saved search will also be automatically selected. +If the discover view is associated with a different index pattern than is currently +selected, opening the discover view changes the selected index pattern. The query language +used for the discover view will also be automatically selected. [[save-load-delete-query]] === Save a query @@ -134,7 +134,7 @@ A saved query is a portable collection of query text and filters that you can re * View the results of the same query in multiple apps * Share your query -Saved queries don't include information specific to Discover, such as the currently selected columns in the document table, the sort order, and the index pattern. If you want to save your current view of Discover for later retrieval and reuse, create a <> instead. +Saved queries don't include information specific to Discover, such as the currently selected columns in the document table, the sort order, and the index pattern. If you want to save your current view of Discover for later retrieval and reuse, create a <> instead. [role="xpack"] ==== Read-only access diff --git a/docs/management/advanced-options.asciidoc b/docs/management/advanced-options.asciidoc index f18b29ac3737a..06ee3423789a8 100644 --- a/docs/management/advanced-options.asciidoc +++ b/docs/management/advanced-options.asciidoc @@ -313,7 +313,7 @@ When disabled, *Discover* loads fields using the {es} search API's [[discover-searchonpageload]]`discover:searchOnPageLoad`:: Controls whether a search is executed when *Discover* first loads. This setting -does not have an effect when loading a saved search. +does not have an effect when loading a discover view. [[discover:showFieldStatistics]]`discover:showFieldStatistics`:: beta[] Enables the Field statistics view. Examine details such as @@ -329,10 +329,10 @@ To calculate the top values for a field in the sidebar using 500 instead of 5,00 The default sort direction for time-based data views. [[doctable-hidetimecolumn]]`doc_table:hideTimeColumn`:: -Hides the "Time" column in *Discover* and in all saved searches on dashboards. +Hides the "Time" column in *Discover* and in all discover viewes on dashboards. [[doctable-highlight]]`doc_table:highlight`:: -Highlights results in *Discover* and saved searches on dashboards. Highlighting +Highlights results in *Discover* and discover viewes on dashboards. Highlighting slows requests when working on big documents. [[doctable-legacy]]`doc_table:legacy`:: diff --git a/docs/settings/reporting-settings.asciidoc b/docs/settings/reporting-settings.asciidoc index 192a47e184c43..5633a039ed20e 100644 --- a/docs/settings/reporting-settings.asciidoc +++ b/docs/settings/reporting-settings.asciidoc @@ -254,10 +254,10 @@ Enables a check that warns you when there's a potential formula included in the Escape formula values in cells with a `'`. See OWASP: https://www.owasp.org/index.php/CSV_Injection. Defaults to `true`. `xpack.reporting.csv.enablePanelActionDownload`:: -deprecated:[7.9.0,This setting has no effect.] Enables CSV export from a saved search on a dashboard. This action is available in the dashboard panel menu for the saved search. +deprecated:[7.9.0,This setting has no effect.] Enables CSV export from a discover view on a dashboard. This action is available in the dashboard panel menu for the discover view. [NOTE] ============ -This setting exists for backwards compatibility, and is hardcoded to `true`. CSV export from a saved search on a dashboard is enabled when Reporting is enabled. +This setting exists for backwards compatibility, and is hardcoded to `true`. CSV export from a discover view on a dashboard is enabled when Reporting is enabled. ============ `xpack.reporting.csv.useByteOrderMarkEncoding`:: diff --git a/docs/setup/configuring-reporting.asciidoc b/docs/setup/configuring-reporting.asciidoc index 5828c740d1254..c12bed853c8e3 100644 --- a/docs/setup/configuring-reporting.asciidoc +++ b/docs/setup/configuring-reporting.asciidoc @@ -139,8 +139,8 @@ PUT :/api/security/role/custom_reporting_user // CONSOLE <1> Grants access to generate PNG and PDF reports in *Dashboard*. -<2> Grants access to download CSV files from saved search panels in *Dashboard*. -<3> Grants access to generate CSV reports from saved searches in *Discover*. +<2> Grants access to download CSV files from discover view panels in *Dashboard*. +<3> Grants access to generate CSV reports from discover viewes in *Discover*. <4> Grants access to generate PDF reports in *Canvas*. <5> Grants access to generate PNG and PDF reports in *Visualize Library*. @@ -175,8 +175,8 @@ PUT localhost:5601/api/security/role/custom_reporting_user --------------------------------------------------------------- // CONSOLE -<1> Grants access to generate CSV reports from saved searches in *Discover*. -<2> Grants access to download CSV reports from saved search panels in *Dashboard*. +<1> Grants access to generate CSV reports from discover viewes in *Discover*. +<2> Grants access to download CSV reports from discover view panels in *Dashboard*. [float] [[grant-user-access-external-provider]] diff --git a/docs/user/dashboard/aggregation-based.asciidoc b/docs/user/dashboard/aggregation-based.asciidoc index 9098ea6265291..d58096bf11ed7 100644 --- a/docs/user/dashboard/aggregation-based.asciidoc +++ b/docs/user/dashboard/aggregation-based.asciidoc @@ -7,7 +7,7 @@ With aggregation-based visualizations, you can: * Split charts up to three aggregation levels, which is more than *Lens* and *TSVB* * Create visualization with non-time series data -* Use a <> as an input +* Use a <> as an input * Sort data tables and use the summary row and percentage column features * Assign colors to data series * Extend features with plugins @@ -112,7 +112,7 @@ Choose the type of visualization you want to create, then use the editor to conf .. Select the data source you want to visualize. + -NOTE: There is no performance impact on the data source you select. For example, *Discover* saved searches perform the same as {data-sources}. +NOTE: There is no performance impact on the data source you select. For example, *Discover* discover viewes perform the same as {data-sources}. . Add the <> you want to visualize using the editor, then click *Update*. + diff --git a/docs/user/dashboard/lens.asciidoc b/docs/user/dashboard/lens.asciidoc index b3c5c4980e933..397d4d5228bd3 100644 --- a/docs/user/dashboard/lens.asciidoc +++ b/docs/user/dashboard/lens.asciidoc @@ -588,10 +588,10 @@ For area, line, and bar charts, press Shift, then click the series in the legend [discrete] [[is-it-possible-to-use-saved-serches-in-lens]] -.*How do I visualize saved searches?* +.*How do I visualize discover viewes?* [%collapsible] ==== -Visualizing saved searches in unsupported. +Visualizing discover viewes in unsupported. ==== [discrete] diff --git a/docs/user/dashboard/make-dashboards-interactive.asciidoc b/docs/user/dashboard/make-dashboards-interactive.asciidoc index e9833d3a542d5..cea9306464528 100644 --- a/docs/user/dashboard/make-dashboards-interactive.asciidoc +++ b/docs/user/dashboard/make-dashboards-interactive.asciidoc @@ -207,9 +207,9 @@ To enable series data interactions, configure <> data in *Discover*. +* *Discover view interactions* — Opens <> data in *Discover*. + -To use saved search interactions, open the panel menu, then click *More > View saved search*. +To use discover view interactions, open the panel menu, then click *More > View discover view*. [[dashboard-links]] === Create links to other dashboards diff --git a/docs/user/dashboard/tsvb.asciidoc b/docs/user/dashboard/tsvb.asciidoc index ce88eef405aa9..e1b950903ff0c 100644 --- a/docs/user/dashboard/tsvb.asciidoc +++ b/docs/user/dashboard/tsvb.asciidoc @@ -233,7 +233,7 @@ For example `https://example.org/{{key}}` This instructs TSVB to substitute the value from your visualization wherever it sees `{{key}}`. -If your data contain reserved or invalid URL characters such as "#" or "&", you should apply a transform to URL-encode the key like this `{{encodeURIComponent key}}`. If you are dynamically constructing a drilldown to another location in Kibana (for example, clicking a table row takes to you a value-scoped saved search), you will likely want to Rison-encode your key as it may contain invalid Rison characters. (https://github.com/Nanonid/rison#rison---compact-data-in-uris[Rison] is the serialization format many parts of Kibana use to store information in their URL.) +If your data contain reserved or invalid URL characters such as "#" or "&", you should apply a transform to URL-encode the key like this `{{encodeURIComponent key}}`. If you are dynamically constructing a drilldown to another location in Kibana (for example, clicking a table row takes to you a value-scoped discover view), you will likely want to Rison-encode your key as it may contain invalid Rison characters. (https://github.com/Nanonid/rison#rison---compact-data-in-uris[Rison] is the serialization format many parts of Kibana use to store information in their URL.) For example: `discover#/view/0ac50180-82d9-11ec-9f4a-55de56b00cc0?_a=(filters:!((query:(match_phrase:(foo.keyword:{{rison key}})))))` diff --git a/docs/user/management.asciidoc b/docs/user/management.asciidoc index 73f13e47c41d7..f8ae48f9c52fe 100644 --- a/docs/user/management.asciidoc +++ b/docs/user/management.asciidoc @@ -85,7 +85,7 @@ You can add and remove remote clusters, and check their connectivity. | <> | Monitor the generation of reports—PDF, PNG, and CSV—and download reports that you previously generated. -A report can contain a dashboard, visualization, saved search, or Canvas workpad. +A report can contain a dashboard, visualization, discover view, or Canvas workpad. | Machine Learning Jobs | View, export, and import your <> and @@ -147,7 +147,7 @@ These include dashboards, visualizations, maps, data views, Canvas workpads, and |Create, manage, and assign tags to your saved objects. | <> -| Manage your saved search sessions, groups of queries that run in the background. +| Manage your discover view sessions, groups of queries that run in the background. Search sessions are useful when your queries take longer than usual to process, for example, when you have a large volume of data or when the performance of your storage location is slow. diff --git a/docs/user/ml/index.asciidoc b/docs/user/ml/index.asciidoc index 4f25e0aa45c78..2488db552479c 100644 --- a/docs/user/ml/index.asciidoc +++ b/docs/user/ml/index.asciidoc @@ -156,7 +156,7 @@ workflow view. Examine the histogram chart of the log rates for a given millions of log events across multiple fields and values. You can find log rate analysis under **{ml-app}** > **AIOps Labs** where -you can select the {data-source} or saved search that you want to analyze. +you can select the {data-source} or discover view that you want to analyze. [role="screenshot"] image::user/ml/images/ml-log-rate-analysis-before.png[Log event histogram chart] @@ -198,7 +198,7 @@ and an example document that matches the category. //end::log-pattern-analysis-intro[] You can find log pattern analysis under **{ml-app}** > **AIOps Labs** where you -can select the {data-source} or saved search that you want to analyze, or in +can select the {data-source} or discover view that you want to analyze, or in **Discover** as an available action for any text field. [role="screenshot"] @@ -223,7 +223,7 @@ to detect distribution changes, trend changes, and other statistically significant change points in a metric of your time series data. You can find change point detection under **{ml-app}** > **AIOps Labs** where -you can select the {data-source} or saved search that you want to analyze. +you can select the {data-source} or discover view that you want to analyze. [role="screenshot"] image::user/ml/images/ml-change-point-detection.png[Change point detection UI] diff --git a/docs/user/reporting/automating-report-generation.asciidoc b/docs/user/reporting/automating-report-generation.asciidoc index f2102e7c0e2db..e675dedb88279 100644 --- a/docs/user/reporting/automating-report-generation.asciidoc +++ b/docs/user/reporting/automating-report-generation.asciidoc @@ -26,7 +26,7 @@ To create the POST URL for CSV reports: . Open the main menu, then click *Discover*. -. Open the saved search you want to share. +. Open the discover view you want to share. . In the toolbar, click *Share > CSV Reports > Copy POST URL*. @@ -56,7 +56,7 @@ If you experience issues with the deprecated report URLs after you upgrade {kib} * *Dashboard* reports: `/api/reporting/generate/dashboard/` * *Visualize Library* reports: `/api/reporting/generate/visualization/` -* *Discover* saved search reports: `/api/reporting/generate/search/` +* *Discover* discover view reports: `/api/reporting/generate/search/` IMPORTANT: In earlier {kib} versions, you could use the `&sync` parameter to append to report URLs that held the request open until the document was fully generated. The `&sync` parameter is now unsupported. If you use the `&sync` parameter in Watcher, you must update the parameter. diff --git a/docs/user/reporting/index.asciidoc b/docs/user/reporting/index.asciidoc index d66563bec0ae2..8879a73097025 100644 --- a/docs/user/reporting/index.asciidoc +++ b/docs/user/reporting/index.asciidoc @@ -4,10 +4,10 @@ [partintro] -- -:frontmatter-description: {kib} provides you with several options to share *Discover* saved searches, dashboards, *Visualize Library* visualizations, and *Canvas* workpads with others, or on a website. +:frontmatter-description: {kib} provides you with several options to share *Discover* discover viewes, dashboards, *Visualize Library* visualizations, and *Canvas* workpads with others, or on a website. :frontmatter-tags-products: [kibana] -{kib} provides you with several options to share *Discover* saved searches, dashboards, *Visualize Library* visualizations, and *Canvas* workpads. +{kib} provides you with several options to share *Discover* discover viewes, dashboards, *Visualize Library* visualizations, and *Canvas* workpads. You access the options from the *Share* menu in the toolbar. The sharing options include the following: @@ -15,11 +15,11 @@ You access the options from the *Share* menu in the toolbar. The sharing options * *PNG Reports* — Generate and download PNG files of dashboards and visualizations. PNG reports are a link:https://www.elastic.co/subscriptions[subscription feature]. -* *CSV Reports* — Generate and download CSV files of saved searches. <>. +* *CSV Reports* — Generate and download CSV files of discover viewes. <>. * *CSV Download* — Generate and download CSV files of *Lens* visualizations. -* *Get links* — Share direct links to saved searches, dashboards, and visualizations. +* *Get links* — Share direct links to discover viewes, dashboards, and visualizations. * *Download as JSON* — Generate and download JSON files of *Canvas* workpads. @@ -37,11 +37,11 @@ For more information on how to configure reporting in {kib}, refer to < 'discoverApp', - name: 'Saved search', + name: 'Discover view', }, { type: 'index-pattern', diff --git a/examples/discover_customization_examples/public/plugin.tsx b/examples/discover_customization_examples/public/plugin.tsx index b66559b020d7a..c5bc18e15ff4d 100644 --- a/examples/discover_customization_examples/public/plugin.tsx +++ b/examples/discover_customization_examples/public/plugin.tsx @@ -134,9 +134,9 @@ export class DiscoverCustomizationExamplesPlugin implements Plugin { onClick: () => alert('Make a copy clicked'), }, { - name: 'Manage saved searches', + name: 'Manage discover viewes', icon: 'gear', - onClick: () => alert('Manage saved searches clicked'), + onClick: () => alert('Manage discover viewes clicked'), }, ], }, diff --git a/legacy_rfcs/text/0013_search_sessions.md b/legacy_rfcs/text/0013_search_sessions.md index 4de9617455e56..57bc95d3b105d 100644 --- a/legacy_rfcs/text/0013_search_sessions.md +++ b/legacy_rfcs/text/0013_search_sessions.md @@ -17,7 +17,7 @@ Search Sessions will enable Kibana applications and solutions to start a group o At its core, search sessions are enabled via several new APIs, that: - Start a session, associating multiple search requests with a single entity - Store the session (and continue search requests in the background) -- Restore the saved search session +- Restore the discover view session ```ts const searchService = dataPluginStart.search; @@ -98,7 +98,7 @@ export enum SearchSessionStatus { The saved object created for a search session will be scoped to a single space, and will be a `hidden` saved object (so that it doesn't show in the management listings). We will provide a separate interface for users to manage their own -saved search sessions (which will use the `list`, `expire`, and `extend` methods described below, which will be restricted +discover view sessions (which will use the `list`, `expire`, and `extend` methods described below, which will be restricted per-user). ```ts diff --git a/packages/kbn-failed-test-reporter-cli/failed_tests_reporter/__fixtures__/ftr_report.xml b/packages/kbn-failed-test-reporter-cli/failed_tests_reporter/__fixtures__/ftr_report.xml index 3bfc686f9e845..e9e304204427c 100644 --- a/packages/kbn-failed-test-reporter-cli/failed_tests_reporter/__fixtures__/ftr_report.xml +++ b/packages/kbn-failed-test-reporter-cli/failed_tests_reporter/__fixtures__/ftr_report.xml @@ -41,7 +41,7 @@ Wait timed out after 10055ms - + { ‹/system-out› ‹skipped/› ‹/testcase› - ‹testcase name="machine learning anomaly detection saved search with lucene query job creation opens the advanced section" classname="Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job·ts" time="6.040"› + ‹testcase name="machine learning anomaly detection discover view with lucene query job creation opens the advanced section" classname="Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job·ts" time="6.040"› - ‹system-out›‹![CDATA[[00:21:57] └-: machine learning...]]›‹/system-out› - ‹failure›‹![CDATA[{ NoSuchSessionError: Tried to run command without establishing a connection + ‹system-out›[00:21:57] └-: machine learning...‹/system-out› diff --git a/packages/kbn-failed-test-reporter-cli/failed_tests_reporter/get_failures.test.ts b/packages/kbn-failed-test-reporter-cli/failed_tests_reporter/get_failures.test.ts index 77d7cd93ce4b0..ca51ba8f88aee 100644 --- a/packages/kbn-failed-test-reporter-cli/failed_tests_reporter/get_failures.test.ts +++ b/packages/kbn-failed-test-reporter-cli/failed_tests_reporter/get_failures.test.ts @@ -62,7 +62,7 @@ it('discovers failures in ftr report', async () => { at Executor.execute (/dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/http.js:489:26) at process._tickCallback (internal/process/next_tick.js:68:7) name: 'NoSuchSessionError', remoteStacktrace: '' }", "likelyIrrelevant": true, - "name": "machine learning anomaly detection saved search with lucene query job creation opens the advanced section", + "name": "machine learning anomaly detection discover view with lucene query job creation opens the advanced section", "system-out": "[00:21:57] └-: machine learning...", "time": "6.040", }, @@ -111,7 +111,7 @@ it('discovers failures in mocha report', async () => { "likelyIrrelevant": true, "name": "code in multiple nodes \\"before all\\" hook", "system-out": " - + ", "time": "0.121", }, @@ -125,7 +125,7 @@ it('discovers failures in mocha report', async () => { "likelyIrrelevant": true, "name": "code in multiple nodes \\"after all\\" hook", "system-out": " - + ", "time": "0.003", }, diff --git a/packages/kbn-reporting/export_types/csv/csv_v2.ts b/packages/kbn-reporting/export_types/csv/csv_v2.ts index b8001f2145405..2a28b9ea614f1 100644 --- a/packages/kbn-reporting/export_types/csv/csv_v2.ts +++ b/packages/kbn-reporting/export_types/csv/csv_v2.ts @@ -125,7 +125,7 @@ export class CsvV2ExportType extends ExportType< if (query && 'esql' in query) { // TODO: use columnsFromLocator - // currently locatorClient.columnsFromLocator can only extract columns from the saved search, + // currently locatorClient.columnsFromLocator can only extract columns from the discover view, // but for the es|ql we simply want to get currently visible columns from params.columns. // we didn't want to add this change inside locatorClient.columnsFromLocator, as it would change the behaviour of csv_v2 for non-ES|QL export, // this should be addressed here https://github.com/elastic/kibana/issues/151190 diff --git a/packages/kbn-reporting/export_types/csv_common/index.ts b/packages/kbn-reporting/export_types/csv_common/index.ts index ec46c66ea3c25..b7010d519eb7f 100644 --- a/packages/kbn-reporting/export_types/csv_common/index.ts +++ b/packages/kbn-reporting/export_types/csv_common/index.ts @@ -36,7 +36,7 @@ interface CsvFromSavedObjectBase { } /** - * Makes title optional, as it can be derived from the saved search object + * Makes title optional, as it can be derived from the discover view object */ export type JobParamsCsvFromSavedObject = CsvFromSavedObjectBase & Omit & { title?: string }; diff --git a/packages/kbn-unified-data-table/src/types.ts b/packages/kbn-unified-data-table/src/types.ts index a27f1db510cbe..65f6f3ffc1b7d 100644 --- a/packages/kbn-unified-data-table/src/types.ts +++ b/packages/kbn-unified-data-table/src/types.ts @@ -13,7 +13,7 @@ import type { DataView } from '@kbn/data-views-plugin/common'; import type { FieldFormatsStart } from '@kbn/field-formats-plugin/public'; /** - * User configurable state of data grid, persisted in saved search + * User configurable state of data grid, persisted in discover view */ export interface UnifiedDataTableSettings { columns?: Record; diff --git a/src/plugins/dashboard/public/plugin.tsx b/src/plugins/dashboard/public/plugin.tsx index 8fb1260eb327d..7e8ecd44a5f68 100644 --- a/src/plugins/dashboard/public/plugin.tsx +++ b/src/plugins/dashboard/public/plugin.tsx @@ -299,7 +299,7 @@ export class DashboardPlugin defaultMessage: 'Analyze data in dashboards.', }), description: i18n.translate('dashboard.featureCatalogue.dashboardDescription', { - defaultMessage: 'Display and share a collection of visualizations and saved searches.', + defaultMessage: 'Display and share a collection of visualizations and discover viewes.', }), icon: 'dashboardApp', path: `/app/${DASHBOARD_APP_ID}#${LANDING_PAGE_PATH}`, diff --git a/src/plugins/data/config.ts b/src/plugins/data/config.ts index b6adfdede2469..fccff553be854 100644 --- a/src/plugins/data/config.ts +++ b/src/plugins/data/config.ts @@ -31,7 +31,7 @@ export const searchSessionsConfigSchema = schema.object({ defaultExpiration: schema.duration({ defaultValue: '7d' }), management: schema.object({ /** - * maxSessions controls how many saved search sessions we load on the management screen. + * maxSessions controls how many discover view sessions we load on the management screen. */ maxSessions: schema.number({ defaultValue: 100 }), /** @@ -57,7 +57,7 @@ export const searchConfigSchema = schema.object({ */ waitForCompletion: schema.duration({ defaultValue: '200ms' }), /** - * How long the async search needs to be available after each search poll. Ongoing async searches and any saved search results are deleted after this period. + * How long the async search needs to be available after each search poll. Ongoing async searches and any discover view results are deleted after this period. * (see es async_search's `keep_alive`) * Note: This is applicable to the searches before the search session is saved. * After search session is saved `keep_alive` is extended using `data.search.sessions.defaultExpiration` config diff --git a/src/plugins/data/public/search/session/session_service.ts b/src/plugins/data/public/search/session/session_service.ts index 70c343651e611..42e5384c3b7b8 100644 --- a/src/plugins/data/public/search/session/session_service.ts +++ b/src/plugins/data/public/search/session/session_service.ts @@ -430,7 +430,7 @@ export class SessionService { } /** - * Is restoring the older saved searches + * Is restoring the older discover viewes */ public isRestore() { return this.state.get().isRestore; @@ -449,7 +449,7 @@ export class SessionService { } /** - * Restore previously saved search session + * Restore previously discover view session * @param sessionId */ public restore(sessionId: string) { diff --git a/src/plugins/data/public/search/session/sessions_mgmt/components/main.tsx b/src/plugins/data/public/search/session/sessions_mgmt/components/main.tsx index 69706b21dde80..75440f34899d2 100644 --- a/src/plugins/data/public/search/session/sessions_mgmt/components/main.tsx +++ b/src/plugins/data/public/search/session/sessions_mgmt/components/main.tsx @@ -40,7 +40,7 @@ export function SearchSessionsMgmtMain({ documentation, ...tableProps }: Props) description={ } bottomBorder diff --git a/src/plugins/data_view_editor/public/components/rollup_beta_warning/rollup_beta_warning.tsx b/src/plugins/data_view_editor/public/components/rollup_beta_warning/rollup_beta_warning.tsx index 15fa8d626e4a1..58f5343cc2a69 100644 --- a/src/plugins/data_view_editor/public/components/rollup_beta_warning/rollup_beta_warning.tsx +++ b/src/plugins/data_view_editor/public/components/rollup_beta_warning/rollup_beta_warning.tsx @@ -25,7 +25,7 @@ export const RollupBetaWarning = () => (

diff --git a/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap index 1f56e3caeaf6b..d459a6c3e2a52 100644 --- a/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap +++ b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap @@ -7,7 +7,7 @@ exports[`Header should render normally 1`] = ` >

diff --git a/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/header.tsx b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/header.tsx index 82c40fd9681ae..ddcf426128ebd 100644 --- a/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/header.tsx +++ b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/header.tsx @@ -18,7 +18,7 @@ export const Header = () => (

diff --git a/src/plugins/discover/README.md b/src/plugins/discover/README.md index 6240cd63f3ea3..4c995adc5f8f4 100644 --- a/src/plugins/discover/README.md +++ b/src/plugins/discover/README.md @@ -1,6 +1,6 @@ # Discover -Contains the Discover application and the saved search embeddable. +Contains the Discover application and the discover view embeddable. ## Project tree @@ -16,7 +16,7 @@ One folder for every "route", each folder contains files and folders related onl * **[/not_found](./public/application/not_found)** (Rendered when a route can't be found) * **[/view_alert](./public/application/view_alert)** (Forwarding links in alert notifications) * **[/components](./public/components)** (All React components used in more than just one app) -* **[/embeddable](./public/embeddable)** (Code related to the saved search embeddable, rendered on dashboards) +* **[/embeddable](./public/embeddable)** (Code related to the discover view embeddable, rendered on dashboards) * **[/hooks](./public/hooks)** (Code containing React hooks) * **[/services](./public/services)** (Services either for external or internal use) * **[/utils](./public/utils)** (All utility functions used across more than one application) diff --git a/src/plugins/discover/common/locator.test.ts b/src/plugins/discover/common/locator.test.ts index 93da54ad365e9..b956479b03f19 100644 --- a/src/plugins/discover/common/locator.test.ts +++ b/src/plugins/discover/common/locator.test.ts @@ -38,7 +38,7 @@ beforeEach(() => { }); describe('Discover url generator', () => { - test('can create a link to Discover with no state and no saved search', async () => { + test('can create a link to Discover with no state and no discover view', async () => { const { locator } = await setup(); const { app, path } = await locator.getLocation({}); const { _a, _g } = getStatesFromKbnUrl(path, ['_a', '_g']); @@ -48,7 +48,7 @@ describe('Discover url generator', () => { expect(_g).toEqual(undefined); }); - test('can create a link to a saved search in Discover', async () => { + test('can create a link to a discover view in Discover', async () => { const { locator } = await setup(); const { path } = await locator.getLocation({ savedSearchId }); const { _a, _g } = getStatesFromKbnUrl(path, ['_a', '_g']); diff --git a/src/plugins/discover/common/locator.ts b/src/plugins/discover/common/locator.ts index 9be9947e743dd..3080f5959e22a 100644 --- a/src/plugins/discover/common/locator.ts +++ b/src/plugins/discover/common/locator.ts @@ -20,7 +20,7 @@ export const DISCOVER_APP_LOCATOR = 'DISCOVER_APP_LOCATOR'; export interface DiscoverAppLocatorParams extends SerializableRecord { /** - * Optionally set saved search ID. + * Optionally set discover view ID. */ savedSearchId?: string; diff --git a/src/plugins/discover/kibana.jsonc b/src/plugins/discover/kibana.jsonc index fbbfcbaaca1ab..4716e76357c4d 100644 --- a/src/plugins/discover/kibana.jsonc +++ b/src/plugins/discover/kibana.jsonc @@ -2,7 +2,7 @@ "type": "plugin", "id": "@kbn/discover-plugin", "owner": "@elastic/kibana-data-discovery", - "description": "This plugin contains the Discover application and the saved search embeddable.", + "description": "This plugin contains the Discover application and the discover view embeddable.", "plugin": { "id": "discover", "server": true, diff --git a/src/plugins/discover/public/__mocks__/saved_search.ts b/src/plugins/discover/public/__mocks__/saved_search.ts index 90a2a9c680825..42346e09c2abc 100644 --- a/src/plugins/discover/public/__mocks__/saved_search.ts +++ b/src/plugins/discover/public/__mocks__/saved_search.ts @@ -14,7 +14,7 @@ import { dataViewAdHoc } from './data_view_complex'; export const savedSearchMock = { id: 'the-saved-search-id', - title: 'A saved search', + title: 'A discover view', searchSource: createSearchSourceMock({ index: dataViewMock }), } as unknown as SavedSearch; diff --git a/src/plugins/discover/public/application/main/components/field_stats_table/field_stats_table.tsx b/src/plugins/discover/public/application/main/components/field_stats_table/field_stats_table.tsx index bba3e23d3e70f..11f484b86c271 100644 --- a/src/plugins/discover/public/application/main/components/field_stats_table/field_stats_table.tsx +++ b/src/plugins/discover/public/application/main/components/field_stats_table/field_stats_table.tsx @@ -74,15 +74,15 @@ export interface FieldStatisticsTableProps { */ dataView: DataView; /** - * Saved search description + * Discover view description */ searchDescription?: string; /** - * Saved search title + * Discover view title */ searchTitle?: string; /** - * Optional saved search + * Optional discover view */ savedSearch?: SavedSearch; /** diff --git a/src/plugins/discover/public/application/main/components/top_nav/__snapshots__/open_search_panel.test.tsx.snap b/src/plugins/discover/public/application/main/components/top_nav/__snapshots__/open_search_panel.test.tsx.snap index 6ef8eda69cfff..1c39a9a456729 100644 --- a/src/plugins/discover/public/application/main/components/top_nav/__snapshots__/open_search_panel.test.tsx.snap +++ b/src/plugins/discover/public/application/main/components/top_nav/__snapshots__/open_search_panel.test.tsx.snap @@ -35,7 +35,7 @@ exports[`OpenSearchPanel render 1`] = ` Array [ Object { "getIconForSavedObject": [Function], - "name": "Saved search", + "name": "Discover view", "type": "search", }, ] diff --git a/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_badges.test.ts b/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_badges.test.ts index 18cd2791ab293..8cfa21a34b445 100644 --- a/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_badges.test.ts +++ b/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_badges.test.ts @@ -43,12 +43,12 @@ describe('getTopNavBadges()', function () { `); }); - describe('managed saved search', () => { + describe('managed discover view', () => { const stateContainerWithManagedSavedSearch = getDiscoverStateMock({ savedSearch: { ...savedSearchMock, managed: true }, }); - test('should return the managed badge when managed saved search', () => { + test('should return the managed badge when managed discover view', () => { const topNavBadges = getTopNavBadges({ hasUnsavedChanges: false, services: discoverServiceMock, diff --git a/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_badges.tsx b/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_badges.tsx index 0510df0bc3a1a..f5151952b3d6c 100644 --- a/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_badges.tsx +++ b/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_badges.tsx @@ -64,7 +64,7 @@ export const getTopNavBadges = ({ data: getManagedContentBadge( i18n.translate('discover.topNav.managedContentLabel', { defaultMessage: - 'This saved search is managed by Elastic. Changes here must be saved to a new saved search.', + 'This discover view is managed by Elastic. Changes here must be saved to a new discover view.', }) ), order: 101, diff --git a/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_links.tsx b/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_links.tsx index bbe9096226fb7..970c373266f99 100644 --- a/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_links.tsx +++ b/src/plugins/discover/public/application/main/components/top_nav/get_top_nav_links.tsx @@ -186,7 +186,7 @@ export const getTopNavLinks = ({ isTextBased, locatorParams: [{ id: locator.id, params }], ...searchSourceSharingData, - // CSV reports can be generated without a saved search so we provide a fallback title + // CSV reports can be generated without a discover view so we provide a fallback title title: savedSearch.title || i18n.translate('discover.localMenu.fallbackReportTitle', { diff --git a/src/plugins/discover/public/application/main/components/top_nav/on_save_search.test.tsx b/src/plugins/discover/public/application/main/components/top_nav/on_save_search.test.tsx index 1d422baf238ff..8406c2306f76e 100644 --- a/src/plugins/discover/public/application/main/components/top_nav/on_save_search.test.tsx +++ b/src/plugins/discover/public/application/main/components/top_nav/on_save_search.test.tsx @@ -90,7 +90,7 @@ describe('onSaveSearch', () => { expect(saveModal?.props.tags).toEqual(['tag1', 'tag2']); }); - it('should update the saved search tags', async () => { + it('should update the discover view tags', async () => { let saveModal: ReactElement | undefined; jest.spyOn(savedObjectsPlugin, 'showSaveModal').mockImplementationOnce((modal) => { saveModal = modal; diff --git a/src/plugins/discover/public/application/main/components/top_nav/on_save_search.tsx b/src/plugins/discover/public/application/main/components/top_nav/on_save_search.tsx index 443a528e26e6e..25e770463184e 100644 --- a/src/plugins/discover/public/application/main/components/top_nav/on_save_search.tsx +++ b/src/plugins/discover/public/application/main/components/top_nav/on_save_search.tsx @@ -251,7 +251,7 @@ const SaveSearchObjectModal: React.FC<{ label={ } /> @@ -274,7 +274,7 @@ const SaveSearchObjectModal: React.FC<{ initialCopyOnSave={initialCopyOnSave} description={description} objectType={i18n.translate('discover.localMenu.saveSaveSearchObjectType', { - defaultMessage: 'search', + defaultMessage: 'Discover view', })} showDescription={true} options={options} @@ -284,7 +284,7 @@ const SaveSearchObjectModal: React.FC<{ managed ? i18n.translate('discover.localMenu.mustCopyOnSave', { defaultMessage: - 'This saved search is managed by Elastic. Changes here must be saved to a new saved search.', + 'This discover view is managed by Elastic. Changes here must be saved to a new discover view.', }) : undefined } diff --git a/src/plugins/discover/public/application/main/components/top_nav/open_search_panel.tsx b/src/plugins/discover/public/application/main/components/top_nav/open_search_panel.tsx index a571ec2db7784..3b12ec6a2c846 100644 --- a/src/plugins/discover/public/application/main/components/top_nav/open_search_panel.tsx +++ b/src/plugins/discover/public/application/main/components/top_nav/open_search_panel.tsx @@ -65,7 +65,7 @@ export function OpenSearchPanel(props: OpenSearchPanelProps) { type: SEARCH_OBJECT_TYPE, getIconForSavedObject: () => 'discoverApp', name: i18n.translate('discover.savedSearch.savedObjectName', { - defaultMessage: 'Saved search', + defaultMessage: 'Discover view', }), }, ]} diff --git a/src/plugins/discover/public/application/main/hooks/use_url.test.ts b/src/plugins/discover/public/application/main/hooks/use_url.test.ts index e66f793ee14b2..822c62362ff5a 100644 --- a/src/plugins/discover/public/application/main/hooks/use_url.test.ts +++ b/src/plugins/discover/public/application/main/hooks/use_url.test.ts @@ -31,20 +31,20 @@ function prepareTest(savedSearch: SavedSearch, path: string) { } describe('test useUrl when the url is changed to /', () => { test('loadSavedSearch is not triggered when the url is e.g. /new', () => { - // the switch to loading the new saved search is taken care in the main route + // the switch to loading the new discover view is taken care in the main route const { load } = prepareTest(savedSearchMockWithTimeFieldNew, '/new'); expect(load).toHaveBeenCalledTimes(0); }); - test('loadSavedSearch is not triggered when a persisted saved search is pre-selected', () => { - // the switch to loading the new saved search is taken care in the main route + test('loadSavedSearch is not triggered when a persisted discover view is pre-selected', () => { + // the switch to loading the new discover view is taken care in the main route const { load } = prepareTest(savedSearchMockWithTimeField, '/'); expect(load).toHaveBeenCalledTimes(0); }); - test('loadSavedSearch is triggered when a new saved search is pre-selected', () => { + test('loadSavedSearch is triggered when a new discover view is pre-selected', () => { const { load } = prepareTest(savedSearchMockWithTimeFieldNew, '/'); expect(load).toHaveBeenCalledTimes(1); }); - test('loadSavedSearch is triggered when a new saved search is pre-selected with an active profile', () => { + test('loadSavedSearch is triggered when a new discover view is pre-selected with an active profile', () => { const { load } = prepareTest(savedSearchMockWithTimeFieldNew, addProfile('', 'test')); expect(load).toHaveBeenCalledTimes(1); }); diff --git a/src/plugins/discover/public/application/main/services/discover_app_state_container.test.ts b/src/plugins/discover/public/application/main/services/discover_app_state_container.test.ts index a215635e7cde8..5e685c6b09b55 100644 --- a/src/plugins/discover/public/application/main/services/discover_app_state_container.test.ts +++ b/src/plugins/discover/public/application/main/services/discover_app_state_container.test.ts @@ -89,7 +89,7 @@ describe('Test discover app state container', () => { const localSavedSearchMock = { id: 'the-saved-search-id', - title: 'A saved search', + title: 'A discover view', breakdownField: 'customBreakDownField', searchSource: createSearchSourceMock({ index: dataViewMock, @@ -130,7 +130,7 @@ describe('Test discover app state container', () => { .mockReturnValue(defaultQuery); const newSavedSearchMock = { id: 'new-saved-search-id', - title: 'A saved search', + title: 'A discover view', searchSource: createSearchSourceMock({ index: dataViewMock, filter: [customFilter], diff --git a/src/plugins/discover/public/application/main/services/discover_app_state_container.ts b/src/plugins/discover/public/application/main/services/discover_app_state_container.ts index e1614bf796391..0693c1bb0270d 100644 --- a/src/plugins/discover/public/application/main/services/discover_app_state_container.ts +++ b/src/plugins/discover/public/application/main/services/discover_app_state_container.ts @@ -46,7 +46,7 @@ export interface DiscoverAppStateContainer extends ReduxLikeStateContainer boolean; /** - * Initializes the state by the given saved search and starts syncing the state with the URL + * Initializes the state by the given discover view and starts syncing the state with the URL * @param currentSavedSearch */ initAndSync: (currentSavedSearch: SavedSearch) => () => void; @@ -76,7 +76,7 @@ export interface DiscoverAppStateContainer extends ReduxLikeStateContainer void; /* - * Get updated AppState when given a saved search + * Get updated AppState when given a discover view * * */ getAppStateFromSavedSearch: (newSavedSearch: SavedSearch) => DiscoverAppState; diff --git a/src/plugins/discover/public/application/main/services/discover_saved_search_container.test.ts b/src/plugins/discover/public/application/main/services/discover_saved_search_container.test.ts index 3ce4c969bbd3f..0ded3c64b3570 100644 --- a/src/plugins/discover/public/application/main/services/discover_saved_search_container.test.ts +++ b/src/plugins/discover/public/application/main/services/discover_saved_search_container.test.ts @@ -21,12 +21,12 @@ describe('DiscoverSavedSearchContainer', () => { const globalStateContainer = getDiscoverGlobalStateContainer(createKbnUrlStateStorage()); describe('getTitle', () => { - it('returns undefined for new saved searches', () => { + it('returns undefined for new discover viewes', () => { const container = getSavedSearchContainer({ services, globalStateContainer }); expect(container.getTitle()).toBe(undefined); }); - it('returns the title of a persisted saved searches', () => { + it('returns the title of a persisted discover viewes', () => { const container = getSavedSearchContainer({ services, globalStateContainer }); container.set(savedSearch); expect(container.getTitle()).toBe(savedSearch.title); @@ -34,7 +34,7 @@ describe('DiscoverSavedSearchContainer', () => { }); describe('set', () => { - it('should update the current and initial state of the saved search', () => { + it('should update the current and initial state of the discover view', () => { const container = getSavedSearchContainer({ services, globalStateContainer }); const newSavedSearch: SavedSearch = { ...savedSearch, title: 'New title' }; const result = container.set(newSavedSearch); @@ -57,7 +57,7 @@ describe('DiscoverSavedSearchContainer', () => { }); describe('new', () => { - it('should create a new saved search', async () => { + it('should create a new discover view', async () => { const container = getSavedSearchContainer({ services, globalStateContainer }); const result = await container.new(dataViewMock); @@ -70,7 +70,7 @@ describe('DiscoverSavedSearchContainer', () => { ); }); - it('should create a new saved search with provided DataView', async () => { + it('should create a new discover view with provided DataView', async () => { const container = getSavedSearchContainer({ services, globalStateContainer }); const result = await container.new(dataViewMock); expect(result.title).toBeUndefined(); @@ -86,7 +86,7 @@ describe('DiscoverSavedSearchContainer', () => { .mockReturnValue(savedSearchMock.searchSource); discoverServiceMock.savedSearch.get = jest.fn().mockReturnValue(savedSearchMock); - it('loads a saved search', async () => { + it('loads a discover view', async () => { const savedSearchContainer = getSavedSearchContainer({ services: discoverServiceMock, globalStateContainer, @@ -101,14 +101,14 @@ describe('DiscoverSavedSearchContainer', () => { describe('persist', () => { const saveOptions = { confirmOverwrite: false }; - it('calls saveSavedSearch with the given saved search and save options', async () => { + it('calls saveSavedSearch with the given discover view and save options', async () => { const savedSearchContainer = getSavedSearchContainer({ services: discoverServiceMock, globalStateContainer, }); const savedSearchToPersist = { ...savedSearchMockWithTimeField, - title: 'My updated saved search', + title: 'My updated discover view', }; await savedSearchContainer.persist(savedSearchToPersist, saveOptions); @@ -118,8 +118,8 @@ describe('DiscoverSavedSearchContainer', () => { ); }); - it('sets the initial and current saved search to the persisted saved search', async () => { - const title = 'My updated saved search'; + it('sets the initial and current discover view to the persisted discover view', async () => { + const title = 'My updated discover view'; const persistedSavedSearch = { ...savedSearch, title, @@ -145,7 +145,7 @@ describe('DiscoverSavedSearchContainer', () => { }); const savedSearchToPersist = { ...savedSearchMockWithTimeField, - title: 'My updated saved search', + title: 'My updated discover view', }; await savedSearchContainer.persist(savedSearchToPersist, saveOptions); @@ -164,7 +164,7 @@ describe('DiscoverSavedSearchContainer', () => { }); const savedSearchToPersist = { ...savedSearchMockWithTimeField, - title: 'My updated saved search', + title: 'My updated discover view', timeRestore: true, }; await savedSearchContainer.persist(savedSearchToPersist, saveOptions); @@ -177,7 +177,7 @@ describe('DiscoverSavedSearchContainer', () => { }); }); - it('Error thrown on persistence layer bubbling up, no changes to the initial saved search ', async () => { + it('Error thrown on persistence layer bubbling up, no changes to the initial discover view ', async () => { discoverServiceMock.savedSearch.save = jest.fn().mockImplementation(() => { throw new Error('oh-noes'); }); @@ -196,13 +196,13 @@ describe('DiscoverSavedSearchContainer', () => { } expect(savedSearchContainer.getHasChanged$().getValue()).toBe(true); expect(savedSearchContainer.getInitial$().getValue().title).not.toBe( - 'My updated saved search' + 'My updated discover view' ); }); }); describe('update', () => { - it('updates a saved search by app state providing hideChart', async () => { + it('updates a discover view by app state providing hideChart', async () => { const savedSearchContainer = getSavedSearchContainer({ services: discoverServiceMock, globalStateContainer, @@ -217,7 +217,7 @@ describe('DiscoverSavedSearchContainer', () => { savedSearchContainer.update({ nextState: { hideChart: true } }); expect(savedSearchContainer.getHasChanged$().getValue()).toBe(false); }); - it('updates a saved search by data view', async () => { + it('updates a discover view by data view', async () => { const savedSearchContainer = getSavedSearchContainer({ services: discoverServiceMock, globalStateContainer, diff --git a/src/plugins/discover/public/application/main/services/discover_saved_search_container.ts b/src/plugins/discover/public/application/main/services/discover_saved_search_container.ts index ef88aba74d7db..fdc4b85cc02aa 100644 --- a/src/plugins/discover/public/application/main/services/discover_saved_search_container.ts +++ b/src/plugins/discover/public/application/main/services/discover_saved_search_container.ts @@ -33,80 +33,80 @@ export interface UpdateParams { */ nextDataView?: DataView | undefined; /** - * The next AppState that should be used for updating the saved search + * The next AppState that should be used for updating the discover view */ nextState?: DiscoverAppState | undefined; /** - * use filter and query services to update the saved search + * use filter and query services to update the discover view */ useFilterAndQueryServices?: boolean; } /** - * Container for the saved search state, allowing to load, update and persist the saved search - * Can also be used to track changes to the saved search + * Container for the discover view state, allowing to load, update and persist the discover view + * Can also be used to track changes to the discover view * It centralizes functionality that was spread across the Discover main codebase - * There are 2 hooks to access the state of the saved search in React components: + * There are 2 hooks to access the state of the discover view in React components: * - useSavedSearch for the current state, that's updated on every relevant state change - * - useSavedSearchInitial for the persisted or initial state, just updated when the saved search is peristed or loaded + * - useSavedSearchInitial for the persisted or initial state, just updated when the discover view is peristed or loaded */ export interface DiscoverSavedSearchContainer { /** - * Get an BehaviorSubject which contains the current state of the current saved search + * Get an BehaviorSubject which contains the current state of the current discover view * All modifications are applied to this state */ getCurrent$: () => BehaviorSubject; /** - * Get the id of the current saved search + * Get the id of the current discover view */ getId: () => string | undefined; /** - * Get an BehaviorSubject which contains the initial state of the current saved search - * This is set when a saved search is loaded or a new saved search is initialized + * Get an BehaviorSubject which contains the initial state of the current discover view + * This is set when a discover view is loaded or a new discover view is initialized */ getInitial$: () => BehaviorSubject; /** - * Get the title of the current saved search + * Get the title of the current discover view */ getTitle: () => string | undefined; /** - * Get an BehaviorSubject containing the state if there have been changes to the initial state of the saved search - * Can be used to track if the saved search has been modified and displayed in the UI + * Get an BehaviorSubject containing the state if there have been changes to the initial state of the discover view + * Can be used to track if the discover view has been modified and displayed in the UI */ getHasChanged$: () => BehaviorSubject; /** - * Get the current state of the saved search + * Get the current state of the discover view */ getState: () => SavedSearch; /** - * Load a saved search by the given id - * Resets the initial and current state of the saved search + * Load a discover view by the given id + * Resets the initial and current state of the discover view * @param id * @param dataView */ load: (id: string, dataView?: DataView) => Promise; /** - * Initialize a new saved search - * Resets the initial and current state of the saved search + * Initialize a new discover view + * Resets the initial and current state of the discover view * @param dataView */ new: (dataView?: DataView) => Promise; /** - * Persist the given saved search - * Resets the initial and current state of the saved search + * Persist the given discover view + * Resets the initial and current state of the discover view */ persist: ( savedSearch: SavedSearch, saveOptions?: SavedObjectSaveOpts ) => Promise<{ id: string | undefined } | undefined>; /** - * Set the persisted & current state of the saved search - * Happens when a saved search is loaded or a new one is created + * Set the persisted & current state of the discover view + * Happens when a discover view is loaded or a new one is created * @param savedSearch */ set: (savedSearch: SavedSearch) => SavedSearch; /** - * Updates the current state of the saved search + * Updates the current state of the discover view * @param params */ update: (params: UpdateParams) => SavedSearch; @@ -225,7 +225,7 @@ export function getSavedSearchContainer({ } /** - * Copies a saved search object, due to the stateful nature of searchSource it has to be copied with a dedicated function + * Copies a discover view object, due to the stateful nature of searchSource it has to be copied with a dedicated function * @param savedSearch */ export function copySavedSearch(savedSearch: SavedSearch): SavedSearch { @@ -254,7 +254,7 @@ export function isEqualSavedSearch(savedSearchPrev: SavedSearch, savedSearchNext ...Object.keys(nextSavedSearchWithoutSearchSource), ] as Array>); - // at least one change in saved search attributes + // at least one change in discover view attributes const hasChangesInSavedSearch = [...keys].some((key) => { if ( ['usesAdHocDataView', 'hideChart'].includes(key) && diff --git a/src/plugins/discover/public/application/main/services/discover_state.test.ts b/src/plugins/discover/public/application/main/services/discover_state.test.ts index 2cf1e2c71880d..837dde73e94ce 100644 --- a/src/plugins/discover/public/application/main/services/discover_state.test.ts +++ b/src/plugins/discover/public/application/main/services/discover_state.test.ts @@ -215,7 +215,7 @@ describe('Test discover state with overridden state storage', () => { }); describe('Test discover initial state sort handling', () => { - test('Non-empty sort in URL should not be overwritten by saved search sort', async () => { + test('Non-empty sort in URL should not be overwritten by discover view sort', async () => { const savedSearch = { ...savedSearchMockWithTimeField, ...{ sort: [['bytes', 'desc']] }, @@ -226,7 +226,7 @@ describe('Test discover initial state sort handling', () => { expect(state.appState.getState().sort).toEqual([['timestamp', 'desc']]); unsubscribe(); }); - test('Empty URL should use saved search sort for state', async () => { + test('Empty URL should use discover view sort for state', async () => { const nextSavedSearch = { ...savedSearchMock, ...{ sort: [['bytes', 'desc']] as SortOrder[] } }; const { state } = await getState('/', { savedSearch: nextSavedSearch }); await state.actions.loadSavedSearch({ savedSearchId: savedSearchMock.id }); @@ -275,11 +275,11 @@ describe('Test createSearchSessionRestorationDataProvider', () => { }); describe('session name', () => { - test('No persisted saved search returns default name', async () => { + test('No persisted discover view returns default name', async () => { expect(await searchSessionInfoProvider.getName()).toBe('Discover'); }); - test('Saved Search with a title returns saved search title', async () => { + test('Saved Search with a title returns discover view title', async () => { mockSavedSearch = { id: 'id', title: 'Name' } as unknown as SavedSearch; expect(await searchSessionInfoProvider.getName()).toBe('Name'); }); @@ -369,7 +369,7 @@ describe('Test discover state actions', () => { searchSourceJSON: '{"query":{"query":"","language":"kuery"},"filter":[],"indexRefName":"kibanaSavedObjectMeta.searchSourceJSON.index"}', }, - title: 'The saved search that will save the world', + title: 'The discover view that will save the world', sort: [], columns: ['test123'], description: 'description', @@ -578,7 +578,7 @@ describe('Test discover state actions', () => { expect(state.savedSearchState.getHasChanged$().getValue()).toBe(false); state.savedSearchState.load = jest.fn().mockReturnValue(savedSearchMockWithTimeField); - // unsetting the previous index else this is considered as update to the persisted saved search + // unsetting the previous index else this is considered as update to the persisted discover view state.appState.set({ index: undefined }); await state.actions.loadSavedSearch({ savedSearchId: 'the-saved-search-id-with-timefield' }); expect(state.savedSearchState.getState().searchSource.getField('index')?.id).toBe( @@ -586,7 +586,7 @@ describe('Test discover state actions', () => { ); expect(state.savedSearchState.getHasChanged$().getValue()).toBe(false); - // switch back to the previous savedSearch, but not cleaning up appState index, so it's considered as update to the persisted saved search + // switch back to the previous savedSearch, but not cleaning up appState index, so it's considered as update to the persisted discover view state.appState.isEmptyURL = jest.fn().mockReturnValue(false); await state.actions.loadSavedSearch({ savedSearchId: savedSearchMock.id }); expect(state.savedSearchState.getState().searchSource.getField('index')?.id).toBe( @@ -594,7 +594,7 @@ describe('Test discover state actions', () => { ); expect(state.savedSearchState.getHasChanged$().getValue()).toBe(true); }); - test('loadSavedSearch generating a new saved search, updated by ad-hoc data view', async () => { + test('loadSavedSearch generating a new discover view, updated by ad-hoc data view', async () => { const { state } = await getState('/'); const dataViewSpecMock = { id: 'mock-id', @@ -765,7 +765,7 @@ describe('Test discover state actions', () => { }); test('undoSavedSearchChanges - when changing data views', async () => { const { state, getCurrentUrl } = await getState('/', { savedSearch: savedSearchMock }); - // Load a given persisted saved search + // Load a given persisted discover view await state.actions.loadSavedSearch({ savedSearchId: savedSearchMock.id }); const unsubscribe = state.actions.initializeAndSync(); await new Promise(process.nextTick); @@ -785,7 +785,7 @@ describe('Test discover state actions', () => { }); expect(state.internalState.getState().dataView?.id).toBe(dataViewComplexMock.id!); - // Undo all changes to the saved search, this should trigger a fetch, again + // Undo all changes to the discover view, this should trigger a fetch, again await state.actions.undoSavedSearchChanges(); await new Promise(process.nextTick); expect(getCurrentUrl()).toBe(initialUrlState); diff --git a/src/plugins/discover/public/application/main/services/discover_state.ts b/src/plugins/discover/public/application/main/services/discover_state.ts index 8994afb8a5f96..3591953e00ed3 100644 --- a/src/plugins/discover/public/application/main/services/discover_state.ts +++ b/src/plugins/discover/public/application/main/services/discover_state.ts @@ -79,15 +79,15 @@ interface DiscoverStateContainerParams { export interface LoadParams { /** - * the id of the saved search to load, if undefined, a new saved search will be created + * the id of the discover view to load, if undefined, a new discover view will be created */ savedSearchId?: string; /** - * the data view to use, if undefined, the saved search's data view will be used + * the data view to use, if undefined, the discover view's data view will be used */ dataView?: DataView; /** - * the data view spec to use, if undefined, the saved search's data view will be used + * the data view spec to use, if undefined, the discover view's data view will be used */ dataViewSpec?: DataViewSpec; } @@ -110,7 +110,7 @@ export interface DiscoverStateContainer { */ internalState: DiscoverInternalStateContainer; /** - * State of saved search, the saved object of Discover + * State of discover view, the saved object of Discover */ savedSearchState: DiscoverSavedSearchContainer; /** @@ -131,7 +131,7 @@ export interface DiscoverStateContainer { actions: { /** * Triggers fetching of new data from Elasticsearch - * If initial is true, when SEARCH_ON_PAGE_LOAD_SETTING is set to false and it's a new saved search no fetch is triggered + * If initial is true, when SEARCH_ON_PAGE_LOAD_SETTING is set to false and it's a new discover view no fetch is triggered * @param initial */ fetchData: (initial?: boolean) => void; @@ -144,8 +144,8 @@ export interface DiscoverStateContainer { */ loadDataViewList: () => Promise; /** - * Load a saved search by id or create a new one that's not persisted yet - * @param LoadParams - optional parameters to load a saved search + * Load a discover view by id or create a new one that's not persisted yet + * @param LoadParams - optional parameters to load a discover view */ loadSavedSearch: (param?: LoadParams) => Promise; /** @@ -165,7 +165,7 @@ export interface DiscoverStateContainer { */ onDataViewEdited: (dataView: DataView) => Promise; /** - * Triggered when a saved search is opened in the savedObject finder + * Triggered when a discover view is opened in the savedObject finder * @param savedSearchId */ onOpenSavedSearch: (savedSearchId: string) => void; @@ -189,11 +189,11 @@ export interface DiscoverStateContainer { */ setDataView: (dataView: DataView) => void; /** - * Undo changes made to the saved search, e.g. when the user triggers the "Reset search" button + * Undo changes made to the discover view, e.g. when the user triggers the "Reset search" button */ undoSavedSearchChanges: () => Promise; /** - * When saving a saved search with an ad hoc data view, a new id needs to be generated for the data view + * When saving a discover view with an ad hoc data view, a new id needs to be generated for the data view * This is to prevent duplicate ids messing with our system */ updateAdHocDataViewId: () => Promise; @@ -292,7 +292,7 @@ export function getDiscoverStateContainer({ }; /** - * When saving a saved search with an ad hoc data view, a new id needs to be generated for the data view + * When saving a discover view with an ad hoc data view, a new id needs to be generated for the data view * This is to prevent duplicate ids messing with our system */ const updateAdHocDataViewId = async () => { @@ -315,7 +315,7 @@ export function getDiscoverStateContainer({ addLog('[discoverState] onOpenSavedSearch', newSavedSearchId); const currentSavedSearch = savedSearchContainer.getState(); if (currentSavedSearch.id && currentSavedSearch.id === newSavedSearchId) { - addLog('[discoverState] undo changes since saved search did not change'); + addLog('[discoverState] undo changes since discover view did not change'); await undoSavedSearchChanges(); } else { addLog('[discoverState] onOpenSavedSearch open view URL'); @@ -383,7 +383,7 @@ export function getDiscoverStateContainer({ // start subscribing to dataStateContainer, triggering data fetching const unsubscribeData = dataStateContainer.subscribe(); - // updates saved search when query or filters change, triggers data fetching + // updates discover view when query or filters change, triggers data fetching const filterUnsubscribe = merge(services.filterManager.getFetches$()).subscribe(() => { savedSearchContainer.update({ nextDataView: internalStateContainer.getState().dataView, @@ -455,7 +455,7 @@ export function getDiscoverStateContainer({ }); }; /** - * Undo all changes to the current saved search + * Undo all changes to the current discover view */ const undoSavedSearchChanges = async () => { addLog('undoSavedSearchChanges'); @@ -467,7 +467,7 @@ export function getDiscoverStateContainer({ }); const newAppState = getDefaultAppState(nextSavedSearch, services); - // a saved search can't have global (pinned) filters so we can reset global filters state + // a discover view can't have global (pinned) filters so we can reset global filters state const globalFilters = globalStateContainer.get()?.filters; if (globalFilters) { await globalStateContainer.set({ diff --git a/src/plugins/discover/public/application/main/services/load_saved_search.ts b/src/plugins/discover/public/application/main/services/load_saved_search.ts index 8b8dcc2beb2f4..b0eff1a1805d5 100644 --- a/src/plugins/discover/public/application/main/services/load_saved_search.ts +++ b/src/plugins/discover/public/application/main/services/load_saved_search.ts @@ -34,7 +34,7 @@ interface LoadSavedSearchDeps { } /** - * Loading persisted saved searches or existing ones and updating services accordingly + * Loading persisted discover viewes or existing ones and updating services accordingly * @param params * @param deps */ @@ -48,7 +48,7 @@ export const loadSavedSearch = async ( const appStateExists = !appStateContainer.isEmptyURL(); const appState = appStateExists ? appStateContainer.getState() : undefined; - // Loading the saved search or creating a new one + // Loading the discover view or creating a new one let nextSavedSearch = savedSearchId ? await savedSearchContainer.load(savedSearchId) : await savedSearchContainer.new( @@ -59,17 +59,17 @@ export const loadSavedSearch = async ( services.filterManager.setAppFilters([]); services.data.query.queryString.clearQuery(); - // reset appState in case a saved search with id is loaded and - // the url is empty so the saved search is loaded in a clean + // reset appState in case a discover view with id is loaded and + // the url is empty so the discover view is loaded in a clean // state else it might be updated by the previous app state if (!appStateExists) { appStateContainer.set({}); } - // Update saved search by a given app state (in URL) + // Update discover view by a given app state (in URL) if (appState) { if (savedSearchId && appState.index) { - // This is for the case appState is overwriting the loaded saved search data view + // This is for the case appState is overwriting the loaded discover view data view const savedSearchDataViewId = nextSavedSearch.searchSource.getField('index')?.id; const stateDataView = await getStateDataView(params, { services, @@ -88,7 +88,7 @@ export const loadSavedSearch = async ( }); } - // Update app state container with the next state derived from the next saved search + // Update app state container with the next state derived from the next discover view const nextAppState = getInitialState(undefined, nextSavedSearch, services); const mergedAppState = appState ? { ...nextAppState, ...cleanupUrlState({ ...appState }, services.uiSettings) } @@ -96,14 +96,14 @@ export const loadSavedSearch = async ( appStateContainer.resetToState(mergedAppState); - // Update all other services and state containers by the next saved search + // Update all other services and state containers by the next discover view updateBySavedSearch(nextSavedSearch, deps); return nextSavedSearch; }; /** - * Update services and state containers based on the given saved search + * Update services and state containers based on the given discover view * @param savedSearch * @param deps */ @@ -140,7 +140,7 @@ function updateBySavedSearch(savedSearch: SavedSearch, deps: LoadSavedSearchDeps // Get the data view to actually use. There are several conditions to consider which data view is used // 1. If a data view is passed in, use that // 2. If an appState with index set is passed in, use the data view from that -// 3. If a saved search is passed in, use the data view from that +// 3. If a discover view is passed in, use the data view from that // And provide a fallback data view if 2. or 3. don't exist, were deleted or invalid const getStateDataView = async ( params: LoadParams, diff --git a/src/plugins/discover/public/application/main/utils/resolve_data_view.ts b/src/plugins/discover/public/application/main/utils/resolve_data_view.ts index 761fb9764c82f..dbdb890a2956a 100644 --- a/src/plugins/discover/public/application/main/utils/resolve_data_view.ts +++ b/src/plugins/discover/public/application/main/utils/resolve_data_view.ts @@ -122,7 +122,7 @@ export function resolveDataView( const ownDataView = savedSearch?.searchSource.getField('index'); if (ownDataView && !stateVal) { - // the given saved search has its own data view, and no data view was specified in the URL + // the given discover view has its own data view, and no data view was specified in the URL return ownDataView; } @@ -136,7 +136,7 @@ export function resolveDataView( }); if (ownDataView) { - // the given data view in the URL was not found, but the saved search has its own data view + // the given data view in the URL was not found, but the discover view has its own data view toastNotifications.addWarning({ title: warningTitle, text: i18n.translate('discover.showingSavedDataViewWarningDescription', { diff --git a/src/plugins/discover/public/application/main/utils/update_saved_search.ts b/src/plugins/discover/public/application/main/utils/update_saved_search.ts index ff9d5a70f39be..699b5c72c3959 100644 --- a/src/plugins/discover/public/application/main/utils/update_saved_search.ts +++ b/src/plugins/discover/public/application/main/utils/update_saved_search.ts @@ -14,8 +14,8 @@ import type { DiscoverServices } from '../../../build_services'; import type { DiscoverGlobalStateContainer } from '../services/discover_global_state_container'; /** - * Updates the saved search with a given data view & Appstate - * Is executed on every change of those, for making sure the saved search is + * Updates the discover view with a given data view & Appstate + * Is executed on every change of those, for making sure the discover view is * up to date before fetching data and persisting or sharing * @param savedSearch * @param dataView diff --git a/src/plugins/discover/public/components/doc_table/doc_table_wrapper.tsx b/src/plugins/discover/public/components/doc_table/doc_table_wrapper.tsx index a61523b6647c3..bbdd66d8a35e5 100644 --- a/src/plugins/discover/public/components/doc_table/doc_table_wrapper.tsx +++ b/src/plugins/discover/public/components/doc_table/doc_table_wrapper.tsx @@ -66,7 +66,7 @@ export interface DocTableProps { */ isPlainRecord?: boolean; /** - * Saved search id + * Discover view id */ savedSearchId?: string; /** diff --git a/src/plugins/discover/public/embeddable/constants.ts b/src/plugins/discover/public/embeddable/constants.ts index 84c1babfc7949..6cf0037f5c1cc 100644 --- a/src/plugins/discover/public/embeddable/constants.ts +++ b/src/plugins/discover/public/embeddable/constants.ts @@ -15,7 +15,7 @@ export const SEARCH_EMBEDDABLE_CELL_ACTIONS_TRIGGER_ID = export const SEARCH_EMBEDDABLE_CELL_ACTIONS_TRIGGER: Trigger = { id: SEARCH_EMBEDDABLE_CELL_ACTIONS_TRIGGER_ID, - title: 'Discover saved searches embeddable cell actions', + title: 'Discover discover viewes embeddable cell actions', description: - 'This trigger is used to replace the cell actions for Discover saved search embeddable grid.', + 'This trigger is used to replace the cell actions for Discover discover view embeddable grid.', } as const; diff --git a/src/plugins/discover/public/embeddable/get_discover_locator_params.test.ts b/src/plugins/discover/public/embeddable/get_discover_locator_params.test.ts index 54e519adddcb7..36280d5418e00 100644 --- a/src/plugins/discover/public/embeddable/get_discover_locator_params.test.ts +++ b/src/plugins/discover/public/embeddable/get_discover_locator_params.test.ts @@ -11,7 +11,7 @@ import { getDiscoverLocatorParams } from './get_discover_locator_params'; import type { SearchInput } from './types'; describe('getDiscoverLocatorParams', () => { - it('should return saved search id if input has savedObjectId', () => { + it('should return discover view id if input has savedObjectId', () => { const input = { savedObjectId: 'savedObjectId' } as SearchInput; expect(getDiscoverLocatorParams({ input, savedSearch: savedSearchMock })).toEqual({ savedSearchId: 'savedObjectId', diff --git a/src/plugins/discover/public/embeddable/saved_search_embeddable.test.ts b/src/plugins/discover/public/embeddable/saved_search_embeddable.test.ts index 47c6a26ba7647..31cfeb4a075fe 100644 --- a/src/plugins/discover/public/embeddable/saved_search_embeddable.test.ts +++ b/src/plugins/discover/public/embeddable/saved_search_embeddable.test.ts @@ -75,7 +75,7 @@ const createSearchFnMock = (nrOfHits: number) => { const dataViewMock = buildDataViewMock({ name: 'the-data-view', fields: deepMockedFields }); -describe('saved search embeddable', () => { +describe('discover view embeddable', () => { let mountpoint: HTMLDivElement; let servicesMock: jest.Mocked; @@ -97,7 +97,7 @@ describe('saved search embeddable', () => { const searchSource = createSearchSourceMock({ index: dataView }, undefined, searchMock); const savedSearch = { id: 'mock-id', - title: 'saved search', + title: 'discover view', sort: [['message', 'asc']] as Array<[string, string]>, searchSource, viewMode: viewModeMockValue, @@ -206,7 +206,7 @@ describe('saved search embeddable', () => { expect(executeTriggerActions).toHaveBeenCalled(); }); - it('should render saved search embeddable when successfully loading data', async () => { + it('should render discover view embeddable when successfully loading data', async () => { // mock return data const { search, resolveSearch } = createSearchFnMock(1); const { embeddable } = createEmbeddable({ searchMock: search }); @@ -235,7 +235,7 @@ describe('saved search embeddable', () => { expect(loadedOutput.error).toBe(undefined); }); - it('should render saved search embeddable when empty data is returned', async () => { + it('should render discover view embeddable when empty data is returned', async () => { // mock return data const { search, resolveSearch } = createSearchFnMock(0); const { embeddable } = createEmbeddable({ searchMock: search }); @@ -358,14 +358,14 @@ describe('saved search embeddable', () => { expect(search).toHaveBeenCalledTimes(1); }); - it('should not reload and fetch when a input title matches the saved search title', async () => { + it('should not reload and fetch when a input title matches the discover view title', async () => { const search = jest.fn().mockReturnValue(getSearchResponse(1)); const { embeddable } = createEmbeddable({ searchMock: search }); embeddable.reload = jest.fn(); await waitOneTick(); embeddable.render(mountpoint); await waitOneTick(); - embeddable.updateOutput({ title: 'saved search' }); + embeddable.updateOutput({ title: 'discover view' }); await waitOneTick(); expect(embeddable.reload).toHaveBeenCalledTimes(0); @@ -428,19 +428,19 @@ describe('saved search embeddable', () => { expect(editUrl).toBe('/base/mock-url'); }; - it('should correctly output edit link params for by reference saved search', async () => { + it('should correctly output edit link params for by reference discover view', async () => { await runEditLinkTest(); }); - it('should correctly output edit link params for by reference saved search with ad hoc data view', async () => { + it('should correctly output edit link params for by reference discover view with ad hoc data view', async () => { await runEditLinkTest(dataViewAdHoc); }); - it('should correctly output edit link params for by value saved search', async () => { + it('should correctly output edit link params for by value discover view', async () => { await runEditLinkTest(undefined, true); }); - it('should correctly output edit link params for by value saved search with ad hoc data view', async () => { + it('should correctly output edit link params for by value discover view with ad hoc data view', async () => { jest .spyOn(servicesMock.locator, 'getRedirectUrl') .mockClear() diff --git a/src/plugins/discover/public/embeddable/saved_search_embeddable.tsx b/src/plugins/discover/public/embeddable/saved_search_embeddable.tsx index 9cc620d259a80..d75f73d850740 100644 --- a/src/plugins/discover/public/embeddable/saved_search_embeddable.tsx +++ b/src/plugins/discover/public/embeddable/saved_search_embeddable.tsx @@ -207,7 +207,7 @@ export class SavedSearchEmbeddable const description = input.hidePanelTitles ? '' : input.description ?? savedSearch.description; const savedObjectId = (input as SearchByReferenceInput).savedObjectId; const locatorParams = getDiscoverLocatorParams({ input, savedSearch }); - // We need to use a redirect URL if this is a by value saved search using + // We need to use a redirect URL if this is a by value discover view using // an ad hoc data view to ensure the data view spec gets encoded in the URL const useRedirect = !savedObjectId && !dataView?.isPersisted(); const editUrl = useRedirect diff --git a/src/plugins/discover/public/embeddable/saved_search_grid.scss b/src/plugins/discover/public/embeddable/saved_search_grid.scss index 1b1046485596b..501726efa7401 100644 --- a/src/plugins/discover/public/embeddable/saved_search_grid.scss +++ b/src/plugins/discover/public/embeddable/saved_search_grid.scss @@ -7,7 +7,7 @@ */ /** - * 1. Fixes fullscreen mode for saved searches on Dashboard. Otherwise, sibling grids can obscure the grid in fullscreen mode. + * 1. Fixes fullscreen mode for discover viewes on Dashboard. Otherwise, sibling grids can obscure the grid in fullscreen mode. * "euiDataGrid__restrictBody" is set to body element when a grid is in fullscreen * https://github.com/elastic/kibana/issues/134032 */ diff --git a/src/plugins/discover/public/embeddable/search_embeddable_factory.ts b/src/plugins/discover/public/embeddable/search_embeddable_factory.ts index 9afe34648b30e..ab02af526f5a9 100644 --- a/src/plugins/discover/public/embeddable/search_embeddable_factory.ts +++ b/src/plugins/discover/public/embeddable/search_embeddable_factory.ts @@ -31,7 +31,7 @@ export class SearchEmbeddableFactory public readonly type = SEARCH_EMBEDDABLE_TYPE; public readonly savedObjectMetaData = { name: i18n.translate('discover.savedSearch.savedObjectName', { - defaultMessage: 'Saved search', + defaultMessage: 'Discover view', }), type: 'search', getIconForSavedObject: () => 'discoverApp', diff --git a/src/plugins/discover/public/embeddable/view_saved_search_action.test.ts b/src/plugins/discover/public/embeddable/view_saved_search_action.test.ts index 667ded0ba28e8..8f0994b511b44 100644 --- a/src/plugins/discover/public/embeddable/view_saved_search_action.test.ts +++ b/src/plugins/discover/public/embeddable/view_saved_search_action.test.ts @@ -35,14 +35,14 @@ const embeddableConfig = { executeTriggerActions, }; -describe('view saved search action', () => { - it('is compatible when embeddable is of type saved search, in view mode && appropriate permissions are set', async () => { +describe('view discover view action', () => { + it('is compatible when embeddable is of type discover view, in view mode && appropriate permissions are set', async () => { const action = new ViewSavedSearchAction(applicationMock, services.locator); const embeddable = new SavedSearchEmbeddable(embeddableConfig, searchInput); expect(await action.isCompatible({ embeddable, trigger })).toBe(true); }); - it('is not compatible when embeddable not of type saved search', async () => { + it('is not compatible when embeddable not of type discover view', async () => { const action = new ViewSavedSearchAction(applicationMock, services.locator); const embeddable = new ContactCardEmbeddable( { @@ -74,7 +74,7 @@ describe('view saved search action', () => { ).toBe(false); }); - it('execute navigates to a saved search', async () => { + it('execute navigates to a discover view', async () => { const action = new ViewSavedSearchAction(applicationMock, services.locator); const embeddable = new SavedSearchEmbeddable(embeddableConfig, searchInput); await new Promise((resolve) => setTimeout(resolve, 0)); diff --git a/src/plugins/discover/public/hooks/use_navigation_props.tsx b/src/plugins/discover/public/hooks/use_navigation_props.tsx index eab1bfb2937c2..d20edf3cab46f 100644 --- a/src/plugins/discover/public/hooks/use_navigation_props.tsx +++ b/src/plugins/discover/public/hooks/use_navigation_props.tsx @@ -47,7 +47,7 @@ const getStateParams = ({ query = data.query.queryString.getQuery(); timeRange = data.query.timefilter.timefilter.getTime(); } else if (isEmbeddableView && filters?.length) { - // applied from saved search embeddable + // applied from discover view embeddable appliedFilters = filters; } diff --git a/src/plugins/discover/public/services/saved_searches/restore_from_saved_search.test.ts b/src/plugins/discover/public/services/saved_searches/restore_from_saved_search.test.ts index 45c9645706583..968cfa5f33c93 100644 --- a/src/plugins/discover/public/services/saved_searches/restore_from_saved_search.test.ts +++ b/src/plugins/discover/public/services/saved_searches/restore_from_saved_search.test.ts @@ -11,7 +11,7 @@ import type { TimeRange, RefreshInterval } from '@kbn/data-plugin/common'; import { savedSearchMock, savedSearchMockWithTimeField } from '../../__mocks__/saved_search'; import { restoreStateFromSavedSearch } from './restore_from_saved_search'; -describe('discover restore state from saved search', () => { +describe('discover restore state from discover view', () => { let timefilterMock: TimefilterContract; const timeRange: TimeRange = { from: 'now-30m', diff --git a/src/plugins/discover/public/utils/get_sharing_data.ts b/src/plugins/discover/public/utils/get_sharing_data.ts index 9e3b2b2369469..63ff09c63aeaf 100644 --- a/src/plugins/discover/public/utils/get_sharing_data.ts +++ b/src/plugins/discover/public/utils/get_sharing_data.ts @@ -56,7 +56,7 @@ export async function getSharingData( searchSource.removeField('aggs'); searchSource.removeField('size'); - // Columns that the user has selected in the saved search + // Columns that the user has selected in the discover view let columns = state.columns || []; if (columns && columns.length > 0) { diff --git a/src/plugins/discover/server/locator/columns_from_locator.test.ts b/src/plugins/discover/server/locator/columns_from_locator.test.ts index 6bc53afda9b18..f5a6064b547a2 100644 --- a/src/plugins/discover/server/locator/columns_from_locator.test.ts +++ b/src/plugins/discover/server/locator/columns_from_locator.test.ts @@ -47,7 +47,7 @@ let mockServices: Services; let mockSavedSearch: SavedObject; let mockDataView: DataView; -// mock search source belonging to the saved search +// mock search source belonging to the discover view let mockSearchSource: SearchSource; // mock params containing the discover app locator @@ -133,7 +133,7 @@ test('with search source using columns when DOC_HIDE_TIME_COLUMN_SETTING is true expect(columns).toEqual(['response', 'url', 'clientip', 'machine.os', 'tags']); }); -test('with saved search containing ["_source"]', async () => { +test('with discover view containing ["_source"]', async () => { mockSavedSearch.attributes.columns = ['_source']; const provider = columnsFromLocatorFactory(mockServices); diff --git a/src/plugins/discover/server/locator/columns_from_locator.ts b/src/plugins/discover/server/locator/columns_from_locator.ts index a872298f515cc..eeca03b044315 100644 --- a/src/plugins/discover/server/locator/columns_from_locator.ts +++ b/src/plugins/discover/server/locator/columns_from_locator.ts @@ -30,7 +30,7 @@ export const getColumns = async ( services.uiSettings.get(SEARCH_FIELDS_FROM_SOURCE), ]); - // Add/adjust columns from the saved search attributes and UI Settings + // Add/adjust columns from the discover view attributes and UI Settings let columns: string[] | undefined; let columnsNext: string[] | undefined; let timeFieldName: string | undefined; diff --git a/src/plugins/discover/server/locator/filters_from_locator.ts b/src/plugins/discover/server/locator/filters_from_locator.ts index 0e79fceab0226..a024040491dd4 100644 --- a/src/plugins/discover/server/locator/filters_from_locator.ts +++ b/src/plugins/discover/server/locator/filters_from_locator.ts @@ -46,7 +46,7 @@ export const filtersFromLocatorFactory = (services: LocatorServicesDeps) => { return filters; - // TODO: support extracting filters from saved search + // TODO: support extracting filters from discover view }; return filtersFromLocator; diff --git a/src/plugins/discover/server/locator/query_from_locator.ts b/src/plugins/discover/server/locator/query_from_locator.ts index 6d3e009463558..630c1d4d189cf 100644 --- a/src/plugins/discover/server/locator/query_from_locator.ts +++ b/src/plugins/discover/server/locator/query_from_locator.ts @@ -22,7 +22,7 @@ export const queryFromLocatorFactory = (services: LocatorServicesDeps) => { ): Promise => { return params.query; - // TODO: support query from saved search + // TODO: support query from discover view }; return queryFromLocator; diff --git a/src/plugins/discover/server/locator/searchsource_from_locator.test.ts b/src/plugins/discover/server/locator/searchsource_from_locator.test.ts index c774b0f373a3e..07f074a0951fa 100644 --- a/src/plugins/discover/server/locator/searchsource_from_locator.test.ts +++ b/src/plugins/discover/server/locator/searchsource_from_locator.test.ts @@ -47,7 +47,7 @@ let mockServices: Services; let mockSavedSearch: SavedObject; let mockDataView: DataView; -// mock search source belonging to the saved search +// mock search source belonging to the discover view let mockSearchSource: SearchSource; // mock params containing the discover app locator @@ -98,7 +98,7 @@ beforeEach(() => { }); }); -test('with saved search containing a filter', async () => { +test('with discover view containing a filter', async () => { const testFilter = { meta: { index: 'logstash-*' }, query: { term: { host: 'elastic.co' } }, @@ -122,8 +122,8 @@ test('with locator params containing a filter', async () => { expect(searchSource.getSerializedFields().filter).toEqual([testFilter]); }); -test('with saved search and locator params both containing a filter', async () => { - // search source belonging to the saved search +test('with discover view and locator params both containing a filter', async () => { + // search source belonging to the discover view mockSearchSource.setField('filter', { meta: { index: 'logstash-*' }, query: { term: { host: 'elastic.co' } }, @@ -170,7 +170,7 @@ test('with locator params containing a timeRange', async () => { ]); }); -test('with saved search containing ["_source"]', async () => { +test('with discover view containing ["_source"]', async () => { mockSavedSearch.attributes.columns = ['_source']; const provider = searchSourceFromLocatorFactory(mockServices); diff --git a/src/plugins/discover/server/locator/searchsource_from_locator.ts b/src/plugins/discover/server/locator/searchsource_from_locator.ts index 70a723ddb5c54..3d886ab3cf739 100644 --- a/src/plugins/discover/server/locator/searchsource_from_locator.ts +++ b/src/plugins/discover/server/locator/searchsource_from_locator.ts @@ -33,7 +33,7 @@ function normalizeFilter(savedSearchFilterTmp?: FilterResponse) { } /* - * Combine the time range filter from the job request body with any filters that have been saved into the saved search object + * Combine the time range filter from the job request body with any filters that have been saved into the discover view object * NOTE: if the filters that were saved into the search are NOT an array, it may be a function, and can not be supported. */ const getFilters = ( @@ -82,7 +82,7 @@ const getFilters = ( }; /* - * Pick the query from the job request body vs any query that has been saved into the saved search object. + * Pick the query from the job request body vs any query that has been saved into the discover view object. */ const getQuery = (searchSource: SearchSource, params: DiscoverAppLocatorParams) => { let query: Query | AggregateQuery | undefined; diff --git a/src/plugins/discover/server/locator/title_from_locator.test.ts b/src/plugins/discover/server/locator/title_from_locator.test.ts index f3e459a8bf39b..f6d606a938767 100644 --- a/src/plugins/discover/server/locator/title_from_locator.test.ts +++ b/src/plugins/discover/server/locator/title_from_locator.test.ts @@ -86,7 +86,7 @@ test(`retrieves title from DiscoverAppLocatorParams`, async () => { expect(title).toBe(testTitle); }); -test(`retrieves title from saved search contents`, async () => { +test(`retrieves title from discover view contents`, async () => { const testTitle = 'Test Title from Saved Search Contents'; mockSavedSearch = { ...defaultSavedSearch, @@ -98,7 +98,7 @@ test(`retrieves title from saved search contents`, async () => { expect(title).toBe(testTitle); }); -test(`throws error if DiscoverAppLocatorParams do not contain a saved search ID`, async () => { +test(`throws error if DiscoverAppLocatorParams do not contain a discover view ID`, async () => { const testFn = async () => { mockPayload = [{ params: { dataViewId: 'not-yet-supported' } }]; const provider = titleFromLocatorFactory(mockServices); @@ -106,6 +106,6 @@ test(`throws error if DiscoverAppLocatorParams do not contain a saved search ID` }; expect(testFn).rejects.toEqual( - new Error('DiscoverAppLocatorParams must contain a saved search reference') + new Error('DiscoverAppLocatorParams must contain a discover view reference') ); }); diff --git a/src/plugins/discover/server/locator/title_from_locator.ts b/src/plugins/discover/server/locator/title_from_locator.ts index 4b2d91269146c..688e2df92f537 100644 --- a/src/plugins/discover/server/locator/title_from_locator.ts +++ b/src/plugins/discover/server/locator/title_from_locator.ts @@ -17,7 +17,7 @@ import { DiscoverAppLocatorParams } from '../../common'; export const titleFromLocatorFactory = (services: LocatorServicesDeps) => { /** * Allows consumers to derive a title of a search in Disocver from DiscoverAppLocatorParams. - * For now, this assumes the DiscoverAppLocatorParams contain a reference to a saved search. In the future, + * For now, this assumes the DiscoverAppLocatorParams contain a reference to a discover view. In the future, * the params may only contain a reference to a DataView * * @public @@ -33,13 +33,13 @@ export const titleFromLocatorFactory = (services: LocatorServicesDeps) => { } if (!savedSearchId) { - throw new Error(`DiscoverAppLocatorParams must contain a saved search reference`); + throw new Error(`DiscoverAppLocatorParams must contain a discover view reference`); } const { savedObjects } = services; const searchObject: SavedObject<{ title?: string }> = await savedObjects.get( 'search', - savedSearchId // assumes params contains saved search reference + savedSearchId // assumes params contains discover view reference ); return ( diff --git a/src/plugins/discover/server/sample_data/register_sample_data.ts b/src/plugins/discover/server/sample_data/register_sample_data.ts index a864045a5b2b7..5c06b40bb1fa3 100644 --- a/src/plugins/discover/server/sample_data/register_sample_data.ts +++ b/src/plugins/discover/server/sample_data/register_sample_data.ts @@ -12,7 +12,7 @@ import { getSavedSearchFullPathUrl } from '@kbn/saved-search-plugin/common'; import { APP_ICON } from '../../common'; function getDiscoverPathForSampleDataset(objId: string) { - // TODO: remove the time range from the URL query when saved search objects start supporting time range configuration + // TODO: remove the time range from the URL query when discover view objects start supporting time range configuration // https://github.com/elastic/kibana/issues/9761 return `${getSavedSearchFullPathUrl(objId)}?_g=(time:(from:now-7d,to:now))`; } diff --git a/src/plugins/discover/server/ui_settings.ts b/src/plugins/discover/server/ui_settings.ts index 806ae826bf3ab..9aeafcb8aaa85 100644 --- a/src/plugins/discover/server/ui_settings.ts +++ b/src/plugins/discover/server/ui_settings.ts @@ -125,7 +125,7 @@ export const getUiSettings: ( description: i18n.translate('discover.advancedSettings.searchOnPageLoadText', { defaultMessage: 'Controls whether a search is executed when Discover first loads. This setting does not ' + - 'have an effect when loading a saved search.', + 'have an effect when loading a discover view.', }), category: ['discover'], schema: schema.boolean(), @@ -321,7 +321,7 @@ export const getUiSettings: ( value: true, description: i18n.translate('discover.advancedSettings.enableESQLDescription', { defaultMessage: - '{technicalPreviewLabel} This tech preview feature is highly experimental--do not rely on this for production saved searches, visualizations or dashboards. This setting enables ES|QL in Discover. If you have feedback on this experience please reach out to us on {link}', + '{technicalPreviewLabel} This tech preview feature is highly experimental--do not rely on this for production discover viewes, visualizations or dashboards. This setting enables ES|QL in Discover. If you have feedback on this experience please reach out to us on {link}', values: { link: `` + diff --git a/src/plugins/home/public/services/feature_catalogue/feature_catalogue_registry.test.ts b/src/plugins/home/public/services/feature_catalogue/feature_catalogue_registry.test.ts index 81b7297f3b62f..c94d4a0ab13a8 100644 --- a/src/plugins/home/public/services/feature_catalogue/feature_catalogue_registry.test.ts +++ b/src/plugins/home/public/services/feature_catalogue/feature_catalogue_registry.test.ts @@ -16,7 +16,7 @@ import { const DASHBOARD_FEATURE: FeatureCatalogueEntry = { id: 'dashboard', title: 'Dashboard', - description: 'Display and share a collection of visualizations and saved searches.', + description: 'Display and share a collection of visualizations and discover viewes.', icon: 'dashboardApp', path: `/app/kibana#dashboard`, showOnHomePage: true, diff --git a/src/plugins/inspector/README.md b/src/plugins/inspector/README.md index 99984b53065ad..e8d442369e00d 100644 --- a/src/plugins/inspector/README.md +++ b/src/plugins/inspector/README.md @@ -14,7 +14,7 @@ a specific view is available depends on the used adapters. ## Inspector Adapters Since the Inspector panel itself is not tied to a specific type of elements (visualizations, -saved searches, etc.), everything you need to open the inspector is a collection +discover viewes, etc.), everything you need to open the inspector is a collection of so called inspector adapters. A single adapter can be any type of JavaScript class. Most likely an adapter offers some kind of logging capabilities for the element, that diff --git a/src/plugins/saved_objects/public/saved_object/helpers/build_saved_object.ts b/src/plugins/saved_objects/public/saved_object/helpers/build_saved_object.ts index 647eece25752a..bbb922d1f0544 100644 --- a/src/plugins/saved_objects/public/saved_object/helpers/build_saved_object.ts +++ b/src/plugins/saved_objects/public/saved_object/helpers/build_saved_object.ts @@ -48,7 +48,7 @@ export function buildSavedObject( savedObject.getDisplayName = () => esType; // NOTE: this.type (not set in this file, but somewhere else) is the sub type, e.g. 'area' or - // 'data table', while esType is the more generic type - e.g. 'visualization' or 'saved search'. + // 'data table', while esType is the more generic type - e.g. 'visualization' or 'discover view'. savedObject.getEsType = () => esType; /** diff --git a/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap index 829472941701c..2bf7f145b233b 100644 --- a/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap +++ b/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap @@ -25,7 +25,7 @@ exports[`NotFoundErrors component renders correctly for index-pattern type 1`] = The data view associated with this object no longer exists.
- If you know what this error means, you can use the + If you know what this error means, you can use the
- If you know what this error means, you can use the + If you know what this error means, you can use the
- The saved search associated with this object no longer exists. + The discover view associated with this object no longer exists.
- If you know what this error means, you can use the + If you know what this error means, you can use the
- If you know what this error means, you can use the + If you know what this error means, you can use the { }); it('displays correct title if one is provided', () => { - let mounted = mountHeader({ ...defaultProps, title: 'my saved search' }); - expect(mounted.find('h1').text()).toMatchInlineSnapshot(`"Inspect my saved search"`); - mounted = mountHeader({ ...defaultProps, title: 'my other saved search' }); - expect(mounted.find('h1').text()).toMatchInlineSnapshot(`"Inspect my other saved search"`); + let mounted = mountHeader({ ...defaultProps, title: 'my discover view' }); + expect(mounted.find('h1').text()).toMatchInlineSnapshot(`"Inspect my discover view"`); + mounted = mountHeader({ ...defaultProps, title: 'my other discover view' }); + expect(mounted.find('h1').text()).toMatchInlineSnapshot(`"Inspect my other discover view"`); }); it('only displays delete button if canDelete is true', () => { diff --git a/src/plugins/saved_objects_management/public/management_section/object_view/components/not_found_errors.test.tsx b/src/plugins/saved_objects_management/public/management_section/object_view/components/not_found_errors.test.tsx index 1359375f2143d..2abe418137d1a 100644 --- a/src/plugins/saved_objects_management/public/management_section/object_view/components/not_found_errors.test.tsx +++ b/src/plugins/saved_objects_management/public/management_section/object_view/components/not_found_errors.test.tsx @@ -25,7 +25,7 @@ describe('NotFoundErrors component', () => { const callOut = mounted.find('EuiCallOut'); expect(callOut.render()).toMatchSnapshot(); expect(mounted.text()).toMatchInlineSnapshot( - `"There is a problem with this saved objectThe saved search associated with this object no longer exists.If you know what this error means, you can use the Saved objects APIsExternal link(opens in a new tab or window) to fix it — otherwise click the delete button above."` + `"There is a problem with this saved objectThe discover view associated with this object no longer exists.If you know what this error means, you can use the Saved objects APIsExternal link(opens in a new tab or window) to fix it — otherwise click the delete button above."` ); }); diff --git a/src/plugins/saved_objects_management/public/management_section/object_view/components/not_found_errors.tsx b/src/plugins/saved_objects_management/public/management_section/object_view/components/not_found_errors.tsx index 3e4efa4e9c199..833a82876f5cd 100644 --- a/src/plugins/saved_objects_management/public/management_section/object_view/components/not_found_errors.tsx +++ b/src/plugins/saved_objects_management/public/management_section/object_view/components/not_found_errors.tsx @@ -31,7 +31,7 @@ export const NotFoundErrors = ({ type, docLinks }: NotFoundErrors) => { return ( ); case 'index-pattern': diff --git a/src/plugins/saved_search/README.md b/src/plugins/saved_search/README.md index d2234f04494a1..6e8ffd91416c2 100644 --- a/src/plugins/saved_search/README.md +++ b/src/plugins/saved_search/README.md @@ -1,3 +1,3 @@ -# Saved search +# Discover view -Contains the saved search saved object definition and helpers. +Contains the discover view saved object definition and helpers. diff --git a/src/plugins/saved_search/common/expressions/kibana_context.ts b/src/plugins/saved_search/common/expressions/kibana_context.ts index 35e675783ba7f..8c286b3cc28ac 100644 --- a/src/plugins/saved_search/common/expressions/kibana_context.ts +++ b/src/plugins/saved_search/common/expressions/kibana_context.ts @@ -65,7 +65,7 @@ export const getKibanaContextFn = ( types: ['string', 'null'], default: null, help: i18n.translate('savedSearch.kibana_context.savedSearchId.help', { - defaultMessage: 'Specify saved search ID to be used for queries and filters', + defaultMessage: 'Specify discover view ID to be used for queries and filters', }), }, }, diff --git a/src/plugins/saved_search/common/saved_searches_url.test.ts b/src/plugins/saved_search/common/saved_searches_url.test.ts index 81f4498939b98..cdd242746105b 100644 --- a/src/plugins/saved_search/common/saved_searches_url.test.ts +++ b/src/plugins/saved_search/common/saved_searches_url.test.ts @@ -10,7 +10,7 @@ import { getSavedSearchUrl, getSavedSearchFullPathUrl } from './saved_searches_u describe('saved_searches_url', () => { describe('getSavedSearchUrl', () => { - test('should return valid saved search url', () => { + test('should return valid discover view url', () => { expect(getSavedSearchUrl()).toBe('#/'); expect(getSavedSearchUrl('id')).toBe('#/view/id'); }); diff --git a/src/plugins/saved_search/common/service/get_saved_searches.test.ts b/src/plugins/saved_search/common/service/get_saved_searches.test.ts index 792a46b904de8..4cba8842e6286 100644 --- a/src/plugins/saved_search/common/service/get_saved_searches.test.ts +++ b/src/plugins/saved_search/common/service/get_saved_searches.test.ts @@ -44,7 +44,7 @@ describe('getSavedSearch', () => { ); }); - test('should find saved search', async () => { + test('should find discover view', async () => { getSavedSrch = jest.fn().mockReturnValue({ item: { attributes: { @@ -151,7 +151,7 @@ describe('getSavedSearch', () => { `); }); - test('should find saved search with sql mode', async () => { + test('should find discover view with sql mode', async () => { getSavedSrch = jest.fn().mockReturnValue({ item: { attributes: { diff --git a/src/plugins/saved_search/common/service/get_saved_searches.ts b/src/plugins/saved_search/common/service/get_saved_searches.ts index d81830e76d519..058fa7dbfa85f 100644 --- a/src/plugins/saved_search/common/service/get_saved_searches.ts +++ b/src/plugins/saved_search/common/service/get_saved_searches.ts @@ -118,8 +118,8 @@ export const getSavedSearch = async (savedSearchId: string, deps: GetSavedSearch }; /** - * Returns a new saved search - * Used when e.g. Discover is opened without a saved search id + * Returns a new discover view + * Used when e.g. Discover is opened without a discover view id * @param search */ export const getNewSavedSearch = ({ diff --git a/src/plugins/saved_search/common/service/saved_searches_utils.test.ts b/src/plugins/saved_search/common/service/saved_searches_utils.test.ts index 950823e0018a0..ccd48a8f69572 100644 --- a/src/plugins/saved_search/common/service/saved_searches_utils.test.ts +++ b/src/plugins/saved_search/common/service/saved_searches_utils.test.ts @@ -17,7 +17,7 @@ describe('saved_searches_utils', () => { test('should convert attributes into SavedSearch', () => { const attributes: SavedSearchAttributes = { kibanaSavedObjectMeta: { searchSourceJSON: '{}' }, - title: 'saved search', + title: 'discover view', sort: [], columns: ['a', 'b'], description: 'foo', @@ -87,7 +87,7 @@ describe('saved_searches_utils', () => { ], "timeRange": undefined, "timeRestore": undefined, - "title": "saved search", + "title": "discover view", "usesAdHocDataView": false, "viewMode": undefined, } diff --git a/src/plugins/saved_search/common/types.ts b/src/plugins/saved_search/common/types.ts index d4ccb46d69cd5..b17628222e3e7 100644 --- a/src/plugins/saved_search/common/types.ts +++ b/src/plugins/saved_search/common/types.ts @@ -66,7 +66,7 @@ export interface SavedSearch { isTextBasedQuery?: boolean; usesAdHocDataView?: boolean; - // for restoring time range with a saved search + // for restoring time range with a discover view timeRestore?: boolean; timeRange?: TimeRange; refreshInterval?: RefreshInterval; @@ -74,7 +74,7 @@ export interface SavedSearch { rowsPerPage?: number; sampleSize?: number; breakdownField?: string; - // Whether or not this saved search is managed by the system + // Whether or not this discover view is managed by the system managed: boolean; references?: SavedObjectReference[]; sharingSavedObjectProps?: { diff --git a/src/plugins/saved_search/kibana.jsonc b/src/plugins/saved_search/kibana.jsonc index da389103a5f78..f27533c357d6a 100644 --- a/src/plugins/saved_search/kibana.jsonc +++ b/src/plugins/saved_search/kibana.jsonc @@ -2,7 +2,7 @@ "type": "plugin", "id": "@kbn/saved-search-plugin", "owner": "@elastic/kibana-data-discovery", - "description": "This plugin contains the definition and helper methods around saved searches, used by discover and visualizations.", + "description": "This plugin contains the definition and helper methods around discover viewes, used by discover and visualizations.", "plugin": { "id": "savedSearch", "server": true, diff --git a/src/plugins/saved_search/public/plugin.ts b/src/plugins/saved_search/public/plugin.ts index 8e8dd697cc55c..6b467c5809be2 100644 --- a/src/plugins/saved_search/public/plugin.ts +++ b/src/plugins/saved_search/public/plugin.ts @@ -37,13 +37,13 @@ import { } from './services/saved_searches'; /** - * Saved search plugin public Setup contract + * Discover view plugin public Setup contract */ // eslint-disable-next-line @typescript-eslint/no-empty-interface export interface SavedSearchPublicPluginSetup {} /** - * Saved search plugin public Setup contract + * Discover view plugin public Setup contract */ export interface SavedSearchPublicPluginStart { get: (savedSearchId: string) => ReturnType; @@ -63,7 +63,7 @@ export interface SavedSearchPublicPluginStart { } /** - * Saved search plugin public Setup contract + * Discover view plugin public Setup contract */ export interface SavedSearchPublicSetupDependencies { contentManagement: ContentManagementPublicSetup; @@ -71,7 +71,7 @@ export interface SavedSearchPublicSetupDependencies { } /** - * Saved search plugin public Setup contract + * Discover view plugin public Setup contract */ export interface SavedSearchPublicStartDependencies { data: DataPublicPluginStart; @@ -100,7 +100,7 @@ export class SavedSearchPublicPlugin latest: LATEST_VERSION, }, name: i18n.translate('savedSearch.contentManagementType', { - defaultMessage: 'Saved search', + defaultMessage: 'Discover view', }), }); diff --git a/src/plugins/saved_search/public/services/saved_searches/check_for_duplicate_title.ts b/src/plugins/saved_search/public/services/saved_searches/check_for_duplicate_title.ts index 49264e24e25ae..8794c47237044 100644 --- a/src/plugins/saved_search/public/services/saved_searches/check_for_duplicate_title.ts +++ b/src/plugins/saved_search/public/services/saved_searches/check_for_duplicate_title.ts @@ -53,7 +53,7 @@ export const checkForDuplicateTitle = async ({ (await hasDuplicatedTitle(title, contentManagement)) ) { onTitleDuplicate(); - return Promise.reject(new Error(`Saved search title already exists: ${title}`)); + return Promise.reject(new Error(`Discover view title already exists: ${title}`)); } return true; diff --git a/src/plugins/saved_search/public/services/saved_searches/saved_search_attribute_service.test.ts b/src/plugins/saved_search/public/services/saved_searches/saved_search_attribute_service.test.ts index f2dcef1104520..889b06943d101 100644 --- a/src/plugins/saved_search/public/services/saved_searches/saved_search_attribute_service.test.ts +++ b/src/plugins/saved_search/public/services/saved_searches/saved_search_attribute_service.test.ts @@ -82,12 +82,12 @@ jest.spyOn(mockServices.contentManagement, 'get').mockImplementation(async ({ id })); describe('getSavedSearchAttributeService', () => { - it('should return saved search attribute service', () => { + it('should return discover view attribute service', () => { const savedSearchAttributeService = getSavedSearchAttributeService(mockServices); expect(savedSearchAttributeService).toBeDefined(); }); - it('should call saveSearchSavedObject when wrapAttributes is called with a by ref saved search', async () => { + it('should call saveSearchSavedObject when wrapAttributes is called with a by ref discover view', async () => { const savedSearchAttributeService = getSavedSearchAttributeService(mockServices); const savedObjectId = 'saved-object-id'; const input: SearchByReferenceInput = { @@ -121,7 +121,7 @@ describe('getSavedSearchAttributeService', () => { ); }); - it('should call getSearchSavedObject when unwrapAttributes is called with a by ref saved search', async () => { + it('should call getSearchSavedObject when unwrapAttributes is called with a by ref discover view', async () => { const savedSearchAttributeService = getSavedSearchAttributeService(mockServices); const savedObjectId = 'saved-object-id'; const input: SearchByReferenceInput = { @@ -149,7 +149,7 @@ describe('getSavedSearchAttributeService', () => { }); describe('toSavedSearch', () => { - it('should convert attributes to saved search', async () => { + it('should convert attributes to discover view', async () => { const savedSearchAttributeService = getSavedSearchAttributeService(mockServices); const savedObjectId = 'saved-object-id'; const attributes: SavedSearchByValueAttributes = { diff --git a/src/plugins/saved_search/server/plugin.ts b/src/plugins/saved_search/server/plugin.ts index d09775442fd08..ba67e8738dd52 100644 --- a/src/plugins/saved_search/server/plugin.ts +++ b/src/plugins/saved_search/server/plugin.ts @@ -22,7 +22,7 @@ import { getKibanaContext } from './expressions/kibana_context'; import { getSavedSearch } from '../common/service/get_saved_searches'; /** - * Saved search plugin server Setup contract + * Discover view plugin server Setup contract */ export interface SavedSearchPublicSetupDependencies { data: DataPluginSetup; diff --git a/src/plugins/saved_search/server/saved_objects/search_migrations.test.ts b/src/plugins/saved_search/server/saved_objects/search_migrations.test.ts index 9d72fecb926d3..246fb66a4091d 100644 --- a/src/plugins/saved_search/server/saved_objects/search_migrations.test.ts +++ b/src/plugins/saved_search/server/saved_objects/search_migrations.test.ts @@ -352,7 +352,7 @@ Object { }); }); - it('should apply search source migrations within saved search', () => { + it('should apply search source migrations within discover view', () => { const savedSearch = { attributes: { kibanaSavedObjectMeta: { @@ -387,7 +387,7 @@ Object { }); }); - it('should not apply search source migrations within saved search when searchSourceJSON is not an object', () => { + it('should not apply search source migrations within discover view when searchSourceJSON is not an object', () => { const savedSearch = { attributes: { kibanaSavedObjectMeta: { diff --git a/src/plugins/vis_default_editor/public/components/sidebar/sidebar_title.tsx b/src/plugins/vis_default_editor/public/components/sidebar/sidebar_title.tsx index 681a41beed000..c155a3f7dc6e6 100644 --- a/src/plugins/vis_default_editor/public/components/sidebar/sidebar_title.tsx +++ b/src/plugins/vis_default_editor/public/components/sidebar/sidebar_title.tsx @@ -62,7 +62,7 @@ export function LinkedSearch({ savedSearch, eventEmitter }: LinkedSearchProps) { const linkButtonAriaLabel = i18n.translate( 'visDefaultEditor.sidebar.savedSearch.linkButtonAriaLabel', { - defaultMessage: 'Link to saved search. Click to learn more or break link.', + defaultMessage: 'Link to discover view. Click to learn more or break link.', } ); @@ -81,7 +81,7 @@ export function LinkedSearch({ savedSearch, eventEmitter }: LinkedSearchProps) {

@@ -133,7 +133,7 @@ export function LinkedSearch({ savedSearch, eventEmitter }: LinkedSearchProps) {

@@ -146,7 +146,7 @@ export function LinkedSearch({ savedSearch, eventEmitter }: LinkedSearchProps) { >

diff --git a/src/plugins/visualizations/common/locator.ts b/src/plugins/visualizations/common/locator.ts index fdb2800ec3a96..deb37cd6e5990 100644 --- a/src/plugins/visualizations/common/locator.ts +++ b/src/plugins/visualizations/common/locator.ts @@ -52,17 +52,17 @@ export type VisualizeLocatorParams = { vis?: SavedVisState; /** - * Whether this visualization is linked a saved search. + * Whether this visualization is linked a discover view. */ linked?: boolean; /** - * The saved search used as the source of the visualization. + * The discover view used as the source of the visualization. */ savedSearchId?: string; /** - * The saved search used as the source of the visualization. + * The discover view used as the source of the visualization. */ indexPattern?: string; }; diff --git a/src/plugins/visualizations/public/embeddable/to_ast.ts b/src/plugins/visualizations/public/embeddable/to_ast.ts index 686c1bf7b3271..406d578cb8a6e 100644 --- a/src/plugins/visualizations/public/embeddable/to_ast.ts +++ b/src/plugins/visualizations/public/embeddable/to_ast.ts @@ -13,7 +13,7 @@ import type { VisToExpressionAst } from '../types'; /** * Creates an ast expression for a visualization based on kibana context (query, filters, timerange) - * including a saved search if the visualization is based on it. + * including a discover view if the visualization is based on it. * The expression also includes particular visualization expression ast if presented. * * @internal diff --git a/src/plugins/visualizations/public/embeddable/visualize_embeddable_factory.test.ts b/src/plugins/visualizations/public/embeddable/visualize_embeddable_factory.test.ts index 98fa2108bbca1..1f87133ea32d2 100644 --- a/src/plugins/visualizations/public/embeddable/visualize_embeddable_factory.test.ts +++ b/src/plugins/visualizations/public/embeddable/visualize_embeddable_factory.test.ts @@ -12,7 +12,7 @@ import { VisualizeEmbeddableFactoryDeps } from './visualize_embeddable_factory'; describe('visualize_embeddable_factory', () => { const factory = new VisualizeEmbeddableFactory({} as VisualizeEmbeddableFactoryDeps); - test('extract saved search references for search source state and not store them in state', () => { + test('extract discover view references for search source state and not store them in state', () => { const { state, references } = factory.extract({ savedVis: { type: 'area', diff --git a/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.test.ts b/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.test.ts index ee0e3d481929d..be014418a1f23 100644 --- a/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.test.ts +++ b/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.test.ts @@ -170,14 +170,14 @@ describe('injectReferences', () => { `); }); - test(`fails when it can't find the saved search reference in the array`, () => { + test(`fails when it can't find the discover view reference in the array`, () => { const context = { id: '1', savedSearchRefName: 'search_0', title: 'test', } as VisSavedObject; expect(() => injectReferences(context, [])).toThrowErrorMatchingInlineSnapshot( - `"Could not find saved search reference \\"search_0\\""` + `"Could not find discover view reference \\"search_0\\""` ); }); diff --git a/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.ts b/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.ts index 8945da771db7f..016ae1c224ff9 100644 --- a/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.ts +++ b/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.ts @@ -36,7 +36,7 @@ export function extractReferences({ searchSourceReferences.forEach((r) => updatedReferences.push(r)); } - // Extract saved search + // Extract discover view if (updatedAttributes.savedSearchId) { updatedReferences.push({ name: 'search_0', @@ -77,7 +77,7 @@ export function injectReferences(savedObject: VisSavedObject, references: SavedO (reference) => reference.name === savedObject.savedSearchRefName ); if (!savedSearchReference) { - throw new Error(`Could not find saved search reference "${savedObject.savedSearchRefName}"`); + throw new Error(`Could not find discover view reference "${savedObject.savedSearchRefName}"`); } savedObject.savedSearchId = savedSearchReference.id; delete savedObject.savedSearchRefName; diff --git a/src/plugins/visualizations/public/vis_types/types.ts b/src/plugins/visualizations/public/vis_types/types.ts index 90f64276adf76..7f72a38a0c7a6 100644 --- a/src/plugins/visualizations/public/vis_types/types.ts +++ b/src/plugins/visualizations/public/vis_types/types.ts @@ -163,7 +163,7 @@ export interface VisTypeDefinition { /** * The flag is necessary for aggregation based visualizations. * When "true", an additional step on the vis creation wizard will be provided - * with the selection of a search source - an index pattern or a saved search. + * with the selection of a search source - an index pattern or a discover view. */ readonly requiresSearch?: boolean; /** diff --git a/src/plugins/visualizations/public/visualize_app/types.ts b/src/plugins/visualizations/public/visualize_app/types.ts index abc55e3e671fe..f90f13b43350b 100644 --- a/src/plugins/visualizations/public/visualize_app/types.ts +++ b/src/plugins/visualizations/public/visualize_app/types.ts @@ -159,7 +159,7 @@ export interface EditorRenderProps { uiState: PersistedState; unifiedSearch: UnifiedSearchPublicPluginStart; /** - * Flag to determine if visualiztion is linked to the saved search + * Flag to determine if visualiztion is linked to the discover view */ linked: boolean; } diff --git a/src/plugins/visualizations/public/visualize_app/utils/get_top_nav_config.tsx b/src/plugins/visualizations/public/visualize_app/utils/get_top_nav_config.tsx index ce12d23ad0c28..3b3271361e525 100644 --- a/src/plugins/visualizations/public/visualize_app/utils/get_top_nav_config.tsx +++ b/src/plugins/visualizations/public/visualize_app/utils/get_top_nav_config.tsx @@ -301,7 +301,7 @@ export const getTopNavConfig = ( }, }), run: async () => { - // lens doesn't support saved searches, should unlink before transition + // lens doesn't support discover viewes, should unlink before transition if (eventEmitter && visInstance.vis.data.savedSearchId) { eventEmitter.emit('unlinkFromSavedSearch', false); } diff --git a/src/plugins/visualizations/public/visualize_app/utils/get_visualization_instance.test.ts b/src/plugins/visualizations/public/visualize_app/utils/get_visualization_instance.test.ts index b6304b6e96ad6..b923390e536c1 100644 --- a/src/plugins/visualizations/public/visualize_app/utils/get_visualization_instance.test.ts +++ b/src/plugins/visualizations/public/visualize_app/utils/get_visualization_instance.test.ts @@ -115,7 +115,7 @@ describe('getVisualizationInstance', () => { expect(vis).toBe(newVisObj); }); - test('should create saved search instance if vis based on saved search id', async () => { + test('should create discover view instance if vis based on discover view id', async () => { visMock.data.savedSearchId = 'saved_search_id'; const { savedSearch } = await getVisualizationInstance(mockServices, 'saved_vis_id'); diff --git a/src/plugins/visualizations/public/visualize_app/utils/use/use_editor_updates.test.ts b/src/plugins/visualizations/public/visualize_app/utils/use/use_editor_updates.test.ts index f6f242d08d0b0..07584be2246b2 100644 --- a/src/plugins/visualizations/public/visualize_app/utils/use/use_editor_updates.test.ts +++ b/src/plugins/visualizations/public/visualize_app/utils/use/use_editor_updates.test.ts @@ -253,7 +253,7 @@ describe('useEditorUpdates', () => { }); describe('handle linked search changes', () => { - test('should update saved search id in saved instance', () => { + test('should update discover view id in saved instance', () => { // @ts-expect-error 4.3.5 upgrade savedVisInstance.savedSearch = { id: 'saved_search_id', @@ -283,7 +283,7 @@ describe('useEditorUpdates', () => { expect(savedVisInstance.vis.data.savedSearchId).toEqual('saved_search_id'); }); - test('should remove saved search id from vis instance', () => { + test('should remove discover view id from vis instance', () => { // @ts-expect-error savedVisInstance.savedVis = { savedSearchId: 'saved_search_id', diff --git a/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.test.ts b/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.test.ts index 99ce99fd094fb..8afada162dd39 100644 --- a/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.test.ts +++ b/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.test.ts @@ -36,7 +36,7 @@ describe('useLinkedSearchUpdates', () => { expect(mockServices.toastNotifications.addSuccess).not.toHaveBeenCalled(); }); - it('should subscribe on unlinkFromSavedSearch event if vis is based on saved search', () => { + it('should subscribe on unlinkFromSavedSearch event if vis is based on discover view', () => { const mockAppState = { transitions: { unlinkSavedSearch: jest.fn(), diff --git a/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts b/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts index ffd23ec06aea6..28e01045a4b76 100644 --- a/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts +++ b/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts @@ -47,7 +47,7 @@ export const useLinkedSearchUpdates = ( if (showToast) { services.toastNotifications.addSuccess( i18n.translate('visualizations.linkedToSearch.unlinkSuccessNotificationText', { - defaultMessage: `Unlinked from saved search '{searchTitle}'`, + defaultMessage: `Unlinked from discover view '{searchTitle}'`, values: { searchTitle: savedSearch.title, }, diff --git a/src/plugins/visualizations/public/visualize_app/utils/use/use_saved_vis_instance.test.ts b/src/plugins/visualizations/public/visualize_app/utils/use/use_saved_vis_instance.test.ts index 4b6b87bd04f1f..e01ffad0c4302 100644 --- a/src/plugins/visualizations/public/visualize_app/utils/use/use_saved_vis_instance.test.ts +++ b/src/plugins/visualizations/public/visualize_app/utils/use/use_saved_vis_instance.test.ts @@ -246,7 +246,7 @@ describe('useSavedVisInstance', () => { expect(toastNotifications.addWarning).toHaveBeenCalled(); }); - test("should throw error if index pattern or saved search id doesn't exist in search params", async () => { + test("should throw error if index pattern or discover view id doesn't exist in search params", async () => { mockServices.history.location = { ...mockServices.history.location, search: '?type=area', diff --git a/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx b/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx index 374d2c4b8fa39..87b2edabbe4b9 100644 --- a/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx +++ b/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx @@ -53,7 +53,7 @@ export class SearchSelection extends React.Component { noItemsMessage={i18n.translate( 'visualizations.newVisWizard.searchSelection.notFoundLabel', { - defaultMessage: 'No matching indices or saved searches found.', + defaultMessage: 'No matching indices or discover viewes found.', } )} savedObjectMetaData={[ @@ -63,10 +63,10 @@ export class SearchSelection extends React.Component { name: i18n.translate( 'visualizations.newVisWizard.searchSelection.savedObjectType.search', { - defaultMessage: 'Saved search', + defaultMessage: 'Discover view', } ), - // ignore the saved searches that have text-based languages queries + // ignore the discover viewes that have text-based languages queries includeFields: ['isTextBasedQuery', 'usesAdHocDataView'], showSavedObject, }, diff --git a/test/accessibility/apps/dashboard.ts b/test/accessibility/apps/dashboard.ts index 32d198c7d5e02..e671e25942d0c 100644 --- a/test/accessibility/apps/dashboard.ts +++ b/test/accessibility/apps/dashboard.ts @@ -51,7 +51,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await a11y.testAppSnapshot(); }); - it('add a saved search', async () => { + it('add a discover view', async () => { await dashboardAddPanel.addSavedSearch('[Flights] Flight Log'); await a11y.testAppSnapshot(); }); diff --git a/test/accessibility/apps/discover.ts b/test/accessibility/apps/discover.ts index 4deb2acb66d74..337f40f9b85d1 100644 --- a/test/accessibility/apps/discover.ts +++ b/test/accessibility/apps/discover.ts @@ -57,7 +57,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await a11y.testAppSnapshot(); }); - it('a11y test on load saved search panel', async () => { + it('a11y test on load discover view panel', async () => { await PageObjects.discover.openLoadSavedSearchPanel(); await a11y.testAppSnapshot(); await PageObjects.discover.closeLoadSavedSearchPanel(); diff --git a/test/analytics/tests/instrumented_events/from_the_browser/loaded_dashboard.ts b/test/analytics/tests/instrumented_events/from_the_browser/loaded_dashboard.ts index 7b21a5637d167..b86896bd48048 100644 --- a/test/analytics/tests/instrumented_events/from_the_browser/loaded_dashboard.ts +++ b/test/analytics/tests/instrumented_events/from_the_browser/loaded_dashboard.ts @@ -98,10 +98,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); /** - * Saved search embeddable + * Discover view embeddable */ - it('emits when saved search is added', async () => { + it('emits when discover view is added', async () => { await dashboardAddPanel.addSavedSearch(SAVED_SEARCH_PANEL_TITLE); const event = await checkEmitsOnce(); @@ -110,12 +110,12 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(event.properties.value2).to.be(1); }); - it('emits on saved search refreshed', async () => { + it('emits on discover view refreshed', async () => { await queryBar.clickQuerySubmitButton(); await checkEmitsOnce(); }); - it("doesn't emit when removing saved search panel", async () => { + it("doesn't emit when removing discover view panel", async () => { await dashboardPanelActions.removePanelByTitle(SAVED_SEARCH_PANEL_TITLE); await checkDoesNotEmit(); }); diff --git a/test/functional/apps/dashboard/group1/embeddable_rendering.ts b/test/functional/apps/dashboard/group1/embeddable_rendering.ts index 45408a8846c17..ec33a760cfb75 100644 --- a/test/functional/apps/dashboard/group1/embeddable_rendering.ts +++ b/test/functional/apps/dashboard/group1/embeddable_rendering.ts @@ -143,7 +143,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.dashboard.waitForRenderComplete(); }); - it('adding saved searches', async () => { + it('adding discover viewes', async () => { const visAndSearchNames = visNames.concat( await dashboardAddPanel.addEverySavedSearch('"Rendering Test"') ); diff --git a/test/functional/apps/dashboard/group2/dashboard_filter_bar.ts b/test/functional/apps/dashboard/group2/dashboard_filter_bar.ts index 276a3f29e8fd5..5508c840e75fd 100644 --- a/test/functional/apps/dashboard/group2/dashboard_filter_bar.ts +++ b/test/functional/apps/dashboard/group2/dashboard_filter_bar.ts @@ -193,7 +193,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - describe('saved search filtering', function () { + describe('discover view filtering', function () { before(async () => { await filterBar.ensureFieldEditorModalIsClosed(); await PageObjects.dashboard.gotoDashboardLandingPage(); diff --git a/test/functional/apps/dashboard/group2/dashboard_filtering.ts b/test/functional/apps/dashboard/group2/dashboard_filtering.ts index 24f276b831036..fcd9267274920 100644 --- a/test/functional/apps/dashboard/group2/dashboard_filtering.ts +++ b/test/functional/apps/dashboard/group2/dashboard_filtering.ts @@ -122,7 +122,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await dashboardExpect.tsvbTopNValuesExist(['-', '-']); }); - it('saved search is filtered', async () => { + it('discover view is filtered', async () => { await dashboardExpect.savedSearchRowsMissing(); }); @@ -183,7 +183,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await dashboardExpect.tsvbTopNValuesExist(['-', '-']); }); - it('saved search is filtered', async () => { + it('discover view is filtered', async () => { await dashboardExpect.savedSearchRowsMissing(); }); @@ -243,7 +243,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await dashboardExpect.tsvbMarkdownWithValuesExists(['7,209.286']); }); - it('saved searches', async () => { + it('discover viewes', async () => { await dashboardExpect.savedSearchRowsExist(); }); @@ -322,7 +322,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await pieChart.expectPieSliceCount(5); }); - it('Pie chart linked to saved search filters data', async () => { + it('Pie chart linked to discover view filters data', async () => { await dashboardAddPanel.addVisualization( 'Filter Test: animals: linked to search with filter' ); @@ -330,7 +330,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await pieChart.expectSliceCountForAllPies(7); }); - it('Pie chart linked to saved search filters shows no data with conflicting dashboard query', async () => { + it('Pie chart linked to discover view filters shows no data with conflicting dashboard query', async () => { await elasticChart.setNewChartUiDebugFlag(true); await queryBar.setQuery('weightLbs<40'); await queryBar.submitQuery(); diff --git a/test/functional/apps/dashboard/group3/dashboard_state.ts b/test/functional/apps/dashboard/group3/dashboard_state.ts index 650d2e6b79269..5e3442dfc75e5 100644 --- a/test/functional/apps/dashboard/group3/dashboard_state.ts +++ b/test/functional/apps/dashboard/group3/dashboard_state.ts @@ -117,7 +117,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(colorChoiceRetained).to.be(true); }); - it('Saved search with no changes will update when the saved object changes', async () => { + it('Discover view with no changes will update when the saved object changes', async () => { await PageObjects.dashboard.gotoDashboardLandingPage(); await PageObjects.header.clickDiscover(); @@ -149,7 +149,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(headers[2]).to.be('agent'); }); - it('Saved search with column changes will not update when the saved object changes', async () => { + it('Discover view with column changes will not update when the saved object changes', async () => { await PageObjects.dashboard.switchToEditMode(); await PageObjects.discover.removeHeaderColumn('bytes'); await PageObjects.dashboard.saveDashboard('Has local edits'); @@ -167,7 +167,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(headers[1]).to.be('agent'); }); - it('Saved search will update when the query is changed in the URL', async () => { + it('Discover view will update when the query is changed in the URL', async () => { const currentQuery = await queryBar.getQueryString(); expect(currentQuery).to.equal(''); const newUrl = updateAppStateQueryParam( diff --git a/test/functional/apps/dashboard/group3/dashboard_time_picker.ts b/test/functional/apps/dashboard/group3/dashboard_time_picker.ts index 303d0fe0f141e..e65ed549d5ff2 100644 --- a/test/functional/apps/dashboard/group3/dashboard_time_picker.ts +++ b/test/functional/apps/dashboard/group3/dashboard_time_picker.ts @@ -51,11 +51,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await pieChart.expectPieSliceCount(10); }); - it('Saved search updated when time picker changes', async () => { + it('Discover view updated when time picker changes', async () => { await PageObjects.dashboard.gotoDashboardLandingPage(); await PageObjects.dashboard.clickNewDashboard(); await dashboardVisualizations.createAndAddSavedSearch({ - name: 'saved search', + name: 'discover view', fields: ['bytes', 'agent'], }); @@ -89,10 +89,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.dashboard.clickNewDashboard(); log.debug('Clicked new dashboard'); await dashboardVisualizations.createAndAddSavedSearch({ - name: 'saved search', + name: 'discover view', fields: ['bytes', 'agent'], }); - log.debug('added saved search'); + log.debug('added discover view'); const currentUrl = await browser.getCurrentUrl(); const kibanaBaseUrl = currentUrl.substring(0, currentUrl.indexOf('#')); const urlQuery = diff --git a/test/functional/apps/dashboard/group3/panel_context_menu.ts b/test/functional/apps/dashboard/group3/panel_context_menu.ts index 4abf860cb17fc..93ea9d839dd73 100644 --- a/test/functional/apps/dashboard/group3/panel_context_menu.ts +++ b/test/functional/apps/dashboard/group3/panel_context_menu.ts @@ -95,7 +95,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - describe('saved search object edit menu', () => { + describe('discover view object edit menu', () => { const searchName = 'my search'; before(async () => { @@ -119,7 +119,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(panelCount).to.be(1); }); - it('opens a saved search when edit link is clicked', async () => { + it('opens a discover view when edit link is clicked', async () => { await dashboardPanelActions.openContextMenu(); await dashboardPanelActions.clickEdit(); await PageObjects.header.waitUntilLoadingHasFinished(); @@ -127,7 +127,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(queryName).to.be(searchName); }); - it('deletes the saved search when delete link is clicked', async () => { + it('deletes the discover view when delete link is clicked', async () => { await PageObjects.header.clickDashboard(); await PageObjects.header.waitUntilLoadingHasFinished(); await dashboardPanelActions.removePanel(); diff --git a/test/functional/apps/dashboard/group3/panel_replacing.ts b/test/functional/apps/dashboard/group3/panel_replacing.ts index 1cb344748594f..a54f28e90b91d 100644 --- a/test/functional/apps/dashboard/group3/panel_replacing.ts +++ b/test/functional/apps/dashboard/group3/panel_replacing.ts @@ -68,8 +68,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(panelTitles[0]).to.be(AREA_CHART_VIS_NAME); }); - it('replaced panel with saved search', async () => { - const replacedSearch = 'replaced saved search'; + it('replaced panel with discover view', async () => { + const replacedSearch = 'replaced discover view'; await dashboardVisualizations.createSavedSearch({ name: replacedSearch, fields: ['bytes', 'agent'], @@ -80,7 +80,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.dashboard.switchToEditMode(); } await dashboardPanelActions.replacePanelByTitle(AREA_CHART_VIS_NAME); - await dashboardReplacePanel.replaceEmbeddable(replacedSearch, 'Saved search'); + await dashboardReplacePanel.replaceEmbeddable(replacedSearch, 'Discover view'); await PageObjects.header.waitUntilLoadingHasFinished(); await PageObjects.dashboard.waitForRenderComplete(); const panelTitles = await PageObjects.dashboard.getPanelTitles(); diff --git a/test/functional/apps/dashboard/group5/data_shared_attributes.ts b/test/functional/apps/dashboard/group5/data_shared_attributes.ts index 3202d418bd512..11ba390370b78 100644 --- a/test/functional/apps/dashboard/group5/data_shared_attributes.ts +++ b/test/functional/apps/dashboard/group5/data_shared_attributes.ts @@ -126,10 +126,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - it('data-shared-item title should update a saved search when using a custom panel title', async () => { + it('data-shared-item title should update a discover view when using a custom panel title', async () => { await PageObjects.dashboard.switchToEditMode(); const CUSTOM_SEARCH_TITLE = 'ima custom title for a search!'; - const el = await dashboardPanelActions.getPanelHeading('Rendering Test: saved search'); + const el = await dashboardPanelActions.getPanelHeading('Rendering Test: discover view'); await dashboardPanelActions.customizePanel(el); await dashboardCustomizePanel.expectCustomizePanelSettingsFlyoutOpen(); await dashboardCustomizePanel.setCustomPanelTitle(CUSTOM_SEARCH_TITLE); diff --git a/test/functional/apps/dashboard/group5/saved_search_embeddable.ts b/test/functional/apps/dashboard/group5/saved_search_embeddable.ts index f20172d10ed5c..564e8cbde739d 100644 --- a/test/functional/apps/dashboard/group5/saved_search_embeddable.ts +++ b/test/functional/apps/dashboard/group5/saved_search_embeddable.ts @@ -20,7 +20,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const from = 'Sep 22, 2015 @ 00:00:00.000'; const to = 'Sep 23, 2015 @ 00:00:00.000'; - describe('dashboard saved search embeddable', () => { + describe('dashboard discover view embeddable', () => { before(async () => { await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional'); await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data'); @@ -67,7 +67,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(marks.length).to.be(0); }); - it('view action leads to a saved search', async function () { + it('view action leads to a discover view', async function () { await filterBar.removeAllFilters(); await PageObjects.dashboard.saveDashboard('Dashboard With Saved Search'); await PageObjects.dashboard.clickCancelOutOfEditMode(false); @@ -91,7 +91,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.discover.waitForDiscoverAppOnScreen(); expect(await PageObjects.discover.getSavedSearchTitle()).to.equal( - 'Rendering Test: saved search' + 'Rendering Test: discover view' ); }); diff --git a/test/functional/apps/dashboard_elements/controls/common/time_slider.ts b/test/functional/apps/dashboard_elements/controls/common/time_slider.ts index c860af183d64e..78ff893ae9717 100644 --- a/test/functional/apps/dashboard_elements/controls/common/time_slider.ts +++ b/test/functional/apps/dashboard_elements/controls/common/time_slider.ts @@ -128,10 +128,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); describe('panel interactions', async () => { - describe('saved search', async () => { + describe('discover view', async () => { before(async () => { await dashboard.navigateToApp(); - await dashboard.loadSavedDashboard('timeslider and saved search'); + await dashboard.loadSavedDashboard('timeslider and discover view'); await dashboard.waitForRenderComplete(); }); diff --git a/test/functional/apps/discover/embeddable/_saved_search_embeddable.ts b/test/functional/apps/discover/embeddable/_saved_search_embeddable.ts index 03f40c5b6ebcf..8631b264fc8bf 100644 --- a/test/functional/apps/discover/embeddable/_saved_search_embeddable.ts +++ b/test/functional/apps/discover/embeddable/_saved_search_embeddable.ts @@ -21,7 +21,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const testSubjects = getService('testSubjects'); const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'timePicker', 'discover']); - describe('discover saved search embeddable', () => { + describe('discover discover view embeddable', () => { before(async () => { await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional'); await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data'); @@ -103,7 +103,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(await cell.getVisibleText()).to.be('Sep 22, 2015 @ 23:50:13.253'); }); - it('should render duplicate saved search embeddables', async () => { + it('should render duplicate discover view embeddables', async () => { await addSearchEmbeddableToDashboard(); await addSearchEmbeddableToDashboard(); const [firstGridCell, secondGridCell] = await dataGrid.getAllCellElements(); @@ -129,7 +129,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { ); }); - it('should replace a panel with a saved search', async () => { + it('should replace a panel with a discover view', async () => { await dashboardAddPanel.addVisualization('Rendering Test: datatable'); await PageObjects.header.waitUntilLoadingHasFinished(); await PageObjects.dashboard.waitForRenderComplete(); diff --git a/test/functional/apps/discover/group1/_discover.ts b/test/functional/apps/discover/group1/_discover.ts index 0210c7d8cc7f2..b582a572999e5 100644 --- a/test/functional/apps/discover/group1/_discover.ts +++ b/test/functional/apps/discover/group1/_discover.ts @@ -126,7 +126,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(isVisible).to.be(false); }); - it('should reload the saved search with persisted query to show the initial hit count', async function () { + it('should reload the discover view with persisted query to show the initial hit count', async function () { await PageObjects.timePicker.setDefaultAbsoluteRange(); await PageObjects.discover.waitUntilSearchingHasFinished(); // apply query some changes diff --git a/test/functional/apps/discover/group1/_discover_histogram.ts b/test/functional/apps/discover/group1/_discover_histogram.ts index ad5563e78f918..982f6e30aede7 100644 --- a/test/functional/apps/discover/group1/_discover_histogram.ts +++ b/test/functional/apps/discover/group1/_discover_histogram.ts @@ -189,13 +189,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(canvasExists).to.be(true); }); }); - it('should allow hiding the histogram, persisted in saved search', async () => { + it('should allow hiding the histogram, persisted in discover view', async () => { const from = 'Jan 1, 2010 @ 00:00:00.000'; const to = 'Mar 21, 2019 @ 00:00:00.000'; const savedSearch = 'persisted hidden histogram'; await prepareTest({ from, to }); - // close chart for saved search + // close chart for discover view await PageObjects.discover.toggleChartVisibility(); let canvasExists: boolean; await retry.try(async () => { @@ -211,13 +211,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.discover.clickNewSearchButton(); await PageObjects.header.waitUntilLoadingHasFinished(); - // load saved search + // load discover view await PageObjects.discover.loadSavedSearch(savedSearch); await PageObjects.header.waitUntilLoadingHasFinished(); canvasExists = await elasticChart.canvasExists(); expect(canvasExists).to.be(false); - // open chart for saved search + // open chart for discover view await PageObjects.discover.toggleChartVisibility(); await retry.waitFor(`Discover histogram to be displayed`, async () => { canvasExists = await elasticChart.canvasExists(); @@ -232,7 +232,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.discover.clickNewSearchButton(); await PageObjects.header.waitUntilLoadingHasFinished(); - // load saved search + // load discover view await PageObjects.discover.loadSavedSearch(savedSearch); await PageObjects.header.waitUntilLoadingHasFinished(); canvasExists = await elasticChart.canvasExists(); @@ -296,7 +296,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(await PageObjects.discover.isChartVisible()).to.be(true); }); - it('should reset all histogram state when resetting the saved search', async () => { + it('should reset all histogram state when resetting the discover view', async () => { await PageObjects.common.navigateToApp('discover'); await PageObjects.discover.waitUntilSearchingHasFinished(); await PageObjects.timePicker.setDefaultAbsoluteRange(); diff --git a/test/functional/apps/discover/group1/_discover_histogram_breakdown.ts b/test/functional/apps/discover/group1/_discover_histogram_breakdown.ts index 86ec135ab0089..210fa1b5fda8a 100644 --- a/test/functional/apps/discover/group1/_discover_histogram_breakdown.ts +++ b/test/functional/apps/discover/group1/_discover_histogram_breakdown.ts @@ -43,7 +43,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(await filterBar.hasFilter('extension.raw', 'png')).to.be(true); }); - it('should save breakdown field in saved search', async () => { + it('should save breakdown field in discover view', async () => { await filterBar.removeFilter('extension.raw'); await PageObjects.discover.saveSearch('with breakdown'); diff --git a/test/functional/apps/discover/group2/_data_grid_pagination.ts b/test/functional/apps/discover/group2/_data_grid_pagination.ts index 4c0a3aa53759e..316078afdef7f 100644 --- a/test/functional/apps/discover/group2/_data_grid_pagination.ts +++ b/test/functional/apps/discover/group2/_data_grid_pagination.ts @@ -86,7 +86,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await testSubjects.existOrFail('unifiedDataTableFooter'); }); - it('should render exact number of rows which where configured in the saved search or in settings', async () => { + it('should render exact number of rows which where configured in the discover view or in settings', async () => { await kibanaServer.uiSettings.update({ ...defaultSettings, 'discover:sampleSize': 12, @@ -113,10 +113,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect((await dataGrid.getDocTableRows()).length).to.be(6); // as in settings await dataGrid.checkCurrentRowsPerPageToBe(6); - // open the saved search + // open the discover view await PageObjects.discover.loadSavedSearch(savedSearchTitle); await PageObjects.discover.waitUntilSearchingHasFinished(); - expect((await dataGrid.getDocTableRows()).length).to.be(10); // as in the saved search + expect((await dataGrid.getDocTableRows()).length).to.be(10); // as in the discover view await dataGrid.checkCurrentRowsPerPageToBe(10); }); }); diff --git a/test/functional/apps/discover/group2/_data_grid_sample_size.ts b/test/functional/apps/discover/group2/_data_grid_sample_size.ts index 891363f0868db..7972a28979daa 100644 --- a/test/functional/apps/discover/group2/_data_grid_sample_size.ts +++ b/test/functional/apps/discover/group2/_data_grid_sample_size.ts @@ -137,13 +137,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(await dataGrid.getCurrentSampleSizeValue()).to.be(DEFAULT_SAMPLE_SIZE); await goToLastPageAndCheckFooterMessage(DEFAULT_SAMPLE_SIZE); - // load the saved search again + // load the discover view again await PageObjects.discover.loadSavedSearch(SAVED_SEARCH_NAME); await dataGrid.clickGridSettings(); expect(await dataGrid.getCurrentSampleSizeValue()).to.be(CUSTOM_SAMPLE_SIZE_FOR_SAVED_SEARCH); await goToLastPageAndCheckFooterMessage(CUSTOM_SAMPLE_SIZE_FOR_SAVED_SEARCH); - // load another saved search without a custom sample size + // load another discover view without a custom sample size await PageObjects.discover.loadSavedSearch('A Saved Search'); await dataGrid.clickGridSettings(); expect(await dataGrid.getCurrentSampleSizeValue()).to.be(DEFAULT_SAMPLE_SIZE); diff --git a/test/functional/apps/discover/group3/_request_counts.ts b/test/functional/apps/discover/group3/_request_counts.ts index d568d623b5c08..2c55d244da0ae 100644 --- a/test/functional/apps/discover/group3/_request_counts.ts +++ b/test/functional/apps/discover/group3/_request_counts.ts @@ -131,7 +131,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - it(`should send ${savedSearchesRequests} requests for saved search changes`, async () => { + it(`should send ${savedSearchesRequests} requests for discover view changes`, async () => { await setQuery(query1); await queryBar.clickQuerySubmitButton(); await PageObjects.timePicker.setAbsoluteRange( @@ -139,25 +139,25 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { 'Sep 23, 2015 @ 00:00:00.000' ); await waitForLoadingToFinish(); - // TODO: Check why the request happens 4 times in case of opening a saved search + // TODO: Check why the request happens 4 times in case of opening a discover view // https://github.com/elastic/kibana/issues/165192 - // creating the saved search + // creating the discover view await expectSearches(type, savedSearchesRequests ?? expectedRequests, async () => { await PageObjects.discover.saveSearch(savedSearch); }); - // resetting the saved search + // resetting the discover view await setQuery(query2); await queryBar.clickQuerySubmitButton(); await waitForLoadingToFinish(); await expectSearches(type, expectedRequests, async () => { await PageObjects.discover.revertUnsavedChanges(); }); - // clearing the saved search + // clearing the discover view await expectSearches('ese', savedSearchesRequests ?? expectedRequests, async () => { await testSubjects.click('discoverNewButton'); await waitForLoadingToFinish(); }); - // loading the saved search + // loading the discover view // TODO: https://github.com/elastic/kibana/issues/165192 await expectSearches(type, savedSearchesRequests ?? expectedRequests, async () => { await PageObjects.discover.loadSavedSearch(savedSearch); diff --git a/test/functional/apps/discover/group3/_unsaved_changes_badge.ts b/test/functional/apps/discover/group3/_unsaved_changes_badge.ts index 305298ff2ccc6..7237725f9035e 100644 --- a/test/functional/apps/discover/group3/_unsaved_changes_badge.ts +++ b/test/functional/apps/discover/group3/_unsaved_changes_badge.ts @@ -9,9 +9,9 @@ import expect from '@kbn/expect'; import { FtrProviderContext } from '../ftr_provider_context'; -const SAVED_SEARCH_NAME = 'test saved search'; -const SAVED_SEARCH_WITH_FILTERS_NAME = 'test saved search with filters'; -const SAVED_SEARCH_ESQL = 'test saved search ES|QL'; +const SAVED_SEARCH_NAME = 'test discover view'; +const SAVED_SEARCH_WITH_FILTERS_NAME = 'test discover view with filters'; +const SAVED_SEARCH_ESQL = 'test discover view ES|QL'; export default function ({ getService, getPageObjects }: FtrProviderContext) { const esArchiver = getService('esArchiver'); @@ -57,7 +57,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.discover.waitUntilSearchingHasFinished(); }); - it('should not show the badge initially nor after changes to a draft saved search', async () => { + it('should not show the badge initially nor after changes to a draft discover view', async () => { await testSubjects.missingOrFail('unsavedChangesBadge'); await PageObjects.unifiedFieldList.clickFieldListItemAdd('bytes'); @@ -68,7 +68,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await testSubjects.missingOrFail('unsavedChangesBadge'); }); - it('should show the badge only after changes to a persisted saved search', async () => { + it('should show the badge only after changes to a persisted discover view', async () => { await PageObjects.discover.saveSearch(SAVED_SEARCH_NAME); await PageObjects.discover.waitUntilSearchingHasFinished(); @@ -85,7 +85,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await testSubjects.missingOrFail('unsavedChangesBadge'); }); - it('should not show a badge after loading a saved search, only after changes', async () => { + it('should not show a badge after loading a discover view, only after changes', async () => { await PageObjects.discover.loadSavedSearch(SAVED_SEARCH_NAME); await testSubjects.missingOrFail('unsavedChangesBadge'); @@ -198,7 +198,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(await PageObjects.discover.getHitCount()).to.be('1,373'); }); - it('should not show a badge after loading an ES|QL saved search, only after changes', async () => { + it('should not show a badge after loading an ES|QL discover view, only after changes', async () => { await PageObjects.discover.selectTextBaseLang(); await monacoEditor.setCodeEditorValue('from logstash-* | limit 10'); diff --git a/test/functional/apps/discover/group4/_adhoc_data_views.ts b/test/functional/apps/discover/group4/_adhoc_data_views.ts index 2fe0167763687..4e10c32e210c2 100644 --- a/test/functional/apps/discover/group4/_adhoc_data_views.ts +++ b/test/functional/apps/discover/group4/_adhoc_data_views.ts @@ -186,7 +186,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(+second).to.equal(+first * 2); }); - it('should open saved search by navigation to context from embeddable', async () => { + it('should open discover view by navigation to context from embeddable', async () => { // navigate to context view await dataGrid.clickRowToggle({ rowIndex: 0 }); const [, surrDocs] = await dataGrid.getRowActions({ rowIndex: 0 }); @@ -200,7 +200,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { } await PageObjects.context.waitUntilContextLoadingHasFinished(); - // open saved search + // open discover view await testSubjects.click('~breadcrumb & ~first'); await PageObjects.header.waitUntilLoadingHasFinished(); diff --git a/test/functional/apps/discover/group4/_chart_hidden.ts b/test/functional/apps/discover/group4/_chart_hidden.ts index 6bee290df896d..1c24bbe9075fe 100644 --- a/test/functional/apps/discover/group4/_chart_hidden.ts +++ b/test/functional/apps/discover/group4/_chart_hidden.ts @@ -54,7 +54,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(await PageObjects.discover.isChartVisible()).to.be(false); }); - it('persists hidden chart option on the saved search ', async function () { + it('persists hidden chart option on the discover view ', async function () { const savedSearchTitle = 'chart hidden'; await PageObjects.discover.saveSearch(savedSearchTitle); diff --git a/test/functional/apps/discover/group4/_indexpattern_with_unmapped_fields.ts b/test/functional/apps/discover/group4/_indexpattern_with_unmapped_fields.ts index 1efa988be9227..371d5ec23eaa1 100644 --- a/test/functional/apps/discover/group4/_indexpattern_with_unmapped_fields.ts +++ b/test/functional/apps/discover/group4/_indexpattern_with_unmapped_fields.ts @@ -43,7 +43,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await kibanaServer.uiSettings.unset('timepicker:timeDefaults'); }); - it('unmapped fields exist on a new saved search', async () => { + it('unmapped fields exist on a new discover view', async () => { const expectedHitCount = '4'; await retry.try(async function () { expect(await PageObjects.discover.getHitCount()).to.be(expectedHitCount); @@ -62,7 +62,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.unifiedFieldList.toggleSidebarSection('unmapped'); }); - it('unmapped fields exist on an existing saved search', async () => { + it('unmapped fields exist on an existing discover view', async () => { await PageObjects.discover.loadSavedSearch('Existing Saved Search'); const expectedHitCount = '4'; await retry.try(async function () { diff --git a/test/functional/apps/discover/group4/_indexpattern_without_timefield.ts b/test/functional/apps/discover/group4/_indexpattern_without_timefield.ts index 2531a368861c3..b2c104e364b67 100644 --- a/test/functional/apps/discover/group4/_indexpattern_without_timefield.ts +++ b/test/functional/apps/discover/group4/_indexpattern_without_timefield.ts @@ -115,7 +115,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(url).to.contain(`refreshInterval:(pause:!t,value:${autoRefreshInterval * 1000})`); }); - it('should allow switching from a saved search with a time field to a saved search without a time field', async () => { + it('should allow switching from a discover view with a time field to a discover view without a time field', async () => { await PageObjects.common.navigateToApp('discover'); await PageObjects.discover.selectIndexPattern('with-timefield'); await PageObjects.header.waitUntilLoadingHasFinished(); diff --git a/test/functional/apps/discover/group4/_runtime_fields_editor.ts b/test/functional/apps/discover/group4/_runtime_fields_editor.ts index 808694680cd8b..790ab593f8c3d 100644 --- a/test/functional/apps/discover/group4/_runtime_fields_editor.ts +++ b/test/functional/apps/discover/group4/_runtime_fields_editor.ts @@ -94,7 +94,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - it('allows creation of a new field and use it in a saved search', async function () { + it('allows creation of a new field and use it in a discover view', async function () { const fieldName = '_runtimefield-saved-search'; await createRuntimeField(fieldName); await PageObjects.unifiedFieldList.clickFieldListItemAdd(fieldName); diff --git a/test/functional/apps/discover/group4/_search_on_page_load.ts b/test/functional/apps/discover/group4/_search_on_page_load.ts index 5d08d8d5cbe9b..029b2c58631db 100644 --- a/test/functional/apps/discover/group4/_search_on_page_load.ts +++ b/test/functional/apps/discover/group4/_search_on_page_load.ts @@ -141,7 +141,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(await PageObjects.unifiedFieldList.doesSidebarShowFields()).to.be(true); }); - it('should reset state after opening a saved search and pressing New', async function () { + it('should reset state after opening a discover view and pressing New', async function () { await PageObjects.discover.loadSavedSearch(savedSearchName); await PageObjects.header.waitUntilLoadingHasFinished(); diff --git a/test/functional/apps/home/_sample_data.ts b/test/functional/apps/home/_sample_data.ts index 4120a9ecc1a54..24086ce973892 100644 --- a/test/functional/apps/home/_sample_data.ts +++ b/test/functional/apps/home/_sample_data.ts @@ -104,7 +104,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await renderable.waitForRender(); log.debug('Checking charts rendered'); await elasticChart.waitForRenderComplete('xyVisChart'); - log.debug('Checking saved searches rendered'); + log.debug('Checking discover viewes rendered'); await dashboardExpect.savedSearchRowCount(10); log.debug('Checking input controls rendered'); await dashboardExpect.controlCount(3); diff --git a/test/functional/apps/management/_import_objects.ts b/test/functional/apps/management/_import_objects.ts index 1801175247474..ffa551ef9d2fa 100644 --- a/test/functional/apps/management/_import_objects.ts +++ b/test/functional/apps/management/_import_objects.ts @@ -130,7 +130,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(isSuccessful).to.be(true); }); - it('should import saved objects linked to saved searches', async function () { + it('should import saved objects linked to discover viewes', async function () { await PageObjects.savedObjects.importFile( path.join(__dirname, 'exports', '_import_objects_saved_search.ndjson') ); @@ -144,11 +144,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.savedObjects.clickImportDone(); const objects = await PageObjects.savedObjects.getRowTitles(); - const isSavedObjectImported = objects.includes('saved object connected to saved search'); + const isSavedObjectImported = objects.includes('saved object connected to discover view'); expect(isSavedObjectImported).to.be(true); }); - it('should not import saved objects linked to saved searches when saved search does not exist', async function () { + it('should not import saved objects linked to discover viewes when discover view does not exist', async function () { await PageObjects.savedObjects.importFile( path.join(__dirname, 'exports', '_import_objects_connected_to_saved_search.ndjson') ); @@ -156,11 +156,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.savedObjects.clickImportDone(); const objects = await PageObjects.savedObjects.getRowTitles(); - const isSavedObjectImported = objects.includes('saved object connected to saved search'); + const isSavedObjectImported = objects.includes('saved object connected to discover view'); expect(isSavedObjectImported).to.be(false); }); - it('should not import saved objects linked to saved searches when saved search index pattern does not exist', async function () { + it('should not import saved objects linked to discover viewes when discover view index pattern does not exist', async function () { await PageObjects.savedObjects.clickCheckboxByTitle('logstash-*'); await PageObjects.savedObjects.clickDelete(); @@ -173,7 +173,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.savedObjects.clickImportDone(); const objects = await PageObjects.savedObjects.getRowTitles(); - const isSavedObjectImported = objects.includes('saved object connected to saved search'); + const isSavedObjectImported = objects.includes('saved object connected to discover view'); expect(isSavedObjectImported).to.be(false); }); diff --git a/test/functional/apps/management/_mgmt_import_saved_objects.ts b/test/functional/apps/management/_mgmt_import_saved_objects.ts index 04a1bb5938322..777136f0595aa 100644 --- a/test/functional/apps/management/_mgmt_import_saved_objects.ts +++ b/test/functional/apps/management/_mgmt_import_saved_objects.ts @@ -15,7 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const PageObjects = getPageObjects(['common', 'settings', 'header', 'savedObjects']); // in 6.4.0 bug the Saved Search conflict would be resolved and get imported but the visualization - // that referenced the saved search was not imported.( https://github.com/elastic/kibana/issues/22238) + // that referenced the discover view was not imported.( https://github.com/elastic/kibana/issues/22238) describe('mgmt saved objects', function describeIndexTests() { before(async () => { diff --git a/test/functional/apps/management/exports/_import_objects_connected_to_saved_search.ndjson b/test/functional/apps/management/exports/_import_objects_connected_to_saved_search.ndjson index 803da8a639bc9..1aefbc10374e5 100644 --- a/test/functional/apps/management/exports/_import_objects_connected_to_saved_search.ndjson +++ b/test/functional/apps/management/exports/_import_objects_connected_to_saved_search.ndjson @@ -1 +1 @@ -{"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"filter\":[],\"query\":{\"query\":\"\",\"language\":\"lucene\"}}"},"savedSearchRefName":"search_0","title":"saved object connected to saved search","uiStateJSON":"{}","visState":"{\"title\":\"PHP Viz\",\"type\":\"horizontal_bar\",\"params\":{\"type\":\"histogram\",\"grid\":{\"categoryLines\":false,\"style\":{\"color\":\"#eee\"}},\"categoryAxes\":[{\"id\":\"CategoryAxis-1\",\"type\":\"category\",\"position\":\"left\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\"},\"labels\":{\"show\":true,\"rotate\":0,\"filter\":false,\"truncate\":200},\"title\":{}}],\"valueAxes\":[{\"id\":\"ValueAxis-1\",\"name\":\"LeftAxis-1\",\"type\":\"value\",\"position\":\"bottom\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\",\"mode\":\"normal\"},\"labels\":{\"show\":true,\"rotate\":75,\"filter\":true,\"truncate\":100},\"title\":{\"text\":\"Count\"}}],\"seriesParams\":[{\"show\":true,\"type\":\"histogram\",\"mode\":\"normal\",\"data\":{\"label\":\"Count\",\"id\":\"1\"},\"valueAxis\":\"ValueAxis-1\",\"drawLinesBetweenPoints\":true,\"showCircles\":true}],\"addTooltip\":true,\"addLegend\":true,\"legendPosition\":\"right\",\"times\":[],\"addTimeMarker\":false},\"aggs\":[{\"id\":\"1\",\"enabled\":true,\"type\":\"count\",\"schema\":\"metric\",\"params\":{}}]}"},"id":"saved_object_connected_to_saved_search","migrationVersion":{"visualization":"7.0.0"},"references":[{"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","name":"search_0","type":"search"}],"type":"visualization","version":1} +{"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"filter\":[],\"query\":{\"query\":\"\",\"language\":\"lucene\"}}"},"savedSearchRefName":"search_0","title":"saved object connected to discover view","uiStateJSON":"{}","visState":"{\"title\":\"PHP Viz\",\"type\":\"horizontal_bar\",\"params\":{\"type\":\"histogram\",\"grid\":{\"categoryLines\":false,\"style\":{\"color\":\"#eee\"}},\"categoryAxes\":[{\"id\":\"CategoryAxis-1\",\"type\":\"category\",\"position\":\"left\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\"},\"labels\":{\"show\":true,\"rotate\":0,\"filter\":false,\"truncate\":200},\"title\":{}}],\"valueAxes\":[{\"id\":\"ValueAxis-1\",\"name\":\"LeftAxis-1\",\"type\":\"value\",\"position\":\"bottom\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\",\"mode\":\"normal\"},\"labels\":{\"show\":true,\"rotate\":75,\"filter\":true,\"truncate\":100},\"title\":{\"text\":\"Count\"}}],\"seriesParams\":[{\"show\":true,\"type\":\"histogram\",\"mode\":\"normal\",\"data\":{\"label\":\"Count\",\"id\":\"1\"},\"valueAxis\":\"ValueAxis-1\",\"drawLinesBetweenPoints\":true,\"showCircles\":true}],\"addTooltip\":true,\"addLegend\":true,\"legendPosition\":\"right\",\"times\":[],\"addTimeMarker\":false},\"aggs\":[{\"id\":\"1\",\"enabled\":true,\"type\":\"count\",\"schema\":\"metric\",\"params\":{}}]}"},"id":"saved_object_connected_to_saved_search","migrationVersion":{"visualization":"7.0.0"},"references":[{"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","name":"search_0","type":"search"}],"type":"visualization","version":1} diff --git a/test/functional/apps/management/exports/_import_objects_saved_search.ndjson b/test/functional/apps/management/exports/_import_objects_saved_search.ndjson index 4e2e350ec59fe..cbf983b501940 100644 --- a/test/functional/apps/management/exports/_import_objects_saved_search.ndjson +++ b/test/functional/apps/management/exports/_import_objects_saved_search.ndjson @@ -1 +1 @@ -{"attributes":{"columns":["_source"],"description":"","hits":0,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"highlightAll\":true,\"version\":true,\"query\":{\"language\":\"lucene\",\"query\":\"php\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":["@timestamp","desc"],"title":"PHP saved search"},"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","migrationVersion":{"search":"7.0.0"},"references":[{"id":"f1e4c910-a2e6-11e7-bb30-233be9be6a15","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","version":1} +{"attributes":{"columns":["_source"],"description":"","hits":0,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"highlightAll\":true,\"version\":true,\"query\":{\"language\":\"lucene\",\"query\":\"php\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":["@timestamp","desc"],"title":"PHP discover view"},"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","migrationVersion":{"search":"7.0.0"},"references":[{"id":"f1e4c910-a2e6-11e7-bb30-233be9be6a15","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","version":1} diff --git a/test/functional/apps/management/exports/_import_objects_with_saved_search.ndjson b/test/functional/apps/management/exports/_import_objects_with_saved_search.ndjson index 0e321b168d68c..1700413e8d376 100644 --- a/test/functional/apps/management/exports/_import_objects_with_saved_search.ndjson +++ b/test/functional/apps/management/exports/_import_objects_with_saved_search.ndjson @@ -1,2 +1,2 @@ -{"attributes":{"columns":["_source"],"description":"","hits":0,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"highlightAll\":true,\"version\":true,\"query\":{\"language\":\"lucene\",\"query\":\"php\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":["@timestamp","desc"],"title":"PHP saved search"},"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","migrationVersion":{"search":"7.0.0"},"references":[{"id":"f1e4c910-a2e6-11e7-bb30-233be9be6a15","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","version":1} -{"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"filter\":[],\"query\":{\"query\":\"\",\"language\":\"lucene\"}}"},"savedSearchRefName":"search_0","title":"saved object connected to saved search","uiStateJSON":"{}","visState":"{\"title\":\"PHP Viz\",\"type\":\"horizontal_bar\",\"params\":{\"type\":\"histogram\",\"grid\":{\"categoryLines\":false,\"style\":{\"color\":\"#eee\"}},\"categoryAxes\":[{\"id\":\"CategoryAxis-1\",\"type\":\"category\",\"position\":\"left\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\"},\"labels\":{\"show\":true,\"rotate\":0,\"filter\":false,\"truncate\":200},\"title\":{}}],\"valueAxes\":[{\"id\":\"ValueAxis-1\",\"name\":\"LeftAxis-1\",\"type\":\"value\",\"position\":\"bottom\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\",\"mode\":\"normal\"},\"labels\":{\"show\":true,\"rotate\":75,\"filter\":true,\"truncate\":100},\"title\":{\"text\":\"Count\"}}],\"seriesParams\":[{\"show\":true,\"type\":\"histogram\",\"mode\":\"normal\",\"data\":{\"label\":\"Count\",\"id\":\"1\"},\"valueAxis\":\"ValueAxis-1\",\"drawLinesBetweenPoints\":true,\"showCircles\":true}],\"addTooltip\":true,\"addLegend\":true,\"legendPosition\":\"right\",\"times\":[],\"addTimeMarker\":false},\"aggs\":[{\"id\":\"1\",\"enabled\":true,\"type\":\"count\",\"schema\":\"metric\",\"params\":{}}]}"},"id":"saved_object_connected_to_saved_search","migrationVersion":{"visualization":"7.0.0"},"references":[{"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","name":"search_0","type":"search"}],"type":"visualization","version":1} +{"attributes":{"columns":["_source"],"description":"","hits":0,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"highlightAll\":true,\"version\":true,\"query\":{\"language\":\"lucene\",\"query\":\"php\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":["@timestamp","desc"],"title":"PHP discover view"},"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","migrationVersion":{"search":"7.0.0"},"references":[{"id":"f1e4c910-a2e6-11e7-bb30-233be9be6a15","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","version":1} +{"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"filter\":[],\"query\":{\"query\":\"\",\"language\":\"lucene\"}}"},"savedSearchRefName":"search_0","title":"saved object connected to discover view","uiStateJSON":"{}","visState":"{\"title\":\"PHP Viz\",\"type\":\"horizontal_bar\",\"params\":{\"type\":\"histogram\",\"grid\":{\"categoryLines\":false,\"style\":{\"color\":\"#eee\"}},\"categoryAxes\":[{\"id\":\"CategoryAxis-1\",\"type\":\"category\",\"position\":\"left\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\"},\"labels\":{\"show\":true,\"rotate\":0,\"filter\":false,\"truncate\":200},\"title\":{}}],\"valueAxes\":[{\"id\":\"ValueAxis-1\",\"name\":\"LeftAxis-1\",\"type\":\"value\",\"position\":\"bottom\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\",\"mode\":\"normal\"},\"labels\":{\"show\":true,\"rotate\":75,\"filter\":true,\"truncate\":100},\"title\":{\"text\":\"Count\"}}],\"seriesParams\":[{\"show\":true,\"type\":\"histogram\",\"mode\":\"normal\",\"data\":{\"label\":\"Count\",\"id\":\"1\"},\"valueAxis\":\"ValueAxis-1\",\"drawLinesBetweenPoints\":true,\"showCircles\":true}],\"addTooltip\":true,\"addLegend\":true,\"legendPosition\":\"right\",\"times\":[],\"addTimeMarker\":false},\"aggs\":[{\"id\":\"1\",\"enabled\":true,\"type\":\"count\",\"schema\":\"metric\",\"params\":{}}]}"},"id":"saved_object_connected_to_saved_search","migrationVersion":{"visualization":"7.0.0"},"references":[{"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","name":"search_0","type":"search"}],"type":"visualization","version":1} diff --git a/test/functional/apps/visualize/group3/_linked_saved_searches.ts b/test/functional/apps/visualize/group3/_linked_saved_searches.ts index f97a4c86e4560..732771eb7bb87 100644 --- a/test/functional/apps/visualize/group3/_linked_saved_searches.ts +++ b/test/functional/apps/visualize/group3/_linked_saved_searches.ts @@ -24,8 +24,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { 'visChart', ]); - describe('saved search visualizations from visualize app', function describeIndexTests() { - describe('linked saved searched', () => { + describe('discover view visualizations from visualize app', function describeIndexTests() { + describe('linked discover viewed', () => { const savedSearchName = 'vis_saved_search'; let discoverSavedSearchUrlPath: string; @@ -43,7 +43,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.common.unsetTime(); }); - it('should create a visualization from a saved search', async () => { + it('should create a visualization from a discover view', async () => { await PageObjects.visualize.navigateToNewAggBasedVisualization(); await PageObjects.visualize.clickDataTable(); await PageObjects.visualize.clickSavedSearch(savedSearchName); @@ -53,7 +53,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - it('should have a valid link to the saved search from the visualization', async () => { + it('should have a valid link to the discover view from the visualization', async () => { await testSubjects.click('showUnlinkSavedSearchPopover'); await testSubjects.click('viewSavedSearch'); await PageObjects.header.waitUntilLoadingHasFinished(); @@ -71,7 +71,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.header.waitUntilLoadingHasFinished(); }); - it('should respect the time filter when linked to a saved search', async () => { + it('should respect the time filter when linked to a discover view', async () => { await PageObjects.timePicker.setAbsoluteRange( 'Sep 19, 2015 @ 06:31:44.000', 'Sep 21, 2015 @ 10:00:00.000' @@ -82,7 +82,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - it('should allow adding filters while having a linked saved search', async () => { + it('should allow adding filters while having a linked discover view', async () => { await filterBar.addFilter({ field: 'bytes', operation: 'is between', @@ -101,11 +101,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const data = await PageObjects.visChart.getTableVisContent(); return data[0][0] === '707'; }); - // The filter on the saved search should now be in the editor + // The filter on the discover view should now be in the editor expect(await filterBar.hasFilter('extension.raw', 'jpg')).to.be(true); // Disabling this filter should now result in different values, since - // the visualization should not be linked anymore with the saved search. + // the visualization should not be linked anymore with the discover view. await filterBar.toggleFilterEnabled('extension.raw'); await PageObjects.header.waitUntilLoadingHasFinished(); await retry.waitFor('wait for count to equal 1,293', async () => { diff --git a/test/functional/fixtures/kbn_archiver/ccs/dashboard/current/kibana.json b/test/functional/fixtures/kbn_archiver/ccs/dashboard/current/kibana.json index 711f242d16ac8..ce3f4687e4f8b 100644 --- a/test/functional/fixtures/kbn_archiver/ccs/dashboard/current/kibana.json +++ b/test/functional/fixtures/kbn_archiver/ccs/dashboard/current/kibana.json @@ -913,7 +913,7 @@ "desc" ] ], - "title": "Bytes and kuery in saved search with filter", + "title": "Bytes and kuery in discover view with filter", "version": 1 }, "coreMigrationVersion": "8.0.1", @@ -2094,7 +2094,7 @@ "desc" ] ], - "title": "Rendering Test: saved search", + "title": "Rendering Test: discover view", "version": 1 }, "coreMigrationVersion": "8.0.1", @@ -2650,4 +2650,4 @@ "type": "index-pattern", "updated_at": "2018-04-16T16:57:12.263Z", "version": "WzE3NiwxXQ==" -} \ No newline at end of file +} diff --git a/test/functional/fixtures/kbn_archiver/dashboard/current/kibana.json b/test/functional/fixtures/kbn_archiver/dashboard/current/kibana.json index 500443f11900a..79a253b366df3 100644 --- a/test/functional/fixtures/kbn_archiver/dashboard/current/kibana.json +++ b/test/functional/fixtures/kbn_archiver/dashboard/current/kibana.json @@ -913,7 +913,7 @@ "desc" ] ], - "title": "Bytes and kuery in saved search with filter", + "title": "Bytes and kuery in discover view with filter", "version": 1 }, "coreMigrationVersion": "8.0.1", @@ -2094,7 +2094,7 @@ "desc" ] ], - "title": "Rendering Test: saved search", + "title": "Rendering Test: discover view", "version": 1 }, "coreMigrationVersion": "8.0.1", @@ -2728,7 +2728,7 @@ "description": "", "panelsJSON": "[{\"version\":\"8.6.0\",\"type\":\"search\",\"gridData\":{\"x\":0,\"y\":0,\"w\":24,\"h\":15,\"i\":\"3d2c7037-b0af-4b9f-810f-75de6278acf2\"},\"panelIndex\":\"3d2c7037-b0af-4b9f-810f-75de6278acf2\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_3d2c7037-b0af-4b9f-810f-75de6278acf2\"}]", "timeFrom": "2018-04-09T23:43:13.577Z", - "title": "timeslider and saved search", + "title": "timeslider and discover view", "timeTo": "2018-04-14T00:40:42.233Z", "version": 1 }, diff --git a/test/functional/fixtures/kbn_archiver/managed_content.json b/test/functional/fixtures/kbn_archiver/managed_content.json index b530dfd3f2352..a2bf37aa5a624 100644 --- a/test/functional/fixtures/kbn_archiver/managed_content.json +++ b/test/functional/fixtures/kbn_archiver/managed_content.json @@ -4,6 +4,6 @@ {"attributes":{"description":"","state":{"adHocDataViews":{},"datasourceStates":{"formBased":{"layers":{"e633b1af-3ab4-4bf5-8faa-fefde06c4a4a":{"columnOrder":["f2555a1a-6f93-43fd-bc63-acdfadd47729","d229daf9-9658-4579-99af-01d8adb2f25f"],"columns":{"d229daf9-9658-4579-99af-01d8adb2f25f":{"dataType":"number","isBucketed":false,"label":"Median of bytes","operationType":"median","params":{"emptyAsNull":true},"scale":"ratio","sourceField":"bytes"},"f2555a1a-6f93-43fd-bc63-acdfadd47729":{"dataType":"date","isBucketed":true,"label":"@timestamp","operationType":"date_histogram","params":{"dropPartials":false,"includeEmptyRows":true,"interval":"auto"},"scale":"interval","sourceField":"@timestamp"}},"incompleteColumns":{},"sampling":1}}},"indexpattern":{"layers":{}},"textBased":{"layers":{}}},"filters":[],"internalReferences":[],"query":{"language":"kuery","query":""},"visualization":{"axisTitlesVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"fittingFunction":"None","gridlinesVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"labelsOrientation":{"x":0,"yLeft":0,"yRight":0},"layers":[{"accessors":["d229daf9-9658-4579-99af-01d8adb2f25f"],"layerId":"e633b1af-3ab4-4bf5-8faa-fefde06c4a4a","layerType":"data","position":"top","seriesType":"bar_stacked","showGridlines":false,"xAccessor":"f2555a1a-6f93-43fd-bc63-acdfadd47729"}],"legend":{"isVisible":true,"position":"right"},"preferredSeriesType":"bar_stacked","tickLabelsVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"valueLabels":"hide"}},"title":"Lens vis (unmanaged)","visualizationType":"lnsXY"},"coreMigrationVersion":"8.8.0","created_at":"2024-01-18T17:42:12.920Z","id":"unmanaged-36db-4a3b-a4ba-7a64ab8f130b","managed":false,"references":[{"id":"5f863f70-4728-4e8d-b441-db08f8c33b28","name":"indexpattern-datasource-layer-e633b1af-3ab4-4bf5-8faa-fefde06c4a4a","type":"index-pattern"}],"type":"lens","typeMigrationVersion":"8.9.0","updated_at":"2024-01-18T17:42:12.920Z","version":"WzQ1LDFd"} -{"attributes":{"columns":["@tags","clientip"],"description":"","grid":{},"hideChart":false,"isTextBasedQuery":false,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"agent.raw:\\\"Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)\\\" \",\"language\":\"kuery\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":[["@timestamp","desc"]],"timeRestore":false,"title":"Saved search","usesAdHocDataView":false},"coreMigrationVersion":"8.8.0","created_at":"2024-01-22T18:11:05.016Z","id":"managed-3d62-4113-ac7c-de2e20a68fbc","managed":true,"references":[{"id":"5f863f70-4728-4e8d-b441-db08f8c33b28","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","typeMigrationVersion":"8.0.0","updated_at":"2024-01-22T18:11:05.016Z","version":"WzIzLDFd"} +{"attributes":{"columns":["@tags","clientip"],"description":"","grid":{},"hideChart":false,"isTextBasedQuery":false,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"agent.raw:\\\"Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)\\\" \",\"language\":\"kuery\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":[["@timestamp","desc"]],"timeRestore":false,"title":"Discover view","usesAdHocDataView":false},"coreMigrationVersion":"8.8.0","created_at":"2024-01-22T18:11:05.016Z","id":"managed-3d62-4113-ac7c-de2e20a68fbc","managed":true,"references":[{"id":"5f863f70-4728-4e8d-b441-db08f8c33b28","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","typeMigrationVersion":"8.0.0","updated_at":"2024-01-22T18:11:05.016Z","version":"WzIzLDFd"} -{"attributes":{"columns":["@tags","clientip"],"description":"","grid":{},"hideChart":false,"isTextBasedQuery":false,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"agent.raw:\\\"Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)\\\" \",\"language\":\"kuery\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":[["@timestamp","desc"]],"timeRestore":false,"title":"Saved search","usesAdHocDataView":false},"coreMigrationVersion":"8.8.0","created_at":"2024-01-22T18:11:05.016Z","id":"unmanaged-3d62-4113-ac7c-de2e20a68fbc","managed":false,"references":[{"id":"5f863f70-4728-4e8d-b441-db08f8c33b28","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","typeMigrationVersion":"8.0.0","updated_at":"2024-01-22T18:11:05.016Z","version":"WzIzLDFd"} +{"attributes":{"columns":["@tags","clientip"],"description":"","grid":{},"hideChart":false,"isTextBasedQuery":false,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"agent.raw:\\\"Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)\\\" \",\"language\":\"kuery\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":[["@timestamp","desc"]],"timeRestore":false,"title":"Discover view","usesAdHocDataView":false},"coreMigrationVersion":"8.8.0","created_at":"2024-01-22T18:11:05.016Z","id":"unmanaged-3d62-4113-ac7c-de2e20a68fbc","managed":false,"references":[{"id":"5f863f70-4728-4e8d-b441-db08f8c33b28","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","typeMigrationVersion":"8.0.0","updated_at":"2024-01-22T18:11:05.016Z","version":"WzIzLDFd"} diff --git a/test/functional/page_objects/discover_page.ts b/test/functional/page_objects/discover_page.ts index 658e235c77d33..cbed13163781d 100644 --- a/test/functional/page_objects/discover_page.ts +++ b/test/functional/page_objects/discover_page.ts @@ -52,7 +52,7 @@ export class DiscoverPageObject extends FtrService { await this.clickSaveSearchButton(); // preventing an occasional flakiness when the saved object wasn't set and the form can't be submitted await this.retry.waitFor( - `saved search title is set to ${searchName} and save button is clickable`, + `discover view title is set to ${searchName} and save button is clickable`, async () => { const saveButton = await this.testSubjects.find('confirmSaveSavedObjectButton'); await this.testSubjects.setValue('savedObjectTitle', searchName); @@ -77,12 +77,12 @@ export class DiscoverPageObject extends FtrService { await this.testSubjects.click('confirmSaveSavedObjectButton'); await this.header.waitUntilLoadingHasFinished(); - // LeeDr - this additional checking for the saved search name was an attempt + // LeeDr - this additional checking for the discover view name was an attempt // to cause this method to wait for the reloading of the page to complete so // that the next action wouldn't have to retry. But it doesn't really solve // that issue. But it does typically take about 3 retries to // complete with the expected searchName. - await this.retry.waitFor(`saved search was persisted with name ${searchName}`, async () => { + await this.retry.waitFor(`discover view was persisted with name ${searchName}`, async () => { return (await this.getCurrentQueryName()) === searchName; }); } @@ -126,7 +126,7 @@ export class DiscoverPageObject extends FtrService { // We need this try loop here because previous actions in Discover like // saving a search cause reloading of the page and the "Open" menu item goes stale. - await this.retry.waitFor('saved search panel is opened', async () => { + await this.retry.waitFor('discover view panel is opened', async () => { await this.clickLoadSavedSearchButton(); await this.header.waitUntilLoadingHasFinished(); isOpen = await this.testSubjects.exists('loadSearchForm'); diff --git a/test/functional/services/dashboard/add_panel.ts b/test/functional/services/dashboard/add_panel.ts index 65adf6dee5359..6ec54be8b4c23 100644 --- a/test/functional/services/dashboard/add_panel.ts +++ b/test/functional/services/dashboard/add_panel.ts @@ -195,7 +195,7 @@ export class DashboardAddPanelService extends FtrService { if (filter) { await this.filterEmbeddableNames(filter.replace('-', ' ')); } - await this.savedObjectsFinder.waitForFilter('Saved search', 'visualization'); + await this.savedObjectsFinder.waitForFilter('Discover view', 'visualization'); let morePages = true; while (morePages) { searchList.push(await this.addEveryEmbeddableOnCurrentPage()); diff --git a/test/interpreter_functional/test_suites/run_pipeline/esaggs.ts b/test/interpreter_functional/test_suites/run_pipeline/esaggs.ts index d29c63b467b64..31e3dfb5fdaf0 100644 --- a/test/interpreter_functional/test_suites/run_pipeline/esaggs.ts +++ b/test/interpreter_functional/test_suites/run_pipeline/esaggs.ts @@ -93,7 +93,7 @@ export default function ({ }); }); - describe('loads a saved search', () => { + describe('loads a discover view', () => { before(async () => { await kibanaServer.importExport.load( 'test/functional/fixtures/kbn_archiver/saved_search.json' @@ -111,7 +111,7 @@ export default function ({ aggs={aggCount id="1" enabled=true schema="metric"} `; - it('correctly applies filter from saved search', async () => { + it('correctly applies filter from discover view', async () => { const result = await expectExpression('esaggs_saved_searches', expression).getResponse(); expect(getCell(result, 0, 0)).to.be(119); }); diff --git a/x-pack/plugins/aiops/public/application/utils/search_utils.ts b/x-pack/plugins/aiops/public/application/utils/search_utils.ts index 99a9dfda4c642..c179204c2b9ae 100644 --- a/x-pack/plugins/aiops/public/application/utils/search_utils.ts +++ b/x-pack/plugins/aiops/public/application/utils/search_utils.ts @@ -5,7 +5,7 @@ * 2.0. */ -// TODO Consolidate with duplicate saved search utils file in +// TODO Consolidate with duplicate discover view utils file in // `x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts` import { cloneDeep } from 'lodash'; @@ -40,7 +40,7 @@ export function isSavedSearchSavedObject(arg: unknown): arg is SavedSearchSavedO /** * Parse the stringified searchSourceJSON - * from a saved search or saved search object + * from a discover view or discover view object */ export function getQueryFromSavedSearchObject(savedSearch: SavedSearchSavedObject | SavedSearch) { const search = isSavedSearchSavedObject(savedSearch) @@ -56,12 +56,12 @@ export function getQueryFromSavedSearchObject(savedSearch: SavedSearchSavedObjec }) : undefined; - // Remove indexRefName because saved search might no longer be relevant + // Remove indexRefName because discover view might no longer be relevant // if user modifies the query or filter - // after opening a saved search + // after opening a discover view if (parsed && Array.isArray(parsed.filter)) { parsed.filter.forEach((f) => { - // @ts-expect-error indexRefName does appear in meta for newly created saved search + // @ts-expect-error indexRefName does appear in meta for newly created discover view f.meta.indexRefName = undefined; }); } @@ -122,7 +122,7 @@ function getSavedSearchSource(savedSearch: SavedSearch) { } /** - * Extract query data from the saved search object + * Extract query data from the discover view object * with overrides from the provided query data and/or filters */ export function getEsQueryFromSavedSearch({ @@ -147,9 +147,9 @@ export function getEsQueryFromSavedSearch({ const savedSearchSource = getSavedSearchSource(savedSearch); - // If saved search has a search source with nested parent - // e.g. a search coming from Dashboard saved search embeddable - // which already combines both the saved search's original query/filters and the Dashboard's + // If discover view has a search source with nested parent + // e.g. a search coming from Dashboard discover view embeddable + // which already combines both the discover view's original query/filters and the Dashboard's // then no need to process any further if (savedSearchSource && savedSearchSource.getParent() !== undefined && userQuery) { // Flattened query from search source may contain a clause that narrows the time range @@ -171,7 +171,7 @@ export function getEsQueryFromSavedSearch({ }; } - // If no saved search available, use user's query and filters + // If no discover view available, use user's query and filters if (!savedSearch && userQuery) { if (filterManager && userFilters) filterManager.addFilters(userFilters); @@ -189,8 +189,8 @@ export function getEsQueryFromSavedSearch({ }; } - // If saved search available, merge saved search with the latest user query or filters - // which might differ from extracted saved search data + // If discover view available, merge discover view with the latest user query or filters + // which might differ from extracted discover view data if (savedSearchSource) { const globalFilters = filterManager?.getGlobalFilters(); // FIXME: Add support for AggregateQuery type #150091 diff --git a/x-pack/plugins/aiops/public/components/change_point_detection/change_point_detection_root.tsx b/x-pack/plugins/aiops/public/components/change_point_detection/change_point_detection_root.tsx index b63e17e2e0d86..4786b5ff36dc9 100644 --- a/x-pack/plugins/aiops/public/components/change_point_detection/change_point_detection_root.tsx +++ b/x-pack/plugins/aiops/public/components/change_point_detection/change_point_detection_root.tsx @@ -47,7 +47,7 @@ const localStorage = new Storage(window.localStorage); export interface ChangePointDetectionAppStateProps { /** The data view to analyze. */ dataView: DataView; - /** The saved search to analyze. */ + /** The discover view to analyze. */ savedSearch: SavedSearch | null; /** App dependencies */ appDependencies: AiopsAppDependencies; diff --git a/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_app_state.tsx b/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_app_state.tsx index 46e3de8b01b67..e1f2d7114c65c 100644 --- a/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_app_state.tsx +++ b/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_app_state.tsx @@ -32,7 +32,7 @@ const localStorage = new Storage(window.localStorage); export interface LogCategorizationAppStateProps { /** The data view to analyze. */ dataView: DataView; - /** The saved search to analyze. */ + /** The discover view to analyze. */ savedSearch: SavedSearch | null; /** App dependencies */ appDependencies: AiopsAppDependencies; diff --git a/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_page.tsx b/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_page.tsx index 792e50fd585c8..0a8d403c827b1 100644 --- a/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_page.tsx +++ b/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_page.tsx @@ -121,8 +121,8 @@ export const LogCategorizationPage: FC = ({ embeddin queryLanguage: SearchQueryLanguage; filters: Filter[]; }) => { - // When the user loads saved search and then clear or modify the query - // we should remove the saved search and replace it with the index pattern id + // When the user loads discover view and then clear or modify the query + // we should remove the discover view and replace it with the index pattern id if (selectedSavedSearch !== null) { setSelectedSavedSearch(null); } diff --git a/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_app_state.tsx b/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_app_state.tsx index daa717b4fd410..afdb2ec77245b 100644 --- a/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_app_state.tsx +++ b/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_app_state.tsx @@ -34,7 +34,7 @@ const localStorage = new Storage(window.localStorage); export interface LogRateAnalysisAppStateProps { /** The data view to analyze. */ dataView: DataView; - /** The saved search to analyze. */ + /** The discover view to analyze. */ savedSearch: SavedSearch | null; /** App dependencies */ appDependencies: AiopsAppDependencies; diff --git a/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_page.tsx b/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_page.tsx index 4931503b7366e..5f043c9260253 100644 --- a/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_page.tsx +++ b/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_page.tsx @@ -65,8 +65,8 @@ export const LogRateAnalysisPage: FC = ({ stickyHistogram }) => { queryLanguage: SearchQueryLanguage; filters: Filter[]; }) => { - // When the user loads a saved search and then clears or modifies the query - // we should remove the saved search and replace it with the index pattern id + // When the user loads a discover view and then clears or modifies the query + // we should remove the discover view and replace it with the index pattern id if (selectedSavedSearch !== null) { setSelectedSavedSearch(null); } diff --git a/x-pack/plugins/aiops/public/hooks/use_data_source.tsx b/x-pack/plugins/aiops/public/hooks/use_data_source.tsx index e0fd8a431df53..f049c046b948a 100644 --- a/x-pack/plugins/aiops/public/hooks/use_data_source.tsx +++ b/x-pack/plugins/aiops/public/hooks/use_data_source.tsx @@ -36,7 +36,7 @@ export interface DataSourceContextProviderProps { } /** - * Context provider that resolves current data view and the saved search + * Context provider that resolves current data view and the discover view * * @param children * @constructor @@ -57,7 +57,7 @@ export const DataSourceContextProvider: FC = ({ } = useAiopsAppContext(); /** - * Resolve data view or saved search if exists. + * Resolve data view or discover view if exists. */ const resolveDataSource = useCallback(async (): Promise => { const dataViewAndSavedSearch: DataViewAndSavedSearch = { @@ -104,7 +104,7 @@ export const DataSourceContextProvider: FC = ({

} diff --git a/x-pack/plugins/alerting/docs/openapi/bundled.json b/x-pack/plugins/alerting/docs/openapi/bundled.json index 6092bfc5bf60c..c66896f2f7e30 100644 --- a/x-pack/plugins/alerting/docs/openapi/bundled.json +++ b/x-pack/plugins/alerting/docs/openapi/bundled.json @@ -4209,7 +4209,7 @@ }, "create_siem_saved_query_rule_request": { "title": "Create saved query rule request", - "description": "A rule that searches the defined indices and creates an alert when a document matches the saved search.\n", + "description": "A rule that searches the defined indices and creates an alert when a document matches the discover view.\n", "type": "object", "required": [ "consumer", @@ -8339,4 +8339,4 @@ } } } -} \ No newline at end of file +} diff --git a/x-pack/plugins/alerting/docs/openapi/bundled.yaml b/x-pack/plugins/alerting/docs/openapi/bundled.yaml index f847686a2cced..1440fef917650 100644 --- a/x-pack/plugins/alerting/docs/openapi/bundled.yaml +++ b/x-pack/plugins/alerting/docs/openapi/bundled.yaml @@ -1680,7 +1680,7 @@ components: create_anomaly_detection_alert_rule_request: title: Create anomaly detection rule request description: | - A rule that checks if the anomaly detection job results contain anomalies that match the rule conditions. + A rule that checks if the anomaly detection job results contain anomalies that match the rule conditions. type: object required: - consumer @@ -1890,7 +1890,7 @@ components: create_es_query_rule_request: title: Create Elasticsearch query rule request description: | - A rule that runs a user-configured query, compares the number of matches to a configured threshold, and schedules actions to run when the threshold condition is met. + A rule that runs a user-configured query, compares the number of matches to a configured threshold, and schedules actions to run when the threshold condition is met. type: object required: - consumer @@ -1925,7 +1925,7 @@ components: create_geo_containment_rule_request: title: Create tracking containment rule request description: | - A rule that runs an Elasticsearch query over indices to determine whether any documents are currently contained within any boundaries from the specified boundary index. In the event that an entity is contained within a boundary, an alert may be generated. + A rule that runs an Elasticsearch query over indices to determine whether any documents are currently contained within any boundaries from the specified boundary index. In the event that an entity is contained within a boundary, an alert may be generated. type: object required: - consumer @@ -2858,7 +2858,7 @@ components: create_siem_saved_query_rule_request: title: Create saved query rule request description: | - A rule that searches the defined indices and creates an alert when a document matches the saved search. + A rule that searches the defined indices and creates an alert when a document matches the discover view. type: object required: - consumer @@ -4785,7 +4785,7 @@ components: scaling_factor: type: integer description: | - The scaling factor to use when encoding values. This property is applicable when `type` is `scaled_float`. Values will be multiplied by this factor at index time and rounded to the closest long value. + The scaling factor to use when encoding values. This property is applicable when `type` is `scaled_float`. Values will be multiplied by this factor at index time and rounded to the closest long value. type: type: string description: Specifies the data type for the field. diff --git a/x-pack/plugins/alerting/docs/openapi/components/schemas/create_siem_saved_query_rule_request.yaml b/x-pack/plugins/alerting/docs/openapi/components/schemas/create_siem_saved_query_rule_request.yaml index 3048c922e492a..4294570b9decb 100644 --- a/x-pack/plugins/alerting/docs/openapi/components/schemas/create_siem_saved_query_rule_request.yaml +++ b/x-pack/plugins/alerting/docs/openapi/components/schemas/create_siem_saved_query_rule_request.yaml @@ -1,6 +1,6 @@ title: Create saved query rule request -description: > - A rule that searches the defined indices and creates an alert when a document matches the saved search. +description: > + A rule that searches the defined indices and creates an alert when a document matches the discover view. type: object required: - consumer @@ -35,4 +35,3 @@ properties: $ref: 'tags.yaml' throttle: $ref: 'throttle.yaml' - \ No newline at end of file diff --git a/x-pack/plugins/canvas/i18n/functions/dict/saved_search.ts b/x-pack/plugins/canvas/i18n/functions/dict/saved_search.ts index 7cdac8909c6ec..22aafb6c8ded3 100644 --- a/x-pack/plugins/canvas/i18n/functions/dict/saved_search.ts +++ b/x-pack/plugins/canvas/i18n/functions/dict/saved_search.ts @@ -12,9 +12,9 @@ import { FunctionFactory } from '../../../types'; export const help: FunctionHelp> = { help: i18n.translate('xpack.canvas.functions.savedSearchHelpText', { - defaultMessage: `Returns an embeddable for a saved search object`, + defaultMessage: `Returns an embeddable for a discover view object`, }), args: { - id: 'The id of the saved search object', + id: 'The id of the discover view object', }, }; diff --git a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_app_state.tsx b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_app_state.tsx index 7e774336dd118..08a654c56ebb3 100644 --- a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_app_state.tsx +++ b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_app_state.tsx @@ -36,7 +36,7 @@ const localStorage = new Storage(window.localStorage); export interface DataDriftDetectionAppStateProps { /** The data view to analyze. */ dataView: DataView; - /** The saved search to analyze. */ + /** The discover view to analyze. */ savedSearch: SavedSearch | null; } @@ -57,7 +57,7 @@ export const DataDriftDetectionAppState: FC = ( savedSearch, }) => { if (!(dataView || savedSearch)) { - throw Error('No data view or saved search available.'); + throw Error('No data view or discover view available.'); } const coreStart = getCoreStart(); diff --git a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_page.tsx b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_page.tsx index 00555f856f6d6..4185d42695297 100644 --- a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_page.tsx +++ b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_page.tsx @@ -188,8 +188,8 @@ export const DataDriftPage: FC = ({ initialSettings }) => { queryLanguage: SearchQueryLanguage; filters: Filter[]; }) => { - // When the user loads a saved search and then clears or modifies the query - // we should remove the saved search and replace it with the index pattern id + // When the user loads a discover view and then clears or modifies the query + // we should remove the discover view and replace it with the index pattern id if (selectedSavedSearch !== null) { setSelectedSavedSearch(null); } diff --git a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_view.tsx b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_view.tsx index d752cb4b166f5..f6368bf4d98d0 100644 --- a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_view.tsx +++ b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_view.tsx @@ -207,8 +207,8 @@ export const IndexDataVisualizerView: FC = (dataVi queryLanguage: SearchQueryLanguage; filters: Filter[]; }) => { - // When the user loads saved search and then clears or modifies the query - // we should remove the saved search and replace it with the index pattern id + // When the user loads discover view and then clears or modifies the query + // we should remove the discover view and replace it with the index pattern id if (currentSavedSearch !== null) { setCurrentSavedSearch(null); } diff --git a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/index_data_visualizer.tsx b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/index_data_visualizer.tsx index 6b4a401b10629..e5000898c9a68 100644 --- a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/index_data_visualizer.tsx +++ b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/index_data_visualizer.tsx @@ -170,7 +170,7 @@ export const DataVisualizerStateContextProvider: FC { }); describe('getEsQueryFromSavedSearch()', () => { - it('return undefined if saved search is not provided', () => { + it('return undefined if discover view is not provided', () => { expect( getEsQueryFromSavedSearch({ dataView: mockDataView, @@ -301,7 +301,7 @@ describe('getEsQueryFromSavedSearch()', () => { }) ).toEqual(undefined); }); - it('return search data from saved search if neither query nor filter is provided ', () => { + it('return search data from discover view if neither query nor filter is provided ', () => { expect( getEsQueryFromSavedSearch({ dataView: mockDataView, @@ -349,7 +349,7 @@ describe('getEsQueryFromSavedSearch()', () => { searchString: 'responsetime > 49', }); }); - it('should override original saved search with the provided query ', () => { + it('should override original discover view with the provided query ', () => { expect( getEsQueryFromSavedSearch({ dataView: mockDataView, @@ -399,7 +399,7 @@ describe('getEsQueryFromSavedSearch()', () => { }); }); - it('should override original saved search with the provided filters ', () => { + it('should override original discover view with the provided filters ', () => { expect( getEsQueryFromSavedSearch({ dataView: mockDataView, diff --git a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts index 04bc52bf08057..fcfcbda3e7d52 100644 --- a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts +++ b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts @@ -29,7 +29,7 @@ import { isSavedSearchSavedObject, SavedSearchSavedObject } from '../../../../co /** * Parse the stringified searchSourceJSON - * from a saved search or saved search object + * from a discover view or discover view object */ export function getQueryFromSavedSearchObject(savedSearch: SavedSearchSavedObject | SavedSearch) { if (!isSavedSearchSavedObject(savedSearch)) { @@ -47,12 +47,12 @@ export function getQueryFromSavedSearchObject(savedSearch: SavedSearchSavedObjec }) : undefined; - // Remove indexRefName because saved search might no longer be relevant + // Remove indexRefName because discover view might no longer be relevant // if user modifies the query or filter - // after opening a saved search + // after opening a discover view if (parsed && Array.isArray(parsed.filter)) { parsed.filter.forEach((f) => { - // @ts-expect-error indexRefName does appear in meta for newly created saved search + // @ts-expect-error indexRefName does appear in meta for newly created discover view f.meta.indexRefName = undefined; }); } @@ -113,7 +113,7 @@ function getSavedSearchSource(savedSearch: SavedSearch) { } /** - * Extract query data from the saved search object + * Extract query data from the discover view object * with overrides from the provided query data and/or filters */ export function getEsQueryFromSavedSearch({ @@ -138,9 +138,9 @@ export function getEsQueryFromSavedSearch({ const savedSearchSource = getSavedSearchSource(savedSearch); - // If saved search has a search source with nested parent - // e.g. a search coming from Dashboard saved search embeddable - // which already combines both the saved search's original query/filters and the Dashboard's + // If discover view has a search source with nested parent + // e.g. a search coming from Dashboard discover view embeddable + // which already combines both the discover view's original query/filters and the Dashboard's // then no need to process any further if (savedSearchSource && savedSearchSource.getParent() !== undefined && userQuery) { // Flattened query from search source may contain a clause that narrows the time range @@ -162,7 +162,7 @@ export function getEsQueryFromSavedSearch({ }; } - // If no saved search available, use user's query and filters + // If no discover view available, use user's query and filters if (!savedSearch && userQuery) { if (filterManager && userFilters) filterManager.addFilters(userFilters); @@ -180,8 +180,8 @@ export function getEsQueryFromSavedSearch({ }; } - // If saved search available, merge saved search with the latest user query or filters - // which might differ from extracted saved search data + // If discover view available, merge discover view with the latest user query or filters + // which might differ from extracted discover view data if (savedSearchSource) { const globalFilters = filterManager?.getGlobalFilters(); // FIXME: Add support for AggregateQuery type #150091 diff --git a/x-pack/plugins/fleet/dev_docs/integrations_overview.md b/x-pack/plugins/fleet/dev_docs/integrations_overview.md index b6ce0f5ce9917..98e2e65ea168e 100644 --- a/x-pack/plugins/fleet/dev_docs/integrations_overview.md +++ b/x-pack/plugins/fleet/dev_docs/integrations_overview.md @@ -143,7 +143,7 @@ Contains screenshots rendered on the integrations detail page for the integratio ## `kibana` directory -Contains top level Kibana assets (dashboards, visualizations, saved searches etc) for the integration. +Contains top level Kibana assets (dashboards, visualizations, discover viewes etc) for the integration. ## Relationship diagram diff --git a/x-pack/plugins/fleet/public/applications/integrations/sections/epm/constants.tsx b/x-pack/plugins/fleet/public/applications/integrations/sections/epm/constants.tsx index eea79a8f9df6b..4e5472926f3c3 100644 --- a/x-pack/plugins/fleet/public/applications/integrations/sections/epm/constants.tsx +++ b/x-pack/plugins/fleet/public/applications/integrations/sections/epm/constants.tsx @@ -48,7 +48,7 @@ export const AssetTitleMap: Record = { defaultMessage: 'Component templates', }), search: i18n.translate('xpack.fleet.epm.assetTitles.savedSearches', { - defaultMessage: 'Saved searches', + defaultMessage: 'Discover view', }), visualization: i18n.translate('xpack.fleet.epm.assetTitles.visualizations', { defaultMessage: 'Visualizations', diff --git a/x-pack/plugins/ml/common/constants/locator.ts b/x-pack/plugins/ml/common/constants/locator.ts index 614c037c13026..b423983624354 100644 --- a/x-pack/plugins/ml/common/constants/locator.ts +++ b/x-pack/plugins/ml/common/constants/locator.ts @@ -28,7 +28,7 @@ export const ML_PAGES = { DATA_VISUALIZER: 'datavisualizer', /** * Page: Data Visualizer - * Open data visualizer by selecting a Kibana data view or saved search + * Open data visualizer by selecting a Kibana data view or discover view */ DATA_VISUALIZER_INDEX_SELECT: 'datavisualizer_index_select', /** diff --git a/x-pack/plugins/ml/public/application/contexts/ml/data_source_context.tsx b/x-pack/plugins/ml/public/application/contexts/ml/data_source_context.tsx index 72d54f328209e..7c00b845cfc63 100644 --- a/x-pack/plugins/ml/public/application/contexts/ml/data_source_context.tsx +++ b/x-pack/plugins/ml/public/application/contexts/ml/data_source_context.tsx @@ -28,7 +28,7 @@ export const DataSourceContext = React.createContext( ); /** - * Context provider that resolves current data view and the saved search from the URL state. + * Context provider that resolves current data view and the discover view from the URL state. * * @param children * @constructor @@ -60,7 +60,7 @@ export const DataSourceContextProvider: FC = ({ children }) => { ); /** - * Resolve data view or saved search if exist in the URL. + * Resolve data view or discover view if exist in the URL. */ const resolveDataSource = useCallback(async () => { if (dataViewId === '') { @@ -118,7 +118,7 @@ export const DataSourceContextProvider: FC = ({ children }) => {

} diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx index d065ef84fa970..4fc0c065c08dd 100644 --- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx +++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx @@ -605,7 +605,7 @@ export const ConfigurationStepForm: FC = ({ {savedSearchQuery !== null && ( {i18n.translate('xpack.ml.dataframe.analytics.create.savedSearchLabel', { - defaultMessage: 'Saved search', + defaultMessage: 'Discover view', })} )} diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/use_saved_search.ts b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/use_saved_search.ts index bb6867b62aac0..50c487b4ed6b9 100644 --- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/use_saved_search.ts +++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/use_saved_search.ts @@ -20,7 +20,7 @@ import { useMlKibana } from '../../../../../contexts/kibana'; import { useDataSource } from '../../../../../contexts/ml'; // `undefined` is used for a non-initialized state -// `null` is set if no saved search is used +// `null` is set if no discover view is used export type SavedSearchQuery = Record | null | undefined; export type SavedSearchQueryStr = | string diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.test.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.test.tsx index c17490f4506d9..7f8b77d84e45e 100644 --- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.test.tsx +++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.test.tsx @@ -175,7 +175,7 @@ describe('Data Frame Analytics: ', () => { }); }); - it('shows the error callout when clicking a saved search using a remote data view', async () => { + it('shows the error callout when clicking a discover view using a remote data view', async () => { // prepare render( @@ -203,13 +203,13 @@ describe('Data Frame Analytics: ', () => { ).toBeInTheDocument(); expect( screen.queryByText( - `The saved search 'the-remote-saved-search-title' uses the data view 'my_remote_cluster:index-pattern-title'.` + `The discover view 'the-remote-saved-search-title' uses the data view 'my_remote_cluster:index-pattern-title'.` ) ).toBeInTheDocument(); expect(mockNavigateToPath).toHaveBeenCalledTimes(0); }); - it('calls navigateToPath for a saved search using a plain data view ', async () => { + it('calls navigateToPath for a discover view using a plain data view ', async () => { // prepare render( diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.tsx index 9525042f6a47a..8306bd5a34d5f 100644 --- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.tsx +++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.tsx @@ -43,7 +43,7 @@ export const SourceSelection: FC = () => { savedObject?: SavedObjectCommon ) => { // Kibana data views including `:` are cross-cluster search indices - // and are not supported by Data Frame Analytics yet. For saved searches + // and are not supported by Data Frame Analytics yet. For discover viewes // and data views that use cross-cluster search we intercept // the selection before redirecting and show an error callout instead. let dataViewName = ''; @@ -58,13 +58,13 @@ export const SourceSelection: FC = () => { })(id); dataViewName = dataViewAndSavedSearch.dataView?.title ?? ''; } catch (error) { - // an unexpected error has occurred. This could be caused by a saved search for which the data view no longer exists. + // an unexpected error has occurred. This could be caused by a discover view for which the data view no longer exists. toastNotificationService.displayErrorToast( error, i18n.translate( 'xpack.ml.dataFrame.analytics.create.searchSelection.errorGettingDataViewTitle', { - defaultMessage: 'Error loading data view used by the saved search', + defaultMessage: 'Error loading data view used by the discover view', } ) ); @@ -79,7 +79,7 @@ export const SourceSelection: FC = () => { i18n.translate( 'xpack.ml.dataFrame.analytics.create.searchSelection.CcsErrorCallOutBody', { - defaultMessage: `The saved search '{savedSearchTitle}' uses the data view '{dataViewName}'.`, + defaultMessage: `The discover view '{savedSearchTitle}' uses the data view '{dataViewName}'.`, values: { savedSearchTitle: getNestedProperty(savedObject, 'attributes.title'), dataViewName, @@ -128,7 +128,7 @@ export const SourceSelection: FC = () => { noItemsMessage={i18n.translate( 'xpack.ml.dataFrame.analytics.create.searchSelection.notFoundLabel', { - defaultMessage: 'No matching indices or saved searches found.', + defaultMessage: 'No matching indices or discover viewes found.', } )} savedObjectMetaData={[ @@ -138,7 +138,7 @@ export const SourceSelection: FC = () => { name: i18n.translate( 'xpack.ml.dataFrame.analytics.create.searchSelection.savedObjectType.search', { - defaultMessage: 'Saved search', + defaultMessage: 'Discover view', } ), }, diff --git a/x-pack/plugins/ml/public/application/datavisualizer/data_drift/index_patterns_picker.tsx b/x-pack/plugins/ml/public/application/datavisualizer/data_drift/index_patterns_picker.tsx index 18f3dcea8ae70..1311283fd4b2c 100644 --- a/x-pack/plugins/ml/public/application/datavisualizer/data_drift/index_patterns_picker.tsx +++ b/x-pack/plugins/ml/public/application/datavisualizer/data_drift/index_patterns_picker.tsx @@ -43,7 +43,7 @@ export const DataDriftIndexOrSearchRedirect: FC = () => { @@ -52,7 +52,7 @@ export const DataDriftIndexOrSearchRedirect: FC = () => { onChoose={onObjectSelection} showFilter noItemsMessage={i18n.translate('xpack.ml.newJob.wizard.searchSelection.notFoundLabel', { - defaultMessage: 'No matching data views or saved searches found.', + defaultMessage: 'No matching data views or discover viewes found.', })} savedObjectMetaData={[ { @@ -61,7 +61,7 @@ export const DataDriftIndexOrSearchRedirect: FC = () => { name: i18n.translate( 'xpack.ml.newJob.wizard.searchSelection.savedObjectType.search', { - defaultMessage: 'Saved search', + defaultMessage: 'Discover view', } ), }, diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/common/json_editor_flyout/json_editor_flyout.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/common/json_editor_flyout/json_editor_flyout.tsx index 5d4cbb1d422de..bf6fe07444749 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/common/json_editor_flyout/json_editor_flyout.tsx +++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/common/json_editor_flyout/json_editor_flyout.tsx @@ -249,7 +249,7 @@ export const JsonEditorFlyout: FC = ({ isDisabled, jobEditorMode, datafee > diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx index 1e30004453616..b3f2218b5a4fe 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx +++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx @@ -154,7 +154,7 @@ export const ChangeDataViewModal: FC = ({ onClose }) => { noItemsMessage={i18n.translate( 'xpack.ml.newJob.wizard.datafeedStep.dataView.step1.noMatchingError', { - defaultMessage: 'No matching indices or saved searches found.', + defaultMessage: 'No matching indices or discover viewes found.', } )} savedObjectMetaData={[ diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/index_or_search/page.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/index_or_search/page.tsx index 0a53ac7b4a81e..bf3acacc6d8ce 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/index_or_search/page.tsx +++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/index_or_search/page.tsx @@ -41,7 +41,7 @@ export const Page: FC = ({ nextStepPath }) => { @@ -50,7 +50,7 @@ export const Page: FC = ({ nextStepPath }) => { onChoose={onObjectSelection} showFilter noItemsMessage={i18n.translate('xpack.ml.newJob.wizard.searchSelection.notFoundLabel', { - defaultMessage: 'No matching data views or saved searches found.', + defaultMessage: 'No matching data views or discover viewes found.', })} savedObjectMetaData={[ { @@ -59,7 +59,7 @@ export const Page: FC = ({ nextStepPath }) => { name: i18n.translate( 'xpack.ml.newJob.wizard.searchSelection.savedObjectType.search', { - defaultMessage: 'Saved search', + defaultMessage: 'Discover view', } ), }, diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/job_type/page.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/job_type/page.tsx index 0666681da6bbc..4c5976ac5e693 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/job_type/page.tsx +++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/job_type/page.tsx @@ -76,7 +76,7 @@ export const Page: FC = () => { const pageTitleLabel = selectedSavedSearch ? i18n.translate('xpack.ml.newJob.wizard.jobType.savedSearchPageTitleLabel', { - defaultMessage: 'saved search {savedSearchTitle}', + defaultMessage: 'discover view {savedSearchTitle}', values: { savedSearchTitle: selectedSavedSearch.title ?? '' }, }) : i18n.translate('xpack.ml.newJob.wizard.jobType.dataViewPageTitleLabel', { @@ -261,7 +261,7 @@ export const Page: FC = () => { diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/page.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/page.tsx index 3090801cf2716..824b87ef0773f 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/page.tsx +++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/page.tsx @@ -146,8 +146,8 @@ export const Page: FC = ({ existingJobsAndGroups, jobType }) => { } if (dataSourceContext.selectedSavedSearch !== null) { - // Jobs created from saved searches cannot be cloned in the wizard as the - // ML job config holds no reference to the saved search ID. + // Jobs created from discover viewes cannot be cloned in the wizard as the + // ML job config holds no reference to the discover view ID. jobCreator.createdBy = null; } diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/wizard_steps.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/wizard_steps.tsx index d05aa2f644abb..16daebf6d1f5f 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/wizard_steps.tsx +++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/wizard_steps.tsx @@ -73,7 +73,7 @@ export const WizardSteps: FC = ({ currentStep, setCurrentStep }) => { function getSummaryStepTitle() { if (dataSourceContext.selectedSavedSearch) { return i18n.translate('xpack.ml.newJob.wizard.stepComponentWrapper.summaryTitleSavedSearch', { - defaultMessage: 'New job from saved search {title}', + defaultMessage: 'New job from discover view {title}', values: { title: dataSourceContext.selectedSavedSearch.title ?? '' }, }); } else if (dataSourceContext.selectedDataView.id !== undefined) { diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/recognize/page.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/recognize/page.tsx index 1feab0193d087..9875bf9091e7e 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/recognize/page.tsx +++ b/x-pack/plugins/ml/public/application/jobs/new_job/recognize/page.tsx @@ -91,7 +91,7 @@ export const Page: FC = ({ moduleId, existingGroupIds }) => { const { selectedSavedSearch, selectedDataView: dataView, combinedQuery } = useDataSource(); const pageTitle = selectedSavedSearch ? i18n.translate('xpack.ml.newJob.recognize.savedSearchPageTitle', { - defaultMessage: 'saved search {savedSearchTitle}', + defaultMessage: 'discover view {savedSearchTitle}', values: { savedSearchTitle: selectedSavedSearch.title ?? '' }, }) : i18n.translate('xpack.ml.newJob.recognize.dataViewPageTitle', { @@ -307,7 +307,7 @@ export const Page: FC = ({ moduleId, existingGroupIds }) => { diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/utils/new_job_utils.test.ts b/x-pack/plugins/ml/public/application/jobs/new_job/utils/new_job_utils.test.ts index 73410aa70f022..efc875b3fd09b 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/utils/new_job_utils.test.ts +++ b/x-pack/plugins/ml/public/application/jobs/new_job/utils/new_job_utils.test.ts @@ -56,7 +56,7 @@ describe('createSearchItems', () => { }); }); - test('should match saved search with kuery and condition', () => { + test('should match discover view with kuery and condition', () => { const savedSearch = getSavedSearchMock({ highlightAll: true, version: true, @@ -82,7 +82,7 @@ describe('createSearchItems', () => { }); }); - test('should match saved search with kuery and not condition', () => { + test('should match discover view with kuery and not condition', () => { const savedSearch = getSavedSearchMock({ highlightAll: true, version: true, @@ -119,7 +119,7 @@ describe('createSearchItems', () => { }); }); - test('should match saved search with kuery and condition and not condition', () => { + test('should match discover view with kuery and condition and not condition', () => { const savedSearch = getSavedSearchMock({ highlightAll: true, version: true, @@ -149,7 +149,7 @@ describe('createSearchItems', () => { }); }); - test('should match saved search with kuery and filter', () => { + test('should match discover view with kuery and filter', () => { const savedSearch = getSavedSearchMock({ highlightAll: true, version: true, diff --git a/x-pack/plugins/ml/public/application/services/new_job_capabilities/load_new_job_capabilities.ts b/x-pack/plugins/ml/public/application/services/new_job_capabilities/load_new_job_capabilities.ts index 63d6150f3402f..e305aebdb8634 100644 --- a/x-pack/plugins/ml/public/application/services/new_job_capabilities/load_new_job_capabilities.ts +++ b/x-pack/plugins/ml/public/application/services/new_job_capabilities/load_new_job_capabilities.ts @@ -35,15 +35,15 @@ export function loadNewJobCapabilities( await serviceToUse.initializeFromDataVIew(dataView); resolve(serviceToUse.newJobCaps); } else if (savedSearchId !== undefined) { - // saved search is being used - // load the data view from the saved search + // discover view is being used + // load the data view from the discover view const { dataView } = await getDataViewAndSavedSearchCallback({ savedSearchService, dataViewsService, })(savedSearchId); if (dataView === null) { // eslint-disable-next-line no-console - console.error('Cannot retrieve data view from saved search'); + console.error('Cannot retrieve data view from discover view'); reject(); return; } diff --git a/x-pack/plugins/ml/public/locator/ml_locator.test.ts b/x-pack/plugins/ml/public/locator/ml_locator.test.ts index ab2d89dee2106..d0f5f37bf6f9d 100644 --- a/x-pack/plugins/ml/public/locator/ml_locator.test.ts +++ b/x-pack/plugins/ml/public/locator/ml_locator.test.ts @@ -290,7 +290,7 @@ describe('ML locator', () => { }); }); - it('should generate valid URL for the Index Data Visualizer select data view or saved search page', async () => { + it('should generate valid URL for the Index Data Visualizer select data view or discover view page', async () => { const location = await definition.getLocation({ page: ML_PAGES.DATA_VISUALIZER_INDEX_SELECT, }); diff --git a/x-pack/plugins/ml/server/models/data_recognizer/data_recognizer.ts b/x-pack/plugins/ml/server/models/data_recognizer/data_recognizer.ts index 635638d51f303..7aa118e01223d 100644 --- a/x-pack/plugins/ml/server/models/data_recognizer/data_recognizer.ts +++ b/x-pack/plugins/ml/server/models/data_recognizer/data_recognizer.ts @@ -1215,7 +1215,7 @@ export class DataRecognizer { } } - // check the kibana saved searches JSON in the module to see if they contain INDEX_PATTERN_ID + // check the kibana discover viewes JSON in the module to see if they contain INDEX_PATTERN_ID // which needs replacement private _doSavedObjectsContainIndexPatternId(moduleConfig: Module) { if (moduleConfig.kibana) { diff --git a/x-pack/plugins/observability_solution/logs_explorer/public/state_machines/log_explorer_controller/src/services/data_view_service.ts b/x-pack/plugins/observability_solution/logs_explorer/public/state_machines/log_explorer_controller/src/services/data_view_service.ts index 76ac9c0c82f23..0870057003571 100644 --- a/x-pack/plugins/observability_solution/logs_explorer/public/state_machines/log_explorer_controller/src/services/data_view_service.ts +++ b/x-pack/plugins/observability_solution/logs_explorer/public/state_machines/log_explorer_controller/src/services/data_view_service.ts @@ -20,7 +20,7 @@ export const createAndSetDataView = * We can't fully rely on the url update of the index param to create and restore the data view * due to a race condition where Discover, when initializing its internal logic, * check the value the index params before it gets updated in the line above. - * In case the index param does not exist, it then create a internal saved search and set the current data view + * In case the index param does not exist, it then create a internal discover view and set the current data view * to the existing one or the default logs-*. * We set explicitly the data view here to be used when restoring the data view on the initial load. */ diff --git a/x-pack/plugins/rollup/server/collectors/helpers.test.ts b/x-pack/plugins/rollup/server/collectors/helpers.test.ts index d1ecfe1aa5980..ba82892943d40 100644 --- a/x-pack/plugins/rollup/server/collectors/helpers.test.ts +++ b/x-pack/plugins/rollup/server/collectors/helpers.test.ts @@ -139,7 +139,7 @@ describe('rollupUsageCollectorHelpers', () => { expect(result).toStrictEqual([]); }); - it('Returns the saved search if exists', async () => { + it('Returns the discover view if exists', async () => { const result = await fetchRollupSavedSearches( mockIndex, getMockCallCluster(defaultMockRollupSavedSearchSavedObjects), diff --git a/x-pack/plugins/rollup/server/collectors/register.test.ts b/x-pack/plugins/rollup/server/collectors/register.test.ts index bcb026714dab5..7b8e3f27a8b66 100644 --- a/x-pack/plugins/rollup/server/collectors/register.test.ts +++ b/x-pack/plugins/rollup/server/collectors/register.test.ts @@ -39,7 +39,7 @@ describe('registerRollupUsageCollector', () => { total: { type: 'long', _meta: { - description: 'Counts all the rollup saved searches', + description: 'Counts all the rollup discover viewes', }, }, }, @@ -49,14 +49,14 @@ describe('registerRollupUsageCollector', () => { type: 'long', _meta: { description: - 'Counts all the visualizations that are based on rollup saved searches', + 'Counts all the visualizations that are based on rollup discover viewes', }, }, lens_total: { type: 'long', _meta: { description: - 'Counts all the lens visualizations that are based on rollup saved searches', + 'Counts all the lens visualizations that are based on rollup discover viewes', }, }, }, diff --git a/x-pack/plugins/rollup/server/collectors/register.ts b/x-pack/plugins/rollup/server/collectors/register.ts index 6c893e058f0e7..13a0d8ea53c09 100644 --- a/x-pack/plugins/rollup/server/collectors/register.ts +++ b/x-pack/plugins/rollup/server/collectors/register.ts @@ -56,7 +56,7 @@ export function registerRollupUsageCollector( total: { type: 'long', _meta: { - description: 'Counts all the rollup saved searches', + description: 'Counts all the rollup discover viewes', }, }, }, @@ -65,14 +65,14 @@ export function registerRollupUsageCollector( total: { type: 'long', _meta: { - description: 'Counts all the visualizations that are based on rollup saved searches', + description: 'Counts all the visualizations that are based on rollup discover viewes', }, }, lens_total: { type: 'long', _meta: { description: - 'Counts all the lens visualizations that are based on rollup saved searches', + 'Counts all the lens visualizations that are based on rollup discover viewes', }, }, }, diff --git a/x-pack/plugins/security_solution/common/types/timeline/store.ts b/x-pack/plugins/security_solution/common/types/timeline/store.ts index 433e3d934344f..56bf4524cdd51 100644 --- a/x-pack/plugins/security_solution/common/types/timeline/store.ts +++ b/x-pack/plugins/security_solution/common/types/timeline/store.ts @@ -59,7 +59,7 @@ export interface TimelinePersistInput { templateTimelineVersion?: number | null; title?: string; updated?: number; - /* used to saved discover Saved search Id */ + /* used to saved discover Discover view Id */ savedSearchId?: string | null; } diff --git a/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.test.tsx b/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.test.tsx index b2d1ac052a1e0..d987015fe093c 100644 --- a/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.test.tsx +++ b/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.test.tsx @@ -118,7 +118,7 @@ const customFilter = { const originalSavedSearchMock = { id: 'the-saved-search-id', - title: 'A saved search', + title: 'A discover view', breakdownField: 'customBreakDownField', searchSource: createSearchSourceMock({ index: dataViewMock, @@ -156,7 +156,7 @@ describe('useDiscoverInTimelineActions', () => { jest.clearAllMocks(); }); describe('getAppStateFromSavedSearch', () => { - it('should reach out to discover to convert app state from saved search', async () => { + it('should reach out to discover to convert app state from discover view', async () => { const { result, waitFor } = renderTestHook(); const { appState } = result.current.getAppStateFromSavedSearch(savedSearchMock); await waitFor(() => { @@ -230,7 +230,7 @@ describe('useDiscoverInTimelineActions', () => { }); }); describe('updateSavedSearch', () => { - it('should add defaults to the savedSearch before updating saved search', async () => { + it('should add defaults to the savedSearch before updating discover view', async () => { const { result } = renderTestHook(); await act(async () => { await result.current.updateSavedSearch(savedSearchMock, TimelineId.active); @@ -251,7 +251,7 @@ describe('useDiscoverInTimelineActions', () => { }) ); }); - it('should initialize saved search when it is not set on the timeline model yet', async () => { + it('should initialize discover view when it is not set on the timeline model yet', async () => { const localMockState: State = { ...mockGlobalState, timeline: { @@ -283,7 +283,7 @@ describe('useDiscoverInTimelineActions', () => { ); }); - it('should update saved search when it has changes', async () => { + it('should update discover view when it has changes', async () => { const changedSavedSearchMock = { ...savedSearchMock, title: 'changed' }; const localMockState: State = { ...mockGlobalState, @@ -317,6 +317,6 @@ describe('useDiscoverInTimelineActions', () => { ); }); - it('should raise appropriate notification in case of any error in saving discover saved search', () => {}); + it('should raise appropriate notification in case of any error in saving discover discover view', () => {}); }); }); diff --git a/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.tsx b/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.tsx index e13788b8f7f07..8ca9a5465634f 100644 --- a/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.tsx +++ b/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.tsx @@ -146,7 +146,7 @@ export const useDiscoverInTimelineActions = ( async (savedSearch: SavedSearch, savedSearchOption: SaveSavedSearchOptions) => { if (!discoverStateContainer) { // eslint-disable-next-line no-console - console.log(`Saved search is not open since state container is null`); + console.log(`Discover view is not open since state container is null`); return; } if (!savedSearch) return; @@ -182,7 +182,7 @@ export const useDiscoverInTimelineActions = ( savedSearch.timeRange ?? discoverDataService.query.timefilter.timefilter.getTime(); savedSearch.tags = ['security-solution-default']; - // If there is already a saved search, only update the local state + // If there is already a discover view, only update the local state if (savedSearchId) { savedSearch.id = savedSearchId; if (!timelineRef.current.savedSearch) { @@ -203,9 +203,9 @@ export const useDiscoverInTimelineActions = ( ); } } else { - // If no saved search exists. Create a new saved search instance and associate it with the timeline. + // If no discover view exists. Create a new discover view instance and associate it with the timeline. try { - // Make sure we're not creating a saved search while a previous creation call is in progress + // Make sure we're not creating a discover view while a previous creation call is in progress if (status !== 'idle') { return; } @@ -229,7 +229,7 @@ export const useDiscoverInTimelineActions = ( savedSearchId: response.id, }) ); - // Also save the timeline, this will only happen once, in case there is no saved search id yet + // Also save the timeline, this will only happen once, in case there is no discover view id yet dispatch(timelineActions.saveTimeline({ id: TimelineId.active, saveAsNew: false })); } } catch (err) { diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.test.tsx b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.test.tsx index 770f9281234ee..e4ee19335c3ba 100644 --- a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.test.tsx +++ b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.test.tsx @@ -29,9 +29,9 @@ describe('Discover Tab Content', () => { }); // issue for enabling below tests: https://github.com/elastic/kibana/issues/165913 - it.skip('should load saved search when a saved timeline is restored', () => {}); + it.skip('should load discover view when a saved timeline is restored', () => {}); it.skip('should reset the discover state when new timeline is created', () => {}); - it.skip('should update saved search if timeline title and description are updated', () => {}); - it.skip('should should not update saved search if the fetched saved search is same as discover updated saved search', () => {}); - it.skip('should update saved search if discover time is update', () => {}); + it.skip('should update discover view if timeline title and description are updated', () => {}); + it.skip('should should not update discover view if the fetched discover view is same as discover updated discover view', () => {}); + it.skip('should update discover view if discover time is update', () => {}); }); diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.tsx b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.tsx index 385225568ac93..68a08a817671e 100644 --- a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.tsx +++ b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.tsx @@ -124,7 +124,7 @@ export const DiscoverTabContent: FC = ({ timelineId }) useEffect(() => { if (isFetching) return; // no-op is fetch is in progress - if (isDiscoverSavedSearchLoaded) return; // no-op if saved search has been already loaded + if (isDiscoverSavedSearchLoaded) return; // no-op if discover view has been already loaded if (!savedSearchById) { // nothing to restore if savedSearchById is null if (status === 'draft') { @@ -188,7 +188,7 @@ export const DiscoverTabContent: FC = ({ timelineId }) const latestState = getCombinedDiscoverSavedSearchState(); const index = latestState?.searchSource.getField('index'); /* when a new timeline is loaded, a new discover instance is loaded which first emits - * discover's initial state which is then updated in the saved search. We want to avoid that.*/ + * discover's initial state which is then updated in the discover view. We want to avoid that.*/ if (!index) return; if (!latestState || combinedDiscoverSavedSearchStateRef.current === latestState) return; if (isEqualWith(latestState, savedSearchById, savedSearchComparator)) return; @@ -250,7 +250,7 @@ export const DiscoverTabContent: FC = ({ timelineId }) const hasESQLURlState = urlAppState?.query && 'esql' in urlAppState.query; /* - * Url state should NOT apply if there is already a saved search being loaded + * Url state should NOT apply if there is already a discover view being loaded * */ const shouldApplyESQLUrlState = !savedSearchAppState?.appState && hasESQLURlState; diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/translations.ts b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/translations.ts index e97da8b29c65e..4388accb38122 100644 --- a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/translations.ts +++ b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/translations.ts @@ -9,6 +9,6 @@ import { i18n } from '@kbn/i18n'; export const GET_TIMELINE_DISCOVER_SAVED_SEARCH_TITLE = (title: string) => i18n.translate('xpack.securitySolution.timelines.discoverInTimeline.savedSearchTitle', { - defaultMessage: 'Saved search for timeline - {title}', + defaultMessage: 'Discover view for timeline - {title}', values: { title }, }); diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/utils/index.test.ts b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/utils/index.test.ts index df4508a935317..599febf00294a 100644 --- a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/utils/index.test.ts +++ b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/utils/index.test.ts @@ -31,7 +31,7 @@ describe('savedSearchComparator', () => { managed: false, }; - it('should result true when saved search is same', () => { + it('should result true when discover view is same', () => { const result = savedSearchComparator(mockSavedSearch, { ...mockSavedSearch }); expect(result).toBe(true); }); diff --git a/x-pack/plugins/security_solution/public/timelines/containers/api.test.ts b/x-pack/plugins/security_solution/public/timelines/containers/api.test.ts index e6238d462e3c3..c7668357dc477 100644 --- a/x-pack/plugins/security_solution/public/timelines/containers/api.test.ts +++ b/x-pack/plugins/security_solution/public/timelines/containers/api.test.ts @@ -505,7 +505,7 @@ describe('copyTimeline', () => { }); }); - it('creates a new saved search when a saved search object is passed', async () => { + it('creates a new discover view when a discover view object is passed', async () => { await api.copyTimeline({ timelineId: 'test', timeline: { @@ -523,7 +523,7 @@ describe('copyTimeline', () => { }) ); - // The new saved search id is sent to the server + // The new discover view id is sent to the server expect(postMock).toHaveBeenCalledWith( TIMELINE_COPY_URL, expect.objectContaining({ @@ -544,7 +544,7 @@ describe('copyTimeline', () => { savedSearch: mockSavedSearch, }); - // The new saved search id is sent to the server + // The new discover view id is sent to the server expect(postMock).toHaveBeenCalledWith( TIMELINE_COPY_URL, expect.objectContaining({ @@ -553,7 +553,7 @@ describe('copyTimeline', () => { ); }); - it('does not save a saved search for timelines without `savedSearchId`', async () => { + it('does not save a discover view for timelines without `savedSearchId`', async () => { jest.clearAllMocks(); await api.copyTimeline({ diff --git a/x-pack/plugins/security_solution/public/timelines/containers/api.ts b/x-pack/plugins/security_solution/public/timelines/containers/api.ts index 4b1c106230fdd..956bfdc1473e3 100644 --- a/x-pack/plugins/security_solution/public/timelines/containers/api.ts +++ b/x-pack/plugins/security_solution/public/timelines/containers/api.ts @@ -152,7 +152,7 @@ const patchTimeline = async ({ }); } } catch (e) { - return Promise.reject(new Error(`Failed to copy saved search: ${timeline.savedSearchId}`)); + return Promise.reject(new Error(`Failed to copy discover view: ${timeline.savedSearchId}`)); } try { @@ -187,7 +187,7 @@ export const copyTimeline = async ({ if (timeline.savedSearchId && savedSearch) { const { savedSearch: savedSearchService } = KibanaServices.get(); const savedSearchCopy = { ...savedSearch }; - // delete the id and change the title to make sure we can copy the saved search + // delete the id and change the title to make sure we can copy the discover view delete savedSearchCopy.id; newSavedSearchId = await savedSearchService.save(savedSearchCopy, { onTitleDuplicate: () => ({}), @@ -195,7 +195,7 @@ export const copyTimeline = async ({ }); } } catch (e) { - return Promise.reject(new Error(`Failed to copy saved search: ${timeline.savedSearchId}`)); + return Promise.reject(new Error(`Failed to copy discover view: ${timeline.savedSearchId}`)); } try { diff --git a/x-pack/plugins/security_solution/public/timelines/store/model.ts b/x-pack/plugins/security_solution/public/timelines/store/model.ts index 0bd6f4806f06b..56da132a4b152 100644 --- a/x-pack/plugins/security_solution/public/timelines/store/model.ts +++ b/x-pack/plugins/security_solution/public/timelines/store/model.ts @@ -134,9 +134,9 @@ export interface TimelineModel { isSelectAllChecked: boolean; isLoading: boolean; selectAll: boolean; - /* discover saved search Id */ + /* discover discover view Id */ savedSearchId: string | null; - /* local saved search object, it's not sent to the server */ + /* local discover view object, it's not sent to the server */ savedSearch: SavedSearch | null; isDiscoverSavedSearchLoaded?: boolean; isDataProviderVisible: boolean; diff --git a/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_mode_control.tsx b/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_mode_control.tsx index 223a21f248f7d..ae81b91fae7d0 100644 --- a/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_mode_control.tsx +++ b/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_mode_control.tsx @@ -80,7 +80,7 @@ const includeRelated = { 'xpack.spaces.management.copyToSpace.copyModeControl.includeRelated.text', { defaultMessage: - 'Copy this object and its related objects. For dashboards, related visualizations, index patterns, and saved searches are also copied.', + 'Copy this object and its related objects. For dashboards, related visualizations, index patterns, and discover viewes are also copied.', } ), }; diff --git a/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json b/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json index d6840a2267d7b..2b7d9f9d82fdc 100644 --- a/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json +++ b/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @@ -12312,7 +12312,7 @@ "total": { "type": "long", "_meta": { - "description": "Counts all the rollup saved searches" + "description": "Counts all the rollup discover viewes" } } } @@ -12324,13 +12324,13 @@ "total": { "type": "long", "_meta": { - "description": "Counts all the visualizations that are based on rollup saved searches" + "description": "Counts all the visualizations that are based on rollup discover viewes" } }, "lens_total": { "type": "long", "_meta": { - "description": "Counts all the lens visualizations that are based on rollup saved searches" + "description": "Counts all the lens visualizations that are based on rollup discover viewes" } } } diff --git a/x-pack/plugins/transform/common/constants.ts b/x-pack/plugins/transform/common/constants.ts index 8ee030b2a953d..aab1b8485a25c 100644 --- a/x-pack/plugins/transform/common/constants.ts +++ b/x-pack/plugins/transform/common/constants.ts @@ -67,7 +67,7 @@ export const TRANSFORM_REACT_QUERY_KEYS = { // - dest index: monitor (applied to df-*) // - cluster: monitor, read_pipeline // -// Note that users with kibana_admin can see all Kibana data views and saved searches +// Note that users with kibana_admin can see all Kibana data views and discover viewes // in the source selection modal when creating a transform, but the wizard will trigger // error callouts when there are no sufficient privileges to read the actual source indices. diff --git a/x-pack/plugins/transform/public/app/hooks/use_search_items/use_search_items.ts b/x-pack/plugins/transform/public/app/hooks/use_search_items/use_search_items.ts index f2a59e0cb1a61..824bb31554dce 100644 --- a/x-pack/plugins/transform/public/app/hooks/use_search_items/use_search_items.ts +++ b/x-pack/plugins/transform/public/app/hooks/use_search_items/use_search_items.ts @@ -39,7 +39,7 @@ export const useSearchItems = (defaultSavedObjectId: string | undefined) => { } try { - // If data view already found, no need to get saved search + // If data view already found, no need to get discover view if (!fetchedDataView) { fetchedSavedSearch = await appDeps.savedSearch.get(id); } @@ -51,7 +51,7 @@ export const useSearchItems = (defaultSavedObjectId: string | undefined) => { if (!isDataView(fetchedDataView) && fetchedSavedSearch === undefined) { setError( i18n.translate('xpack.transform.searchItems.errorInitializationTitle', { - defaultMessage: `An error occurred initializing the Kibana data view or saved search.`, + defaultMessage: `An error occurred initializing the Kibana data view or discover view.`, }) ); return; diff --git a/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx b/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx index 246460d11d3ee..815afd5b3d9a2 100644 --- a/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx +++ b/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx @@ -364,7 +364,7 @@ export const StepDefineForm: FC = React.memo((props) => { label={ searchItems?.savedSearch?.id !== undefined ? i18n.translate('xpack.transform.stepDefineForm.savedSearchLabel', { - defaultMessage: 'Saved search', + defaultMessage: 'Discover view', }) : i18n.translate('xpack.transform.stepDefineForm.searchFilterLabel', { defaultMessage: 'Search filter', diff --git a/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_summary.tsx b/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_summary.tsx index b4c5c5fb8a7ce..d99fc37602b06 100644 --- a/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_summary.tsx +++ b/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_summary.tsx @@ -143,7 +143,7 @@ export const StepDefineSummary: FC = ({ {searchItems.savedSearch !== undefined && searchItems.savedSearch.id !== undefined && ( {searchItems.savedSearch.title} diff --git a/x-pack/plugins/transform/public/app/sections/transform_management/components/search_selection/search_selection.tsx b/x-pack/plugins/transform/public/app/sections/transform_management/components/search_selection/search_selection.tsx index 3c6fcc67f0c7e..af91a95dbb627 100644 --- a/x-pack/plugins/transform/public/app/sections/transform_management/components/search_selection/search_selection.tsx +++ b/x-pack/plugins/transform/public/app/sections/transform_management/components/search_selection/search_selection.tsx @@ -51,7 +51,7 @@ export const SearchSelection: FC = ({ noItemsMessage={i18n.translate( 'xpack.transform.newTransform.searchSelection.notFoundLabel', { - defaultMessage: 'No matching indices or saved searches found.', + defaultMessage: 'No matching indices or discover viewes found.', } )} savedObjectMetaData={[ @@ -61,7 +61,7 @@ export const SearchSelection: FC = ({ name: i18n.translate( 'xpack.transform.newTransform.searchSelection.savedObjectType.search', { - defaultMessage: 'Saved search', + defaultMessage: 'Discover view', } ), }, diff --git a/x-pack/plugins/transform/readme.md b/x-pack/plugins/transform/readme.md index e86d92340bf0c..27ea2730d1a24 100644 --- a/x-pack/plugins/transform/readme.md +++ b/x-pack/plugins/transform/readme.md @@ -118,7 +118,7 @@ With PATH_TO_CONFIG and other options as follows. Group | PATH_TO_CONFIG ----- | -------------- creation - index pattern | `test/functional/apps/transform/creation/index_pattern/config.ts` - creation - runtime mappings, saved searches | `test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts` + creation - runtime mappings, discover viewes | `test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts` edit, clone | `test/functional/apps/transform/edit_clone/config.ts` feature controls | `test/functional/apps/transform/feature_controls/config.ts` permissions | `test/functional/apps/transform/permissions/config.ts` @@ -129,7 +129,7 @@ With PATH_TO_CONFIG and other options as follows. Group | PATH_TO_CONFIG ----- | -------------- creation - index pattern | `test/functional_basic/apps/transform/creation/index_pattern/config.ts` - creation - runtime mappings, saved searches | `test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts` + creation - runtime mappings, discover viewes | `test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts` edit, clone | `test/functional_basic/apps/transform/edit_clone/config.ts` feature controls | `test/functional_basic/apps/transform/feature_controls/config.ts` permissions | `test/functional_basic/apps/transform/permissions/config.ts` diff --git a/x-pack/plugins/watcher/common/lib/serialization/serialization_helpers/build_input.js b/x-pack/plugins/watcher/common/lib/serialization/serialization_helpers/build_input.js index 5146099010ccf..eee40e8b0020b 100644 --- a/x-pack/plugins/watcher/common/lib/serialization/serialization_helpers/build_input.js +++ b/x-pack/plugins/watcher/common/lib/serialization/serialization_helpers/build_input.js @@ -35,7 +35,7 @@ function buildRange(timeWindowSize, timeWindowUnit, timeField) { watch.input.search.request.body.query */ function buildQuery(timeWindowSize, timeWindowUnit, timeField) { - //TODO: This is where a saved search would be applied + //TODO: This is where a discover view would be applied return { bool: { filter: { diff --git a/x-pack/test/functional/apps/aiops/log_rate_analysis.ts b/x-pack/test/functional/apps/aiops/log_rate_analysis.ts index 4bb1393b5c910..a6d4006f52572 100644 --- a/x-pack/test/functional/apps/aiops/log_rate_analysis.ts +++ b/x-pack/test/functional/apps/aiops/log_rate_analysis.ts @@ -27,7 +27,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { await elasticChart.setNewChartUiDebugFlag(true); await ml.testExecution.logTestStep( - `${testData.suiteTitle} loads the saved search selection page` + `${testData.suiteTitle} loads the discover view selection page` ); await aiops.logRateAnalysisPage.navigateToDataViewSelection(); diff --git a/x-pack/test/functional/apps/canvas/embeddables/saved_search.ts b/x-pack/test/functional/apps/canvas/embeddables/saved_search.ts index 59285140672c6..b9fb8aefea842 100644 --- a/x-pack/test/functional/apps/canvas/embeddables/saved_search.ts +++ b/x-pack/test/functional/apps/canvas/embeddables/saved_search.ts @@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const dashboardAddPanel = getService('dashboardAddPanel'); const dashboardPanelActions = getService('dashboardPanelActions'); - describe('saved search in canvas', function () { + describe('discover view in canvas', function () { before(async () => { await kibanaServer.savedObjects.cleanStandardList(); await kibanaServer.importExport.load( @@ -24,7 +24,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.canvas.goToListingPage(); // create new workpad await PageObjects.canvas.createNewWorkpad(); - await PageObjects.canvas.setWorkpadName('saved search tests'); + await PageObjects.canvas.setWorkpadName('discover view tests'); }); after(async () => { @@ -32,17 +32,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); describe('by-reference', () => { - it('adds existing saved search embeddable from the visualize library', async () => { + it('adds existing discover view embeddable from the visualize library', async () => { await PageObjects.canvas.clickAddFromLibrary(); await dashboardAddPanel.addSavedSearch('Rendering-Test:-saved-search'); await testSubjects.existOrFail('embeddablePanelHeading-RenderingTest:savedsearch'); }); - it('edits saved search by-reference embeddable', async () => { - await dashboardPanelActions.editPanelByTitle('Rendering Test: saved search'); - await PageObjects.discover.saveSearch('Rendering Test: saved search v2'); + it('edits discover view by-reference embeddable', async () => { + await dashboardPanelActions.editPanelByTitle('Rendering Test: discover view'); + await PageObjects.discover.saveSearch('Rendering Test: discover view v2'); await PageObjects.canvas.goToListingPage(); - await PageObjects.canvas.loadFirstWorkpad('saved search tests'); + await PageObjects.canvas.loadFirstWorkpad('discover view tests'); await testSubjects.existOrFail('embeddablePanelHeading-RenderingTest:savedsearchv2'); }); }); diff --git a/x-pack/test/functional/apps/dashboard/group2/_async_dashboard.ts b/x-pack/test/functional/apps/dashboard/group2/_async_dashboard.ts index 66b31842df00a..a6dec009b9b59 100644 --- a/x-pack/test/functional/apps/dashboard/group2/_async_dashboard.ts +++ b/x-pack/test/functional/apps/dashboard/group2/_async_dashboard.ts @@ -185,7 +185,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { log.debug('Checking charts rendered'); await elasticChart.waitForRenderComplete('xyVisChart'); - log.debug('Checking saved searches rendered'); + log.debug('Checking discover viewes rendered'); await dashboardExpect.savedSearchRowCount(10); log.debug('Checking input controls rendered'); await dashboardExpect.controlCount(3); diff --git a/x-pack/test/functional/apps/dashboard/group2/dashboard_search_by_value.ts b/x-pack/test/functional/apps/dashboard/group2/dashboard_search_by_value.ts index 92cc910313615..207c15c1b5f19 100644 --- a/x-pack/test/functional/apps/dashboard/group2/dashboard_search_by_value.ts +++ b/x-pack/test/functional/apps/dashboard/group2/dashboard_search_by_value.ts @@ -18,7 +18,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const testSubjects = getService('testSubjects'); const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'timePicker', 'discover']); - describe('saved searches by value', () => { + describe('discover viewes by value', () => { before(async () => { await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional'); await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data'); @@ -55,7 +55,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(rows.length).to.be.above(0); }; - it('should allow cloning a by ref saved search embeddable to a by value embeddable', async () => { + it('should allow cloning a by ref discover view embeddable to a by value embeddable', async () => { await addSearchEmbeddableToDashboard(); let panels = await testSubjects.findAll(`embeddablePanel`); expect(panels.length).to.be(1); @@ -84,7 +84,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { ).to.be(false); }); - it('should allow unlinking a by ref saved search embeddable from library', async () => { + it('should allow unlinking a by ref discover view embeddable from library', async () => { await addSearchEmbeddableToDashboard(); let panels = await testSubjects.findAll(`embeddablePanel`); expect(panels.length).to.be(1); diff --git a/x-pack/test/functional/apps/dashboard/group3/reporting/__snapshots__/download_csv.snap b/x-pack/test/functional/apps/dashboard/group3/reporting/__snapshots__/download_csv.snap index 126947dd748b1..ede6d7d1e3113 100644 --- a/x-pack/test/functional/apps/dashboard/group3/reporting/__snapshots__/download_csv.snap +++ b/x-pack/test/functional/apps/dashboard/group3/reporting/__snapshots__/download_csv.snap @@ -1,6 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`dashboard Reporting Download CSV Default Saved Search Data Download CSV export of a saved search panel 1`] = ` +exports[`dashboard Reporting Download CSV Default Saved Search Data Download CSV export of a discover view panel 1`] = ` "\\"order_date\\",category,currency,\\"customer_id\\",\\"order_id\\",\\"day_of_week_i\\",\\"products.created_on\\",sku \\"Jun 22, 2019 @ 00:00:00.000\\",\\"Women's Clothing, Women's Shoes\\",EUR,27,731788,6,\\"Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000\\",\\"ZO0486004860, ZO0177901779, ZO0680506805, ZO0340503405\\" \\"Jun 22, 2019 @ 00:00:00.000\\",\\"Women's Accessories, Women's Shoes\\",EUR,17,730663,6,\\"Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000\\",\\"ZO0697406974, ZO0370303703, ZO0368103681, ZO0013800138\\" @@ -460,7 +460,7 @@ exports[`dashboard Reporting Download CSV Default Saved Search Data Download CSV " `; -exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a filtered CSV export of a saved search panel 1`] = ` +exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a filtered CSV export of a discover view panel 1`] = ` "\\"order_date\\",category,currency,\\"customer_id\\",\\"order_id\\",\\"day_of_week_i\\",\\"products.created_on\\",sku \\"Jun 22, 2019 @ 00:00:00.000\\",\\"Men's Clothing, Men's Shoes\\",EUR,13,715752,6,\\"Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000\\",\\"ZO0130801308, ZO0402604026, ZO0630506305, ZO0297402974\\" \\"Jun 22, 2019 @ 00:00:00.000\\",\\"Men's Shoes, Men's Clothing\\",EUR,50,565284,6,\\"Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000\\",\\"ZO0687206872, ZO0422304223\\" @@ -562,7 +562,7 @@ exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a " `; -exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a saved search panel with a custom time range that does not intersect with dashboard time range 1`] = ` +exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a discover view panel with a custom time range that does not intersect with dashboard time range 1`] = ` "\\"order_date\\",category,currency,\\"customer_id\\",\\"order_id\\",\\"day_of_week_i\\",\\"products.created_on\\",sku \\"Jun 15, 2019 @ 00:00:00.000\\",\\"Women's Clothing, Women's Shoes\\",EUR,27,732985,6,\\"Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000\\",\\"ZO0048100481, ZO0133401334, ZO0153201532, ZO0381603816\\" \\"Jun 15, 2019 @ 00:00:00.000\\",\\"Women's Accessories, Women's Clothing, Women's Shoes\\",EUR,5,731613,6,\\"Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000\\",\\"ZO0203502035, ZO0706807068, ZO0072000720, ZO0011200112\\" @@ -707,13 +707,13 @@ exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a " `; -exports[`dashboard Reporting Download CSV Field Formatters and Scripted Fields Download CSV export of a saved search panel 1`] = ` +exports[`dashboard Reporting Download CSV Field Formatters and Scripted Fields Download CSV export of a discover view panel 1`] = ` "date,\\"_id\\",name,gender,value,year,\\"years_ago\\",\\"date_informal\\" \\"Jan 1, 1982 @ 00:00:00.000\\",\\"1982-Fethany-F\\",Fethany,F,780,1982,\\"37.00000000000000000000\\",\\"Jan 1st 82\\" " `; -exports[`dashboard Reporting Download CSV Filtered Saved Search Downloads filtered Discover saved search report 1`] = ` +exports[`dashboard Reporting Download CSV Filtered Saved Search Downloads filtered Discover discover view report 1`] = ` "\\"order_date\\",category,\\"order_id\\",\\"customer_full_name\\",\\"taxful_total_price\\",currency \\"Jun 25, 2019 @ 00:00:00.000\\",\\"Women's Clothing\\",569144,\\"Betty Perkins\\",\\"61.969\\",EUR \\"Jun 25, 2019 @ 00:00:00.000\\",\\"Women's Clothing, Women's Shoes\\",568503,\\"Betty Bryant\\",68,EUR diff --git a/x-pack/test/functional/apps/dashboard/group3/reporting/download_csv.ts b/x-pack/test/functional/apps/dashboard/group3/reporting/download_csv.ts index c23f991f69f07..59e8a17e7e8bf 100644 --- a/x-pack/test/functional/apps/dashboard/group3/reporting/download_csv.ts +++ b/x-pack/test/functional/apps/dashboard/group3/reporting/download_csv.ts @@ -91,7 +91,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await reporting.teardownEcommerce(); }); - it('Download CSV export of a saved search panel', async function () { + it('Download CSV export of a discover view panel', async function () { await PageObjects.dashboard.loadSavedDashboard('Ecom Dashboard - 3 Day Period'); await clickActionsMenu('EcommerceData'); await clickDownloadCsv(); @@ -100,7 +100,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expectSnapshot(csvFile).toMatch(); }); - it('Downloads a filtered CSV export of a saved search panel', async function () { + it('Downloads a filtered CSV export of a discover view panel', async function () { await PageObjects.dashboard.loadSavedDashboard('Ecom Dashboard - 3 Day Period'); // add a filter @@ -113,7 +113,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expectSnapshot(csvFile).toMatch(); }); - it('Downloads a saved search panel with a custom time range that does not intersect with dashboard time range', async function () { + it('Downloads a discover view panel with a custom time range that does not intersect with dashboard time range', async function () { await PageObjects.dashboard.loadSavedDashboard( 'Ecom Dashboard - 3 Day Period - custom time range' ); @@ -163,7 +163,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.common.unsetTime(); }); - it('Downloads filtered Discover saved search report', async () => { + it('Downloads filtered Discover discover view report', async () => { await clickActionsMenu(TEST_SEARCH_TITLE.replace(/ /g, '')); await clickDownloadCsv(); @@ -196,7 +196,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await esArchiver.unload('x-pack/test/functional/es_archives/reporting/hugedata'); }); - it('Download CSV export of a saved search panel', async () => { + it('Download CSV export of a discover view panel', async () => { await clickActionsMenu('namessearch'); await clickDownloadCsv(); diff --git a/x-pack/test/functional/apps/dashboard/group3/reporting/screenshots.ts b/x-pack/test/functional/apps/dashboard/group3/reporting/screenshots.ts index 6ecaa84c96974..00770d5110d83 100644 --- a/x-pack/test/functional/apps/dashboard/group3/reporting/screenshots.ts +++ b/x-pack/test/functional/apps/dashboard/group3/reporting/screenshots.ts @@ -155,7 +155,7 @@ export default function ({ await unloadEcommerce(); }); - it('downloads a PDF file with saved search given EuiDataGrid enabled', async function () { + it('downloads a PDF file with discover view given EuiDataGrid enabled', async function () { await kibanaServer.uiSettings.update({ 'doc_table:legacy': false }); this.timeout(300000); await PageObjects.dashboard.navigateToApp(); diff --git a/x-pack/test/functional/apps/discover/saved_search_embeddable.ts b/x-pack/test/functional/apps/discover/saved_search_embeddable.ts index fd546315a1fd9..303959c12f39b 100644 --- a/x-pack/test/functional/apps/discover/saved_search_embeddable.ts +++ b/x-pack/test/functional/apps/discover/saved_search_embeddable.ts @@ -19,7 +19,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const testSubjects = getService('testSubjects'); const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'timePicker', 'discover']); - describe('discover saved search embeddable', () => { + describe('discover discover view embeddable', () => { before(async () => { await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional'); await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data'); @@ -64,7 +64,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { } }; - it('should allow removing the dashboard panel after the underlying saved search has been deleted', async () => { + it('should allow removing the dashboard panel after the underlying discover view has been deleted', async () => { const searchTitle = 'TempSearch'; const searchId = '90943e30-9a47-11e8-b64d-95841ca0b247'; await kibanaServer.savedObjects.create({ @@ -90,7 +90,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { ], }); await addSearchEmbeddableToDashboard(searchTitle); - await PageObjects.dashboard.saveDashboard('Dashboard with deleted saved search', { + await PageObjects.dashboard.saveDashboard('Dashboard with deleted discover view', { waitDialogIsClosed: true, exitFromEditMode: false, }); diff --git a/x-pack/test/functional/apps/discover/saved_searches.ts b/x-pack/test/functional/apps/discover/saved_searches.ts index 8f5fe5dc9bc11..582e51b115c92 100644 --- a/x-pack/test/functional/apps/discover/saved_searches.ts +++ b/x-pack/test/functional/apps/discover/saved_searches.ts @@ -46,7 +46,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); describe('Customize time range', () => { - it('should be possible to customize time range for saved searches on dashboards', async () => { + it('should be possible to customize time range for discover viewes on dashboards', async () => { await PageObjects.dashboard.navigateToApp(); await PageObjects.dashboard.clickNewDashboard(); await dashboardAddPanel.clickOpenAddPanel(); @@ -64,7 +64,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - it(`should unselect saved search when navigating to a 'new'`, async function () { + it(`should unselect discover view when navigating to a 'new'`, async function () { await PageObjects.common.navigateToApp('discover'); await PageObjects.discover.selectIndexPattern('ecommerce'); await filterBar.addFilter({ field: 'category', operation: 'is', value: `Men's Shoes` }); diff --git a/x-pack/test/functional/apps/ml/anomaly_detection_jobs/saved_search_job.ts b/x-pack/test/functional/apps/ml/anomaly_detection_jobs/saved_search_job.ts index b8493e2daa1b6..39aa00d2b5917 100644 --- a/x-pack/test/functional/apps/ml/anomaly_detection_jobs/saved_search_job.ts +++ b/x-pack/test/functional/apps/ml/anomaly_detection_jobs/saved_search_job.ts @@ -16,7 +16,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with filter', jobSource: 'ft_farequote_filter', jobId: `fq_saved_search_1_${Date.now()}`, - jobDescription: 'Create multi metric job based on a saved search with filter', + jobDescription: 'Create multi metric job based on a discover view with filter', jobGroups: ['automated', 'farequote', 'multi-metric', 'saved-search'], aggAndFieldIdentifiers: ['Mean(responsetime)'], splitField: 'airline', @@ -66,7 +66,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with lucene query', jobSource: 'ft_farequote_lucene', jobId: `fq_saved_search_2_${Date.now()}`, - jobDescription: 'Create multi metric job based on a saved search with lucene query', + jobDescription: 'Create multi metric job based on a discover view with lucene query', jobGroups: ['automated', 'farequote', 'multi-metric', 'saved-search'], aggAndFieldIdentifiers: ['Mean(responsetime)'], splitField: 'airline', @@ -116,7 +116,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with kuery query', jobSource: 'ft_farequote_kuery', jobId: `fq_saved_search_3_${Date.now()}`, - jobDescription: 'Create multi metric job based on a saved search with kuery query', + jobDescription: 'Create multi metric job based on a discover view with kuery query', jobGroups: ['automated', 'farequote', 'multi-metric', 'saved-search'], aggAndFieldIdentifiers: ['Mean(responsetime)'], splitField: 'airline', @@ -167,7 +167,7 @@ export default function ({ getService }: FtrProviderContext) { jobSource: 'ft_farequote_filter_and_lucene', jobId: `fq_saved_search_4_${Date.now()}`, jobDescription: - 'Create multi metric job based on a saved search with filter and lucene query', + 'Create multi metric job based on a discover view with filter and lucene query', jobGroups: ['automated', 'farequote', 'multi-metric', 'saved-search'], aggAndFieldIdentifiers: ['Mean(responsetime)'], splitField: 'airline', @@ -217,7 +217,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with filter and kuery query', jobSource: 'ft_farequote_filter_and_kuery', jobId: `fq_saved_search_5_${Date.now()}`, - jobDescription: 'Create multi metric job based on a saved search with filter and kuery query', + jobDescription: 'Create multi metric job based on a discover view with filter and kuery query', jobGroups: ['automated', 'farequote', 'multi-metric', 'saved-search'], aggAndFieldIdentifiers: ['Mean(responsetime)'], splitField: 'airline', @@ -265,7 +265,7 @@ export default function ({ getService }: FtrProviderContext) { }, ]; - describe('saved search', function () { + describe('discover view', function () { this.tags(['ml']); before(async () => { await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/farequote'); diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts index 307678384d470..8d8c10669bb78 100644 --- a/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts +++ b/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts @@ -15,13 +15,13 @@ export default function ({ getService }: FtrProviderContext) { const editedDescription = 'Edited description'; // FLAKY: https://github.com/elastic/kibana/issues/147020 - describe.skip('classification saved search creation', function () { + describe.skip('classification discover view creation', function () { before(async () => { await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/farequote_small'); await ml.testResources.createDataViewIfNeeded('ft_farequote_small', '@timestamp'); await ml.testResources.createSavedSearchFarequoteLuceneIfNeeded('ft_farequote_small'); await ml.testResources.createSavedSearchFarequoteKueryIfNeeded('ft_farequote_small'); - // Need to use the saved searches with filters that match multiple airlines + // Need to use the discover viewes with filters that match multiple airlines await ml.testResources.createSavedSearchFarequoteFilterTwoAndLuceneIfNeeded( 'ft_farequote_small' ); @@ -78,7 +78,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with lucene query', jobType: 'classification', jobId: `fq_saved_search_2_${dateNow}`, - jobDescription: 'Classification job based on a saved search with lucene query', + jobDescription: 'Classification job based on a discover view with lucene query', source: 'ft_farequote_lucene', get destinationIndex(): string { return `user-${this.jobId}`; @@ -178,7 +178,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with kuery query', jobType: 'classification', jobId: `fq_saved_search_3_${dateNow}`, - jobDescription: 'Classification job based on a saved search with kuery query', + jobDescription: 'Classification job based on a discover view with kuery query', source: 'ft_farequote_kuery', get destinationIndex(): string { return `user-${this.jobId}`; @@ -278,7 +278,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with filter and lucene query', jobType: 'classification', jobId: `fq_saved_search_4_${dateNow}`, - jobDescription: 'Classification job based on a saved search with filter and lucene query', + jobDescription: 'Classification job based on a discover view with filter and lucene query', source: 'ft_farequote_filter_two_and_lucene', get destinationIndex(): string { return `user-${this.jobId}`; @@ -371,7 +371,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with filter and kuery query', jobType: 'classification', jobId: `fq_saved_search_5_${dateNow}`, - jobDescription: 'Classification job based on a saved search with filter and kuery query', + jobDescription: 'Classification job based on a discover view with filter and kuery query', source: 'ft_farequote_filter_two_and_kuery', get destinationIndex(): string { return `user-${this.jobId}`; diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation_saved_search.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation_saved_search.ts index 93478ebbb766e..06bf2168bacae 100644 --- a/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation_saved_search.ts +++ b/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation_saved_search.ts @@ -13,7 +13,7 @@ export default function ({ getService }: FtrProviderContext) { const ml = getService('ml'); const editedDescription = 'Edited description'; - describe('outlier detection saved search creation', function () { + describe('outlier detection discover view creation', function () { before(async () => { await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/farequote_small'); await ml.testResources.createDataViewIfNeeded('ft_farequote_small', '@timestamp'); @@ -51,7 +51,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with lucene query', jobType: 'outlier_detection', jobId: `fq_saved_search_2_${dateNow}`, - jobDescription: 'Outlier detection job based on a saved search with lucene query', + jobDescription: 'Outlier detection job based on a discover view with lucene query', source: 'ft_farequote_lucene', get destinationIndex(): string { return `user-${this.jobId}`; @@ -128,7 +128,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with kuery query', jobType: 'outlier_detection', jobId: `fq_saved_search_3_${dateNow}`, - jobDescription: 'Outlier detection job based on a saved search with kuery query', + jobDescription: 'Outlier detection job based on a discover view with kuery query', source: 'ft_farequote_kuery', get destinationIndex(): string { return `user-${this.jobId}`; @@ -205,7 +205,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with filter and kuery query', jobType: 'outlier_detection', jobId: `fq_saved_search_4_${dateNow}`, - jobDescription: 'Outlier detection job based on a saved search with filter and kuery query', + jobDescription: 'Outlier detection job based on a discover view with filter and kuery query', source: 'ft_farequote_filter_and_kuery', get destinationIndex(): string { return `user-${this.jobId}`; @@ -283,7 +283,7 @@ export default function ({ getService }: FtrProviderContext) { jobType: 'outlier_detection', jobId: `fq_saved_search_5_${dateNow}`, jobDescription: - 'Outlier detection job based on a saved search with filter and lucene query', + 'Outlier detection job based on a discover view with filter and lucene query', source: 'ft_farequote_filter_and_lucene', get destinationIndex(): string { return `user-${this.jobId}`; diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation_saved_search.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation_saved_search.ts index fb5702e98ac1d..f1ff31392f647 100644 --- a/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation_saved_search.ts +++ b/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation_saved_search.ts @@ -13,7 +13,7 @@ export default function ({ getService }: FtrProviderContext) { const ml = getService('ml'); const editedDescription = 'Edited description'; - describe('regression saved search creation', function () { + describe('regression discover view creation', function () { before(async () => { await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/farequote_small'); await ml.testResources.createDataViewIfNeeded('ft_farequote_small', '@timestamp'); @@ -59,7 +59,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with lucene query', jobType: 'regression', jobId: `fq_saved_search_2_${dateNow}`, - jobDescription: 'Regression job based on a saved search with lucene query', + jobDescription: 'Regression job based on a discover view with lucene query', source: 'ft_farequote_lucene', get destinationIndex(): string { return `user-${this.jobId}`; @@ -147,7 +147,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with kuery query', jobType: 'regression', jobId: `fq_saved_search_3_${dateNow}`, - jobDescription: 'Regression job based on a saved search with kuery query', + jobDescription: 'Regression job based on a discover view with kuery query', source: 'ft_farequote_kuery', get destinationIndex(): string { return `user-${this.jobId}`; @@ -235,7 +235,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with filter and kuery query', jobType: 'regression', jobId: `fq_saved_search_4_${dateNow}`, - jobDescription: 'Regression job based on a saved search with filter and kuery query', + jobDescription: 'Regression job based on a discover view with filter and kuery query', source: 'ft_farequote_filter_and_kuery', get destinationIndex(): string { return `user-${this.jobId}`; @@ -317,7 +317,7 @@ export default function ({ getService }: FtrProviderContext) { suiteTitle: 'with filter and lucene query', jobType: 'regression', jobId: `fq_saved_search_5_${dateNow}`, - jobDescription: 'Regression job based on a saved search with filter and lucene query', + jobDescription: 'Regression job based on a discover view with filter and lucene query', source: 'ft_farequote_filter_and_lucene', get destinationIndex(): string { return `user-${this.jobId}`; diff --git a/x-pack/test/functional/apps/ml/data_visualizer/data_drift.ts b/x-pack/test/functional/apps/ml/data_visualizer/data_drift.ts index a3ef0eddef6c4..22d1a6a48effc 100644 --- a/x-pack/test/functional/apps/ml/data_visualizer/data_drift.ts +++ b/x-pack/test/functional/apps/ml/data_visualizer/data_drift.ts @@ -8,7 +8,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context'; export const farequoteKQLFiltersSearchTestData = { - suiteTitle: 'KQL saved search and filters', + suiteTitle: 'KQL discover view and filters', isSavedSearch: true, dateTimeField: '@timestamp', sourceIndexOrSavedSearch: 'ft_farequote_filter_and_kuery', @@ -121,7 +121,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it(`${farequoteKQLFiltersSearchTestData.suiteTitle} loads the source data in data drift`, async () => { await ml.testExecution.logTestStep( - `${farequoteKQLFiltersSearchTestData.suiteTitle} loads the data drift index or saved search select page` + `${farequoteKQLFiltersSearchTestData.suiteTitle} loads the data drift index or discover view select page` ); await ml.navigation.navigateToDataDrift(); @@ -154,7 +154,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await ml.navigation.navigateToMl(); await elasticChart.setNewChartUiDebugFlag(true); await ml.testExecution.logTestStep( - `${dataViewCreationTestData.suiteTitle} loads the saved search selection page` + `${dataViewCreationTestData.suiteTitle} loads the discover view selection page` ); await ml.navigation.navigateToDataDrift(); }); diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer.ts index f0185fc371006..19ac96cb58821 100644 --- a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer.ts +++ b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer.ts @@ -24,7 +24,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) { function runTests(testData: TestData) { it(`${testData.suiteTitle} loads the source data in the data visualizer`, async () => { await ml.testExecution.logTestStep( - `${testData.suiteTitle} loads the saved search selection page` + `${testData.suiteTitle} loads the discover view selection page` ); await ml.dataVisualizer.navigateToDataViewSelection(); @@ -173,7 +173,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) { runTests(farequoteDataViewTestData); - // Run tests on farequote KQL saved search. + // Run tests on farequote KQL discover view. it(`${farequoteKQLSearchTestData.suiteTitle} loads the data visualizer selector page`, async () => { // Only navigate back to the data visualizer selector page before running next tests, // to ensure the time picker isn't set back to the default (last 15 minutes). @@ -182,7 +182,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) { runTests(farequoteKQLSearchTestData); - // Run tests on farequote lucene saved search. + // Run tests on farequote lucene discover view. it(`${farequoteLuceneSearchTestData.suiteTitle} loads the data visualizer selector page`, async () => { // Only navigate back to the data visualizer selector page before running next tests, // to ensure the time picker isn't set back to the default (last 15 minutes). @@ -221,7 +221,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) { it(`${testData.suiteTitle} loads lens charts`, async () => { await ml.testExecution.logTestStep( - `${testData.suiteTitle} loads the saved search selection page` + `${testData.suiteTitle} loads the discover view selection page` ); await ml.dataVisualizer.navigateToDataViewSelection(); diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_actions_panel.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_actions_panel.ts index 6f259a8120d28..030f7101480e3 100644 --- a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_actions_panel.ts +++ b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_actions_panel.ts @@ -51,7 +51,7 @@ export default function ({ getService }: FtrProviderContext) { await ml.navigation.navigateToMl(); await ml.navigation.navigateToDataVisualizer(); - await ml.testExecution.logTestStep('loads the saved search selection page'); + await ml.testExecution.logTestStep('loads the discover view selection page'); await ml.dataVisualizer.navigateToDataViewSelection(); await ml.testExecution.logTestStep('loads the index data visualizer page'); @@ -83,7 +83,7 @@ export default function ({ getService }: FtrProviderContext) { await ml.navigation.navigateToMl(); await ml.navigation.navigateToDataVisualizer(); - await ml.testExecution.logTestStep('loads the saved search selection page'); + await ml.testExecution.logTestStep('loads the discover view selection page'); await ml.dataVisualizer.navigateToDataViewSelection(); await ml.testExecution.logTestStep('loads the index data visualizer page'); diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_data_view_management.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_data_view_management.ts index 28611dbcb8a1b..f276da6958437 100644 --- a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_data_view_management.ts +++ b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_data_view_management.ts @@ -116,7 +116,7 @@ export default function ({ getService }: FtrProviderContext) { await ml.navigation.navigateToDataVisualizer(); await ml.testExecution.logTestStep( - `${testData.suiteTitle} loads the saved search selection page` + `${testData.suiteTitle} loads the discover view selection page` ); await ml.dataVisualizer.navigateToDataViewSelection(); diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_filters.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_filters.ts index 4be111e00bc85..7bf05a21be754 100644 --- a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_filters.ts +++ b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_filters.ts @@ -52,7 +52,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await ml.navigation.navigateToDataVisualizer(); await ml.testExecution.logTestStep( - `${testData.suiteTitle} loads the saved search selection page` + `${testData.suiteTitle} loads the discover view selection page` ); await ml.dataVisualizer.navigateToDataViewSelection(); @@ -89,7 +89,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await ml.navigation.navigateToDataVisualizer(); await ml.testExecution.logTestStep( - `${testData.suiteTitle} loads the saved search selection page` + `${testData.suiteTitle} loads the discover view selection page` ); await ml.dataVisualizer.navigateToDataViewSelection(); diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_random_sampler.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_random_sampler.ts index e5fee365ff08e..3ba8ef6fe4e15 100644 --- a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_random_sampler.ts +++ b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_random_sampler.ts @@ -16,7 +16,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) { await ml.testExecution.logTestStep(`navigates to Data Visualizer page`); await ml.navigation.navigateToDataVisualizer(); - await ml.testExecution.logTestStep(`loads the saved search selection page`); + await ml.testExecution.logTestStep(`loads the discover view selection page`); await ml.dataVisualizer.navigateToDataViewSelection(); await ml.testExecution.logTestStep(`loads the index data visualizer page`); diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_test_data.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_test_data.ts index 40c0f83070f6e..1d9d8ddd77b25 100644 --- a/x-pack/test/functional/apps/ml/data_visualizer/index_test_data.ts +++ b/x-pack/test/functional/apps/ml/data_visualizer/index_test_data.ts @@ -106,7 +106,7 @@ export const farequoteDataViewTestData: TestData = { }; export const farequoteKQLSearchTestData: TestData = { - suiteTitle: 'KQL saved search', + suiteTitle: 'KQL discover view', isSavedSearch: true, sourceIndexOrSavedSearch: 'ft_farequote_kuery', fieldNameFilters: ['@version'], @@ -203,7 +203,7 @@ export const farequoteKQLSearchTestData: TestData = { }; export const farequoteKQLFiltersSearchTestData: TestData = { - suiteTitle: 'KQL saved search and filters', + suiteTitle: 'KQL discover view and filters', isSavedSearch: true, sourceIndexOrSavedSearch: 'ft_farequote_filter_and_kuery', fieldNameFilters: ['@version'], @@ -302,7 +302,7 @@ export const farequoteKQLFiltersSearchTestData: TestData = { }; export const farequoteLuceneSearchTestData: TestData = { - suiteTitle: 'lucene saved search', + suiteTitle: 'lucene discover view', isSavedSearch: true, sourceIndexOrSavedSearch: 'ft_farequote_lucene', fieldNameFilters: ['@version.keyword', 'type'], @@ -399,7 +399,7 @@ export const farequoteLuceneSearchTestData: TestData = { }; export const farequoteLuceneFiltersSearchTestData: TestData = { - suiteTitle: 'lucene saved search and filter', + suiteTitle: 'lucene discover view and filter', isSavedSearch: true, sourceIndexOrSavedSearch: 'ft_farequote_filter_and_lucene', fieldNameFilters: ['@version.keyword', 'type'], diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_test_data_random_sampler.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_test_data_random_sampler.ts index dfc6c80aa8b40..1865c58496964 100644 --- a/x-pack/test/functional/apps/ml/data_visualizer/index_test_data_random_sampler.ts +++ b/x-pack/test/functional/apps/ml/data_visualizer/index_test_data_random_sampler.ts @@ -106,7 +106,7 @@ export const farequoteDataViewTestData: TestData = { }; export const farequoteKQLSearchTestData: TestData = { - suiteTitle: 'KQL saved search', + suiteTitle: 'KQL discover view', isSavedSearch: true, sourceIndexOrSavedSearch: 'ft_farequote_kuery', fieldNameFilters: ['@version'], @@ -203,7 +203,7 @@ export const farequoteKQLSearchTestData: TestData = { }; export const farequoteKQLFiltersSearchTestData: TestData = { - suiteTitle: 'KQL saved search and filters', + suiteTitle: 'KQL discover view and filters', isSavedSearch: true, sourceIndexOrSavedSearch: 'ft_farequote_filter_and_kuery', fieldNameFilters: ['@version'], @@ -302,7 +302,7 @@ export const farequoteKQLFiltersSearchTestData: TestData = { }; export const farequoteLuceneSearchTestData: TestData = { - suiteTitle: 'lucene saved search', + suiteTitle: 'lucene discover view', isSavedSearch: true, sourceIndexOrSavedSearch: 'ft_farequote_lucene', fieldNameFilters: ['@version.keyword', 'type'], @@ -399,7 +399,7 @@ export const farequoteLuceneSearchTestData: TestData = { }; export const farequoteLuceneFiltersSearchTestData: TestData = { - suiteTitle: 'lucene saved search and filter', + suiteTitle: 'lucene discover view and filter', isSavedSearch: true, sourceIndexOrSavedSearch: 'ft_farequote_filter_and_lucene', fieldNameFilters: ['@version.keyword', 'type'], diff --git a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts index 0b51b78265c25..395d3c9718b03 100644 --- a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts +++ b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts @@ -15,7 +15,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) { testFiles: [require.resolve('.')], junit: { reportName: - 'Chrome X-Pack UI Functional Tests - transform - creation - runtime mappings & saved search', + 'Chrome X-Pack UI Functional Tests - transform - creation - runtime mappings & discover view', }, }; } diff --git a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/creation_saved_search.ts b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/creation_saved_search.ts index c85a1a88b429c..1fc98aab44c43 100644 --- a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/creation_saved_search.ts +++ b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/creation_saved_search.ts @@ -39,7 +39,7 @@ export default function ({ getService }: FtrProviderContext) { const testDataList: Array = [ { type: 'pivot', - suiteTitle: 'batch transform with terms groups and avg agg with saved search filter', + suiteTitle: 'batch transform with terms groups and avg agg with discover view filter', source: 'ft_farequote_filter', groupByEntries: [ { @@ -55,7 +55,7 @@ export default function ({ getService }: FtrProviderContext) { ], transformId: `fq_1_${Date.now()}`, transformDescription: - 'farequote batch transform with groups terms(airline) and aggregation avg(responsetime.avg) with saved search filter', + 'farequote batch transform with groups terms(airline) and aggregation avg(responsetime.avg) with discover view filter', get destinationIndex(): string { return `user-${this.transformId}`; }, @@ -79,7 +79,7 @@ export default function ({ getService }: FtrProviderContext) { } as PivotTransformTestData, { type: 'latest', - suiteTitle: 'batch transform with unique term and sort by time with saved search filter', + suiteTitle: 'batch transform with unique term and sort by time with discover view filter', source: 'ft_farequote_filter', uniqueKeys: [ { @@ -93,7 +93,7 @@ export default function ({ getService }: FtrProviderContext) { }, transformId: `fq_2_${Date.now()}`, transformDescription: - 'farequote batch transform with airline unique key and sort by timestamp with saved search filter', + 'farequote batch transform with airline unique key and sort by timestamp with discover view filter', get destinationIndex(): string { return `user-latest-${this.transformId}`; }, diff --git a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/index.ts b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/index.ts index 943fb97200a7b..b16f95f76f196 100644 --- a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/index.ts +++ b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/index.ts @@ -11,7 +11,7 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) { const esArchiver = getService('esArchiver'); const transform = getService('transform'); - describe('transform - creation - runtime mappings & saved search', function () { + describe('transform - creation - runtime mappings & discover view', function () { this.tags('transform'); before(async () => { diff --git a/x-pack/test/functional/fixtures/kbn_archiver/dashboard_view_mode.json b/x-pack/test/functional/fixtures/kbn_archiver/dashboard_view_mode.json index 9a5f39cdb390d..41da7467328f4 100644 --- a/x-pack/test/functional/fixtures/kbn_archiver/dashboard_view_mode.json +++ b/x-pack/test/functional/fixtures/kbn_archiver/dashboard_view_mode.json @@ -28,7 +28,7 @@ "desc" ] ], - "title": "Saved search for dashboard", + "title": "Discover view for dashboard", "version": 1 }, "coreMigrationVersion": "7.16.0", diff --git a/x-pack/test/functional/fixtures/kbn_archiver/reporting/ecommerce.json b/x-pack/test/functional/fixtures/kbn_archiver/reporting/ecommerce.json index 1d64dc744950e..ae006fd30c840 100644 --- a/x-pack/test/functional/fixtures/kbn_archiver/reporting/ecommerce.json +++ b/x-pack/test/functional/fixtures/kbn_archiver/reporting/ecommerce.json @@ -340,7 +340,7 @@ "kibanaSavedObjectMeta": { "searchSourceJSON": "{\"query\":{\"language\":\"kuery\",\"query\":\"\"},\"filter\":[]}" }, - "description": "saved search panel with custom time range that does not intersect with dashboard time range", + "description": "discover view panel with custom time range that does not intersect with dashboard time range", "refreshInterval": { "pause": true, "value": 0 diff --git a/x-pack/test/functional/fixtures/kbn_archiver/reporting/logs.json b/x-pack/test/functional/fixtures/kbn_archiver/reporting/logs.json index e7121b78f6ddd..07686bfafb27c 100644 --- a/x-pack/test/functional/fixtures/kbn_archiver/reporting/logs.json +++ b/x-pack/test/functional/fixtures/kbn_archiver/reporting/logs.json @@ -521,7 +521,7 @@ ] ], "timeRestore": false, - "title": "A saved search with match_phrase filter and no columns selected", + "title": "A discover view with match_phrase filter and no columns selected", "usesAdHocDataView": false }, "coreMigrationVersion": "8.7.0", @@ -576,7 +576,7 @@ "to": "2015-11-01T01:39:01.782Z" }, "timeRestore": true, - "title": "A saved search with the time stored and a query", + "title": "A discover view with the time stored and a query", "usesAdHocDataView": false }, "coreMigrationVersion": "8.7.0", @@ -618,7 +618,7 @@ ] ], "timeRestore": false, - "title": "A saved search with a query", + "title": "A discover view with a query", "usesAdHocDataView": false }, "coreMigrationVersion": "8.7.0", diff --git a/x-pack/test/functional/services/ml/test_resources.ts b/x-pack/test/functional/services/ml/test_resources.ts index 5035b6844b9c3..08b335dc0b39a 100644 --- a/x-pack/test/functional/services/ml/test_resources.ts +++ b/x-pack/test/functional/services/ml/test_resources.ts @@ -187,7 +187,7 @@ export function MachineLearningTestResourcesProvider( }, async createSavedSearch(title: string, body: object): Promise { - log.debug(`Creating saved search with title '${title}'`); + log.debug(`Creating discover view with title '${title}'`); const { body: createResponse, status } = await supertest .post(`/api/saved_objects/${SavedObjectType.SEARCH}`) @@ -218,7 +218,7 @@ export function MachineLearningTestResourcesProvider( const title = savedSearch.requestBody.attributes.title; const savedSearchId = await this.getSavedSearchId(title); if (savedSearchId !== undefined) { - log.debug(`Saved search with title '${title}' already exists. Nothing to create.`); + log.debug(`Discover view with title '${title}' already exists. Nothing to create.`); return savedSearchId; } else { const body = await this.updateSavedSearchRequestBody( @@ -233,7 +233,7 @@ export function MachineLearningTestResourcesProvider( const dataViewId = await this.getDataViewId(dataViewTitle); if (dataViewId === undefined) { throw new Error( - `Index pattern '${dataViewTitle}' to base saved search on does not exist. ` + `Index pattern '${dataViewTitle}' to base discover view on does not exist. ` ); } @@ -351,11 +351,11 @@ export function MachineLearningTestResourcesProvider( }, async deleteSavedSearchByTitle(title: string) { - log.debug(`Deleting saved search with title '${title}'...`); + log.debug(`Deleting discover view with title '${title}'...`); const savedSearchId = await this.getSavedSearchId(title); if (savedSearchId === undefined) { - log.debug(`Saved search with title '${title}' does not exists. Nothing to delete.`); + log.debug(`Discover view with title '${title}' does not exists. Nothing to delete.`); return; } else { await this.deleteSavedSearchById(savedSearchId); diff --git a/x-pack/test/functional_basic/apps/ml/data_visualizer/group3/index_data_visualizer_actions_panel.ts b/x-pack/test/functional_basic/apps/ml/data_visualizer/group3/index_data_visualizer_actions_panel.ts index 62cbc2e41e36a..b11f9bfd6f068 100644 --- a/x-pack/test/functional_basic/apps/ml/data_visualizer/group3/index_data_visualizer_actions_panel.ts +++ b/x-pack/test/functional_basic/apps/ml/data_visualizer/group3/index_data_visualizer_actions_panel.ts @@ -33,7 +33,7 @@ export default function ({ getService }: FtrProviderContext) { await ml.navigation.navigateToMl(); await ml.navigation.navigateToDataVisualizer(); - await ml.testExecution.logTestStep('loads the saved search selection page'); + await ml.testExecution.logTestStep('loads the discover view selection page'); await ml.dataVisualizer.navigateToDataViewSelection(); await ml.testExecution.logTestStep('loads the index data visualizer page'); diff --git a/x-pack/test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts b/x-pack/test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts index 91daf3d099007..138f68cb6e7a9 100644 --- a/x-pack/test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts +++ b/x-pack/test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts @@ -17,7 +17,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) { junit: { ...transformConfig.get('junit'), reportName: - 'Chrome X-Pack UI Functional Tests Basic License - transform - creation - runtime mappings & saved search', + 'Chrome X-Pack UI Functional Tests Basic License - transform - creation - runtime mappings & discover view', }, }; } diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/__snapshots__/csv_v2.snap b/x-pack/test/reporting_api_integration/reporting_and_security/__snapshots__/csv_v2.snap index a76973fb73f64..db20c2030743d 100644 --- a/x-pack/test/reporting_api_integration/reporting_and_security/__snapshots__/csv_v2.snap +++ b/x-pack/test/reporting_api_integration/reporting_and_security/__snapshots__/csv_v2.snap @@ -1,6 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`Reporting APIs CSV Generation from Saved Search ID export from non-timebased data view query stored in the saved search csv file matches 1`] = ` +exports[`Reporting APIs CSV Generation from Saved Search ID export from non-timebased data view query stored in the discover view csv file matches 1`] = ` "_id,_index,_score,eon,epoch,era,period tvJJX4UBvD7uFsw9L2x4,timeless-test,1,Phanerozoic, Pliocene,Cenozoic,Neogene t_JJX4UBvD7uFsw9L2x4,timeless-test,1,Phanerozoic, Holocene,Cenozoic,Quaternary @@ -11,7 +11,7 @@ u_JJX4UBvD7uFsw9L2x4,timeless-test,1,Proterozoic,-,Paleozoic,Permian " `; -exports[`Reporting APIs CSV Generation from Saved Search ID export from non-timebased data view query stored in the saved search job response data is correct 1`] = ` +exports[`Reporting APIs CSV Generation from Saved Search ID export from non-timebased data view query stored in the discover view job response data is correct 1`] = ` Object { "contentDisposition": "attachment; filename=*zoic.csv", "contentType": "text/csv; charset=utf-8", diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/csv_v2.ts b/x-pack/test/reporting_api_integration/reporting_and_security/csv_v2.ts index 5b70c5db2fd8a..35f9e678dc983 100644 --- a/x-pack/test/reporting_api_integration/reporting_and_security/csv_v2.ts +++ b/x-pack/test/reporting_api_integration/reporting_and_security/csv_v2.ts @@ -38,7 +38,7 @@ export default ({ getService }: FtrProviderContext) => { version: '8.7.0', ...params, }; - log.info(`sending request for saved search: ${job.locatorParams[0].params.savedSearchId}`); + log.info(`sending request for discover view: ${job.locatorParams[0].params.savedSearchId}`); const jobParams = rison.encode(job); return await supertest .post(`/api/reporting/generate/csv_v2`) @@ -139,7 +139,7 @@ export default ({ getService }: FtrProviderContext) => { }); }); - describe('query stored in the saved search', () => { + describe('query stored in the discover view', () => { let response: request.Response; let job: ReportApiJSON; let path: string; diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts b/x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts index 8db27a6817a80..fd96224493357 100644 --- a/x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts +++ b/x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts @@ -60,7 +60,7 @@ export default function ({ getService }: FtrProviderContext) { * NOTE: All timestamps in the documents are midnight UTC. * "00:00:00.000" means the time is formatted in UTC timezone */ - describe('CSV saved search export', () => { + describe('CSV discover view export', () => { const JOB_PARAMS_CSV_DEFAULT_SPACE = `columns:!(order_date,category,customer_full_name,taxful_total_price,currency),objectType:search,searchSource:(fields:!((field:'*',include_unmapped:true))` + `,filter:!((meta:(field:order_date,index:aac3e500-f2c7-11ea-8250-fb138aa491e7,params:()),query:(range:(order_date:(format:strict_date_optional_time,gte:'2019-06-02T12:28:40.866Z'` + diff --git a/x-pack/test/reporting_functional/services/scenarios.ts b/x-pack/test/reporting_functional/services/scenarios.ts index d1123cf2eab05..91489e0ccf584 100644 --- a/x-pack/test/reporting_functional/services/scenarios.ts +++ b/x-pack/test/reporting_functional/services/scenarios.ts @@ -63,7 +63,7 @@ export function createScenarios( }; const openSavedSearch = async (title: string) => { - log.debug(`Opening saved search: ${title}`); + log.debug(`Opening discover view: ${title}`); await PageObjects.common.navigateToApp('discover'); await PageObjects.discover.loadSavedSearch(title); }; diff --git a/x-pack/test/saved_object_tagging/functional/tests/discover_integration.ts b/x-pack/test/saved_object_tagging/functional/tests/discover_integration.ts index 8258b4570ed9b..fea72b1e9df91 100644 --- a/x-pack/test/saved_object_tagging/functional/tests/discover_integration.ts +++ b/x-pack/test/saved_object_tagging/functional/tests/discover_integration.ts @@ -108,7 +108,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { await PageObjects.header.waitUntilLoadingHasFinished(); }); - it('allows to select tags for a new saved search', async () => { + it('allows to select tags for a new discover view', async () => { await PageObjects.discover.saveSearch('My New Search', undefined, { tags: ['tag-1', 'tag-2'], }); @@ -122,7 +122,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { const searchName = 'search-with-new-tag'; // preventing an occasional flakiness when the saved object wasn't set and the form can't be submitted await retry.waitFor( - `saved search title is set to ${searchName} and save button is clickable`, + `discover view title is set to ${searchName} and save button is clickable`, async () => { const saveButton = await testSubjects.find('confirmSaveSavedObjectButton'); await testSubjects.setValue('savedObjectTitle', searchName); @@ -161,7 +161,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { await PageObjects.header.waitUntilLoadingHasFinished(); }); - it('allows to select tags for an existing saved search', async () => { + it('allows to select tags for an existing discover view', async () => { await PageObjects.discover.loadSavedSearch('A Saved Search'); await PageObjects.header.waitUntilLoadingHasFinished(); await PageObjects.discover.saveSearch('A Saved Search', undefined, { diff --git a/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/save_search_session_relative_time.ts b/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/save_search_session_relative_time.ts index ad46f0a2add88..f1028b13b1cd1 100644 --- a/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/save_search_session_relative_time.ts +++ b/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/save_search_session_relative_time.ts @@ -87,7 +87,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await dashboardExpect.noErrorEmbeddablesPresent(); log.debug('Checking charts rendered'); await elasticChart.waitForRenderComplete(visualizationContainer ?? 'lnsVisualizationContainer'); - log.debug('Checking saved searches rendered'); + log.debug('Checking discover viewes rendered'); await dashboardExpect.savedSearchRowCount(11); log.debug('Checking input controls rendered'); await dashboardExpect.controlCount(3); diff --git a/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/session_searches_integration.ts b/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/session_searches_integration.ts index cffd9db8dd12b..3861378a40628 100644 --- a/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/session_searches_integration.ts +++ b/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/session_searches_integration.ts @@ -43,7 +43,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await searchSessions.deleteAllSearchSessions(); }); - it('until session is saved search keepAlive is short, when it is saved, keepAlive is extended and search is saved into the session saved object, when session is extended, searches are also extended', async () => { + it('until session is discover view keepAlive is short, when it is saved, keepAlive is extended and search is saved into the session saved object, when session is extended, searches are also extended', async () => { await PageObjects.dashboard.loadSavedDashboard('Not Delayed'); await PageObjects.dashboard.waitForRenderComplete(); await searchSessions.expectState('completed'); diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/creation.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/creation.cy.ts index fe47cf3a538cb..6342375cb22d2 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/creation.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/creation.cy.ts @@ -132,7 +132,7 @@ describe('Timelines', { tags: ['@ess', '@serverless'] }, (): void => { cy.get(TIMELINE_STATUS).should('not.exist'); // Offsetting the extra save that is happening in the background - // for the saved search object. + // for the discover view object. cy.get(LOADING_INDICATOR).should('be.visible'); cy.get(LOADING_INDICATOR).should('not.exist'); @@ -154,7 +154,7 @@ describe('Timelines', { tags: ['@ess', '@serverless'] }, (): void => { addNameToTimelineAndSave('First'); // Offsetting the extra save that is happening in the background - // for the saved search object. + // for the discover view object. cy.get(LOADING_INDICATOR).should('be.visible'); cy.get(LOADING_INDICATOR).should('not.exist'); diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/esql/discover_timeline_state_integration.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/esql/discover_timeline_state_integration.cy.ts index eaa4fc2416db5..7f553ee48b460 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/esql/discover_timeline_state_integration.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/esql/discover_timeline_state_integration.cy.ts @@ -174,8 +174,8 @@ describe( }); }); - describe('Discover saved search state for ESQL tab', () => { - it('should save esql tab saved search with `Security Solution` tag', () => { + describe('Discover discover view state for ESQL tab', () => { + it('should save esql tab discover view with `Security Solution` tag', () => { const timelineSuffix = Date.now(); const timelineName = `SavedObject timeline-${timelineSuffix}`; addDiscoverEsqlQuery(esqlQuery); @@ -192,11 +192,11 @@ describe( cy.get(BASIC_TABLE_LOADING).should('not.exist'); cy.get(SAVED_OBJECTS_ROW_TITLES).should( 'contain.text', - `Saved search for timeline - ${timelineName}` + `Discover view for timeline - ${timelineName}` ); }); - it('should rename the saved search on timeline rename', () => { + it('should rename the discover view on timeline rename', () => { const initialTimelineSuffix = Date.now(); const initialTimelineName = `Timeline-${initialTimelineSuffix}`; addDiscoverEsqlQuery(esqlQuery); @@ -216,14 +216,14 @@ describe( cy.get(BASIC_TABLE_LOADING).should('not.exist'); cy.get(SAVED_OBJECTS_ROW_TITLES).should( 'contain.text', - `Saved search for timeline - ${renamedTimelineName}` + `Discover view for timeline - ${renamedTimelineName}` ); }); }); // Issue for enabling below tests: https://github.com/elastic/kibana/issues/165913 context.skip('Advanced Settings', () => { - it('rows per page in saved search should be according to the user selected number of pages', () => {}); + it('rows per page in discover view should be according to the user selected number of pages', () => {}); it('rows per page in new search should be according to the value selected in advanced settings', () => {}); }); } diff --git a/x-pack/test/stack_functional_integration/apps/ccs/ccs_discover.js b/x-pack/test/stack_functional_integration/apps/ccs/ccs_discover.js index a3d226b36e7bc..9d072d6cc5be6 100644 --- a/x-pack/test/stack_functional_integration/apps/ccs/ccs_discover.js +++ b/x-pack/test/stack_functional_integration/apps/ccs/ccs_discover.js @@ -179,7 +179,7 @@ export default ({ getService, getPageObjects }) => { }); }); - it('should reload the saved search with persisted query to show the initial hit count', async function () { + it('should reload the discover view with persisted query to show the initial hit count', async function () { await PageObjects.discover.selectIndexPattern( 'ftr-remote:makelogs工程-*,local:makelogs工程-*' ); diff --git a/x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts b/x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts index 2d54d3ba0a52b..6091157a22f73 100644 --- a/x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts +++ b/x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts @@ -58,7 +58,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { await PageObjects.home.launchSampleDashboard('flights'); await PageObjects.header.waitUntilLoadingHasFinished(); await renderable.waitForRender(); - log.debug('Checking saved searches rendered'); + log.debug('Checking discover viewes rendered'); await dashboardExpect.savedSearchRowCount(49); log.debug('Checking input controls rendered'); if (semver.lt(process.env.ORIGINAL_VERSION!, '8.6.0-SNAPSHOT')) { diff --git a/x-pack/test_serverless/functional/fixtures/kbn_archiver/reporting/logs.json b/x-pack/test_serverless/functional/fixtures/kbn_archiver/reporting/logs.json index 05e92981916af..8d32dc1211649 100644 --- a/x-pack/test_serverless/functional/fixtures/kbn_archiver/reporting/logs.json +++ b/x-pack/test_serverless/functional/fixtures/kbn_archiver/reporting/logs.json @@ -441,7 +441,7 @@ ] ], "timeRestore": false, - "title": "A saved search with match_phrase filter and no columns selected", + "title": "A discover view with match_phrase filter and no columns selected", "usesAdHocDataView": false }, "coreMigrationVersion": "8.7.0", @@ -496,7 +496,7 @@ "to": "2015-11-01T01:39:01.782Z" }, "timeRestore": true, - "title": "A saved search with the time stored and a query", + "title": "A discover view with the time stored and a query", "usesAdHocDataView": false }, "coreMigrationVersion": "8.7.0", @@ -538,7 +538,7 @@ ] ], "timeRestore": false, - "title": "A saved search with a query", + "title": "A discover view with a query", "usesAdHocDataView": false }, "coreMigrationVersion": "8.7.0", diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/embeddable/_saved_search_embeddable.ts b/x-pack/test_serverless/functional/test_suites/common/discover/embeddable/_saved_search_embeddable.ts index 5b95dace01a6d..ab25343a1a8a8 100644 --- a/x-pack/test_serverless/functional/test_suites/common/discover/embeddable/_saved_search_embeddable.ts +++ b/x-pack/test_serverless/functional/test_suites/common/discover/embeddable/_saved_search_embeddable.ts @@ -21,7 +21,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const testSubjects = getService('testSubjects'); const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'timePicker', 'discover']); - describe('discover saved search embeddable', () => { + describe('discover discover view embeddable', () => { before(async () => { await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional'); await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data'); @@ -103,7 +103,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(await cell.getVisibleText()).to.be('Sep 22, 2015 @ 23:50:13.253'); }); - it('should render duplicate saved search embeddables', async () => { + it('should render duplicate discover view embeddables', async () => { await addSearchEmbeddableToDashboard(); await addSearchEmbeddableToDashboard(); const [firstGridCell, secondGridCell] = await dataGrid.getAllCellElements(); @@ -129,7 +129,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { ); }); - it('should replace a panel with a saved search', async () => { + it('should replace a panel with a discover view', async () => { await dashboardAddPanel.addVisualization('Rendering Test: datatable'); await PageObjects.header.waitUntilLoadingHasFinished(); await PageObjects.dashboard.waitForRenderComplete(); diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover.ts b/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover.ts index 9768eb43e76ca..a09cb0cb67070 100644 --- a/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover.ts +++ b/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover.ts @@ -129,7 +129,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(isVisible).to.be(false); }); - it('should reload the saved search with persisted query to show the initial hit count', async function () { + it('should reload the discover view with persisted query to show the initial hit count', async function () { await PageObjects.timePicker.setDefaultAbsoluteRange(); await PageObjects.discover.waitUntilSearchingHasFinished(); // apply query some changes diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts b/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts index cf581ad3edb51..4d1c87688483b 100644 --- a/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts +++ b/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts @@ -192,13 +192,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(canvasExists).to.be(true); }); }); - it('should allow hiding the histogram, persisted in saved search', async () => { + it('should allow hiding the histogram, persisted in discover view', async () => { const from = 'Jan 1, 2010 @ 00:00:00.000'; const to = 'Mar 21, 2019 @ 00:00:00.000'; const savedSearch = 'persisted hidden histogram'; await prepareTest({ from, to }); - // close chart for saved search + // close chart for discover view await PageObjects.discover.toggleChartVisibility(); let canvasExists: boolean; await retry.try(async () => { @@ -214,13 +214,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.discover.clickNewSearchButton(); await PageObjects.header.waitUntilLoadingHasFinished(); - // load saved search + // load discover view await PageObjects.discover.loadSavedSearch(savedSearch); await PageObjects.header.waitUntilLoadingHasFinished(); canvasExists = await elasticChart.canvasExists(); expect(canvasExists).to.be(false); - // open chart for saved search + // open chart for discover view await PageObjects.discover.toggleChartVisibility(); await retry.waitFor(`Discover histogram to be displayed`, async () => { canvasExists = await elasticChart.canvasExists(); @@ -235,7 +235,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.discover.clickNewSearchButton(); await PageObjects.header.waitUntilLoadingHasFinished(); - // load saved search + // load discover view await PageObjects.discover.loadSavedSearch(savedSearch); await PageObjects.header.waitUntilLoadingHasFinished(); canvasExists = await elasticChart.canvasExists(); @@ -299,7 +299,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(await PageObjects.discover.isChartVisible()).to.be(true); }); - it('should reset all histogram state when resetting the saved search', async () => { + it('should reset all histogram state when resetting the discover view', async () => { await PageObjects.common.navigateToApp('discover'); await PageObjects.discover.waitUntilSearchingHasFinished(); await PageObjects.timePicker.setDefaultAbsoluteRange(); diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/group2/_adhoc_data_views.ts b/x-pack/test_serverless/functional/test_suites/common/discover/group2/_adhoc_data_views.ts index 03dd58892e5cf..0e2edb88ffffe 100644 --- a/x-pack/test_serverless/functional/test_suites/common/discover/group2/_adhoc_data_views.ts +++ b/x-pack/test_serverless/functional/test_suites/common/discover/group2/_adhoc_data_views.ts @@ -186,7 +186,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { expect(+second).to.equal(+first * 2); }); - it('should open saved search by navigation to context from embeddable', async () => { + it('should open discover view by navigation to context from embeddable', async () => { // navigate to context view await dataGrid.clickRowToggle({ rowIndex: 0 }); const [, surrDocs] = await dataGrid.getRowActions({ rowIndex: 0 }); @@ -200,7 +200,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { } await PageObjects.context.waitUntilContextLoadingHasFinished(); - // open saved search + // open discover view // TODO: Clicking breadcrumbs works differently in Serverless await PageObjects.svlCommonNavigation.breadcrumbs.clickBreadcrumb({ deepLinkId: 'discover' }); await PageObjects.header.waitUntilLoadingHasFinished(); diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/group3/_request_counts.ts b/x-pack/test_serverless/functional/test_suites/common/discover/group3/_request_counts.ts index 8e373bae57ad6..d3382c470a91c 100644 --- a/x-pack/test_serverless/functional/test_suites/common/discover/group3/_request_counts.ts +++ b/x-pack/test_serverless/functional/test_suites/common/discover/group3/_request_counts.ts @@ -135,7 +135,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); }); - it('should send 2 requests for saved search changes', async () => { + it('should send 2 requests for discover view changes', async () => { await setQuery(query1); await queryBar.clickQuerySubmitButton(); await PageObjects.timePicker.setAbsoluteRange( @@ -143,25 +143,25 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { 'Sep 23, 2015 @ 00:00:00.000' ); await waitForLoadingToFinish(); - // TODO: Check why the request happens 4 times in case of opening a saved search + // TODO: Check why the request happens 4 times in case of opening a discover view // https://github.com/elastic/kibana/issues/165192 - // creating the saved search + // creating the discover view await expectSearches(type, savedSearchesRequests ?? 2, async () => { await PageObjects.discover.saveSearch(savedSearch); }); - // resetting the saved search + // resetting the discover view await setQuery(query2); await queryBar.clickQuerySubmitButton(); await waitForLoadingToFinish(); await expectSearches(type, 2, async () => { await PageObjects.discover.revertUnsavedChanges(); }); - // clearing the saved search + // clearing the discover view await expectSearches('ese', 2, async () => { await testSubjects.click('discoverNewButton'); await waitForLoadingToFinish(); }); - // loading the saved search + // loading the discover view // TODO: https://github.com/elastic/kibana/issues/165192 await expectSearches(type, savedSearchesRequests ?? 2, async () => { await PageObjects.discover.loadSavedSearch(savedSearch); diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/group3/_unsaved_changes_badge.ts b/x-pack/test_serverless/functional/test_suites/common/discover/group3/_unsaved_changes_badge.ts index 1f6f89a7bb33b..4d973cdf12e52 100644 --- a/x-pack/test_serverless/functional/test_suites/common/discover/group3/_unsaved_changes_badge.ts +++ b/x-pack/test_serverless/functional/test_suites/common/discover/group3/_unsaved_changes_badge.ts @@ -8,8 +8,8 @@ import expect from '@kbn/expect'; import { FtrProviderContext } from '../../../../ftr_provider_context'; -const SAVED_SEARCH_NAME = 'test saved search'; -const SAVED_SEARCH_WITH_FILTERS_NAME = 'test saved search with filters'; +const SAVED_SEARCH_NAME = 'test discover view'; +const SAVED_SEARCH_WITH_FILTERS_NAME = 'test discover view with filters'; export default function ({ getService, getPageObjects }: FtrProviderContext) { const esArchiver = getService('esArchiver'); @@ -53,7 +53,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.discover.waitUntilSearchingHasFinished(); }); - it('should not show the badge initially nor after changes to a draft saved search', async () => { + it('should not show the badge initially nor after changes to a draft discover view', async () => { await testSubjects.missingOrFail('unsavedChangesBadge'); await PageObjects.unifiedFieldList.clickFieldListItemAdd('bytes'); @@ -64,7 +64,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await testSubjects.missingOrFail('unsavedChangesBadge'); }); - it('should show the badge only after changes to a persisted saved search', async () => { + it('should show the badge only after changes to a persisted discover view', async () => { await PageObjects.discover.saveSearch(SAVED_SEARCH_NAME); await PageObjects.discover.waitUntilSearchingHasFinished(); @@ -81,7 +81,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await testSubjects.missingOrFail('unsavedChangesBadge'); }); - it('should not show a badge after loading a saved search, only after changes', async () => { + it('should not show a badge after loading a discover view, only after changes', async () => { await PageObjects.discover.loadSavedSearch(SAVED_SEARCH_NAME); await testSubjects.missingOrFail('unsavedChangesBadge'); diff --git a/x-pack/test_serverless/functional/test_suites/common/reporting/management.ts b/x-pack/test_serverless/functional/test_suites/common/reporting/management.ts index 90be1b602441a..d6010241c5b77 100644 --- a/x-pack/test_serverless/functional/test_suites/common/reporting/management.ts +++ b/x-pack/test_serverless/functional/test_suites/common/reporting/management.ts @@ -55,7 +55,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { const TEST_PASSWORD = config.get('servers.kibana.password'); before('initialize saved object archive', async () => { - // add test saved search object + // add test discover view object await kibanaServer.importExport.load(savedObjectsArchive); });