@@ -133,7 +133,7 @@ export function LinkedSearch({ savedSearch, eventEmitter }: LinkedSearchProps) {
@@ -146,7 +146,7 @@ export function LinkedSearch({ savedSearch, eventEmitter }: LinkedSearchProps) {
>
diff --git a/src/plugins/visualizations/common/locator.ts b/src/plugins/visualizations/common/locator.ts
index fdb2800ec3a96..deb37cd6e5990 100644
--- a/src/plugins/visualizations/common/locator.ts
+++ b/src/plugins/visualizations/common/locator.ts
@@ -52,17 +52,17 @@ export type VisualizeLocatorParams = {
vis?: SavedVisState;
/**
- * Whether this visualization is linked a saved search.
+ * Whether this visualization is linked a discover view.
*/
linked?: boolean;
/**
- * The saved search used as the source of the visualization.
+ * The discover view used as the source of the visualization.
*/
savedSearchId?: string;
/**
- * The saved search used as the source of the visualization.
+ * The discover view used as the source of the visualization.
*/
indexPattern?: string;
};
diff --git a/src/plugins/visualizations/public/embeddable/to_ast.ts b/src/plugins/visualizations/public/embeddable/to_ast.ts
index 686c1bf7b3271..406d578cb8a6e 100644
--- a/src/plugins/visualizations/public/embeddable/to_ast.ts
+++ b/src/plugins/visualizations/public/embeddable/to_ast.ts
@@ -13,7 +13,7 @@ import type { VisToExpressionAst } from '../types';
/**
* Creates an ast expression for a visualization based on kibana context (query, filters, timerange)
- * including a saved search if the visualization is based on it.
+ * including a discover view if the visualization is based on it.
* The expression also includes particular visualization expression ast if presented.
*
* @internal
diff --git a/src/plugins/visualizations/public/embeddable/visualize_embeddable_factory.test.ts b/src/plugins/visualizations/public/embeddable/visualize_embeddable_factory.test.ts
index 98fa2108bbca1..1f87133ea32d2 100644
--- a/src/plugins/visualizations/public/embeddable/visualize_embeddable_factory.test.ts
+++ b/src/plugins/visualizations/public/embeddable/visualize_embeddable_factory.test.ts
@@ -12,7 +12,7 @@ import { VisualizeEmbeddableFactoryDeps } from './visualize_embeddable_factory';
describe('visualize_embeddable_factory', () => {
const factory = new VisualizeEmbeddableFactory({} as VisualizeEmbeddableFactoryDeps);
- test('extract saved search references for search source state and not store them in state', () => {
+ test('extract discover view references for search source state and not store them in state', () => {
const { state, references } = factory.extract({
savedVis: {
type: 'area',
diff --git a/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.test.ts b/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.test.ts
index ee0e3d481929d..be014418a1f23 100644
--- a/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.test.ts
+++ b/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.test.ts
@@ -170,14 +170,14 @@ describe('injectReferences', () => {
`);
});
- test(`fails when it can't find the saved search reference in the array`, () => {
+ test(`fails when it can't find the discover view reference in the array`, () => {
const context = {
id: '1',
savedSearchRefName: 'search_0',
title: 'test',
} as VisSavedObject;
expect(() => injectReferences(context, [])).toThrowErrorMatchingInlineSnapshot(
- `"Could not find saved search reference \\"search_0\\""`
+ `"Could not find discover view reference \\"search_0\\""`
);
});
diff --git a/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.ts b/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.ts
index 8945da771db7f..016ae1c224ff9 100644
--- a/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.ts
+++ b/src/plugins/visualizations/public/utils/saved_visualization_references/saved_visualization_references.ts
@@ -36,7 +36,7 @@ export function extractReferences({
searchSourceReferences.forEach((r) => updatedReferences.push(r));
}
- // Extract saved search
+ // Extract discover view
if (updatedAttributes.savedSearchId) {
updatedReferences.push({
name: 'search_0',
@@ -77,7 +77,7 @@ export function injectReferences(savedObject: VisSavedObject, references: SavedO
(reference) => reference.name === savedObject.savedSearchRefName
);
if (!savedSearchReference) {
- throw new Error(`Could not find saved search reference "${savedObject.savedSearchRefName}"`);
+ throw new Error(`Could not find discover view reference "${savedObject.savedSearchRefName}"`);
}
savedObject.savedSearchId = savedSearchReference.id;
delete savedObject.savedSearchRefName;
diff --git a/src/plugins/visualizations/public/vis_types/types.ts b/src/plugins/visualizations/public/vis_types/types.ts
index 90f64276adf76..7f72a38a0c7a6 100644
--- a/src/plugins/visualizations/public/vis_types/types.ts
+++ b/src/plugins/visualizations/public/vis_types/types.ts
@@ -163,7 +163,7 @@ export interface VisTypeDefinition
{
/**
* The flag is necessary for aggregation based visualizations.
* When "true", an additional step on the vis creation wizard will be provided
- * with the selection of a search source - an index pattern or a saved search.
+ * with the selection of a search source - an index pattern or a discover view.
*/
readonly requiresSearch?: boolean;
/**
diff --git a/src/plugins/visualizations/public/visualize_app/types.ts b/src/plugins/visualizations/public/visualize_app/types.ts
index abc55e3e671fe..f90f13b43350b 100644
--- a/src/plugins/visualizations/public/visualize_app/types.ts
+++ b/src/plugins/visualizations/public/visualize_app/types.ts
@@ -159,7 +159,7 @@ export interface EditorRenderProps {
uiState: PersistedState;
unifiedSearch: UnifiedSearchPublicPluginStart;
/**
- * Flag to determine if visualiztion is linked to the saved search
+ * Flag to determine if visualiztion is linked to the discover view
*/
linked: boolean;
}
diff --git a/src/plugins/visualizations/public/visualize_app/utils/get_top_nav_config.tsx b/src/plugins/visualizations/public/visualize_app/utils/get_top_nav_config.tsx
index ce12d23ad0c28..3b3271361e525 100644
--- a/src/plugins/visualizations/public/visualize_app/utils/get_top_nav_config.tsx
+++ b/src/plugins/visualizations/public/visualize_app/utils/get_top_nav_config.tsx
@@ -301,7 +301,7 @@ export const getTopNavConfig = (
},
}),
run: async () => {
- // lens doesn't support saved searches, should unlink before transition
+ // lens doesn't support discover viewes, should unlink before transition
if (eventEmitter && visInstance.vis.data.savedSearchId) {
eventEmitter.emit('unlinkFromSavedSearch', false);
}
diff --git a/src/plugins/visualizations/public/visualize_app/utils/get_visualization_instance.test.ts b/src/plugins/visualizations/public/visualize_app/utils/get_visualization_instance.test.ts
index b6304b6e96ad6..b923390e536c1 100644
--- a/src/plugins/visualizations/public/visualize_app/utils/get_visualization_instance.test.ts
+++ b/src/plugins/visualizations/public/visualize_app/utils/get_visualization_instance.test.ts
@@ -115,7 +115,7 @@ describe('getVisualizationInstance', () => {
expect(vis).toBe(newVisObj);
});
- test('should create saved search instance if vis based on saved search id', async () => {
+ test('should create discover view instance if vis based on discover view id', async () => {
visMock.data.savedSearchId = 'saved_search_id';
const { savedSearch } = await getVisualizationInstance(mockServices, 'saved_vis_id');
diff --git a/src/plugins/visualizations/public/visualize_app/utils/use/use_editor_updates.test.ts b/src/plugins/visualizations/public/visualize_app/utils/use/use_editor_updates.test.ts
index f6f242d08d0b0..07584be2246b2 100644
--- a/src/plugins/visualizations/public/visualize_app/utils/use/use_editor_updates.test.ts
+++ b/src/plugins/visualizations/public/visualize_app/utils/use/use_editor_updates.test.ts
@@ -253,7 +253,7 @@ describe('useEditorUpdates', () => {
});
describe('handle linked search changes', () => {
- test('should update saved search id in saved instance', () => {
+ test('should update discover view id in saved instance', () => {
// @ts-expect-error 4.3.5 upgrade
savedVisInstance.savedSearch = {
id: 'saved_search_id',
@@ -283,7 +283,7 @@ describe('useEditorUpdates', () => {
expect(savedVisInstance.vis.data.savedSearchId).toEqual('saved_search_id');
});
- test('should remove saved search id from vis instance', () => {
+ test('should remove discover view id from vis instance', () => {
// @ts-expect-error
savedVisInstance.savedVis = {
savedSearchId: 'saved_search_id',
diff --git a/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.test.ts b/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.test.ts
index 99ce99fd094fb..8afada162dd39 100644
--- a/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.test.ts
+++ b/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.test.ts
@@ -36,7 +36,7 @@ describe('useLinkedSearchUpdates', () => {
expect(mockServices.toastNotifications.addSuccess).not.toHaveBeenCalled();
});
- it('should subscribe on unlinkFromSavedSearch event if vis is based on saved search', () => {
+ it('should subscribe on unlinkFromSavedSearch event if vis is based on discover view', () => {
const mockAppState = {
transitions: {
unlinkSavedSearch: jest.fn(),
diff --git a/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts b/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts
index ffd23ec06aea6..28e01045a4b76 100644
--- a/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts
+++ b/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts
@@ -47,7 +47,7 @@ export const useLinkedSearchUpdates = (
if (showToast) {
services.toastNotifications.addSuccess(
i18n.translate('visualizations.linkedToSearch.unlinkSuccessNotificationText', {
- defaultMessage: `Unlinked from saved search '{searchTitle}'`,
+ defaultMessage: `Unlinked from discover view '{searchTitle}'`,
values: {
searchTitle: savedSearch.title,
},
diff --git a/src/plugins/visualizations/public/visualize_app/utils/use/use_saved_vis_instance.test.ts b/src/plugins/visualizations/public/visualize_app/utils/use/use_saved_vis_instance.test.ts
index 4b6b87bd04f1f..e01ffad0c4302 100644
--- a/src/plugins/visualizations/public/visualize_app/utils/use/use_saved_vis_instance.test.ts
+++ b/src/plugins/visualizations/public/visualize_app/utils/use/use_saved_vis_instance.test.ts
@@ -246,7 +246,7 @@ describe('useSavedVisInstance', () => {
expect(toastNotifications.addWarning).toHaveBeenCalled();
});
- test("should throw error if index pattern or saved search id doesn't exist in search params", async () => {
+ test("should throw error if index pattern or discover view id doesn't exist in search params", async () => {
mockServices.history.location = {
...mockServices.history.location,
search: '?type=area',
diff --git a/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx b/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx
index 374d2c4b8fa39..87b2edabbe4b9 100644
--- a/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx
+++ b/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx
@@ -53,7 +53,7 @@ export class SearchSelection extends React.Component {
noItemsMessage={i18n.translate(
'visualizations.newVisWizard.searchSelection.notFoundLabel',
{
- defaultMessage: 'No matching indices or saved searches found.',
+ defaultMessage: 'No matching indices or discover viewes found.',
}
)}
savedObjectMetaData={[
@@ -63,10 +63,10 @@ export class SearchSelection extends React.Component {
name: i18n.translate(
'visualizations.newVisWizard.searchSelection.savedObjectType.search',
{
- defaultMessage: 'Saved search',
+ defaultMessage: 'Discover view',
}
),
- // ignore the saved searches that have text-based languages queries
+ // ignore the discover viewes that have text-based languages queries
includeFields: ['isTextBasedQuery', 'usesAdHocDataView'],
showSavedObject,
},
diff --git a/test/accessibility/apps/dashboard.ts b/test/accessibility/apps/dashboard.ts
index 32d198c7d5e02..e671e25942d0c 100644
--- a/test/accessibility/apps/dashboard.ts
+++ b/test/accessibility/apps/dashboard.ts
@@ -51,7 +51,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await a11y.testAppSnapshot();
});
- it('add a saved search', async () => {
+ it('add a discover view', async () => {
await dashboardAddPanel.addSavedSearch('[Flights] Flight Log');
await a11y.testAppSnapshot();
});
diff --git a/test/accessibility/apps/discover.ts b/test/accessibility/apps/discover.ts
index 4deb2acb66d74..337f40f9b85d1 100644
--- a/test/accessibility/apps/discover.ts
+++ b/test/accessibility/apps/discover.ts
@@ -57,7 +57,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await a11y.testAppSnapshot();
});
- it('a11y test on load saved search panel', async () => {
+ it('a11y test on load discover view panel', async () => {
await PageObjects.discover.openLoadSavedSearchPanel();
await a11y.testAppSnapshot();
await PageObjects.discover.closeLoadSavedSearchPanel();
diff --git a/test/analytics/tests/instrumented_events/from_the_browser/loaded_dashboard.ts b/test/analytics/tests/instrumented_events/from_the_browser/loaded_dashboard.ts
index 7b21a5637d167..b86896bd48048 100644
--- a/test/analytics/tests/instrumented_events/from_the_browser/loaded_dashboard.ts
+++ b/test/analytics/tests/instrumented_events/from_the_browser/loaded_dashboard.ts
@@ -98,10 +98,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
/**
- * Saved search embeddable
+ * Discover view embeddable
*/
- it('emits when saved search is added', async () => {
+ it('emits when discover view is added', async () => {
await dashboardAddPanel.addSavedSearch(SAVED_SEARCH_PANEL_TITLE);
const event = await checkEmitsOnce();
@@ -110,12 +110,12 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(event.properties.value2).to.be(1);
});
- it('emits on saved search refreshed', async () => {
+ it('emits on discover view refreshed', async () => {
await queryBar.clickQuerySubmitButton();
await checkEmitsOnce();
});
- it("doesn't emit when removing saved search panel", async () => {
+ it("doesn't emit when removing discover view panel", async () => {
await dashboardPanelActions.removePanelByTitle(SAVED_SEARCH_PANEL_TITLE);
await checkDoesNotEmit();
});
diff --git a/test/functional/apps/dashboard/group1/embeddable_rendering.ts b/test/functional/apps/dashboard/group1/embeddable_rendering.ts
index 45408a8846c17..ec33a760cfb75 100644
--- a/test/functional/apps/dashboard/group1/embeddable_rendering.ts
+++ b/test/functional/apps/dashboard/group1/embeddable_rendering.ts
@@ -143,7 +143,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.dashboard.waitForRenderComplete();
});
- it('adding saved searches', async () => {
+ it('adding discover viewes', async () => {
const visAndSearchNames = visNames.concat(
await dashboardAddPanel.addEverySavedSearch('"Rendering Test"')
);
diff --git a/test/functional/apps/dashboard/group2/dashboard_filter_bar.ts b/test/functional/apps/dashboard/group2/dashboard_filter_bar.ts
index 276a3f29e8fd5..5508c840e75fd 100644
--- a/test/functional/apps/dashboard/group2/dashboard_filter_bar.ts
+++ b/test/functional/apps/dashboard/group2/dashboard_filter_bar.ts
@@ -193,7 +193,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
- describe('saved search filtering', function () {
+ describe('discover view filtering', function () {
before(async () => {
await filterBar.ensureFieldEditorModalIsClosed();
await PageObjects.dashboard.gotoDashboardLandingPage();
diff --git a/test/functional/apps/dashboard/group2/dashboard_filtering.ts b/test/functional/apps/dashboard/group2/dashboard_filtering.ts
index 24f276b831036..fcd9267274920 100644
--- a/test/functional/apps/dashboard/group2/dashboard_filtering.ts
+++ b/test/functional/apps/dashboard/group2/dashboard_filtering.ts
@@ -122,7 +122,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await dashboardExpect.tsvbTopNValuesExist(['-', '-']);
});
- it('saved search is filtered', async () => {
+ it('discover view is filtered', async () => {
await dashboardExpect.savedSearchRowsMissing();
});
@@ -183,7 +183,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await dashboardExpect.tsvbTopNValuesExist(['-', '-']);
});
- it('saved search is filtered', async () => {
+ it('discover view is filtered', async () => {
await dashboardExpect.savedSearchRowsMissing();
});
@@ -243,7 +243,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await dashboardExpect.tsvbMarkdownWithValuesExists(['7,209.286']);
});
- it('saved searches', async () => {
+ it('discover viewes', async () => {
await dashboardExpect.savedSearchRowsExist();
});
@@ -322,7 +322,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await pieChart.expectPieSliceCount(5);
});
- it('Pie chart linked to saved search filters data', async () => {
+ it('Pie chart linked to discover view filters data', async () => {
await dashboardAddPanel.addVisualization(
'Filter Test: animals: linked to search with filter'
);
@@ -330,7 +330,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await pieChart.expectSliceCountForAllPies(7);
});
- it('Pie chart linked to saved search filters shows no data with conflicting dashboard query', async () => {
+ it('Pie chart linked to discover view filters shows no data with conflicting dashboard query', async () => {
await elasticChart.setNewChartUiDebugFlag(true);
await queryBar.setQuery('weightLbs<40');
await queryBar.submitQuery();
diff --git a/test/functional/apps/dashboard/group3/dashboard_state.ts b/test/functional/apps/dashboard/group3/dashboard_state.ts
index 650d2e6b79269..5e3442dfc75e5 100644
--- a/test/functional/apps/dashboard/group3/dashboard_state.ts
+++ b/test/functional/apps/dashboard/group3/dashboard_state.ts
@@ -117,7 +117,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(colorChoiceRetained).to.be(true);
});
- it('Saved search with no changes will update when the saved object changes', async () => {
+ it('Discover view with no changes will update when the saved object changes', async () => {
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.header.clickDiscover();
@@ -149,7 +149,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(headers[2]).to.be('agent');
});
- it('Saved search with column changes will not update when the saved object changes', async () => {
+ it('Discover view with column changes will not update when the saved object changes', async () => {
await PageObjects.dashboard.switchToEditMode();
await PageObjects.discover.removeHeaderColumn('bytes');
await PageObjects.dashboard.saveDashboard('Has local edits');
@@ -167,7 +167,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(headers[1]).to.be('agent');
});
- it('Saved search will update when the query is changed in the URL', async () => {
+ it('Discover view will update when the query is changed in the URL', async () => {
const currentQuery = await queryBar.getQueryString();
expect(currentQuery).to.equal('');
const newUrl = updateAppStateQueryParam(
diff --git a/test/functional/apps/dashboard/group3/dashboard_time_picker.ts b/test/functional/apps/dashboard/group3/dashboard_time_picker.ts
index 303d0fe0f141e..e65ed549d5ff2 100644
--- a/test/functional/apps/dashboard/group3/dashboard_time_picker.ts
+++ b/test/functional/apps/dashboard/group3/dashboard_time_picker.ts
@@ -51,11 +51,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await pieChart.expectPieSliceCount(10);
});
- it('Saved search updated when time picker changes', async () => {
+ it('Discover view updated when time picker changes', async () => {
await PageObjects.dashboard.gotoDashboardLandingPage();
await PageObjects.dashboard.clickNewDashboard();
await dashboardVisualizations.createAndAddSavedSearch({
- name: 'saved search',
+ name: 'discover view',
fields: ['bytes', 'agent'],
});
@@ -89,10 +89,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.dashboard.clickNewDashboard();
log.debug('Clicked new dashboard');
await dashboardVisualizations.createAndAddSavedSearch({
- name: 'saved search',
+ name: 'discover view',
fields: ['bytes', 'agent'],
});
- log.debug('added saved search');
+ log.debug('added discover view');
const currentUrl = await browser.getCurrentUrl();
const kibanaBaseUrl = currentUrl.substring(0, currentUrl.indexOf('#'));
const urlQuery =
diff --git a/test/functional/apps/dashboard/group3/panel_context_menu.ts b/test/functional/apps/dashboard/group3/panel_context_menu.ts
index 4abf860cb17fc..93ea9d839dd73 100644
--- a/test/functional/apps/dashboard/group3/panel_context_menu.ts
+++ b/test/functional/apps/dashboard/group3/panel_context_menu.ts
@@ -95,7 +95,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
- describe('saved search object edit menu', () => {
+ describe('discover view object edit menu', () => {
const searchName = 'my search';
before(async () => {
@@ -119,7 +119,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(panelCount).to.be(1);
});
- it('opens a saved search when edit link is clicked', async () => {
+ it('opens a discover view when edit link is clicked', async () => {
await dashboardPanelActions.openContextMenu();
await dashboardPanelActions.clickEdit();
await PageObjects.header.waitUntilLoadingHasFinished();
@@ -127,7 +127,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(queryName).to.be(searchName);
});
- it('deletes the saved search when delete link is clicked', async () => {
+ it('deletes the discover view when delete link is clicked', async () => {
await PageObjects.header.clickDashboard();
await PageObjects.header.waitUntilLoadingHasFinished();
await dashboardPanelActions.removePanel();
diff --git a/test/functional/apps/dashboard/group3/panel_replacing.ts b/test/functional/apps/dashboard/group3/panel_replacing.ts
index 1cb344748594f..a54f28e90b91d 100644
--- a/test/functional/apps/dashboard/group3/panel_replacing.ts
+++ b/test/functional/apps/dashboard/group3/panel_replacing.ts
@@ -68,8 +68,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(panelTitles[0]).to.be(AREA_CHART_VIS_NAME);
});
- it('replaced panel with saved search', async () => {
- const replacedSearch = 'replaced saved search';
+ it('replaced panel with discover view', async () => {
+ const replacedSearch = 'replaced discover view';
await dashboardVisualizations.createSavedSearch({
name: replacedSearch,
fields: ['bytes', 'agent'],
@@ -80,7 +80,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.dashboard.switchToEditMode();
}
await dashboardPanelActions.replacePanelByTitle(AREA_CHART_VIS_NAME);
- await dashboardReplacePanel.replaceEmbeddable(replacedSearch, 'Saved search');
+ await dashboardReplacePanel.replaceEmbeddable(replacedSearch, 'Discover view');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.dashboard.waitForRenderComplete();
const panelTitles = await PageObjects.dashboard.getPanelTitles();
diff --git a/test/functional/apps/dashboard/group5/data_shared_attributes.ts b/test/functional/apps/dashboard/group5/data_shared_attributes.ts
index 3202d418bd512..11ba390370b78 100644
--- a/test/functional/apps/dashboard/group5/data_shared_attributes.ts
+++ b/test/functional/apps/dashboard/group5/data_shared_attributes.ts
@@ -126,10 +126,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
- it('data-shared-item title should update a saved search when using a custom panel title', async () => {
+ it('data-shared-item title should update a discover view when using a custom panel title', async () => {
await PageObjects.dashboard.switchToEditMode();
const CUSTOM_SEARCH_TITLE = 'ima custom title for a search!';
- const el = await dashboardPanelActions.getPanelHeading('Rendering Test: saved search');
+ const el = await dashboardPanelActions.getPanelHeading('Rendering Test: discover view');
await dashboardPanelActions.customizePanel(el);
await dashboardCustomizePanel.expectCustomizePanelSettingsFlyoutOpen();
await dashboardCustomizePanel.setCustomPanelTitle(CUSTOM_SEARCH_TITLE);
diff --git a/test/functional/apps/dashboard/group5/saved_search_embeddable.ts b/test/functional/apps/dashboard/group5/saved_search_embeddable.ts
index f20172d10ed5c..564e8cbde739d 100644
--- a/test/functional/apps/dashboard/group5/saved_search_embeddable.ts
+++ b/test/functional/apps/dashboard/group5/saved_search_embeddable.ts
@@ -20,7 +20,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const from = 'Sep 22, 2015 @ 00:00:00.000';
const to = 'Sep 23, 2015 @ 00:00:00.000';
- describe('dashboard saved search embeddable', () => {
+ describe('dashboard discover view embeddable', () => {
before(async () => {
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data');
@@ -67,7 +67,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(marks.length).to.be(0);
});
- it('view action leads to a saved search', async function () {
+ it('view action leads to a discover view', async function () {
await filterBar.removeAllFilters();
await PageObjects.dashboard.saveDashboard('Dashboard With Saved Search');
await PageObjects.dashboard.clickCancelOutOfEditMode(false);
@@ -91,7 +91,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.waitForDiscoverAppOnScreen();
expect(await PageObjects.discover.getSavedSearchTitle()).to.equal(
- 'Rendering Test: saved search'
+ 'Rendering Test: discover view'
);
});
diff --git a/test/functional/apps/dashboard_elements/controls/common/time_slider.ts b/test/functional/apps/dashboard_elements/controls/common/time_slider.ts
index c860af183d64e..78ff893ae9717 100644
--- a/test/functional/apps/dashboard_elements/controls/common/time_slider.ts
+++ b/test/functional/apps/dashboard_elements/controls/common/time_slider.ts
@@ -128,10 +128,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
describe('panel interactions', async () => {
- describe('saved search', async () => {
+ describe('discover view', async () => {
before(async () => {
await dashboard.navigateToApp();
- await dashboard.loadSavedDashboard('timeslider and saved search');
+ await dashboard.loadSavedDashboard('timeslider and discover view');
await dashboard.waitForRenderComplete();
});
diff --git a/test/functional/apps/discover/embeddable/_saved_search_embeddable.ts b/test/functional/apps/discover/embeddable/_saved_search_embeddable.ts
index 03f40c5b6ebcf..8631b264fc8bf 100644
--- a/test/functional/apps/discover/embeddable/_saved_search_embeddable.ts
+++ b/test/functional/apps/discover/embeddable/_saved_search_embeddable.ts
@@ -21,7 +21,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'timePicker', 'discover']);
- describe('discover saved search embeddable', () => {
+ describe('discover discover view embeddable', () => {
before(async () => {
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data');
@@ -103,7 +103,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await cell.getVisibleText()).to.be('Sep 22, 2015 @ 23:50:13.253');
});
- it('should render duplicate saved search embeddables', async () => {
+ it('should render duplicate discover view embeddables', async () => {
await addSearchEmbeddableToDashboard();
await addSearchEmbeddableToDashboard();
const [firstGridCell, secondGridCell] = await dataGrid.getAllCellElements();
@@ -129,7 +129,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
});
- it('should replace a panel with a saved search', async () => {
+ it('should replace a panel with a discover view', async () => {
await dashboardAddPanel.addVisualization('Rendering Test: datatable');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.dashboard.waitForRenderComplete();
diff --git a/test/functional/apps/discover/group1/_discover.ts b/test/functional/apps/discover/group1/_discover.ts
index 0210c7d8cc7f2..b582a572999e5 100644
--- a/test/functional/apps/discover/group1/_discover.ts
+++ b/test/functional/apps/discover/group1/_discover.ts
@@ -126,7 +126,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(isVisible).to.be(false);
});
- it('should reload the saved search with persisted query to show the initial hit count', async function () {
+ it('should reload the discover view with persisted query to show the initial hit count', async function () {
await PageObjects.timePicker.setDefaultAbsoluteRange();
await PageObjects.discover.waitUntilSearchingHasFinished();
// apply query some changes
diff --git a/test/functional/apps/discover/group1/_discover_histogram.ts b/test/functional/apps/discover/group1/_discover_histogram.ts
index ad5563e78f918..982f6e30aede7 100644
--- a/test/functional/apps/discover/group1/_discover_histogram.ts
+++ b/test/functional/apps/discover/group1/_discover_histogram.ts
@@ -189,13 +189,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(canvasExists).to.be(true);
});
});
- it('should allow hiding the histogram, persisted in saved search', async () => {
+ it('should allow hiding the histogram, persisted in discover view', async () => {
const from = 'Jan 1, 2010 @ 00:00:00.000';
const to = 'Mar 21, 2019 @ 00:00:00.000';
const savedSearch = 'persisted hidden histogram';
await prepareTest({ from, to });
- // close chart for saved search
+ // close chart for discover view
await PageObjects.discover.toggleChartVisibility();
let canvasExists: boolean;
await retry.try(async () => {
@@ -211,13 +211,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.clickNewSearchButton();
await PageObjects.header.waitUntilLoadingHasFinished();
- // load saved search
+ // load discover view
await PageObjects.discover.loadSavedSearch(savedSearch);
await PageObjects.header.waitUntilLoadingHasFinished();
canvasExists = await elasticChart.canvasExists();
expect(canvasExists).to.be(false);
- // open chart for saved search
+ // open chart for discover view
await PageObjects.discover.toggleChartVisibility();
await retry.waitFor(`Discover histogram to be displayed`, async () => {
canvasExists = await elasticChart.canvasExists();
@@ -232,7 +232,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.clickNewSearchButton();
await PageObjects.header.waitUntilLoadingHasFinished();
- // load saved search
+ // load discover view
await PageObjects.discover.loadSavedSearch(savedSearch);
await PageObjects.header.waitUntilLoadingHasFinished();
canvasExists = await elasticChart.canvasExists();
@@ -296,7 +296,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await PageObjects.discover.isChartVisible()).to.be(true);
});
- it('should reset all histogram state when resetting the saved search', async () => {
+ it('should reset all histogram state when resetting the discover view', async () => {
await PageObjects.common.navigateToApp('discover');
await PageObjects.discover.waitUntilSearchingHasFinished();
await PageObjects.timePicker.setDefaultAbsoluteRange();
diff --git a/test/functional/apps/discover/group1/_discover_histogram_breakdown.ts b/test/functional/apps/discover/group1/_discover_histogram_breakdown.ts
index 86ec135ab0089..210fa1b5fda8a 100644
--- a/test/functional/apps/discover/group1/_discover_histogram_breakdown.ts
+++ b/test/functional/apps/discover/group1/_discover_histogram_breakdown.ts
@@ -43,7 +43,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await filterBar.hasFilter('extension.raw', 'png')).to.be(true);
});
- it('should save breakdown field in saved search', async () => {
+ it('should save breakdown field in discover view', async () => {
await filterBar.removeFilter('extension.raw');
await PageObjects.discover.saveSearch('with breakdown');
diff --git a/test/functional/apps/discover/group2/_data_grid_pagination.ts b/test/functional/apps/discover/group2/_data_grid_pagination.ts
index 4c0a3aa53759e..316078afdef7f 100644
--- a/test/functional/apps/discover/group2/_data_grid_pagination.ts
+++ b/test/functional/apps/discover/group2/_data_grid_pagination.ts
@@ -86,7 +86,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await testSubjects.existOrFail('unifiedDataTableFooter');
});
- it('should render exact number of rows which where configured in the saved search or in settings', async () => {
+ it('should render exact number of rows which where configured in the discover view or in settings', async () => {
await kibanaServer.uiSettings.update({
...defaultSettings,
'discover:sampleSize': 12,
@@ -113,10 +113,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect((await dataGrid.getDocTableRows()).length).to.be(6); // as in settings
await dataGrid.checkCurrentRowsPerPageToBe(6);
- // open the saved search
+ // open the discover view
await PageObjects.discover.loadSavedSearch(savedSearchTitle);
await PageObjects.discover.waitUntilSearchingHasFinished();
- expect((await dataGrid.getDocTableRows()).length).to.be(10); // as in the saved search
+ expect((await dataGrid.getDocTableRows()).length).to.be(10); // as in the discover view
await dataGrid.checkCurrentRowsPerPageToBe(10);
});
});
diff --git a/test/functional/apps/discover/group2/_data_grid_sample_size.ts b/test/functional/apps/discover/group2/_data_grid_sample_size.ts
index 891363f0868db..7972a28979daa 100644
--- a/test/functional/apps/discover/group2/_data_grid_sample_size.ts
+++ b/test/functional/apps/discover/group2/_data_grid_sample_size.ts
@@ -137,13 +137,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await dataGrid.getCurrentSampleSizeValue()).to.be(DEFAULT_SAMPLE_SIZE);
await goToLastPageAndCheckFooterMessage(DEFAULT_SAMPLE_SIZE);
- // load the saved search again
+ // load the discover view again
await PageObjects.discover.loadSavedSearch(SAVED_SEARCH_NAME);
await dataGrid.clickGridSettings();
expect(await dataGrid.getCurrentSampleSizeValue()).to.be(CUSTOM_SAMPLE_SIZE_FOR_SAVED_SEARCH);
await goToLastPageAndCheckFooterMessage(CUSTOM_SAMPLE_SIZE_FOR_SAVED_SEARCH);
- // load another saved search without a custom sample size
+ // load another discover view without a custom sample size
await PageObjects.discover.loadSavedSearch('A Saved Search');
await dataGrid.clickGridSettings();
expect(await dataGrid.getCurrentSampleSizeValue()).to.be(DEFAULT_SAMPLE_SIZE);
diff --git a/test/functional/apps/discover/group3/_request_counts.ts b/test/functional/apps/discover/group3/_request_counts.ts
index d568d623b5c08..2c55d244da0ae 100644
--- a/test/functional/apps/discover/group3/_request_counts.ts
+++ b/test/functional/apps/discover/group3/_request_counts.ts
@@ -131,7 +131,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
- it(`should send ${savedSearchesRequests} requests for saved search changes`, async () => {
+ it(`should send ${savedSearchesRequests} requests for discover view changes`, async () => {
await setQuery(query1);
await queryBar.clickQuerySubmitButton();
await PageObjects.timePicker.setAbsoluteRange(
@@ -139,25 +139,25 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'Sep 23, 2015 @ 00:00:00.000'
);
await waitForLoadingToFinish();
- // TODO: Check why the request happens 4 times in case of opening a saved search
+ // TODO: Check why the request happens 4 times in case of opening a discover view
// https://github.com/elastic/kibana/issues/165192
- // creating the saved search
+ // creating the discover view
await expectSearches(type, savedSearchesRequests ?? expectedRequests, async () => {
await PageObjects.discover.saveSearch(savedSearch);
});
- // resetting the saved search
+ // resetting the discover view
await setQuery(query2);
await queryBar.clickQuerySubmitButton();
await waitForLoadingToFinish();
await expectSearches(type, expectedRequests, async () => {
await PageObjects.discover.revertUnsavedChanges();
});
- // clearing the saved search
+ // clearing the discover view
await expectSearches('ese', savedSearchesRequests ?? expectedRequests, async () => {
await testSubjects.click('discoverNewButton');
await waitForLoadingToFinish();
});
- // loading the saved search
+ // loading the discover view
// TODO: https://github.com/elastic/kibana/issues/165192
await expectSearches(type, savedSearchesRequests ?? expectedRequests, async () => {
await PageObjects.discover.loadSavedSearch(savedSearch);
diff --git a/test/functional/apps/discover/group3/_unsaved_changes_badge.ts b/test/functional/apps/discover/group3/_unsaved_changes_badge.ts
index 305298ff2ccc6..7237725f9035e 100644
--- a/test/functional/apps/discover/group3/_unsaved_changes_badge.ts
+++ b/test/functional/apps/discover/group3/_unsaved_changes_badge.ts
@@ -9,9 +9,9 @@
import expect from '@kbn/expect';
import { FtrProviderContext } from '../ftr_provider_context';
-const SAVED_SEARCH_NAME = 'test saved search';
-const SAVED_SEARCH_WITH_FILTERS_NAME = 'test saved search with filters';
-const SAVED_SEARCH_ESQL = 'test saved search ES|QL';
+const SAVED_SEARCH_NAME = 'test discover view';
+const SAVED_SEARCH_WITH_FILTERS_NAME = 'test discover view with filters';
+const SAVED_SEARCH_ESQL = 'test discover view ES|QL';
export default function ({ getService, getPageObjects }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
@@ -57,7 +57,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.waitUntilSearchingHasFinished();
});
- it('should not show the badge initially nor after changes to a draft saved search', async () => {
+ it('should not show the badge initially nor after changes to a draft discover view', async () => {
await testSubjects.missingOrFail('unsavedChangesBadge');
await PageObjects.unifiedFieldList.clickFieldListItemAdd('bytes');
@@ -68,7 +68,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await testSubjects.missingOrFail('unsavedChangesBadge');
});
- it('should show the badge only after changes to a persisted saved search', async () => {
+ it('should show the badge only after changes to a persisted discover view', async () => {
await PageObjects.discover.saveSearch(SAVED_SEARCH_NAME);
await PageObjects.discover.waitUntilSearchingHasFinished();
@@ -85,7 +85,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await testSubjects.missingOrFail('unsavedChangesBadge');
});
- it('should not show a badge after loading a saved search, only after changes', async () => {
+ it('should not show a badge after loading a discover view, only after changes', async () => {
await PageObjects.discover.loadSavedSearch(SAVED_SEARCH_NAME);
await testSubjects.missingOrFail('unsavedChangesBadge');
@@ -198,7 +198,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await PageObjects.discover.getHitCount()).to.be('1,373');
});
- it('should not show a badge after loading an ES|QL saved search, only after changes', async () => {
+ it('should not show a badge after loading an ES|QL discover view, only after changes', async () => {
await PageObjects.discover.selectTextBaseLang();
await monacoEditor.setCodeEditorValue('from logstash-* | limit 10');
diff --git a/test/functional/apps/discover/group4/_adhoc_data_views.ts b/test/functional/apps/discover/group4/_adhoc_data_views.ts
index 2fe0167763687..4e10c32e210c2 100644
--- a/test/functional/apps/discover/group4/_adhoc_data_views.ts
+++ b/test/functional/apps/discover/group4/_adhoc_data_views.ts
@@ -186,7 +186,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(+second).to.equal(+first * 2);
});
- it('should open saved search by navigation to context from embeddable', async () => {
+ it('should open discover view by navigation to context from embeddable', async () => {
// navigate to context view
await dataGrid.clickRowToggle({ rowIndex: 0 });
const [, surrDocs] = await dataGrid.getRowActions({ rowIndex: 0 });
@@ -200,7 +200,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
}
await PageObjects.context.waitUntilContextLoadingHasFinished();
- // open saved search
+ // open discover view
await testSubjects.click('~breadcrumb & ~first');
await PageObjects.header.waitUntilLoadingHasFinished();
diff --git a/test/functional/apps/discover/group4/_chart_hidden.ts b/test/functional/apps/discover/group4/_chart_hidden.ts
index 6bee290df896d..1c24bbe9075fe 100644
--- a/test/functional/apps/discover/group4/_chart_hidden.ts
+++ b/test/functional/apps/discover/group4/_chart_hidden.ts
@@ -54,7 +54,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await PageObjects.discover.isChartVisible()).to.be(false);
});
- it('persists hidden chart option on the saved search ', async function () {
+ it('persists hidden chart option on the discover view ', async function () {
const savedSearchTitle = 'chart hidden';
await PageObjects.discover.saveSearch(savedSearchTitle);
diff --git a/test/functional/apps/discover/group4/_indexpattern_with_unmapped_fields.ts b/test/functional/apps/discover/group4/_indexpattern_with_unmapped_fields.ts
index 1efa988be9227..371d5ec23eaa1 100644
--- a/test/functional/apps/discover/group4/_indexpattern_with_unmapped_fields.ts
+++ b/test/functional/apps/discover/group4/_indexpattern_with_unmapped_fields.ts
@@ -43,7 +43,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.unset('timepicker:timeDefaults');
});
- it('unmapped fields exist on a new saved search', async () => {
+ it('unmapped fields exist on a new discover view', async () => {
const expectedHitCount = '4';
await retry.try(async function () {
expect(await PageObjects.discover.getHitCount()).to.be(expectedHitCount);
@@ -62,7 +62,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.unifiedFieldList.toggleSidebarSection('unmapped');
});
- it('unmapped fields exist on an existing saved search', async () => {
+ it('unmapped fields exist on an existing discover view', async () => {
await PageObjects.discover.loadSavedSearch('Existing Saved Search');
const expectedHitCount = '4';
await retry.try(async function () {
diff --git a/test/functional/apps/discover/group4/_indexpattern_without_timefield.ts b/test/functional/apps/discover/group4/_indexpattern_without_timefield.ts
index 2531a368861c3..b2c104e364b67 100644
--- a/test/functional/apps/discover/group4/_indexpattern_without_timefield.ts
+++ b/test/functional/apps/discover/group4/_indexpattern_without_timefield.ts
@@ -115,7 +115,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(url).to.contain(`refreshInterval:(pause:!t,value:${autoRefreshInterval * 1000})`);
});
- it('should allow switching from a saved search with a time field to a saved search without a time field', async () => {
+ it('should allow switching from a discover view with a time field to a discover view without a time field', async () => {
await PageObjects.common.navigateToApp('discover');
await PageObjects.discover.selectIndexPattern('with-timefield');
await PageObjects.header.waitUntilLoadingHasFinished();
diff --git a/test/functional/apps/discover/group4/_runtime_fields_editor.ts b/test/functional/apps/discover/group4/_runtime_fields_editor.ts
index 808694680cd8b..790ab593f8c3d 100644
--- a/test/functional/apps/discover/group4/_runtime_fields_editor.ts
+++ b/test/functional/apps/discover/group4/_runtime_fields_editor.ts
@@ -94,7 +94,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
- it('allows creation of a new field and use it in a saved search', async function () {
+ it('allows creation of a new field and use it in a discover view', async function () {
const fieldName = '_runtimefield-saved-search';
await createRuntimeField(fieldName);
await PageObjects.unifiedFieldList.clickFieldListItemAdd(fieldName);
diff --git a/test/functional/apps/discover/group4/_search_on_page_load.ts b/test/functional/apps/discover/group4/_search_on_page_load.ts
index 5d08d8d5cbe9b..029b2c58631db 100644
--- a/test/functional/apps/discover/group4/_search_on_page_load.ts
+++ b/test/functional/apps/discover/group4/_search_on_page_load.ts
@@ -141,7 +141,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await PageObjects.unifiedFieldList.doesSidebarShowFields()).to.be(true);
});
- it('should reset state after opening a saved search and pressing New', async function () {
+ it('should reset state after opening a discover view and pressing New', async function () {
await PageObjects.discover.loadSavedSearch(savedSearchName);
await PageObjects.header.waitUntilLoadingHasFinished();
diff --git a/test/functional/apps/home/_sample_data.ts b/test/functional/apps/home/_sample_data.ts
index 4120a9ecc1a54..24086ce973892 100644
--- a/test/functional/apps/home/_sample_data.ts
+++ b/test/functional/apps/home/_sample_data.ts
@@ -104,7 +104,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await renderable.waitForRender();
log.debug('Checking charts rendered');
await elasticChart.waitForRenderComplete('xyVisChart');
- log.debug('Checking saved searches rendered');
+ log.debug('Checking discover viewes rendered');
await dashboardExpect.savedSearchRowCount(10);
log.debug('Checking input controls rendered');
await dashboardExpect.controlCount(3);
diff --git a/test/functional/apps/management/_import_objects.ts b/test/functional/apps/management/_import_objects.ts
index 1801175247474..ffa551ef9d2fa 100644
--- a/test/functional/apps/management/_import_objects.ts
+++ b/test/functional/apps/management/_import_objects.ts
@@ -130,7 +130,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(isSuccessful).to.be(true);
});
- it('should import saved objects linked to saved searches', async function () {
+ it('should import saved objects linked to discover viewes', async function () {
await PageObjects.savedObjects.importFile(
path.join(__dirname, 'exports', '_import_objects_saved_search.ndjson')
);
@@ -144,11 +144,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.savedObjects.clickImportDone();
const objects = await PageObjects.savedObjects.getRowTitles();
- const isSavedObjectImported = objects.includes('saved object connected to saved search');
+ const isSavedObjectImported = objects.includes('saved object connected to discover view');
expect(isSavedObjectImported).to.be(true);
});
- it('should not import saved objects linked to saved searches when saved search does not exist', async function () {
+ it('should not import saved objects linked to discover viewes when discover view does not exist', async function () {
await PageObjects.savedObjects.importFile(
path.join(__dirname, 'exports', '_import_objects_connected_to_saved_search.ndjson')
);
@@ -156,11 +156,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.savedObjects.clickImportDone();
const objects = await PageObjects.savedObjects.getRowTitles();
- const isSavedObjectImported = objects.includes('saved object connected to saved search');
+ const isSavedObjectImported = objects.includes('saved object connected to discover view');
expect(isSavedObjectImported).to.be(false);
});
- it('should not import saved objects linked to saved searches when saved search index pattern does not exist', async function () {
+ it('should not import saved objects linked to discover viewes when discover view index pattern does not exist', async function () {
await PageObjects.savedObjects.clickCheckboxByTitle('logstash-*');
await PageObjects.savedObjects.clickDelete();
@@ -173,7 +173,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.savedObjects.clickImportDone();
const objects = await PageObjects.savedObjects.getRowTitles();
- const isSavedObjectImported = objects.includes('saved object connected to saved search');
+ const isSavedObjectImported = objects.includes('saved object connected to discover view');
expect(isSavedObjectImported).to.be(false);
});
diff --git a/test/functional/apps/management/_mgmt_import_saved_objects.ts b/test/functional/apps/management/_mgmt_import_saved_objects.ts
index 04a1bb5938322..777136f0595aa 100644
--- a/test/functional/apps/management/_mgmt_import_saved_objects.ts
+++ b/test/functional/apps/management/_mgmt_import_saved_objects.ts
@@ -15,7 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const PageObjects = getPageObjects(['common', 'settings', 'header', 'savedObjects']);
// in 6.4.0 bug the Saved Search conflict would be resolved and get imported but the visualization
- // that referenced the saved search was not imported.( https://github.com/elastic/kibana/issues/22238)
+ // that referenced the discover view was not imported.( https://github.com/elastic/kibana/issues/22238)
describe('mgmt saved objects', function describeIndexTests() {
before(async () => {
diff --git a/test/functional/apps/management/exports/_import_objects_connected_to_saved_search.ndjson b/test/functional/apps/management/exports/_import_objects_connected_to_saved_search.ndjson
index 803da8a639bc9..1aefbc10374e5 100644
--- a/test/functional/apps/management/exports/_import_objects_connected_to_saved_search.ndjson
+++ b/test/functional/apps/management/exports/_import_objects_connected_to_saved_search.ndjson
@@ -1 +1 @@
-{"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"filter\":[],\"query\":{\"query\":\"\",\"language\":\"lucene\"}}"},"savedSearchRefName":"search_0","title":"saved object connected to saved search","uiStateJSON":"{}","visState":"{\"title\":\"PHP Viz\",\"type\":\"horizontal_bar\",\"params\":{\"type\":\"histogram\",\"grid\":{\"categoryLines\":false,\"style\":{\"color\":\"#eee\"}},\"categoryAxes\":[{\"id\":\"CategoryAxis-1\",\"type\":\"category\",\"position\":\"left\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\"},\"labels\":{\"show\":true,\"rotate\":0,\"filter\":false,\"truncate\":200},\"title\":{}}],\"valueAxes\":[{\"id\":\"ValueAxis-1\",\"name\":\"LeftAxis-1\",\"type\":\"value\",\"position\":\"bottom\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\",\"mode\":\"normal\"},\"labels\":{\"show\":true,\"rotate\":75,\"filter\":true,\"truncate\":100},\"title\":{\"text\":\"Count\"}}],\"seriesParams\":[{\"show\":true,\"type\":\"histogram\",\"mode\":\"normal\",\"data\":{\"label\":\"Count\",\"id\":\"1\"},\"valueAxis\":\"ValueAxis-1\",\"drawLinesBetweenPoints\":true,\"showCircles\":true}],\"addTooltip\":true,\"addLegend\":true,\"legendPosition\":\"right\",\"times\":[],\"addTimeMarker\":false},\"aggs\":[{\"id\":\"1\",\"enabled\":true,\"type\":\"count\",\"schema\":\"metric\",\"params\":{}}]}"},"id":"saved_object_connected_to_saved_search","migrationVersion":{"visualization":"7.0.0"},"references":[{"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","name":"search_0","type":"search"}],"type":"visualization","version":1}
+{"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"filter\":[],\"query\":{\"query\":\"\",\"language\":\"lucene\"}}"},"savedSearchRefName":"search_0","title":"saved object connected to discover view","uiStateJSON":"{}","visState":"{\"title\":\"PHP Viz\",\"type\":\"horizontal_bar\",\"params\":{\"type\":\"histogram\",\"grid\":{\"categoryLines\":false,\"style\":{\"color\":\"#eee\"}},\"categoryAxes\":[{\"id\":\"CategoryAxis-1\",\"type\":\"category\",\"position\":\"left\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\"},\"labels\":{\"show\":true,\"rotate\":0,\"filter\":false,\"truncate\":200},\"title\":{}}],\"valueAxes\":[{\"id\":\"ValueAxis-1\",\"name\":\"LeftAxis-1\",\"type\":\"value\",\"position\":\"bottom\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\",\"mode\":\"normal\"},\"labels\":{\"show\":true,\"rotate\":75,\"filter\":true,\"truncate\":100},\"title\":{\"text\":\"Count\"}}],\"seriesParams\":[{\"show\":true,\"type\":\"histogram\",\"mode\":\"normal\",\"data\":{\"label\":\"Count\",\"id\":\"1\"},\"valueAxis\":\"ValueAxis-1\",\"drawLinesBetweenPoints\":true,\"showCircles\":true}],\"addTooltip\":true,\"addLegend\":true,\"legendPosition\":\"right\",\"times\":[],\"addTimeMarker\":false},\"aggs\":[{\"id\":\"1\",\"enabled\":true,\"type\":\"count\",\"schema\":\"metric\",\"params\":{}}]}"},"id":"saved_object_connected_to_saved_search","migrationVersion":{"visualization":"7.0.0"},"references":[{"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","name":"search_0","type":"search"}],"type":"visualization","version":1}
diff --git a/test/functional/apps/management/exports/_import_objects_saved_search.ndjson b/test/functional/apps/management/exports/_import_objects_saved_search.ndjson
index 4e2e350ec59fe..cbf983b501940 100644
--- a/test/functional/apps/management/exports/_import_objects_saved_search.ndjson
+++ b/test/functional/apps/management/exports/_import_objects_saved_search.ndjson
@@ -1 +1 @@
-{"attributes":{"columns":["_source"],"description":"","hits":0,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"highlightAll\":true,\"version\":true,\"query\":{\"language\":\"lucene\",\"query\":\"php\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":["@timestamp","desc"],"title":"PHP saved search"},"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","migrationVersion":{"search":"7.0.0"},"references":[{"id":"f1e4c910-a2e6-11e7-bb30-233be9be6a15","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","version":1}
+{"attributes":{"columns":["_source"],"description":"","hits":0,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"highlightAll\":true,\"version\":true,\"query\":{\"language\":\"lucene\",\"query\":\"php\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":["@timestamp","desc"],"title":"PHP discover view"},"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","migrationVersion":{"search":"7.0.0"},"references":[{"id":"f1e4c910-a2e6-11e7-bb30-233be9be6a15","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","version":1}
diff --git a/test/functional/apps/management/exports/_import_objects_with_saved_search.ndjson b/test/functional/apps/management/exports/_import_objects_with_saved_search.ndjson
index 0e321b168d68c..1700413e8d376 100644
--- a/test/functional/apps/management/exports/_import_objects_with_saved_search.ndjson
+++ b/test/functional/apps/management/exports/_import_objects_with_saved_search.ndjson
@@ -1,2 +1,2 @@
-{"attributes":{"columns":["_source"],"description":"","hits":0,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"highlightAll\":true,\"version\":true,\"query\":{\"language\":\"lucene\",\"query\":\"php\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":["@timestamp","desc"],"title":"PHP saved search"},"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","migrationVersion":{"search":"7.0.0"},"references":[{"id":"f1e4c910-a2e6-11e7-bb30-233be9be6a15","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","version":1}
-{"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"filter\":[],\"query\":{\"query\":\"\",\"language\":\"lucene\"}}"},"savedSearchRefName":"search_0","title":"saved object connected to saved search","uiStateJSON":"{}","visState":"{\"title\":\"PHP Viz\",\"type\":\"horizontal_bar\",\"params\":{\"type\":\"histogram\",\"grid\":{\"categoryLines\":false,\"style\":{\"color\":\"#eee\"}},\"categoryAxes\":[{\"id\":\"CategoryAxis-1\",\"type\":\"category\",\"position\":\"left\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\"},\"labels\":{\"show\":true,\"rotate\":0,\"filter\":false,\"truncate\":200},\"title\":{}}],\"valueAxes\":[{\"id\":\"ValueAxis-1\",\"name\":\"LeftAxis-1\",\"type\":\"value\",\"position\":\"bottom\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\",\"mode\":\"normal\"},\"labels\":{\"show\":true,\"rotate\":75,\"filter\":true,\"truncate\":100},\"title\":{\"text\":\"Count\"}}],\"seriesParams\":[{\"show\":true,\"type\":\"histogram\",\"mode\":\"normal\",\"data\":{\"label\":\"Count\",\"id\":\"1\"},\"valueAxis\":\"ValueAxis-1\",\"drawLinesBetweenPoints\":true,\"showCircles\":true}],\"addTooltip\":true,\"addLegend\":true,\"legendPosition\":\"right\",\"times\":[],\"addTimeMarker\":false},\"aggs\":[{\"id\":\"1\",\"enabled\":true,\"type\":\"count\",\"schema\":\"metric\",\"params\":{}}]}"},"id":"saved_object_connected_to_saved_search","migrationVersion":{"visualization":"7.0.0"},"references":[{"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","name":"search_0","type":"search"}],"type":"visualization","version":1}
+{"attributes":{"columns":["_source"],"description":"","hits":0,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"highlightAll\":true,\"version\":true,\"query\":{\"language\":\"lucene\",\"query\":\"php\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":["@timestamp","desc"],"title":"PHP discover view"},"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","migrationVersion":{"search":"7.0.0"},"references":[{"id":"f1e4c910-a2e6-11e7-bb30-233be9be6a15","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","version":1}
+{"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"filter\":[],\"query\":{\"query\":\"\",\"language\":\"lucene\"}}"},"savedSearchRefName":"search_0","title":"saved object connected to discover view","uiStateJSON":"{}","visState":"{\"title\":\"PHP Viz\",\"type\":\"horizontal_bar\",\"params\":{\"type\":\"histogram\",\"grid\":{\"categoryLines\":false,\"style\":{\"color\":\"#eee\"}},\"categoryAxes\":[{\"id\":\"CategoryAxis-1\",\"type\":\"category\",\"position\":\"left\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\"},\"labels\":{\"show\":true,\"rotate\":0,\"filter\":false,\"truncate\":200},\"title\":{}}],\"valueAxes\":[{\"id\":\"ValueAxis-1\",\"name\":\"LeftAxis-1\",\"type\":\"value\",\"position\":\"bottom\",\"show\":true,\"style\":{},\"scale\":{\"type\":\"linear\",\"mode\":\"normal\"},\"labels\":{\"show\":true,\"rotate\":75,\"filter\":true,\"truncate\":100},\"title\":{\"text\":\"Count\"}}],\"seriesParams\":[{\"show\":true,\"type\":\"histogram\",\"mode\":\"normal\",\"data\":{\"label\":\"Count\",\"id\":\"1\"},\"valueAxis\":\"ValueAxis-1\",\"drawLinesBetweenPoints\":true,\"showCircles\":true}],\"addTooltip\":true,\"addLegend\":true,\"legendPosition\":\"right\",\"times\":[],\"addTimeMarker\":false},\"aggs\":[{\"id\":\"1\",\"enabled\":true,\"type\":\"count\",\"schema\":\"metric\",\"params\":{}}]}"},"id":"saved_object_connected_to_saved_search","migrationVersion":{"visualization":"7.0.0"},"references":[{"id":"c45e6c50-ba72-11e7-a8f9-ad70f02e633d","name":"search_0","type":"search"}],"type":"visualization","version":1}
diff --git a/test/functional/apps/visualize/group3/_linked_saved_searches.ts b/test/functional/apps/visualize/group3/_linked_saved_searches.ts
index f97a4c86e4560..732771eb7bb87 100644
--- a/test/functional/apps/visualize/group3/_linked_saved_searches.ts
+++ b/test/functional/apps/visualize/group3/_linked_saved_searches.ts
@@ -24,8 +24,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'visChart',
]);
- describe('saved search visualizations from visualize app', function describeIndexTests() {
- describe('linked saved searched', () => {
+ describe('discover view visualizations from visualize app', function describeIndexTests() {
+ describe('linked discover viewed', () => {
const savedSearchName = 'vis_saved_search';
let discoverSavedSearchUrlPath: string;
@@ -43,7 +43,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.common.unsetTime();
});
- it('should create a visualization from a saved search', async () => {
+ it('should create a visualization from a discover view', async () => {
await PageObjects.visualize.navigateToNewAggBasedVisualization();
await PageObjects.visualize.clickDataTable();
await PageObjects.visualize.clickSavedSearch(savedSearchName);
@@ -53,7 +53,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
- it('should have a valid link to the saved search from the visualization', async () => {
+ it('should have a valid link to the discover view from the visualization', async () => {
await testSubjects.click('showUnlinkSavedSearchPopover');
await testSubjects.click('viewSavedSearch');
await PageObjects.header.waitUntilLoadingHasFinished();
@@ -71,7 +71,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.header.waitUntilLoadingHasFinished();
});
- it('should respect the time filter when linked to a saved search', async () => {
+ it('should respect the time filter when linked to a discover view', async () => {
await PageObjects.timePicker.setAbsoluteRange(
'Sep 19, 2015 @ 06:31:44.000',
'Sep 21, 2015 @ 10:00:00.000'
@@ -82,7 +82,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
- it('should allow adding filters while having a linked saved search', async () => {
+ it('should allow adding filters while having a linked discover view', async () => {
await filterBar.addFilter({
field: 'bytes',
operation: 'is between',
@@ -101,11 +101,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const data = await PageObjects.visChart.getTableVisContent();
return data[0][0] === '707';
});
- // The filter on the saved search should now be in the editor
+ // The filter on the discover view should now be in the editor
expect(await filterBar.hasFilter('extension.raw', 'jpg')).to.be(true);
// Disabling this filter should now result in different values, since
- // the visualization should not be linked anymore with the saved search.
+ // the visualization should not be linked anymore with the discover view.
await filterBar.toggleFilterEnabled('extension.raw');
await PageObjects.header.waitUntilLoadingHasFinished();
await retry.waitFor('wait for count to equal 1,293', async () => {
diff --git a/test/functional/fixtures/kbn_archiver/ccs/dashboard/current/kibana.json b/test/functional/fixtures/kbn_archiver/ccs/dashboard/current/kibana.json
index 711f242d16ac8..ce3f4687e4f8b 100644
--- a/test/functional/fixtures/kbn_archiver/ccs/dashboard/current/kibana.json
+++ b/test/functional/fixtures/kbn_archiver/ccs/dashboard/current/kibana.json
@@ -913,7 +913,7 @@
"desc"
]
],
- "title": "Bytes and kuery in saved search with filter",
+ "title": "Bytes and kuery in discover view with filter",
"version": 1
},
"coreMigrationVersion": "8.0.1",
@@ -2094,7 +2094,7 @@
"desc"
]
],
- "title": "Rendering Test: saved search",
+ "title": "Rendering Test: discover view",
"version": 1
},
"coreMigrationVersion": "8.0.1",
@@ -2650,4 +2650,4 @@
"type": "index-pattern",
"updated_at": "2018-04-16T16:57:12.263Z",
"version": "WzE3NiwxXQ=="
-}
\ No newline at end of file
+}
diff --git a/test/functional/fixtures/kbn_archiver/dashboard/current/kibana.json b/test/functional/fixtures/kbn_archiver/dashboard/current/kibana.json
index 500443f11900a..79a253b366df3 100644
--- a/test/functional/fixtures/kbn_archiver/dashboard/current/kibana.json
+++ b/test/functional/fixtures/kbn_archiver/dashboard/current/kibana.json
@@ -913,7 +913,7 @@
"desc"
]
],
- "title": "Bytes and kuery in saved search with filter",
+ "title": "Bytes and kuery in discover view with filter",
"version": 1
},
"coreMigrationVersion": "8.0.1",
@@ -2094,7 +2094,7 @@
"desc"
]
],
- "title": "Rendering Test: saved search",
+ "title": "Rendering Test: discover view",
"version": 1
},
"coreMigrationVersion": "8.0.1",
@@ -2728,7 +2728,7 @@
"description": "",
"panelsJSON": "[{\"version\":\"8.6.0\",\"type\":\"search\",\"gridData\":{\"x\":0,\"y\":0,\"w\":24,\"h\":15,\"i\":\"3d2c7037-b0af-4b9f-810f-75de6278acf2\"},\"panelIndex\":\"3d2c7037-b0af-4b9f-810f-75de6278acf2\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_3d2c7037-b0af-4b9f-810f-75de6278acf2\"}]",
"timeFrom": "2018-04-09T23:43:13.577Z",
- "title": "timeslider and saved search",
+ "title": "timeslider and discover view",
"timeTo": "2018-04-14T00:40:42.233Z",
"version": 1
},
diff --git a/test/functional/fixtures/kbn_archiver/managed_content.json b/test/functional/fixtures/kbn_archiver/managed_content.json
index b530dfd3f2352..a2bf37aa5a624 100644
--- a/test/functional/fixtures/kbn_archiver/managed_content.json
+++ b/test/functional/fixtures/kbn_archiver/managed_content.json
@@ -4,6 +4,6 @@
{"attributes":{"description":"","state":{"adHocDataViews":{},"datasourceStates":{"formBased":{"layers":{"e633b1af-3ab4-4bf5-8faa-fefde06c4a4a":{"columnOrder":["f2555a1a-6f93-43fd-bc63-acdfadd47729","d229daf9-9658-4579-99af-01d8adb2f25f"],"columns":{"d229daf9-9658-4579-99af-01d8adb2f25f":{"dataType":"number","isBucketed":false,"label":"Median of bytes","operationType":"median","params":{"emptyAsNull":true},"scale":"ratio","sourceField":"bytes"},"f2555a1a-6f93-43fd-bc63-acdfadd47729":{"dataType":"date","isBucketed":true,"label":"@timestamp","operationType":"date_histogram","params":{"dropPartials":false,"includeEmptyRows":true,"interval":"auto"},"scale":"interval","sourceField":"@timestamp"}},"incompleteColumns":{},"sampling":1}}},"indexpattern":{"layers":{}},"textBased":{"layers":{}}},"filters":[],"internalReferences":[],"query":{"language":"kuery","query":""},"visualization":{"axisTitlesVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"fittingFunction":"None","gridlinesVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"labelsOrientation":{"x":0,"yLeft":0,"yRight":0},"layers":[{"accessors":["d229daf9-9658-4579-99af-01d8adb2f25f"],"layerId":"e633b1af-3ab4-4bf5-8faa-fefde06c4a4a","layerType":"data","position":"top","seriesType":"bar_stacked","showGridlines":false,"xAccessor":"f2555a1a-6f93-43fd-bc63-acdfadd47729"}],"legend":{"isVisible":true,"position":"right"},"preferredSeriesType":"bar_stacked","tickLabelsVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"valueLabels":"hide"}},"title":"Lens vis (unmanaged)","visualizationType":"lnsXY"},"coreMigrationVersion":"8.8.0","created_at":"2024-01-18T17:42:12.920Z","id":"unmanaged-36db-4a3b-a4ba-7a64ab8f130b","managed":false,"references":[{"id":"5f863f70-4728-4e8d-b441-db08f8c33b28","name":"indexpattern-datasource-layer-e633b1af-3ab4-4bf5-8faa-fefde06c4a4a","type":"index-pattern"}],"type":"lens","typeMigrationVersion":"8.9.0","updated_at":"2024-01-18T17:42:12.920Z","version":"WzQ1LDFd"}
-{"attributes":{"columns":["@tags","clientip"],"description":"","grid":{},"hideChart":false,"isTextBasedQuery":false,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"agent.raw:\\\"Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)\\\" \",\"language\":\"kuery\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":[["@timestamp","desc"]],"timeRestore":false,"title":"Saved search","usesAdHocDataView":false},"coreMigrationVersion":"8.8.0","created_at":"2024-01-22T18:11:05.016Z","id":"managed-3d62-4113-ac7c-de2e20a68fbc","managed":true,"references":[{"id":"5f863f70-4728-4e8d-b441-db08f8c33b28","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","typeMigrationVersion":"8.0.0","updated_at":"2024-01-22T18:11:05.016Z","version":"WzIzLDFd"}
+{"attributes":{"columns":["@tags","clientip"],"description":"","grid":{},"hideChart":false,"isTextBasedQuery":false,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"agent.raw:\\\"Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)\\\" \",\"language\":\"kuery\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":[["@timestamp","desc"]],"timeRestore":false,"title":"Discover view","usesAdHocDataView":false},"coreMigrationVersion":"8.8.0","created_at":"2024-01-22T18:11:05.016Z","id":"managed-3d62-4113-ac7c-de2e20a68fbc","managed":true,"references":[{"id":"5f863f70-4728-4e8d-b441-db08f8c33b28","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","typeMigrationVersion":"8.0.0","updated_at":"2024-01-22T18:11:05.016Z","version":"WzIzLDFd"}
-{"attributes":{"columns":["@tags","clientip"],"description":"","grid":{},"hideChart":false,"isTextBasedQuery":false,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"agent.raw:\\\"Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)\\\" \",\"language\":\"kuery\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":[["@timestamp","desc"]],"timeRestore":false,"title":"Saved search","usesAdHocDataView":false},"coreMigrationVersion":"8.8.0","created_at":"2024-01-22T18:11:05.016Z","id":"unmanaged-3d62-4113-ac7c-de2e20a68fbc","managed":false,"references":[{"id":"5f863f70-4728-4e8d-b441-db08f8c33b28","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","typeMigrationVersion":"8.0.0","updated_at":"2024-01-22T18:11:05.016Z","version":"WzIzLDFd"}
+{"attributes":{"columns":["@tags","clientip"],"description":"","grid":{},"hideChart":false,"isTextBasedQuery":false,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"agent.raw:\\\"Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)\\\" \",\"language\":\"kuery\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"sort":[["@timestamp","desc"]],"timeRestore":false,"title":"Discover view","usesAdHocDataView":false},"coreMigrationVersion":"8.8.0","created_at":"2024-01-22T18:11:05.016Z","id":"unmanaged-3d62-4113-ac7c-de2e20a68fbc","managed":false,"references":[{"id":"5f863f70-4728-4e8d-b441-db08f8c33b28","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"search","typeMigrationVersion":"8.0.0","updated_at":"2024-01-22T18:11:05.016Z","version":"WzIzLDFd"}
diff --git a/test/functional/page_objects/discover_page.ts b/test/functional/page_objects/discover_page.ts
index 658e235c77d33..cbed13163781d 100644
--- a/test/functional/page_objects/discover_page.ts
+++ b/test/functional/page_objects/discover_page.ts
@@ -52,7 +52,7 @@ export class DiscoverPageObject extends FtrService {
await this.clickSaveSearchButton();
// preventing an occasional flakiness when the saved object wasn't set and the form can't be submitted
await this.retry.waitFor(
- `saved search title is set to ${searchName} and save button is clickable`,
+ `discover view title is set to ${searchName} and save button is clickable`,
async () => {
const saveButton = await this.testSubjects.find('confirmSaveSavedObjectButton');
await this.testSubjects.setValue('savedObjectTitle', searchName);
@@ -77,12 +77,12 @@ export class DiscoverPageObject extends FtrService {
await this.testSubjects.click('confirmSaveSavedObjectButton');
await this.header.waitUntilLoadingHasFinished();
- // LeeDr - this additional checking for the saved search name was an attempt
+ // LeeDr - this additional checking for the discover view name was an attempt
// to cause this method to wait for the reloading of the page to complete so
// that the next action wouldn't have to retry. But it doesn't really solve
// that issue. But it does typically take about 3 retries to
// complete with the expected searchName.
- await this.retry.waitFor(`saved search was persisted with name ${searchName}`, async () => {
+ await this.retry.waitFor(`discover view was persisted with name ${searchName}`, async () => {
return (await this.getCurrentQueryName()) === searchName;
});
}
@@ -126,7 +126,7 @@ export class DiscoverPageObject extends FtrService {
// We need this try loop here because previous actions in Discover like
// saving a search cause reloading of the page and the "Open" menu item goes stale.
- await this.retry.waitFor('saved search panel is opened', async () => {
+ await this.retry.waitFor('discover view panel is opened', async () => {
await this.clickLoadSavedSearchButton();
await this.header.waitUntilLoadingHasFinished();
isOpen = await this.testSubjects.exists('loadSearchForm');
diff --git a/test/functional/services/dashboard/add_panel.ts b/test/functional/services/dashboard/add_panel.ts
index 65adf6dee5359..6ec54be8b4c23 100644
--- a/test/functional/services/dashboard/add_panel.ts
+++ b/test/functional/services/dashboard/add_panel.ts
@@ -195,7 +195,7 @@ export class DashboardAddPanelService extends FtrService {
if (filter) {
await this.filterEmbeddableNames(filter.replace('-', ' '));
}
- await this.savedObjectsFinder.waitForFilter('Saved search', 'visualization');
+ await this.savedObjectsFinder.waitForFilter('Discover view', 'visualization');
let morePages = true;
while (morePages) {
searchList.push(await this.addEveryEmbeddableOnCurrentPage());
diff --git a/test/interpreter_functional/test_suites/run_pipeline/esaggs.ts b/test/interpreter_functional/test_suites/run_pipeline/esaggs.ts
index d29c63b467b64..31e3dfb5fdaf0 100644
--- a/test/interpreter_functional/test_suites/run_pipeline/esaggs.ts
+++ b/test/interpreter_functional/test_suites/run_pipeline/esaggs.ts
@@ -93,7 +93,7 @@ export default function ({
});
});
- describe('loads a saved search', () => {
+ describe('loads a discover view', () => {
before(async () => {
await kibanaServer.importExport.load(
'test/functional/fixtures/kbn_archiver/saved_search.json'
@@ -111,7 +111,7 @@ export default function ({
aggs={aggCount id="1" enabled=true schema="metric"}
`;
- it('correctly applies filter from saved search', async () => {
+ it('correctly applies filter from discover view', async () => {
const result = await expectExpression('esaggs_saved_searches', expression).getResponse();
expect(getCell(result, 0, 0)).to.be(119);
});
diff --git a/x-pack/plugins/aiops/public/application/utils/search_utils.ts b/x-pack/plugins/aiops/public/application/utils/search_utils.ts
index 99a9dfda4c642..c179204c2b9ae 100644
--- a/x-pack/plugins/aiops/public/application/utils/search_utils.ts
+++ b/x-pack/plugins/aiops/public/application/utils/search_utils.ts
@@ -5,7 +5,7 @@
* 2.0.
*/
-// TODO Consolidate with duplicate saved search utils file in
+// TODO Consolidate with duplicate discover view utils file in
// `x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts`
import { cloneDeep } from 'lodash';
@@ -40,7 +40,7 @@ export function isSavedSearchSavedObject(arg: unknown): arg is SavedSearchSavedO
/**
* Parse the stringified searchSourceJSON
- * from a saved search or saved search object
+ * from a discover view or discover view object
*/
export function getQueryFromSavedSearchObject(savedSearch: SavedSearchSavedObject | SavedSearch) {
const search = isSavedSearchSavedObject(savedSearch)
@@ -56,12 +56,12 @@ export function getQueryFromSavedSearchObject(savedSearch: SavedSearchSavedObjec
})
: undefined;
- // Remove indexRefName because saved search might no longer be relevant
+ // Remove indexRefName because discover view might no longer be relevant
// if user modifies the query or filter
- // after opening a saved search
+ // after opening a discover view
if (parsed && Array.isArray(parsed.filter)) {
parsed.filter.forEach((f) => {
- // @ts-expect-error indexRefName does appear in meta for newly created saved search
+ // @ts-expect-error indexRefName does appear in meta for newly created discover view
f.meta.indexRefName = undefined;
});
}
@@ -122,7 +122,7 @@ function getSavedSearchSource(savedSearch: SavedSearch) {
}
/**
- * Extract query data from the saved search object
+ * Extract query data from the discover view object
* with overrides from the provided query data and/or filters
*/
export function getEsQueryFromSavedSearch({
@@ -147,9 +147,9 @@ export function getEsQueryFromSavedSearch({
const savedSearchSource = getSavedSearchSource(savedSearch);
- // If saved search has a search source with nested parent
- // e.g. a search coming from Dashboard saved search embeddable
- // which already combines both the saved search's original query/filters and the Dashboard's
+ // If discover view has a search source with nested parent
+ // e.g. a search coming from Dashboard discover view embeddable
+ // which already combines both the discover view's original query/filters and the Dashboard's
// then no need to process any further
if (savedSearchSource && savedSearchSource.getParent() !== undefined && userQuery) {
// Flattened query from search source may contain a clause that narrows the time range
@@ -171,7 +171,7 @@ export function getEsQueryFromSavedSearch({
};
}
- // If no saved search available, use user's query and filters
+ // If no discover view available, use user's query and filters
if (!savedSearch && userQuery) {
if (filterManager && userFilters) filterManager.addFilters(userFilters);
@@ -189,8 +189,8 @@ export function getEsQueryFromSavedSearch({
};
}
- // If saved search available, merge saved search with the latest user query or filters
- // which might differ from extracted saved search data
+ // If discover view available, merge discover view with the latest user query or filters
+ // which might differ from extracted discover view data
if (savedSearchSource) {
const globalFilters = filterManager?.getGlobalFilters();
// FIXME: Add support for AggregateQuery type #150091
diff --git a/x-pack/plugins/aiops/public/components/change_point_detection/change_point_detection_root.tsx b/x-pack/plugins/aiops/public/components/change_point_detection/change_point_detection_root.tsx
index b63e17e2e0d86..4786b5ff36dc9 100644
--- a/x-pack/plugins/aiops/public/components/change_point_detection/change_point_detection_root.tsx
+++ b/x-pack/plugins/aiops/public/components/change_point_detection/change_point_detection_root.tsx
@@ -47,7 +47,7 @@ const localStorage = new Storage(window.localStorage);
export interface ChangePointDetectionAppStateProps {
/** The data view to analyze. */
dataView: DataView;
- /** The saved search to analyze. */
+ /** The discover view to analyze. */
savedSearch: SavedSearch | null;
/** App dependencies */
appDependencies: AiopsAppDependencies;
diff --git a/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_app_state.tsx b/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_app_state.tsx
index 46e3de8b01b67..e1f2d7114c65c 100644
--- a/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_app_state.tsx
+++ b/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_app_state.tsx
@@ -32,7 +32,7 @@ const localStorage = new Storage(window.localStorage);
export interface LogCategorizationAppStateProps {
/** The data view to analyze. */
dataView: DataView;
- /** The saved search to analyze. */
+ /** The discover view to analyze. */
savedSearch: SavedSearch | null;
/** App dependencies */
appDependencies: AiopsAppDependencies;
diff --git a/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_page.tsx b/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_page.tsx
index 792e50fd585c8..0a8d403c827b1 100644
--- a/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_page.tsx
+++ b/x-pack/plugins/aiops/public/components/log_categorization/log_categorization_page.tsx
@@ -121,8 +121,8 @@ export const LogCategorizationPage: FC = ({ embeddin
queryLanguage: SearchQueryLanguage;
filters: Filter[];
}) => {
- // When the user loads saved search and then clear or modify the query
- // we should remove the saved search and replace it with the index pattern id
+ // When the user loads discover view and then clear or modify the query
+ // we should remove the discover view and replace it with the index pattern id
if (selectedSavedSearch !== null) {
setSelectedSavedSearch(null);
}
diff --git a/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_app_state.tsx b/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_app_state.tsx
index daa717b4fd410..afdb2ec77245b 100644
--- a/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_app_state.tsx
+++ b/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_app_state.tsx
@@ -34,7 +34,7 @@ const localStorage = new Storage(window.localStorage);
export interface LogRateAnalysisAppStateProps {
/** The data view to analyze. */
dataView: DataView;
- /** The saved search to analyze. */
+ /** The discover view to analyze. */
savedSearch: SavedSearch | null;
/** App dependencies */
appDependencies: AiopsAppDependencies;
diff --git a/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_page.tsx b/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_page.tsx
index 4931503b7366e..5f043c9260253 100644
--- a/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_page.tsx
+++ b/x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_page.tsx
@@ -65,8 +65,8 @@ export const LogRateAnalysisPage: FC = ({ stickyHistogram }) => {
queryLanguage: SearchQueryLanguage;
filters: Filter[];
}) => {
- // When the user loads a saved search and then clears or modifies the query
- // we should remove the saved search and replace it with the index pattern id
+ // When the user loads a discover view and then clears or modifies the query
+ // we should remove the discover view and replace it with the index pattern id
if (selectedSavedSearch !== null) {
setSelectedSavedSearch(null);
}
diff --git a/x-pack/plugins/aiops/public/hooks/use_data_source.tsx b/x-pack/plugins/aiops/public/hooks/use_data_source.tsx
index e0fd8a431df53..f049c046b948a 100644
--- a/x-pack/plugins/aiops/public/hooks/use_data_source.tsx
+++ b/x-pack/plugins/aiops/public/hooks/use_data_source.tsx
@@ -36,7 +36,7 @@ export interface DataSourceContextProviderProps {
}
/**
- * Context provider that resolves current data view and the saved search
+ * Context provider that resolves current data view and the discover view
*
* @param children
* @constructor
@@ -57,7 +57,7 @@ export const DataSourceContextProvider: FC = ({
} = useAiopsAppContext();
/**
- * Resolve data view or saved search if exists.
+ * Resolve data view or discover view if exists.
*/
const resolveDataSource = useCallback(async (): Promise => {
const dataViewAndSavedSearch: DataViewAndSavedSearch = {
@@ -104,7 +104,7 @@ export const DataSourceContextProvider: FC = ({
}
diff --git a/x-pack/plugins/alerting/docs/openapi/bundled.json b/x-pack/plugins/alerting/docs/openapi/bundled.json
index 6092bfc5bf60c..c66896f2f7e30 100644
--- a/x-pack/plugins/alerting/docs/openapi/bundled.json
+++ b/x-pack/plugins/alerting/docs/openapi/bundled.json
@@ -4209,7 +4209,7 @@
},
"create_siem_saved_query_rule_request": {
"title": "Create saved query rule request",
- "description": "A rule that searches the defined indices and creates an alert when a document matches the saved search.\n",
+ "description": "A rule that searches the defined indices and creates an alert when a document matches the discover view.\n",
"type": "object",
"required": [
"consumer",
@@ -8339,4 +8339,4 @@
}
}
}
-}
\ No newline at end of file
+}
diff --git a/x-pack/plugins/alerting/docs/openapi/bundled.yaml b/x-pack/plugins/alerting/docs/openapi/bundled.yaml
index f847686a2cced..1440fef917650 100644
--- a/x-pack/plugins/alerting/docs/openapi/bundled.yaml
+++ b/x-pack/plugins/alerting/docs/openapi/bundled.yaml
@@ -1680,7 +1680,7 @@ components:
create_anomaly_detection_alert_rule_request:
title: Create anomaly detection rule request
description: |
- A rule that checks if the anomaly detection job results contain anomalies that match the rule conditions.
+ A rule that checks if the anomaly detection job results contain anomalies that match the rule conditions.
type: object
required:
- consumer
@@ -1890,7 +1890,7 @@ components:
create_es_query_rule_request:
title: Create Elasticsearch query rule request
description: |
- A rule that runs a user-configured query, compares the number of matches to a configured threshold, and schedules actions to run when the threshold condition is met.
+ A rule that runs a user-configured query, compares the number of matches to a configured threshold, and schedules actions to run when the threshold condition is met.
type: object
required:
- consumer
@@ -1925,7 +1925,7 @@ components:
create_geo_containment_rule_request:
title: Create tracking containment rule request
description: |
- A rule that runs an Elasticsearch query over indices to determine whether any documents are currently contained within any boundaries from the specified boundary index. In the event that an entity is contained within a boundary, an alert may be generated.
+ A rule that runs an Elasticsearch query over indices to determine whether any documents are currently contained within any boundaries from the specified boundary index. In the event that an entity is contained within a boundary, an alert may be generated.
type: object
required:
- consumer
@@ -2858,7 +2858,7 @@ components:
create_siem_saved_query_rule_request:
title: Create saved query rule request
description: |
- A rule that searches the defined indices and creates an alert when a document matches the saved search.
+ A rule that searches the defined indices and creates an alert when a document matches the discover view.
type: object
required:
- consumer
@@ -4785,7 +4785,7 @@ components:
scaling_factor:
type: integer
description: |
- The scaling factor to use when encoding values. This property is applicable when `type` is `scaled_float`. Values will be multiplied by this factor at index time and rounded to the closest long value.
+ The scaling factor to use when encoding values. This property is applicable when `type` is `scaled_float`. Values will be multiplied by this factor at index time and rounded to the closest long value.
type:
type: string
description: Specifies the data type for the field.
diff --git a/x-pack/plugins/alerting/docs/openapi/components/schemas/create_siem_saved_query_rule_request.yaml b/x-pack/plugins/alerting/docs/openapi/components/schemas/create_siem_saved_query_rule_request.yaml
index 3048c922e492a..4294570b9decb 100644
--- a/x-pack/plugins/alerting/docs/openapi/components/schemas/create_siem_saved_query_rule_request.yaml
+++ b/x-pack/plugins/alerting/docs/openapi/components/schemas/create_siem_saved_query_rule_request.yaml
@@ -1,6 +1,6 @@
title: Create saved query rule request
-description: >
- A rule that searches the defined indices and creates an alert when a document matches the saved search.
+description: >
+ A rule that searches the defined indices and creates an alert when a document matches the discover view.
type: object
required:
- consumer
@@ -35,4 +35,3 @@ properties:
$ref: 'tags.yaml'
throttle:
$ref: 'throttle.yaml'
-
\ No newline at end of file
diff --git a/x-pack/plugins/canvas/i18n/functions/dict/saved_search.ts b/x-pack/plugins/canvas/i18n/functions/dict/saved_search.ts
index 7cdac8909c6ec..22aafb6c8ded3 100644
--- a/x-pack/plugins/canvas/i18n/functions/dict/saved_search.ts
+++ b/x-pack/plugins/canvas/i18n/functions/dict/saved_search.ts
@@ -12,9 +12,9 @@ import { FunctionFactory } from '../../../types';
export const help: FunctionHelp> = {
help: i18n.translate('xpack.canvas.functions.savedSearchHelpText', {
- defaultMessage: `Returns an embeddable for a saved search object`,
+ defaultMessage: `Returns an embeddable for a discover view object`,
}),
args: {
- id: 'The id of the saved search object',
+ id: 'The id of the discover view object',
},
};
diff --git a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_app_state.tsx b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_app_state.tsx
index 7e774336dd118..08a654c56ebb3 100644
--- a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_app_state.tsx
+++ b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_app_state.tsx
@@ -36,7 +36,7 @@ const localStorage = new Storage(window.localStorage);
export interface DataDriftDetectionAppStateProps {
/** The data view to analyze. */
dataView: DataView;
- /** The saved search to analyze. */
+ /** The discover view to analyze. */
savedSearch: SavedSearch | null;
}
@@ -57,7 +57,7 @@ export const DataDriftDetectionAppState: FC = (
savedSearch,
}) => {
if (!(dataView || savedSearch)) {
- throw Error('No data view or saved search available.');
+ throw Error('No data view or discover view available.');
}
const coreStart = getCoreStart();
diff --git a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_page.tsx b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_page.tsx
index 00555f856f6d6..4185d42695297 100644
--- a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_page.tsx
+++ b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_page.tsx
@@ -188,8 +188,8 @@ export const DataDriftPage: FC = ({ initialSettings }) => {
queryLanguage: SearchQueryLanguage;
filters: Filter[];
}) => {
- // When the user loads a saved search and then clears or modifies the query
- // we should remove the saved search and replace it with the index pattern id
+ // When the user loads a discover view and then clears or modifies the query
+ // we should remove the discover view and replace it with the index pattern id
if (selectedSavedSearch !== null) {
setSelectedSavedSearch(null);
}
diff --git a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_view.tsx b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_view.tsx
index d752cb4b166f5..f6368bf4d98d0 100644
--- a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_view.tsx
+++ b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_view.tsx
@@ -207,8 +207,8 @@ export const IndexDataVisualizerView: FC = (dataVi
queryLanguage: SearchQueryLanguage;
filters: Filter[];
}) => {
- // When the user loads saved search and then clears or modifies the query
- // we should remove the saved search and replace it with the index pattern id
+ // When the user loads discover view and then clears or modifies the query
+ // we should remove the discover view and replace it with the index pattern id
if (currentSavedSearch !== null) {
setCurrentSavedSearch(null);
}
diff --git a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/index_data_visualizer.tsx b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/index_data_visualizer.tsx
index 6b4a401b10629..e5000898c9a68 100644
--- a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/index_data_visualizer.tsx
+++ b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/index_data_visualizer.tsx
@@ -170,7 +170,7 @@ export const DataVisualizerStateContextProvider: FC {
});
describe('getEsQueryFromSavedSearch()', () => {
- it('return undefined if saved search is not provided', () => {
+ it('return undefined if discover view is not provided', () => {
expect(
getEsQueryFromSavedSearch({
dataView: mockDataView,
@@ -301,7 +301,7 @@ describe('getEsQueryFromSavedSearch()', () => {
})
).toEqual(undefined);
});
- it('return search data from saved search if neither query nor filter is provided ', () => {
+ it('return search data from discover view if neither query nor filter is provided ', () => {
expect(
getEsQueryFromSavedSearch({
dataView: mockDataView,
@@ -349,7 +349,7 @@ describe('getEsQueryFromSavedSearch()', () => {
searchString: 'responsetime > 49',
});
});
- it('should override original saved search with the provided query ', () => {
+ it('should override original discover view with the provided query ', () => {
expect(
getEsQueryFromSavedSearch({
dataView: mockDataView,
@@ -399,7 +399,7 @@ describe('getEsQueryFromSavedSearch()', () => {
});
});
- it('should override original saved search with the provided filters ', () => {
+ it('should override original discover view with the provided filters ', () => {
expect(
getEsQueryFromSavedSearch({
dataView: mockDataView,
diff --git a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts
index 04bc52bf08057..fcfcbda3e7d52 100644
--- a/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts
+++ b/x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.ts
@@ -29,7 +29,7 @@ import { isSavedSearchSavedObject, SavedSearchSavedObject } from '../../../../co
/**
* Parse the stringified searchSourceJSON
- * from a saved search or saved search object
+ * from a discover view or discover view object
*/
export function getQueryFromSavedSearchObject(savedSearch: SavedSearchSavedObject | SavedSearch) {
if (!isSavedSearchSavedObject(savedSearch)) {
@@ -47,12 +47,12 @@ export function getQueryFromSavedSearchObject(savedSearch: SavedSearchSavedObjec
})
: undefined;
- // Remove indexRefName because saved search might no longer be relevant
+ // Remove indexRefName because discover view might no longer be relevant
// if user modifies the query or filter
- // after opening a saved search
+ // after opening a discover view
if (parsed && Array.isArray(parsed.filter)) {
parsed.filter.forEach((f) => {
- // @ts-expect-error indexRefName does appear in meta for newly created saved search
+ // @ts-expect-error indexRefName does appear in meta for newly created discover view
f.meta.indexRefName = undefined;
});
}
@@ -113,7 +113,7 @@ function getSavedSearchSource(savedSearch: SavedSearch) {
}
/**
- * Extract query data from the saved search object
+ * Extract query data from the discover view object
* with overrides from the provided query data and/or filters
*/
export function getEsQueryFromSavedSearch({
@@ -138,9 +138,9 @@ export function getEsQueryFromSavedSearch({
const savedSearchSource = getSavedSearchSource(savedSearch);
- // If saved search has a search source with nested parent
- // e.g. a search coming from Dashboard saved search embeddable
- // which already combines both the saved search's original query/filters and the Dashboard's
+ // If discover view has a search source with nested parent
+ // e.g. a search coming from Dashboard discover view embeddable
+ // which already combines both the discover view's original query/filters and the Dashboard's
// then no need to process any further
if (savedSearchSource && savedSearchSource.getParent() !== undefined && userQuery) {
// Flattened query from search source may contain a clause that narrows the time range
@@ -162,7 +162,7 @@ export function getEsQueryFromSavedSearch({
};
}
- // If no saved search available, use user's query and filters
+ // If no discover view available, use user's query and filters
if (!savedSearch && userQuery) {
if (filterManager && userFilters) filterManager.addFilters(userFilters);
@@ -180,8 +180,8 @@ export function getEsQueryFromSavedSearch({
};
}
- // If saved search available, merge saved search with the latest user query or filters
- // which might differ from extracted saved search data
+ // If discover view available, merge discover view with the latest user query or filters
+ // which might differ from extracted discover view data
if (savedSearchSource) {
const globalFilters = filterManager?.getGlobalFilters();
// FIXME: Add support for AggregateQuery type #150091
diff --git a/x-pack/plugins/fleet/dev_docs/integrations_overview.md b/x-pack/plugins/fleet/dev_docs/integrations_overview.md
index b6ce0f5ce9917..98e2e65ea168e 100644
--- a/x-pack/plugins/fleet/dev_docs/integrations_overview.md
+++ b/x-pack/plugins/fleet/dev_docs/integrations_overview.md
@@ -143,7 +143,7 @@ Contains screenshots rendered on the integrations detail page for the integratio
## `kibana` directory
-Contains top level Kibana assets (dashboards, visualizations, saved searches etc) for the integration.
+Contains top level Kibana assets (dashboards, visualizations, discover viewes etc) for the integration.
## Relationship diagram
diff --git a/x-pack/plugins/fleet/public/applications/integrations/sections/epm/constants.tsx b/x-pack/plugins/fleet/public/applications/integrations/sections/epm/constants.tsx
index eea79a8f9df6b..4e5472926f3c3 100644
--- a/x-pack/plugins/fleet/public/applications/integrations/sections/epm/constants.tsx
+++ b/x-pack/plugins/fleet/public/applications/integrations/sections/epm/constants.tsx
@@ -48,7 +48,7 @@ export const AssetTitleMap: Record = {
defaultMessage: 'Component templates',
}),
search: i18n.translate('xpack.fleet.epm.assetTitles.savedSearches', {
- defaultMessage: 'Saved searches',
+ defaultMessage: 'Discover view',
}),
visualization: i18n.translate('xpack.fleet.epm.assetTitles.visualizations', {
defaultMessage: 'Visualizations',
diff --git a/x-pack/plugins/ml/common/constants/locator.ts b/x-pack/plugins/ml/common/constants/locator.ts
index 614c037c13026..b423983624354 100644
--- a/x-pack/plugins/ml/common/constants/locator.ts
+++ b/x-pack/plugins/ml/common/constants/locator.ts
@@ -28,7 +28,7 @@ export const ML_PAGES = {
DATA_VISUALIZER: 'datavisualizer',
/**
* Page: Data Visualizer
- * Open data visualizer by selecting a Kibana data view or saved search
+ * Open data visualizer by selecting a Kibana data view or discover view
*/
DATA_VISUALIZER_INDEX_SELECT: 'datavisualizer_index_select',
/**
diff --git a/x-pack/plugins/ml/public/application/contexts/ml/data_source_context.tsx b/x-pack/plugins/ml/public/application/contexts/ml/data_source_context.tsx
index 72d54f328209e..7c00b845cfc63 100644
--- a/x-pack/plugins/ml/public/application/contexts/ml/data_source_context.tsx
+++ b/x-pack/plugins/ml/public/application/contexts/ml/data_source_context.tsx
@@ -28,7 +28,7 @@ export const DataSourceContext = React.createContext(
);
/**
- * Context provider that resolves current data view and the saved search from the URL state.
+ * Context provider that resolves current data view and the discover view from the URL state.
*
* @param children
* @constructor
@@ -60,7 +60,7 @@ export const DataSourceContextProvider: FC = ({ children }) => {
);
/**
- * Resolve data view or saved search if exist in the URL.
+ * Resolve data view or discover view if exist in the URL.
*/
const resolveDataSource = useCallback(async () => {
if (dataViewId === '') {
@@ -118,7 +118,7 @@ export const DataSourceContextProvider: FC = ({ children }) => {
}
diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx
index d065ef84fa970..4fc0c065c08dd 100644
--- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx
+++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx
@@ -605,7 +605,7 @@ export const ConfigurationStepForm: FC = ({
{savedSearchQuery !== null && (
{i18n.translate('xpack.ml.dataframe.analytics.create.savedSearchLabel', {
- defaultMessage: 'Saved search',
+ defaultMessage: 'Discover view',
})}
)}
diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/use_saved_search.ts b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/use_saved_search.ts
index bb6867b62aac0..50c487b4ed6b9 100644
--- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/use_saved_search.ts
+++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/use_saved_search.ts
@@ -20,7 +20,7 @@ import { useMlKibana } from '../../../../../contexts/kibana';
import { useDataSource } from '../../../../../contexts/ml';
// `undefined` is used for a non-initialized state
-// `null` is set if no saved search is used
+// `null` is set if no discover view is used
export type SavedSearchQuery = Record | null | undefined;
export type SavedSearchQueryStr =
| string
diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.test.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.test.tsx
index c17490f4506d9..7f8b77d84e45e 100644
--- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.test.tsx
+++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.test.tsx
@@ -175,7 +175,7 @@ describe('Data Frame Analytics: ', () => {
});
});
- it('shows the error callout when clicking a saved search using a remote data view', async () => {
+ it('shows the error callout when clicking a discover view using a remote data view', async () => {
// prepare
render(
@@ -203,13 +203,13 @@ describe('Data Frame Analytics: ', () => {
).toBeInTheDocument();
expect(
screen.queryByText(
- `The saved search 'the-remote-saved-search-title' uses the data view 'my_remote_cluster:index-pattern-title'.`
+ `The discover view 'the-remote-saved-search-title' uses the data view 'my_remote_cluster:index-pattern-title'.`
)
).toBeInTheDocument();
expect(mockNavigateToPath).toHaveBeenCalledTimes(0);
});
- it('calls navigateToPath for a saved search using a plain data view ', async () => {
+ it('calls navigateToPath for a discover view using a plain data view ', async () => {
// prepare
render(
diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.tsx
index 9525042f6a47a..8306bd5a34d5f 100644
--- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.tsx
+++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/source_selection/source_selection.tsx
@@ -43,7 +43,7 @@ export const SourceSelection: FC = () => {
savedObject?: SavedObjectCommon
) => {
// Kibana data views including `:` are cross-cluster search indices
- // and are not supported by Data Frame Analytics yet. For saved searches
+ // and are not supported by Data Frame Analytics yet. For discover viewes
// and data views that use cross-cluster search we intercept
// the selection before redirecting and show an error callout instead.
let dataViewName = '';
@@ -58,13 +58,13 @@ export const SourceSelection: FC = () => {
})(id);
dataViewName = dataViewAndSavedSearch.dataView?.title ?? '';
} catch (error) {
- // an unexpected error has occurred. This could be caused by a saved search for which the data view no longer exists.
+ // an unexpected error has occurred. This could be caused by a discover view for which the data view no longer exists.
toastNotificationService.displayErrorToast(
error,
i18n.translate(
'xpack.ml.dataFrame.analytics.create.searchSelection.errorGettingDataViewTitle',
{
- defaultMessage: 'Error loading data view used by the saved search',
+ defaultMessage: 'Error loading data view used by the discover view',
}
)
);
@@ -79,7 +79,7 @@ export const SourceSelection: FC = () => {
i18n.translate(
'xpack.ml.dataFrame.analytics.create.searchSelection.CcsErrorCallOutBody',
{
- defaultMessage: `The saved search '{savedSearchTitle}' uses the data view '{dataViewName}'.`,
+ defaultMessage: `The discover view '{savedSearchTitle}' uses the data view '{dataViewName}'.`,
values: {
savedSearchTitle: getNestedProperty(savedObject, 'attributes.title'),
dataViewName,
@@ -128,7 +128,7 @@ export const SourceSelection: FC = () => {
noItemsMessage={i18n.translate(
'xpack.ml.dataFrame.analytics.create.searchSelection.notFoundLabel',
{
- defaultMessage: 'No matching indices or saved searches found.',
+ defaultMessage: 'No matching indices or discover viewes found.',
}
)}
savedObjectMetaData={[
@@ -138,7 +138,7 @@ export const SourceSelection: FC = () => {
name: i18n.translate(
'xpack.ml.dataFrame.analytics.create.searchSelection.savedObjectType.search',
{
- defaultMessage: 'Saved search',
+ defaultMessage: 'Discover view',
}
),
},
diff --git a/x-pack/plugins/ml/public/application/datavisualizer/data_drift/index_patterns_picker.tsx b/x-pack/plugins/ml/public/application/datavisualizer/data_drift/index_patterns_picker.tsx
index 18f3dcea8ae70..1311283fd4b2c 100644
--- a/x-pack/plugins/ml/public/application/datavisualizer/data_drift/index_patterns_picker.tsx
+++ b/x-pack/plugins/ml/public/application/datavisualizer/data_drift/index_patterns_picker.tsx
@@ -43,7 +43,7 @@ export const DataDriftIndexOrSearchRedirect: FC = () => {
@@ -52,7 +52,7 @@ export const DataDriftIndexOrSearchRedirect: FC = () => {
onChoose={onObjectSelection}
showFilter
noItemsMessage={i18n.translate('xpack.ml.newJob.wizard.searchSelection.notFoundLabel', {
- defaultMessage: 'No matching data views or saved searches found.',
+ defaultMessage: 'No matching data views or discover viewes found.',
})}
savedObjectMetaData={[
{
@@ -61,7 +61,7 @@ export const DataDriftIndexOrSearchRedirect: FC = () => {
name: i18n.translate(
'xpack.ml.newJob.wizard.searchSelection.savedObjectType.search',
{
- defaultMessage: 'Saved search',
+ defaultMessage: 'Discover view',
}
),
},
diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/common/json_editor_flyout/json_editor_flyout.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/common/json_editor_flyout/json_editor_flyout.tsx
index 5d4cbb1d422de..bf6fe07444749 100644
--- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/common/json_editor_flyout/json_editor_flyout.tsx
+++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/common/json_editor_flyout/json_editor_flyout.tsx
@@ -249,7 +249,7 @@ export const JsonEditorFlyout: FC = ({ isDisabled, jobEditorMode, datafee
>
diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx
index 1e30004453616..b3f2218b5a4fe 100644
--- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx
+++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/datafeed_step/components/data_view/change_data_view.tsx
@@ -154,7 +154,7 @@ export const ChangeDataViewModal: FC = ({ onClose }) => {
noItemsMessage={i18n.translate(
'xpack.ml.newJob.wizard.datafeedStep.dataView.step1.noMatchingError',
{
- defaultMessage: 'No matching indices or saved searches found.',
+ defaultMessage: 'No matching indices or discover viewes found.',
}
)}
savedObjectMetaData={[
diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/index_or_search/page.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/index_or_search/page.tsx
index 0a53ac7b4a81e..bf3acacc6d8ce 100644
--- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/index_or_search/page.tsx
+++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/index_or_search/page.tsx
@@ -41,7 +41,7 @@ export const Page: FC = ({ nextStepPath }) => {
@@ -50,7 +50,7 @@ export const Page: FC = ({ nextStepPath }) => {
onChoose={onObjectSelection}
showFilter
noItemsMessage={i18n.translate('xpack.ml.newJob.wizard.searchSelection.notFoundLabel', {
- defaultMessage: 'No matching data views or saved searches found.',
+ defaultMessage: 'No matching data views or discover viewes found.',
})}
savedObjectMetaData={[
{
@@ -59,7 +59,7 @@ export const Page: FC = ({ nextStepPath }) => {
name: i18n.translate(
'xpack.ml.newJob.wizard.searchSelection.savedObjectType.search',
{
- defaultMessage: 'Saved search',
+ defaultMessage: 'Discover view',
}
),
},
diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/job_type/page.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/job_type/page.tsx
index 0666681da6bbc..4c5976ac5e693 100644
--- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/job_type/page.tsx
+++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/job_type/page.tsx
@@ -76,7 +76,7 @@ export const Page: FC = () => {
const pageTitleLabel = selectedSavedSearch
? i18n.translate('xpack.ml.newJob.wizard.jobType.savedSearchPageTitleLabel', {
- defaultMessage: 'saved search {savedSearchTitle}',
+ defaultMessage: 'discover view {savedSearchTitle}',
values: { savedSearchTitle: selectedSavedSearch.title ?? '' },
})
: i18n.translate('xpack.ml.newJob.wizard.jobType.dataViewPageTitleLabel', {
@@ -261,7 +261,7 @@ export const Page: FC = () => {
diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/page.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/page.tsx
index 3090801cf2716..824b87ef0773f 100644
--- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/page.tsx
+++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/page.tsx
@@ -146,8 +146,8 @@ export const Page: FC = ({ existingJobsAndGroups, jobType }) => {
}
if (dataSourceContext.selectedSavedSearch !== null) {
- // Jobs created from saved searches cannot be cloned in the wizard as the
- // ML job config holds no reference to the saved search ID.
+ // Jobs created from discover viewes cannot be cloned in the wizard as the
+ // ML job config holds no reference to the discover view ID.
jobCreator.createdBy = null;
}
diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/wizard_steps.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/wizard_steps.tsx
index d05aa2f644abb..16daebf6d1f5f 100644
--- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/wizard_steps.tsx
+++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/wizard_steps.tsx
@@ -73,7 +73,7 @@ export const WizardSteps: FC = ({ currentStep, setCurrentStep }) => {
function getSummaryStepTitle() {
if (dataSourceContext.selectedSavedSearch) {
return i18n.translate('xpack.ml.newJob.wizard.stepComponentWrapper.summaryTitleSavedSearch', {
- defaultMessage: 'New job from saved search {title}',
+ defaultMessage: 'New job from discover view {title}',
values: { title: dataSourceContext.selectedSavedSearch.title ?? '' },
});
} else if (dataSourceContext.selectedDataView.id !== undefined) {
diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/recognize/page.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/recognize/page.tsx
index 1feab0193d087..9875bf9091e7e 100644
--- a/x-pack/plugins/ml/public/application/jobs/new_job/recognize/page.tsx
+++ b/x-pack/plugins/ml/public/application/jobs/new_job/recognize/page.tsx
@@ -91,7 +91,7 @@ export const Page: FC = ({ moduleId, existingGroupIds }) => {
const { selectedSavedSearch, selectedDataView: dataView, combinedQuery } = useDataSource();
const pageTitle = selectedSavedSearch
? i18n.translate('xpack.ml.newJob.recognize.savedSearchPageTitle', {
- defaultMessage: 'saved search {savedSearchTitle}',
+ defaultMessage: 'discover view {savedSearchTitle}',
values: { savedSearchTitle: selectedSavedSearch.title ?? '' },
})
: i18n.translate('xpack.ml.newJob.recognize.dataViewPageTitle', {
@@ -307,7 +307,7 @@ export const Page: FC = ({ moduleId, existingGroupIds }) => {
diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/utils/new_job_utils.test.ts b/x-pack/plugins/ml/public/application/jobs/new_job/utils/new_job_utils.test.ts
index 73410aa70f022..efc875b3fd09b 100644
--- a/x-pack/plugins/ml/public/application/jobs/new_job/utils/new_job_utils.test.ts
+++ b/x-pack/plugins/ml/public/application/jobs/new_job/utils/new_job_utils.test.ts
@@ -56,7 +56,7 @@ describe('createSearchItems', () => {
});
});
- test('should match saved search with kuery and condition', () => {
+ test('should match discover view with kuery and condition', () => {
const savedSearch = getSavedSearchMock({
highlightAll: true,
version: true,
@@ -82,7 +82,7 @@ describe('createSearchItems', () => {
});
});
- test('should match saved search with kuery and not condition', () => {
+ test('should match discover view with kuery and not condition', () => {
const savedSearch = getSavedSearchMock({
highlightAll: true,
version: true,
@@ -119,7 +119,7 @@ describe('createSearchItems', () => {
});
});
- test('should match saved search with kuery and condition and not condition', () => {
+ test('should match discover view with kuery and condition and not condition', () => {
const savedSearch = getSavedSearchMock({
highlightAll: true,
version: true,
@@ -149,7 +149,7 @@ describe('createSearchItems', () => {
});
});
- test('should match saved search with kuery and filter', () => {
+ test('should match discover view with kuery and filter', () => {
const savedSearch = getSavedSearchMock({
highlightAll: true,
version: true,
diff --git a/x-pack/plugins/ml/public/application/services/new_job_capabilities/load_new_job_capabilities.ts b/x-pack/plugins/ml/public/application/services/new_job_capabilities/load_new_job_capabilities.ts
index 63d6150f3402f..e305aebdb8634 100644
--- a/x-pack/plugins/ml/public/application/services/new_job_capabilities/load_new_job_capabilities.ts
+++ b/x-pack/plugins/ml/public/application/services/new_job_capabilities/load_new_job_capabilities.ts
@@ -35,15 +35,15 @@ export function loadNewJobCapabilities(
await serviceToUse.initializeFromDataVIew(dataView);
resolve(serviceToUse.newJobCaps);
} else if (savedSearchId !== undefined) {
- // saved search is being used
- // load the data view from the saved search
+ // discover view is being used
+ // load the data view from the discover view
const { dataView } = await getDataViewAndSavedSearchCallback({
savedSearchService,
dataViewsService,
})(savedSearchId);
if (dataView === null) {
// eslint-disable-next-line no-console
- console.error('Cannot retrieve data view from saved search');
+ console.error('Cannot retrieve data view from discover view');
reject();
return;
}
diff --git a/x-pack/plugins/ml/public/locator/ml_locator.test.ts b/x-pack/plugins/ml/public/locator/ml_locator.test.ts
index ab2d89dee2106..d0f5f37bf6f9d 100644
--- a/x-pack/plugins/ml/public/locator/ml_locator.test.ts
+++ b/x-pack/plugins/ml/public/locator/ml_locator.test.ts
@@ -290,7 +290,7 @@ describe('ML locator', () => {
});
});
- it('should generate valid URL for the Index Data Visualizer select data view or saved search page', async () => {
+ it('should generate valid URL for the Index Data Visualizer select data view or discover view page', async () => {
const location = await definition.getLocation({
page: ML_PAGES.DATA_VISUALIZER_INDEX_SELECT,
});
diff --git a/x-pack/plugins/ml/server/models/data_recognizer/data_recognizer.ts b/x-pack/plugins/ml/server/models/data_recognizer/data_recognizer.ts
index 635638d51f303..7aa118e01223d 100644
--- a/x-pack/plugins/ml/server/models/data_recognizer/data_recognizer.ts
+++ b/x-pack/plugins/ml/server/models/data_recognizer/data_recognizer.ts
@@ -1215,7 +1215,7 @@ export class DataRecognizer {
}
}
- // check the kibana saved searches JSON in the module to see if they contain INDEX_PATTERN_ID
+ // check the kibana discover viewes JSON in the module to see if they contain INDEX_PATTERN_ID
// which needs replacement
private _doSavedObjectsContainIndexPatternId(moduleConfig: Module) {
if (moduleConfig.kibana) {
diff --git a/x-pack/plugins/observability_solution/logs_explorer/public/state_machines/log_explorer_controller/src/services/data_view_service.ts b/x-pack/plugins/observability_solution/logs_explorer/public/state_machines/log_explorer_controller/src/services/data_view_service.ts
index 76ac9c0c82f23..0870057003571 100644
--- a/x-pack/plugins/observability_solution/logs_explorer/public/state_machines/log_explorer_controller/src/services/data_view_service.ts
+++ b/x-pack/plugins/observability_solution/logs_explorer/public/state_machines/log_explorer_controller/src/services/data_view_service.ts
@@ -20,7 +20,7 @@ export const createAndSetDataView =
* We can't fully rely on the url update of the index param to create and restore the data view
* due to a race condition where Discover, when initializing its internal logic,
* check the value the index params before it gets updated in the line above.
- * In case the index param does not exist, it then create a internal saved search and set the current data view
+ * In case the index param does not exist, it then create a internal discover view and set the current data view
* to the existing one or the default logs-*.
* We set explicitly the data view here to be used when restoring the data view on the initial load.
*/
diff --git a/x-pack/plugins/rollup/server/collectors/helpers.test.ts b/x-pack/plugins/rollup/server/collectors/helpers.test.ts
index d1ecfe1aa5980..ba82892943d40 100644
--- a/x-pack/plugins/rollup/server/collectors/helpers.test.ts
+++ b/x-pack/plugins/rollup/server/collectors/helpers.test.ts
@@ -139,7 +139,7 @@ describe('rollupUsageCollectorHelpers', () => {
expect(result).toStrictEqual([]);
});
- it('Returns the saved search if exists', async () => {
+ it('Returns the discover view if exists', async () => {
const result = await fetchRollupSavedSearches(
mockIndex,
getMockCallCluster(defaultMockRollupSavedSearchSavedObjects),
diff --git a/x-pack/plugins/rollup/server/collectors/register.test.ts b/x-pack/plugins/rollup/server/collectors/register.test.ts
index bcb026714dab5..7b8e3f27a8b66 100644
--- a/x-pack/plugins/rollup/server/collectors/register.test.ts
+++ b/x-pack/plugins/rollup/server/collectors/register.test.ts
@@ -39,7 +39,7 @@ describe('registerRollupUsageCollector', () => {
total: {
type: 'long',
_meta: {
- description: 'Counts all the rollup saved searches',
+ description: 'Counts all the rollup discover viewes',
},
},
},
@@ -49,14 +49,14 @@ describe('registerRollupUsageCollector', () => {
type: 'long',
_meta: {
description:
- 'Counts all the visualizations that are based on rollup saved searches',
+ 'Counts all the visualizations that are based on rollup discover viewes',
},
},
lens_total: {
type: 'long',
_meta: {
description:
- 'Counts all the lens visualizations that are based on rollup saved searches',
+ 'Counts all the lens visualizations that are based on rollup discover viewes',
},
},
},
diff --git a/x-pack/plugins/rollup/server/collectors/register.ts b/x-pack/plugins/rollup/server/collectors/register.ts
index 6c893e058f0e7..13a0d8ea53c09 100644
--- a/x-pack/plugins/rollup/server/collectors/register.ts
+++ b/x-pack/plugins/rollup/server/collectors/register.ts
@@ -56,7 +56,7 @@ export function registerRollupUsageCollector(
total: {
type: 'long',
_meta: {
- description: 'Counts all the rollup saved searches',
+ description: 'Counts all the rollup discover viewes',
},
},
},
@@ -65,14 +65,14 @@ export function registerRollupUsageCollector(
total: {
type: 'long',
_meta: {
- description: 'Counts all the visualizations that are based on rollup saved searches',
+ description: 'Counts all the visualizations that are based on rollup discover viewes',
},
},
lens_total: {
type: 'long',
_meta: {
description:
- 'Counts all the lens visualizations that are based on rollup saved searches',
+ 'Counts all the lens visualizations that are based on rollup discover viewes',
},
},
},
diff --git a/x-pack/plugins/security_solution/common/types/timeline/store.ts b/x-pack/plugins/security_solution/common/types/timeline/store.ts
index 433e3d934344f..56bf4524cdd51 100644
--- a/x-pack/plugins/security_solution/common/types/timeline/store.ts
+++ b/x-pack/plugins/security_solution/common/types/timeline/store.ts
@@ -59,7 +59,7 @@ export interface TimelinePersistInput {
templateTimelineVersion?: number | null;
title?: string;
updated?: number;
- /* used to saved discover Saved search Id */
+ /* used to saved discover Discover view Id */
savedSearchId?: string | null;
}
diff --git a/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.test.tsx b/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.test.tsx
index b2d1ac052a1e0..d987015fe093c 100644
--- a/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.test.tsx
+++ b/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.test.tsx
@@ -118,7 +118,7 @@ const customFilter = {
const originalSavedSearchMock = {
id: 'the-saved-search-id',
- title: 'A saved search',
+ title: 'A discover view',
breakdownField: 'customBreakDownField',
searchSource: createSearchSourceMock({
index: dataViewMock,
@@ -156,7 +156,7 @@ describe('useDiscoverInTimelineActions', () => {
jest.clearAllMocks();
});
describe('getAppStateFromSavedSearch', () => {
- it('should reach out to discover to convert app state from saved search', async () => {
+ it('should reach out to discover to convert app state from discover view', async () => {
const { result, waitFor } = renderTestHook();
const { appState } = result.current.getAppStateFromSavedSearch(savedSearchMock);
await waitFor(() => {
@@ -230,7 +230,7 @@ describe('useDiscoverInTimelineActions', () => {
});
});
describe('updateSavedSearch', () => {
- it('should add defaults to the savedSearch before updating saved search', async () => {
+ it('should add defaults to the savedSearch before updating discover view', async () => {
const { result } = renderTestHook();
await act(async () => {
await result.current.updateSavedSearch(savedSearchMock, TimelineId.active);
@@ -251,7 +251,7 @@ describe('useDiscoverInTimelineActions', () => {
})
);
});
- it('should initialize saved search when it is not set on the timeline model yet', async () => {
+ it('should initialize discover view when it is not set on the timeline model yet', async () => {
const localMockState: State = {
...mockGlobalState,
timeline: {
@@ -283,7 +283,7 @@ describe('useDiscoverInTimelineActions', () => {
);
});
- it('should update saved search when it has changes', async () => {
+ it('should update discover view when it has changes', async () => {
const changedSavedSearchMock = { ...savedSearchMock, title: 'changed' };
const localMockState: State = {
...mockGlobalState,
@@ -317,6 +317,6 @@ describe('useDiscoverInTimelineActions', () => {
);
});
- it('should raise appropriate notification in case of any error in saving discover saved search', () => {});
+ it('should raise appropriate notification in case of any error in saving discover discover view', () => {});
});
});
diff --git a/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.tsx b/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.tsx
index e13788b8f7f07..8ca9a5465634f 100644
--- a/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.tsx
+++ b/x-pack/plugins/security_solution/public/common/components/discover_in_timeline/use_discover_in_timeline_actions.tsx
@@ -146,7 +146,7 @@ export const useDiscoverInTimelineActions = (
async (savedSearch: SavedSearch, savedSearchOption: SaveSavedSearchOptions) => {
if (!discoverStateContainer) {
// eslint-disable-next-line no-console
- console.log(`Saved search is not open since state container is null`);
+ console.log(`Discover view is not open since state container is null`);
return;
}
if (!savedSearch) return;
@@ -182,7 +182,7 @@ export const useDiscoverInTimelineActions = (
savedSearch.timeRange ?? discoverDataService.query.timefilter.timefilter.getTime();
savedSearch.tags = ['security-solution-default'];
- // If there is already a saved search, only update the local state
+ // If there is already a discover view, only update the local state
if (savedSearchId) {
savedSearch.id = savedSearchId;
if (!timelineRef.current.savedSearch) {
@@ -203,9 +203,9 @@ export const useDiscoverInTimelineActions = (
);
}
} else {
- // If no saved search exists. Create a new saved search instance and associate it with the timeline.
+ // If no discover view exists. Create a new discover view instance and associate it with the timeline.
try {
- // Make sure we're not creating a saved search while a previous creation call is in progress
+ // Make sure we're not creating a discover view while a previous creation call is in progress
if (status !== 'idle') {
return;
}
@@ -229,7 +229,7 @@ export const useDiscoverInTimelineActions = (
savedSearchId: response.id,
})
);
- // Also save the timeline, this will only happen once, in case there is no saved search id yet
+ // Also save the timeline, this will only happen once, in case there is no discover view id yet
dispatch(timelineActions.saveTimeline({ id: TimelineId.active, saveAsNew: false }));
}
} catch (err) {
diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.test.tsx b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.test.tsx
index 770f9281234ee..e4ee19335c3ba 100644
--- a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.test.tsx
+++ b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.test.tsx
@@ -29,9 +29,9 @@ describe('Discover Tab Content', () => {
});
// issue for enabling below tests: https://github.com/elastic/kibana/issues/165913
- it.skip('should load saved search when a saved timeline is restored', () => {});
+ it.skip('should load discover view when a saved timeline is restored', () => {});
it.skip('should reset the discover state when new timeline is created', () => {});
- it.skip('should update saved search if timeline title and description are updated', () => {});
- it.skip('should should not update saved search if the fetched saved search is same as discover updated saved search', () => {});
- it.skip('should update saved search if discover time is update', () => {});
+ it.skip('should update discover view if timeline title and description are updated', () => {});
+ it.skip('should should not update discover view if the fetched discover view is same as discover updated discover view', () => {});
+ it.skip('should update discover view if discover time is update', () => {});
});
diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.tsx b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.tsx
index 385225568ac93..68a08a817671e 100644
--- a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.tsx
+++ b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/index.tsx
@@ -124,7 +124,7 @@ export const DiscoverTabContent: FC = ({ timelineId })
useEffect(() => {
if (isFetching) return; // no-op is fetch is in progress
- if (isDiscoverSavedSearchLoaded) return; // no-op if saved search has been already loaded
+ if (isDiscoverSavedSearchLoaded) return; // no-op if discover view has been already loaded
if (!savedSearchById) {
// nothing to restore if savedSearchById is null
if (status === 'draft') {
@@ -188,7 +188,7 @@ export const DiscoverTabContent: FC = ({ timelineId })
const latestState = getCombinedDiscoverSavedSearchState();
const index = latestState?.searchSource.getField('index');
/* when a new timeline is loaded, a new discover instance is loaded which first emits
- * discover's initial state which is then updated in the saved search. We want to avoid that.*/
+ * discover's initial state which is then updated in the discover view. We want to avoid that.*/
if (!index) return;
if (!latestState || combinedDiscoverSavedSearchStateRef.current === latestState) return;
if (isEqualWith(latestState, savedSearchById, savedSearchComparator)) return;
@@ -250,7 +250,7 @@ export const DiscoverTabContent: FC = ({ timelineId })
const hasESQLURlState = urlAppState?.query && 'esql' in urlAppState.query;
/*
- * Url state should NOT apply if there is already a saved search being loaded
+ * Url state should NOT apply if there is already a discover view being loaded
* */
const shouldApplyESQLUrlState = !savedSearchAppState?.appState && hasESQLURlState;
diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/translations.ts b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/translations.ts
index e97da8b29c65e..4388accb38122 100644
--- a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/translations.ts
+++ b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/translations.ts
@@ -9,6 +9,6 @@ import { i18n } from '@kbn/i18n';
export const GET_TIMELINE_DISCOVER_SAVED_SEARCH_TITLE = (title: string) =>
i18n.translate('xpack.securitySolution.timelines.discoverInTimeline.savedSearchTitle', {
- defaultMessage: 'Saved search for timeline - {title}',
+ defaultMessage: 'Discover view for timeline - {title}',
values: { title },
});
diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/utils/index.test.ts b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/utils/index.test.ts
index df4508a935317..599febf00294a 100644
--- a/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/utils/index.test.ts
+++ b/x-pack/plugins/security_solution/public/timelines/components/timeline/esql_tab_content/utils/index.test.ts
@@ -31,7 +31,7 @@ describe('savedSearchComparator', () => {
managed: false,
};
- it('should result true when saved search is same', () => {
+ it('should result true when discover view is same', () => {
const result = savedSearchComparator(mockSavedSearch, { ...mockSavedSearch });
expect(result).toBe(true);
});
diff --git a/x-pack/plugins/security_solution/public/timelines/containers/api.test.ts b/x-pack/plugins/security_solution/public/timelines/containers/api.test.ts
index e6238d462e3c3..c7668357dc477 100644
--- a/x-pack/plugins/security_solution/public/timelines/containers/api.test.ts
+++ b/x-pack/plugins/security_solution/public/timelines/containers/api.test.ts
@@ -505,7 +505,7 @@ describe('copyTimeline', () => {
});
});
- it('creates a new saved search when a saved search object is passed', async () => {
+ it('creates a new discover view when a discover view object is passed', async () => {
await api.copyTimeline({
timelineId: 'test',
timeline: {
@@ -523,7 +523,7 @@ describe('copyTimeline', () => {
})
);
- // The new saved search id is sent to the server
+ // The new discover view id is sent to the server
expect(postMock).toHaveBeenCalledWith(
TIMELINE_COPY_URL,
expect.objectContaining({
@@ -544,7 +544,7 @@ describe('copyTimeline', () => {
savedSearch: mockSavedSearch,
});
- // The new saved search id is sent to the server
+ // The new discover view id is sent to the server
expect(postMock).toHaveBeenCalledWith(
TIMELINE_COPY_URL,
expect.objectContaining({
@@ -553,7 +553,7 @@ describe('copyTimeline', () => {
);
});
- it('does not save a saved search for timelines without `savedSearchId`', async () => {
+ it('does not save a discover view for timelines without `savedSearchId`', async () => {
jest.clearAllMocks();
await api.copyTimeline({
diff --git a/x-pack/plugins/security_solution/public/timelines/containers/api.ts b/x-pack/plugins/security_solution/public/timelines/containers/api.ts
index 4b1c106230fdd..956bfdc1473e3 100644
--- a/x-pack/plugins/security_solution/public/timelines/containers/api.ts
+++ b/x-pack/plugins/security_solution/public/timelines/containers/api.ts
@@ -152,7 +152,7 @@ const patchTimeline = async ({
});
}
} catch (e) {
- return Promise.reject(new Error(`Failed to copy saved search: ${timeline.savedSearchId}`));
+ return Promise.reject(new Error(`Failed to copy discover view: ${timeline.savedSearchId}`));
}
try {
@@ -187,7 +187,7 @@ export const copyTimeline = async ({
if (timeline.savedSearchId && savedSearch) {
const { savedSearch: savedSearchService } = KibanaServices.get();
const savedSearchCopy = { ...savedSearch };
- // delete the id and change the title to make sure we can copy the saved search
+ // delete the id and change the title to make sure we can copy the discover view
delete savedSearchCopy.id;
newSavedSearchId = await savedSearchService.save(savedSearchCopy, {
onTitleDuplicate: () => ({}),
@@ -195,7 +195,7 @@ export const copyTimeline = async ({
});
}
} catch (e) {
- return Promise.reject(new Error(`Failed to copy saved search: ${timeline.savedSearchId}`));
+ return Promise.reject(new Error(`Failed to copy discover view: ${timeline.savedSearchId}`));
}
try {
diff --git a/x-pack/plugins/security_solution/public/timelines/store/model.ts b/x-pack/plugins/security_solution/public/timelines/store/model.ts
index 0bd6f4806f06b..56da132a4b152 100644
--- a/x-pack/plugins/security_solution/public/timelines/store/model.ts
+++ b/x-pack/plugins/security_solution/public/timelines/store/model.ts
@@ -134,9 +134,9 @@ export interface TimelineModel {
isSelectAllChecked: boolean;
isLoading: boolean;
selectAll: boolean;
- /* discover saved search Id */
+ /* discover discover view Id */
savedSearchId: string | null;
- /* local saved search object, it's not sent to the server */
+ /* local discover view object, it's not sent to the server */
savedSearch: SavedSearch | null;
isDiscoverSavedSearchLoaded?: boolean;
isDataProviderVisible: boolean;
diff --git a/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_mode_control.tsx b/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_mode_control.tsx
index 223a21f248f7d..ae81b91fae7d0 100644
--- a/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_mode_control.tsx
+++ b/x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_mode_control.tsx
@@ -80,7 +80,7 @@ const includeRelated = {
'xpack.spaces.management.copyToSpace.copyModeControl.includeRelated.text',
{
defaultMessage:
- 'Copy this object and its related objects. For dashboards, related visualizations, index patterns, and saved searches are also copied.',
+ 'Copy this object and its related objects. For dashboards, related visualizations, index patterns, and discover viewes are also copied.',
}
),
};
diff --git a/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json b/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json
index d6840a2267d7b..2b7d9f9d82fdc 100644
--- a/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json
+++ b/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json
@@ -12312,7 +12312,7 @@
"total": {
"type": "long",
"_meta": {
- "description": "Counts all the rollup saved searches"
+ "description": "Counts all the rollup discover viewes"
}
}
}
@@ -12324,13 +12324,13 @@
"total": {
"type": "long",
"_meta": {
- "description": "Counts all the visualizations that are based on rollup saved searches"
+ "description": "Counts all the visualizations that are based on rollup discover viewes"
}
},
"lens_total": {
"type": "long",
"_meta": {
- "description": "Counts all the lens visualizations that are based on rollup saved searches"
+ "description": "Counts all the lens visualizations that are based on rollup discover viewes"
}
}
}
diff --git a/x-pack/plugins/transform/common/constants.ts b/x-pack/plugins/transform/common/constants.ts
index 8ee030b2a953d..aab1b8485a25c 100644
--- a/x-pack/plugins/transform/common/constants.ts
+++ b/x-pack/plugins/transform/common/constants.ts
@@ -67,7 +67,7 @@ export const TRANSFORM_REACT_QUERY_KEYS = {
// - dest index: monitor (applied to df-*)
// - cluster: monitor, read_pipeline
//
-// Note that users with kibana_admin can see all Kibana data views and saved searches
+// Note that users with kibana_admin can see all Kibana data views and discover viewes
// in the source selection modal when creating a transform, but the wizard will trigger
// error callouts when there are no sufficient privileges to read the actual source indices.
diff --git a/x-pack/plugins/transform/public/app/hooks/use_search_items/use_search_items.ts b/x-pack/plugins/transform/public/app/hooks/use_search_items/use_search_items.ts
index f2a59e0cb1a61..824bb31554dce 100644
--- a/x-pack/plugins/transform/public/app/hooks/use_search_items/use_search_items.ts
+++ b/x-pack/plugins/transform/public/app/hooks/use_search_items/use_search_items.ts
@@ -39,7 +39,7 @@ export const useSearchItems = (defaultSavedObjectId: string | undefined) => {
}
try {
- // If data view already found, no need to get saved search
+ // If data view already found, no need to get discover view
if (!fetchedDataView) {
fetchedSavedSearch = await appDeps.savedSearch.get(id);
}
@@ -51,7 +51,7 @@ export const useSearchItems = (defaultSavedObjectId: string | undefined) => {
if (!isDataView(fetchedDataView) && fetchedSavedSearch === undefined) {
setError(
i18n.translate('xpack.transform.searchItems.errorInitializationTitle', {
- defaultMessage: `An error occurred initializing the Kibana data view or saved search.`,
+ defaultMessage: `An error occurred initializing the Kibana data view or discover view.`,
})
);
return;
diff --git a/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx b/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx
index 246460d11d3ee..815afd5b3d9a2 100644
--- a/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx
+++ b/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx
@@ -364,7 +364,7 @@ export const StepDefineForm: FC = React.memo((props) => {
label={
searchItems?.savedSearch?.id !== undefined
? i18n.translate('xpack.transform.stepDefineForm.savedSearchLabel', {
- defaultMessage: 'Saved search',
+ defaultMessage: 'Discover view',
})
: i18n.translate('xpack.transform.stepDefineForm.searchFilterLabel', {
defaultMessage: 'Search filter',
diff --git a/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_summary.tsx b/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_summary.tsx
index b4c5c5fb8a7ce..d99fc37602b06 100644
--- a/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_summary.tsx
+++ b/x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_summary.tsx
@@ -143,7 +143,7 @@ export const StepDefineSummary: FC = ({
{searchItems.savedSearch !== undefined && searchItems.savedSearch.id !== undefined && (
{searchItems.savedSearch.title}
diff --git a/x-pack/plugins/transform/public/app/sections/transform_management/components/search_selection/search_selection.tsx b/x-pack/plugins/transform/public/app/sections/transform_management/components/search_selection/search_selection.tsx
index 3c6fcc67f0c7e..af91a95dbb627 100644
--- a/x-pack/plugins/transform/public/app/sections/transform_management/components/search_selection/search_selection.tsx
+++ b/x-pack/plugins/transform/public/app/sections/transform_management/components/search_selection/search_selection.tsx
@@ -51,7 +51,7 @@ export const SearchSelection: FC = ({
noItemsMessage={i18n.translate(
'xpack.transform.newTransform.searchSelection.notFoundLabel',
{
- defaultMessage: 'No matching indices or saved searches found.',
+ defaultMessage: 'No matching indices or discover viewes found.',
}
)}
savedObjectMetaData={[
@@ -61,7 +61,7 @@ export const SearchSelection: FC = ({
name: i18n.translate(
'xpack.transform.newTransform.searchSelection.savedObjectType.search',
{
- defaultMessage: 'Saved search',
+ defaultMessage: 'Discover view',
}
),
},
diff --git a/x-pack/plugins/transform/readme.md b/x-pack/plugins/transform/readme.md
index e86d92340bf0c..27ea2730d1a24 100644
--- a/x-pack/plugins/transform/readme.md
+++ b/x-pack/plugins/transform/readme.md
@@ -118,7 +118,7 @@ With PATH_TO_CONFIG and other options as follows.
Group | PATH_TO_CONFIG
----- | --------------
creation - index pattern | `test/functional/apps/transform/creation/index_pattern/config.ts`
- creation - runtime mappings, saved searches | `test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts`
+ creation - runtime mappings, discover viewes | `test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts`
edit, clone | `test/functional/apps/transform/edit_clone/config.ts`
feature controls | `test/functional/apps/transform/feature_controls/config.ts`
permissions | `test/functional/apps/transform/permissions/config.ts`
@@ -129,7 +129,7 @@ With PATH_TO_CONFIG and other options as follows.
Group | PATH_TO_CONFIG
----- | --------------
creation - index pattern | `test/functional_basic/apps/transform/creation/index_pattern/config.ts`
- creation - runtime mappings, saved searches | `test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts`
+ creation - runtime mappings, discover viewes | `test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts`
edit, clone | `test/functional_basic/apps/transform/edit_clone/config.ts`
feature controls | `test/functional_basic/apps/transform/feature_controls/config.ts`
permissions | `test/functional_basic/apps/transform/permissions/config.ts`
diff --git a/x-pack/plugins/watcher/common/lib/serialization/serialization_helpers/build_input.js b/x-pack/plugins/watcher/common/lib/serialization/serialization_helpers/build_input.js
index 5146099010ccf..eee40e8b0020b 100644
--- a/x-pack/plugins/watcher/common/lib/serialization/serialization_helpers/build_input.js
+++ b/x-pack/plugins/watcher/common/lib/serialization/serialization_helpers/build_input.js
@@ -35,7 +35,7 @@ function buildRange(timeWindowSize, timeWindowUnit, timeField) {
watch.input.search.request.body.query
*/
function buildQuery(timeWindowSize, timeWindowUnit, timeField) {
- //TODO: This is where a saved search would be applied
+ //TODO: This is where a discover view would be applied
return {
bool: {
filter: {
diff --git a/x-pack/test/functional/apps/aiops/log_rate_analysis.ts b/x-pack/test/functional/apps/aiops/log_rate_analysis.ts
index 4bb1393b5c910..a6d4006f52572 100644
--- a/x-pack/test/functional/apps/aiops/log_rate_analysis.ts
+++ b/x-pack/test/functional/apps/aiops/log_rate_analysis.ts
@@ -27,7 +27,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await elasticChart.setNewChartUiDebugFlag(true);
await ml.testExecution.logTestStep(
- `${testData.suiteTitle} loads the saved search selection page`
+ `${testData.suiteTitle} loads the discover view selection page`
);
await aiops.logRateAnalysisPage.navigateToDataViewSelection();
diff --git a/x-pack/test/functional/apps/canvas/embeddables/saved_search.ts b/x-pack/test/functional/apps/canvas/embeddables/saved_search.ts
index 59285140672c6..b9fb8aefea842 100644
--- a/x-pack/test/functional/apps/canvas/embeddables/saved_search.ts
+++ b/x-pack/test/functional/apps/canvas/embeddables/saved_search.ts
@@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const dashboardAddPanel = getService('dashboardAddPanel');
const dashboardPanelActions = getService('dashboardPanelActions');
- describe('saved search in canvas', function () {
+ describe('discover view in canvas', function () {
before(async () => {
await kibanaServer.savedObjects.cleanStandardList();
await kibanaServer.importExport.load(
@@ -24,7 +24,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.canvas.goToListingPage();
// create new workpad
await PageObjects.canvas.createNewWorkpad();
- await PageObjects.canvas.setWorkpadName('saved search tests');
+ await PageObjects.canvas.setWorkpadName('discover view tests');
});
after(async () => {
@@ -32,17 +32,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
describe('by-reference', () => {
- it('adds existing saved search embeddable from the visualize library', async () => {
+ it('adds existing discover view embeddable from the visualize library', async () => {
await PageObjects.canvas.clickAddFromLibrary();
await dashboardAddPanel.addSavedSearch('Rendering-Test:-saved-search');
await testSubjects.existOrFail('embeddablePanelHeading-RenderingTest:savedsearch');
});
- it('edits saved search by-reference embeddable', async () => {
- await dashboardPanelActions.editPanelByTitle('Rendering Test: saved search');
- await PageObjects.discover.saveSearch('Rendering Test: saved search v2');
+ it('edits discover view by-reference embeddable', async () => {
+ await dashboardPanelActions.editPanelByTitle('Rendering Test: discover view');
+ await PageObjects.discover.saveSearch('Rendering Test: discover view v2');
await PageObjects.canvas.goToListingPage();
- await PageObjects.canvas.loadFirstWorkpad('saved search tests');
+ await PageObjects.canvas.loadFirstWorkpad('discover view tests');
await testSubjects.existOrFail('embeddablePanelHeading-RenderingTest:savedsearchv2');
});
});
diff --git a/x-pack/test/functional/apps/dashboard/group2/_async_dashboard.ts b/x-pack/test/functional/apps/dashboard/group2/_async_dashboard.ts
index 66b31842df00a..a6dec009b9b59 100644
--- a/x-pack/test/functional/apps/dashboard/group2/_async_dashboard.ts
+++ b/x-pack/test/functional/apps/dashboard/group2/_async_dashboard.ts
@@ -185,7 +185,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
log.debug('Checking charts rendered');
await elasticChart.waitForRenderComplete('xyVisChart');
- log.debug('Checking saved searches rendered');
+ log.debug('Checking discover viewes rendered');
await dashboardExpect.savedSearchRowCount(10);
log.debug('Checking input controls rendered');
await dashboardExpect.controlCount(3);
diff --git a/x-pack/test/functional/apps/dashboard/group2/dashboard_search_by_value.ts b/x-pack/test/functional/apps/dashboard/group2/dashboard_search_by_value.ts
index 92cc910313615..207c15c1b5f19 100644
--- a/x-pack/test/functional/apps/dashboard/group2/dashboard_search_by_value.ts
+++ b/x-pack/test/functional/apps/dashboard/group2/dashboard_search_by_value.ts
@@ -18,7 +18,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'timePicker', 'discover']);
- describe('saved searches by value', () => {
+ describe('discover viewes by value', () => {
before(async () => {
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data');
@@ -55,7 +55,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(rows.length).to.be.above(0);
};
- it('should allow cloning a by ref saved search embeddable to a by value embeddable', async () => {
+ it('should allow cloning a by ref discover view embeddable to a by value embeddable', async () => {
await addSearchEmbeddableToDashboard();
let panels = await testSubjects.findAll(`embeddablePanel`);
expect(panels.length).to.be(1);
@@ -84,7 +84,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
).to.be(false);
});
- it('should allow unlinking a by ref saved search embeddable from library', async () => {
+ it('should allow unlinking a by ref discover view embeddable from library', async () => {
await addSearchEmbeddableToDashboard();
let panels = await testSubjects.findAll(`embeddablePanel`);
expect(panels.length).to.be(1);
diff --git a/x-pack/test/functional/apps/dashboard/group3/reporting/__snapshots__/download_csv.snap b/x-pack/test/functional/apps/dashboard/group3/reporting/__snapshots__/download_csv.snap
index 126947dd748b1..ede6d7d1e3113 100644
--- a/x-pack/test/functional/apps/dashboard/group3/reporting/__snapshots__/download_csv.snap
+++ b/x-pack/test/functional/apps/dashboard/group3/reporting/__snapshots__/download_csv.snap
@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
-exports[`dashboard Reporting Download CSV Default Saved Search Data Download CSV export of a saved search panel 1`] = `
+exports[`dashboard Reporting Download CSV Default Saved Search Data Download CSV export of a discover view panel 1`] = `
"\\"order_date\\",category,currency,\\"customer_id\\",\\"order_id\\",\\"day_of_week_i\\",\\"products.created_on\\",sku
\\"Jun 22, 2019 @ 00:00:00.000\\",\\"Women's Clothing, Women's Shoes\\",EUR,27,731788,6,\\"Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000\\",\\"ZO0486004860, ZO0177901779, ZO0680506805, ZO0340503405\\"
\\"Jun 22, 2019 @ 00:00:00.000\\",\\"Women's Accessories, Women's Shoes\\",EUR,17,730663,6,\\"Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000\\",\\"ZO0697406974, ZO0370303703, ZO0368103681, ZO0013800138\\"
@@ -460,7 +460,7 @@ exports[`dashboard Reporting Download CSV Default Saved Search Data Download CSV
"
`;
-exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a filtered CSV export of a saved search panel 1`] = `
+exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a filtered CSV export of a discover view panel 1`] = `
"\\"order_date\\",category,currency,\\"customer_id\\",\\"order_id\\",\\"day_of_week_i\\",\\"products.created_on\\",sku
\\"Jun 22, 2019 @ 00:00:00.000\\",\\"Men's Clothing, Men's Shoes\\",EUR,13,715752,6,\\"Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000\\",\\"ZO0130801308, ZO0402604026, ZO0630506305, ZO0297402974\\"
\\"Jun 22, 2019 @ 00:00:00.000\\",\\"Men's Shoes, Men's Clothing\\",EUR,50,565284,6,\\"Dec 11, 2016 @ 00:00:00.000, Dec 11, 2016 @ 00:00:00.000\\",\\"ZO0687206872, ZO0422304223\\"
@@ -562,7 +562,7 @@ exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a
"
`;
-exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a saved search panel with a custom time range that does not intersect with dashboard time range 1`] = `
+exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a discover view panel with a custom time range that does not intersect with dashboard time range 1`] = `
"\\"order_date\\",category,currency,\\"customer_id\\",\\"order_id\\",\\"day_of_week_i\\",\\"products.created_on\\",sku
\\"Jun 15, 2019 @ 00:00:00.000\\",\\"Women's Clothing, Women's Shoes\\",EUR,27,732985,6,\\"Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000\\",\\"ZO0048100481, ZO0133401334, ZO0153201532, ZO0381603816\\"
\\"Jun 15, 2019 @ 00:00:00.000\\",\\"Women's Accessories, Women's Clothing, Women's Shoes\\",EUR,5,731613,6,\\"Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000, Dec 4, 2016 @ 00:00:00.000\\",\\"ZO0203502035, ZO0706807068, ZO0072000720, ZO0011200112\\"
@@ -707,13 +707,13 @@ exports[`dashboard Reporting Download CSV Default Saved Search Data Downloads a
"
`;
-exports[`dashboard Reporting Download CSV Field Formatters and Scripted Fields Download CSV export of a saved search panel 1`] = `
+exports[`dashboard Reporting Download CSV Field Formatters and Scripted Fields Download CSV export of a discover view panel 1`] = `
"date,\\"_id\\",name,gender,value,year,\\"years_ago\\",\\"date_informal\\"
\\"Jan 1, 1982 @ 00:00:00.000\\",\\"1982-Fethany-F\\",Fethany,F,780,1982,\\"37.00000000000000000000\\",\\"Jan 1st 82\\"
"
`;
-exports[`dashboard Reporting Download CSV Filtered Saved Search Downloads filtered Discover saved search report 1`] = `
+exports[`dashboard Reporting Download CSV Filtered Saved Search Downloads filtered Discover discover view report 1`] = `
"\\"order_date\\",category,\\"order_id\\",\\"customer_full_name\\",\\"taxful_total_price\\",currency
\\"Jun 25, 2019 @ 00:00:00.000\\",\\"Women's Clothing\\",569144,\\"Betty Perkins\\",\\"61.969\\",EUR
\\"Jun 25, 2019 @ 00:00:00.000\\",\\"Women's Clothing, Women's Shoes\\",568503,\\"Betty Bryant\\",68,EUR
diff --git a/x-pack/test/functional/apps/dashboard/group3/reporting/download_csv.ts b/x-pack/test/functional/apps/dashboard/group3/reporting/download_csv.ts
index c23f991f69f07..59e8a17e7e8bf 100644
--- a/x-pack/test/functional/apps/dashboard/group3/reporting/download_csv.ts
+++ b/x-pack/test/functional/apps/dashboard/group3/reporting/download_csv.ts
@@ -91,7 +91,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await reporting.teardownEcommerce();
});
- it('Download CSV export of a saved search panel', async function () {
+ it('Download CSV export of a discover view panel', async function () {
await PageObjects.dashboard.loadSavedDashboard('Ecom Dashboard - 3 Day Period');
await clickActionsMenu('EcommerceData');
await clickDownloadCsv();
@@ -100,7 +100,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expectSnapshot(csvFile).toMatch();
});
- it('Downloads a filtered CSV export of a saved search panel', async function () {
+ it('Downloads a filtered CSV export of a discover view panel', async function () {
await PageObjects.dashboard.loadSavedDashboard('Ecom Dashboard - 3 Day Period');
// add a filter
@@ -113,7 +113,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expectSnapshot(csvFile).toMatch();
});
- it('Downloads a saved search panel with a custom time range that does not intersect with dashboard time range', async function () {
+ it('Downloads a discover view panel with a custom time range that does not intersect with dashboard time range', async function () {
await PageObjects.dashboard.loadSavedDashboard(
'Ecom Dashboard - 3 Day Period - custom time range'
);
@@ -163,7 +163,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.common.unsetTime();
});
- it('Downloads filtered Discover saved search report', async () => {
+ it('Downloads filtered Discover discover view report', async () => {
await clickActionsMenu(TEST_SEARCH_TITLE.replace(/ /g, ''));
await clickDownloadCsv();
@@ -196,7 +196,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await esArchiver.unload('x-pack/test/functional/es_archives/reporting/hugedata');
});
- it('Download CSV export of a saved search panel', async () => {
+ it('Download CSV export of a discover view panel', async () => {
await clickActionsMenu('namessearch');
await clickDownloadCsv();
diff --git a/x-pack/test/functional/apps/dashboard/group3/reporting/screenshots.ts b/x-pack/test/functional/apps/dashboard/group3/reporting/screenshots.ts
index 6ecaa84c96974..00770d5110d83 100644
--- a/x-pack/test/functional/apps/dashboard/group3/reporting/screenshots.ts
+++ b/x-pack/test/functional/apps/dashboard/group3/reporting/screenshots.ts
@@ -155,7 +155,7 @@ export default function ({
await unloadEcommerce();
});
- it('downloads a PDF file with saved search given EuiDataGrid enabled', async function () {
+ it('downloads a PDF file with discover view given EuiDataGrid enabled', async function () {
await kibanaServer.uiSettings.update({ 'doc_table:legacy': false });
this.timeout(300000);
await PageObjects.dashboard.navigateToApp();
diff --git a/x-pack/test/functional/apps/discover/saved_search_embeddable.ts b/x-pack/test/functional/apps/discover/saved_search_embeddable.ts
index fd546315a1fd9..303959c12f39b 100644
--- a/x-pack/test/functional/apps/discover/saved_search_embeddable.ts
+++ b/x-pack/test/functional/apps/discover/saved_search_embeddable.ts
@@ -19,7 +19,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'timePicker', 'discover']);
- describe('discover saved search embeddable', () => {
+ describe('discover discover view embeddable', () => {
before(async () => {
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data');
@@ -64,7 +64,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
}
};
- it('should allow removing the dashboard panel after the underlying saved search has been deleted', async () => {
+ it('should allow removing the dashboard panel after the underlying discover view has been deleted', async () => {
const searchTitle = 'TempSearch';
const searchId = '90943e30-9a47-11e8-b64d-95841ca0b247';
await kibanaServer.savedObjects.create({
@@ -90,7 +90,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
],
});
await addSearchEmbeddableToDashboard(searchTitle);
- await PageObjects.dashboard.saveDashboard('Dashboard with deleted saved search', {
+ await PageObjects.dashboard.saveDashboard('Dashboard with deleted discover view', {
waitDialogIsClosed: true,
exitFromEditMode: false,
});
diff --git a/x-pack/test/functional/apps/discover/saved_searches.ts b/x-pack/test/functional/apps/discover/saved_searches.ts
index 8f5fe5dc9bc11..582e51b115c92 100644
--- a/x-pack/test/functional/apps/discover/saved_searches.ts
+++ b/x-pack/test/functional/apps/discover/saved_searches.ts
@@ -46,7 +46,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
describe('Customize time range', () => {
- it('should be possible to customize time range for saved searches on dashboards', async () => {
+ it('should be possible to customize time range for discover viewes on dashboards', async () => {
await PageObjects.dashboard.navigateToApp();
await PageObjects.dashboard.clickNewDashboard();
await dashboardAddPanel.clickOpenAddPanel();
@@ -64,7 +64,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
- it(`should unselect saved search when navigating to a 'new'`, async function () {
+ it(`should unselect discover view when navigating to a 'new'`, async function () {
await PageObjects.common.navigateToApp('discover');
await PageObjects.discover.selectIndexPattern('ecommerce');
await filterBar.addFilter({ field: 'category', operation: 'is', value: `Men's Shoes` });
diff --git a/x-pack/test/functional/apps/ml/anomaly_detection_jobs/saved_search_job.ts b/x-pack/test/functional/apps/ml/anomaly_detection_jobs/saved_search_job.ts
index b8493e2daa1b6..39aa00d2b5917 100644
--- a/x-pack/test/functional/apps/ml/anomaly_detection_jobs/saved_search_job.ts
+++ b/x-pack/test/functional/apps/ml/anomaly_detection_jobs/saved_search_job.ts
@@ -16,7 +16,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with filter',
jobSource: 'ft_farequote_filter',
jobId: `fq_saved_search_1_${Date.now()}`,
- jobDescription: 'Create multi metric job based on a saved search with filter',
+ jobDescription: 'Create multi metric job based on a discover view with filter',
jobGroups: ['automated', 'farequote', 'multi-metric', 'saved-search'],
aggAndFieldIdentifiers: ['Mean(responsetime)'],
splitField: 'airline',
@@ -66,7 +66,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with lucene query',
jobSource: 'ft_farequote_lucene',
jobId: `fq_saved_search_2_${Date.now()}`,
- jobDescription: 'Create multi metric job based on a saved search with lucene query',
+ jobDescription: 'Create multi metric job based on a discover view with lucene query',
jobGroups: ['automated', 'farequote', 'multi-metric', 'saved-search'],
aggAndFieldIdentifiers: ['Mean(responsetime)'],
splitField: 'airline',
@@ -116,7 +116,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with kuery query',
jobSource: 'ft_farequote_kuery',
jobId: `fq_saved_search_3_${Date.now()}`,
- jobDescription: 'Create multi metric job based on a saved search with kuery query',
+ jobDescription: 'Create multi metric job based on a discover view with kuery query',
jobGroups: ['automated', 'farequote', 'multi-metric', 'saved-search'],
aggAndFieldIdentifiers: ['Mean(responsetime)'],
splitField: 'airline',
@@ -167,7 +167,7 @@ export default function ({ getService }: FtrProviderContext) {
jobSource: 'ft_farequote_filter_and_lucene',
jobId: `fq_saved_search_4_${Date.now()}`,
jobDescription:
- 'Create multi metric job based on a saved search with filter and lucene query',
+ 'Create multi metric job based on a discover view with filter and lucene query',
jobGroups: ['automated', 'farequote', 'multi-metric', 'saved-search'],
aggAndFieldIdentifiers: ['Mean(responsetime)'],
splitField: 'airline',
@@ -217,7 +217,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with filter and kuery query',
jobSource: 'ft_farequote_filter_and_kuery',
jobId: `fq_saved_search_5_${Date.now()}`,
- jobDescription: 'Create multi metric job based on a saved search with filter and kuery query',
+ jobDescription: 'Create multi metric job based on a discover view with filter and kuery query',
jobGroups: ['automated', 'farequote', 'multi-metric', 'saved-search'],
aggAndFieldIdentifiers: ['Mean(responsetime)'],
splitField: 'airline',
@@ -265,7 +265,7 @@ export default function ({ getService }: FtrProviderContext) {
},
];
- describe('saved search', function () {
+ describe('discover view', function () {
this.tags(['ml']);
before(async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/farequote');
diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts
index 307678384d470..8d8c10669bb78 100644
--- a/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts
+++ b/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation_saved_search.ts
@@ -15,13 +15,13 @@ export default function ({ getService }: FtrProviderContext) {
const editedDescription = 'Edited description';
// FLAKY: https://github.com/elastic/kibana/issues/147020
- describe.skip('classification saved search creation', function () {
+ describe.skip('classification discover view creation', function () {
before(async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/farequote_small');
await ml.testResources.createDataViewIfNeeded('ft_farequote_small', '@timestamp');
await ml.testResources.createSavedSearchFarequoteLuceneIfNeeded('ft_farequote_small');
await ml.testResources.createSavedSearchFarequoteKueryIfNeeded('ft_farequote_small');
- // Need to use the saved searches with filters that match multiple airlines
+ // Need to use the discover viewes with filters that match multiple airlines
await ml.testResources.createSavedSearchFarequoteFilterTwoAndLuceneIfNeeded(
'ft_farequote_small'
);
@@ -78,7 +78,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with lucene query',
jobType: 'classification',
jobId: `fq_saved_search_2_${dateNow}`,
- jobDescription: 'Classification job based on a saved search with lucene query',
+ jobDescription: 'Classification job based on a discover view with lucene query',
source: 'ft_farequote_lucene',
get destinationIndex(): string {
return `user-${this.jobId}`;
@@ -178,7 +178,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with kuery query',
jobType: 'classification',
jobId: `fq_saved_search_3_${dateNow}`,
- jobDescription: 'Classification job based on a saved search with kuery query',
+ jobDescription: 'Classification job based on a discover view with kuery query',
source: 'ft_farequote_kuery',
get destinationIndex(): string {
return `user-${this.jobId}`;
@@ -278,7 +278,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with filter and lucene query',
jobType: 'classification',
jobId: `fq_saved_search_4_${dateNow}`,
- jobDescription: 'Classification job based on a saved search with filter and lucene query',
+ jobDescription: 'Classification job based on a discover view with filter and lucene query',
source: 'ft_farequote_filter_two_and_lucene',
get destinationIndex(): string {
return `user-${this.jobId}`;
@@ -371,7 +371,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with filter and kuery query',
jobType: 'classification',
jobId: `fq_saved_search_5_${dateNow}`,
- jobDescription: 'Classification job based on a saved search with filter and kuery query',
+ jobDescription: 'Classification job based on a discover view with filter and kuery query',
source: 'ft_farequote_filter_two_and_kuery',
get destinationIndex(): string {
return `user-${this.jobId}`;
diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation_saved_search.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation_saved_search.ts
index 93478ebbb766e..06bf2168bacae 100644
--- a/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation_saved_search.ts
+++ b/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation_saved_search.ts
@@ -13,7 +13,7 @@ export default function ({ getService }: FtrProviderContext) {
const ml = getService('ml');
const editedDescription = 'Edited description';
- describe('outlier detection saved search creation', function () {
+ describe('outlier detection discover view creation', function () {
before(async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/farequote_small');
await ml.testResources.createDataViewIfNeeded('ft_farequote_small', '@timestamp');
@@ -51,7 +51,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with lucene query',
jobType: 'outlier_detection',
jobId: `fq_saved_search_2_${dateNow}`,
- jobDescription: 'Outlier detection job based on a saved search with lucene query',
+ jobDescription: 'Outlier detection job based on a discover view with lucene query',
source: 'ft_farequote_lucene',
get destinationIndex(): string {
return `user-${this.jobId}`;
@@ -128,7 +128,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with kuery query',
jobType: 'outlier_detection',
jobId: `fq_saved_search_3_${dateNow}`,
- jobDescription: 'Outlier detection job based on a saved search with kuery query',
+ jobDescription: 'Outlier detection job based on a discover view with kuery query',
source: 'ft_farequote_kuery',
get destinationIndex(): string {
return `user-${this.jobId}`;
@@ -205,7 +205,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with filter and kuery query',
jobType: 'outlier_detection',
jobId: `fq_saved_search_4_${dateNow}`,
- jobDescription: 'Outlier detection job based on a saved search with filter and kuery query',
+ jobDescription: 'Outlier detection job based on a discover view with filter and kuery query',
source: 'ft_farequote_filter_and_kuery',
get destinationIndex(): string {
return `user-${this.jobId}`;
@@ -283,7 +283,7 @@ export default function ({ getService }: FtrProviderContext) {
jobType: 'outlier_detection',
jobId: `fq_saved_search_5_${dateNow}`,
jobDescription:
- 'Outlier detection job based on a saved search with filter and lucene query',
+ 'Outlier detection job based on a discover view with filter and lucene query',
source: 'ft_farequote_filter_and_lucene',
get destinationIndex(): string {
return `user-${this.jobId}`;
diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation_saved_search.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation_saved_search.ts
index fb5702e98ac1d..f1ff31392f647 100644
--- a/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation_saved_search.ts
+++ b/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation_saved_search.ts
@@ -13,7 +13,7 @@ export default function ({ getService }: FtrProviderContext) {
const ml = getService('ml');
const editedDescription = 'Edited description';
- describe('regression saved search creation', function () {
+ describe('regression discover view creation', function () {
before(async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/farequote_small');
await ml.testResources.createDataViewIfNeeded('ft_farequote_small', '@timestamp');
@@ -59,7 +59,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with lucene query',
jobType: 'regression',
jobId: `fq_saved_search_2_${dateNow}`,
- jobDescription: 'Regression job based on a saved search with lucene query',
+ jobDescription: 'Regression job based on a discover view with lucene query',
source: 'ft_farequote_lucene',
get destinationIndex(): string {
return `user-${this.jobId}`;
@@ -147,7 +147,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with kuery query',
jobType: 'regression',
jobId: `fq_saved_search_3_${dateNow}`,
- jobDescription: 'Regression job based on a saved search with kuery query',
+ jobDescription: 'Regression job based on a discover view with kuery query',
source: 'ft_farequote_kuery',
get destinationIndex(): string {
return `user-${this.jobId}`;
@@ -235,7 +235,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with filter and kuery query',
jobType: 'regression',
jobId: `fq_saved_search_4_${dateNow}`,
- jobDescription: 'Regression job based on a saved search with filter and kuery query',
+ jobDescription: 'Regression job based on a discover view with filter and kuery query',
source: 'ft_farequote_filter_and_kuery',
get destinationIndex(): string {
return `user-${this.jobId}`;
@@ -317,7 +317,7 @@ export default function ({ getService }: FtrProviderContext) {
suiteTitle: 'with filter and lucene query',
jobType: 'regression',
jobId: `fq_saved_search_5_${dateNow}`,
- jobDescription: 'Regression job based on a saved search with filter and lucene query',
+ jobDescription: 'Regression job based on a discover view with filter and lucene query',
source: 'ft_farequote_filter_and_lucene',
get destinationIndex(): string {
return `user-${this.jobId}`;
diff --git a/x-pack/test/functional/apps/ml/data_visualizer/data_drift.ts b/x-pack/test/functional/apps/ml/data_visualizer/data_drift.ts
index a3ef0eddef6c4..22d1a6a48effc 100644
--- a/x-pack/test/functional/apps/ml/data_visualizer/data_drift.ts
+++ b/x-pack/test/functional/apps/ml/data_visualizer/data_drift.ts
@@ -8,7 +8,7 @@
import { FtrProviderContext } from '../../../ftr_provider_context';
export const farequoteKQLFiltersSearchTestData = {
- suiteTitle: 'KQL saved search and filters',
+ suiteTitle: 'KQL discover view and filters',
isSavedSearch: true,
dateTimeField: '@timestamp',
sourceIndexOrSavedSearch: 'ft_farequote_filter_and_kuery',
@@ -121,7 +121,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it(`${farequoteKQLFiltersSearchTestData.suiteTitle} loads the source data in data drift`, async () => {
await ml.testExecution.logTestStep(
- `${farequoteKQLFiltersSearchTestData.suiteTitle} loads the data drift index or saved search select page`
+ `${farequoteKQLFiltersSearchTestData.suiteTitle} loads the data drift index or discover view select page`
);
await ml.navigation.navigateToDataDrift();
@@ -154,7 +154,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await ml.navigation.navigateToMl();
await elasticChart.setNewChartUiDebugFlag(true);
await ml.testExecution.logTestStep(
- `${dataViewCreationTestData.suiteTitle} loads the saved search selection page`
+ `${dataViewCreationTestData.suiteTitle} loads the discover view selection page`
);
await ml.navigation.navigateToDataDrift();
});
diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer.ts
index f0185fc371006..19ac96cb58821 100644
--- a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer.ts
+++ b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer.ts
@@ -24,7 +24,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
function runTests(testData: TestData) {
it(`${testData.suiteTitle} loads the source data in the data visualizer`, async () => {
await ml.testExecution.logTestStep(
- `${testData.suiteTitle} loads the saved search selection page`
+ `${testData.suiteTitle} loads the discover view selection page`
);
await ml.dataVisualizer.navigateToDataViewSelection();
@@ -173,7 +173,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
runTests(farequoteDataViewTestData);
- // Run tests on farequote KQL saved search.
+ // Run tests on farequote KQL discover view.
it(`${farequoteKQLSearchTestData.suiteTitle} loads the data visualizer selector page`, async () => {
// Only navigate back to the data visualizer selector page before running next tests,
// to ensure the time picker isn't set back to the default (last 15 minutes).
@@ -182,7 +182,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
runTests(farequoteKQLSearchTestData);
- // Run tests on farequote lucene saved search.
+ // Run tests on farequote lucene discover view.
it(`${farequoteLuceneSearchTestData.suiteTitle} loads the data visualizer selector page`, async () => {
// Only navigate back to the data visualizer selector page before running next tests,
// to ensure the time picker isn't set back to the default (last 15 minutes).
@@ -221,7 +221,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
it(`${testData.suiteTitle} loads lens charts`, async () => {
await ml.testExecution.logTestStep(
- `${testData.suiteTitle} loads the saved search selection page`
+ `${testData.suiteTitle} loads the discover view selection page`
);
await ml.dataVisualizer.navigateToDataViewSelection();
diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_actions_panel.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_actions_panel.ts
index 6f259a8120d28..030f7101480e3 100644
--- a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_actions_panel.ts
+++ b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_actions_panel.ts
@@ -51,7 +51,7 @@ export default function ({ getService }: FtrProviderContext) {
await ml.navigation.navigateToMl();
await ml.navigation.navigateToDataVisualizer();
- await ml.testExecution.logTestStep('loads the saved search selection page');
+ await ml.testExecution.logTestStep('loads the discover view selection page');
await ml.dataVisualizer.navigateToDataViewSelection();
await ml.testExecution.logTestStep('loads the index data visualizer page');
@@ -83,7 +83,7 @@ export default function ({ getService }: FtrProviderContext) {
await ml.navigation.navigateToMl();
await ml.navigation.navigateToDataVisualizer();
- await ml.testExecution.logTestStep('loads the saved search selection page');
+ await ml.testExecution.logTestStep('loads the discover view selection page');
await ml.dataVisualizer.navigateToDataViewSelection();
await ml.testExecution.logTestStep('loads the index data visualizer page');
diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_data_view_management.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_data_view_management.ts
index 28611dbcb8a1b..f276da6958437 100644
--- a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_data_view_management.ts
+++ b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_data_view_management.ts
@@ -116,7 +116,7 @@ export default function ({ getService }: FtrProviderContext) {
await ml.navigation.navigateToDataVisualizer();
await ml.testExecution.logTestStep(
- `${testData.suiteTitle} loads the saved search selection page`
+ `${testData.suiteTitle} loads the discover view selection page`
);
await ml.dataVisualizer.navigateToDataViewSelection();
diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_filters.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_filters.ts
index 4be111e00bc85..7bf05a21be754 100644
--- a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_filters.ts
+++ b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_filters.ts
@@ -52,7 +52,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await ml.navigation.navigateToDataVisualizer();
await ml.testExecution.logTestStep(
- `${testData.suiteTitle} loads the saved search selection page`
+ `${testData.suiteTitle} loads the discover view selection page`
);
await ml.dataVisualizer.navigateToDataViewSelection();
@@ -89,7 +89,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await ml.navigation.navigateToDataVisualizer();
await ml.testExecution.logTestStep(
- `${testData.suiteTitle} loads the saved search selection page`
+ `${testData.suiteTitle} loads the discover view selection page`
);
await ml.dataVisualizer.navigateToDataViewSelection();
diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_random_sampler.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_random_sampler.ts
index e5fee365ff08e..3ba8ef6fe4e15 100644
--- a/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_random_sampler.ts
+++ b/x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_random_sampler.ts
@@ -16,7 +16,7 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
await ml.testExecution.logTestStep(`navigates to Data Visualizer page`);
await ml.navigation.navigateToDataVisualizer();
- await ml.testExecution.logTestStep(`loads the saved search selection page`);
+ await ml.testExecution.logTestStep(`loads the discover view selection page`);
await ml.dataVisualizer.navigateToDataViewSelection();
await ml.testExecution.logTestStep(`loads the index data visualizer page`);
diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_test_data.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_test_data.ts
index 40c0f83070f6e..1d9d8ddd77b25 100644
--- a/x-pack/test/functional/apps/ml/data_visualizer/index_test_data.ts
+++ b/x-pack/test/functional/apps/ml/data_visualizer/index_test_data.ts
@@ -106,7 +106,7 @@ export const farequoteDataViewTestData: TestData = {
};
export const farequoteKQLSearchTestData: TestData = {
- suiteTitle: 'KQL saved search',
+ suiteTitle: 'KQL discover view',
isSavedSearch: true,
sourceIndexOrSavedSearch: 'ft_farequote_kuery',
fieldNameFilters: ['@version'],
@@ -203,7 +203,7 @@ export const farequoteKQLSearchTestData: TestData = {
};
export const farequoteKQLFiltersSearchTestData: TestData = {
- suiteTitle: 'KQL saved search and filters',
+ suiteTitle: 'KQL discover view and filters',
isSavedSearch: true,
sourceIndexOrSavedSearch: 'ft_farequote_filter_and_kuery',
fieldNameFilters: ['@version'],
@@ -302,7 +302,7 @@ export const farequoteKQLFiltersSearchTestData: TestData = {
};
export const farequoteLuceneSearchTestData: TestData = {
- suiteTitle: 'lucene saved search',
+ suiteTitle: 'lucene discover view',
isSavedSearch: true,
sourceIndexOrSavedSearch: 'ft_farequote_lucene',
fieldNameFilters: ['@version.keyword', 'type'],
@@ -399,7 +399,7 @@ export const farequoteLuceneSearchTestData: TestData = {
};
export const farequoteLuceneFiltersSearchTestData: TestData = {
- suiteTitle: 'lucene saved search and filter',
+ suiteTitle: 'lucene discover view and filter',
isSavedSearch: true,
sourceIndexOrSavedSearch: 'ft_farequote_filter_and_lucene',
fieldNameFilters: ['@version.keyword', 'type'],
diff --git a/x-pack/test/functional/apps/ml/data_visualizer/index_test_data_random_sampler.ts b/x-pack/test/functional/apps/ml/data_visualizer/index_test_data_random_sampler.ts
index dfc6c80aa8b40..1865c58496964 100644
--- a/x-pack/test/functional/apps/ml/data_visualizer/index_test_data_random_sampler.ts
+++ b/x-pack/test/functional/apps/ml/data_visualizer/index_test_data_random_sampler.ts
@@ -106,7 +106,7 @@ export const farequoteDataViewTestData: TestData = {
};
export const farequoteKQLSearchTestData: TestData = {
- suiteTitle: 'KQL saved search',
+ suiteTitle: 'KQL discover view',
isSavedSearch: true,
sourceIndexOrSavedSearch: 'ft_farequote_kuery',
fieldNameFilters: ['@version'],
@@ -203,7 +203,7 @@ export const farequoteKQLSearchTestData: TestData = {
};
export const farequoteKQLFiltersSearchTestData: TestData = {
- suiteTitle: 'KQL saved search and filters',
+ suiteTitle: 'KQL discover view and filters',
isSavedSearch: true,
sourceIndexOrSavedSearch: 'ft_farequote_filter_and_kuery',
fieldNameFilters: ['@version'],
@@ -302,7 +302,7 @@ export const farequoteKQLFiltersSearchTestData: TestData = {
};
export const farequoteLuceneSearchTestData: TestData = {
- suiteTitle: 'lucene saved search',
+ suiteTitle: 'lucene discover view',
isSavedSearch: true,
sourceIndexOrSavedSearch: 'ft_farequote_lucene',
fieldNameFilters: ['@version.keyword', 'type'],
@@ -399,7 +399,7 @@ export const farequoteLuceneSearchTestData: TestData = {
};
export const farequoteLuceneFiltersSearchTestData: TestData = {
- suiteTitle: 'lucene saved search and filter',
+ suiteTitle: 'lucene discover view and filter',
isSavedSearch: true,
sourceIndexOrSavedSearch: 'ft_farequote_filter_and_lucene',
fieldNameFilters: ['@version.keyword', 'type'],
diff --git a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts
index 0b51b78265c25..395d3c9718b03 100644
--- a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts
+++ b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/config.ts
@@ -15,7 +15,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
testFiles: [require.resolve('.')],
junit: {
reportName:
- 'Chrome X-Pack UI Functional Tests - transform - creation - runtime mappings & saved search',
+ 'Chrome X-Pack UI Functional Tests - transform - creation - runtime mappings & discover view',
},
};
}
diff --git a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/creation_saved_search.ts b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/creation_saved_search.ts
index c85a1a88b429c..1fc98aab44c43 100644
--- a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/creation_saved_search.ts
+++ b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/creation_saved_search.ts
@@ -39,7 +39,7 @@ export default function ({ getService }: FtrProviderContext) {
const testDataList: Array = [
{
type: 'pivot',
- suiteTitle: 'batch transform with terms groups and avg agg with saved search filter',
+ suiteTitle: 'batch transform with terms groups and avg agg with discover view filter',
source: 'ft_farequote_filter',
groupByEntries: [
{
@@ -55,7 +55,7 @@ export default function ({ getService }: FtrProviderContext) {
],
transformId: `fq_1_${Date.now()}`,
transformDescription:
- 'farequote batch transform with groups terms(airline) and aggregation avg(responsetime.avg) with saved search filter',
+ 'farequote batch transform with groups terms(airline) and aggregation avg(responsetime.avg) with discover view filter',
get destinationIndex(): string {
return `user-${this.transformId}`;
},
@@ -79,7 +79,7 @@ export default function ({ getService }: FtrProviderContext) {
} as PivotTransformTestData,
{
type: 'latest',
- suiteTitle: 'batch transform with unique term and sort by time with saved search filter',
+ suiteTitle: 'batch transform with unique term and sort by time with discover view filter',
source: 'ft_farequote_filter',
uniqueKeys: [
{
@@ -93,7 +93,7 @@ export default function ({ getService }: FtrProviderContext) {
},
transformId: `fq_2_${Date.now()}`,
transformDescription:
- 'farequote batch transform with airline unique key and sort by timestamp with saved search filter',
+ 'farequote batch transform with airline unique key and sort by timestamp with discover view filter',
get destinationIndex(): string {
return `user-latest-${this.transformId}`;
},
diff --git a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/index.ts b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/index.ts
index 943fb97200a7b..b16f95f76f196 100644
--- a/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/index.ts
+++ b/x-pack/test/functional/apps/transform/creation/runtime_mappings_saved_search/index.ts
@@ -11,7 +11,7 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
const transform = getService('transform');
- describe('transform - creation - runtime mappings & saved search', function () {
+ describe('transform - creation - runtime mappings & discover view', function () {
this.tags('transform');
before(async () => {
diff --git a/x-pack/test/functional/fixtures/kbn_archiver/dashboard_view_mode.json b/x-pack/test/functional/fixtures/kbn_archiver/dashboard_view_mode.json
index 9a5f39cdb390d..41da7467328f4 100644
--- a/x-pack/test/functional/fixtures/kbn_archiver/dashboard_view_mode.json
+++ b/x-pack/test/functional/fixtures/kbn_archiver/dashboard_view_mode.json
@@ -28,7 +28,7 @@
"desc"
]
],
- "title": "Saved search for dashboard",
+ "title": "Discover view for dashboard",
"version": 1
},
"coreMigrationVersion": "7.16.0",
diff --git a/x-pack/test/functional/fixtures/kbn_archiver/reporting/ecommerce.json b/x-pack/test/functional/fixtures/kbn_archiver/reporting/ecommerce.json
index 1d64dc744950e..ae006fd30c840 100644
--- a/x-pack/test/functional/fixtures/kbn_archiver/reporting/ecommerce.json
+++ b/x-pack/test/functional/fixtures/kbn_archiver/reporting/ecommerce.json
@@ -340,7 +340,7 @@
"kibanaSavedObjectMeta": {
"searchSourceJSON": "{\"query\":{\"language\":\"kuery\",\"query\":\"\"},\"filter\":[]}"
},
- "description": "saved search panel with custom time range that does not intersect with dashboard time range",
+ "description": "discover view panel with custom time range that does not intersect with dashboard time range",
"refreshInterval": {
"pause": true,
"value": 0
diff --git a/x-pack/test/functional/fixtures/kbn_archiver/reporting/logs.json b/x-pack/test/functional/fixtures/kbn_archiver/reporting/logs.json
index e7121b78f6ddd..07686bfafb27c 100644
--- a/x-pack/test/functional/fixtures/kbn_archiver/reporting/logs.json
+++ b/x-pack/test/functional/fixtures/kbn_archiver/reporting/logs.json
@@ -521,7 +521,7 @@
]
],
"timeRestore": false,
- "title": "A saved search with match_phrase filter and no columns selected",
+ "title": "A discover view with match_phrase filter and no columns selected",
"usesAdHocDataView": false
},
"coreMigrationVersion": "8.7.0",
@@ -576,7 +576,7 @@
"to": "2015-11-01T01:39:01.782Z"
},
"timeRestore": true,
- "title": "A saved search with the time stored and a query",
+ "title": "A discover view with the time stored and a query",
"usesAdHocDataView": false
},
"coreMigrationVersion": "8.7.0",
@@ -618,7 +618,7 @@
]
],
"timeRestore": false,
- "title": "A saved search with a query",
+ "title": "A discover view with a query",
"usesAdHocDataView": false
},
"coreMigrationVersion": "8.7.0",
diff --git a/x-pack/test/functional/services/ml/test_resources.ts b/x-pack/test/functional/services/ml/test_resources.ts
index 5035b6844b9c3..08b335dc0b39a 100644
--- a/x-pack/test/functional/services/ml/test_resources.ts
+++ b/x-pack/test/functional/services/ml/test_resources.ts
@@ -187,7 +187,7 @@ export function MachineLearningTestResourcesProvider(
},
async createSavedSearch(title: string, body: object): Promise {
- log.debug(`Creating saved search with title '${title}'`);
+ log.debug(`Creating discover view with title '${title}'`);
const { body: createResponse, status } = await supertest
.post(`/api/saved_objects/${SavedObjectType.SEARCH}`)
@@ -218,7 +218,7 @@ export function MachineLearningTestResourcesProvider(
const title = savedSearch.requestBody.attributes.title;
const savedSearchId = await this.getSavedSearchId(title);
if (savedSearchId !== undefined) {
- log.debug(`Saved search with title '${title}' already exists. Nothing to create.`);
+ log.debug(`Discover view with title '${title}' already exists. Nothing to create.`);
return savedSearchId;
} else {
const body = await this.updateSavedSearchRequestBody(
@@ -233,7 +233,7 @@ export function MachineLearningTestResourcesProvider(
const dataViewId = await this.getDataViewId(dataViewTitle);
if (dataViewId === undefined) {
throw new Error(
- `Index pattern '${dataViewTitle}' to base saved search on does not exist. `
+ `Index pattern '${dataViewTitle}' to base discover view on does not exist. `
);
}
@@ -351,11 +351,11 @@ export function MachineLearningTestResourcesProvider(
},
async deleteSavedSearchByTitle(title: string) {
- log.debug(`Deleting saved search with title '${title}'...`);
+ log.debug(`Deleting discover view with title '${title}'...`);
const savedSearchId = await this.getSavedSearchId(title);
if (savedSearchId === undefined) {
- log.debug(`Saved search with title '${title}' does not exists. Nothing to delete.`);
+ log.debug(`Discover view with title '${title}' does not exists. Nothing to delete.`);
return;
} else {
await this.deleteSavedSearchById(savedSearchId);
diff --git a/x-pack/test/functional_basic/apps/ml/data_visualizer/group3/index_data_visualizer_actions_panel.ts b/x-pack/test/functional_basic/apps/ml/data_visualizer/group3/index_data_visualizer_actions_panel.ts
index 62cbc2e41e36a..b11f9bfd6f068 100644
--- a/x-pack/test/functional_basic/apps/ml/data_visualizer/group3/index_data_visualizer_actions_panel.ts
+++ b/x-pack/test/functional_basic/apps/ml/data_visualizer/group3/index_data_visualizer_actions_panel.ts
@@ -33,7 +33,7 @@ export default function ({ getService }: FtrProviderContext) {
await ml.navigation.navigateToMl();
await ml.navigation.navigateToDataVisualizer();
- await ml.testExecution.logTestStep('loads the saved search selection page');
+ await ml.testExecution.logTestStep('loads the discover view selection page');
await ml.dataVisualizer.navigateToDataViewSelection();
await ml.testExecution.logTestStep('loads the index data visualizer page');
diff --git a/x-pack/test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts b/x-pack/test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts
index 91daf3d099007..138f68cb6e7a9 100644
--- a/x-pack/test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts
+++ b/x-pack/test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts
@@ -17,7 +17,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
junit: {
...transformConfig.get('junit'),
reportName:
- 'Chrome X-Pack UI Functional Tests Basic License - transform - creation - runtime mappings & saved search',
+ 'Chrome X-Pack UI Functional Tests Basic License - transform - creation - runtime mappings & discover view',
},
};
}
diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/__snapshots__/csv_v2.snap b/x-pack/test/reporting_api_integration/reporting_and_security/__snapshots__/csv_v2.snap
index a76973fb73f64..db20c2030743d 100644
--- a/x-pack/test/reporting_api_integration/reporting_and_security/__snapshots__/csv_v2.snap
+++ b/x-pack/test/reporting_api_integration/reporting_and_security/__snapshots__/csv_v2.snap
@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
-exports[`Reporting APIs CSV Generation from Saved Search ID export from non-timebased data view query stored in the saved search csv file matches 1`] = `
+exports[`Reporting APIs CSV Generation from Saved Search ID export from non-timebased data view query stored in the discover view csv file matches 1`] = `
"_id,_index,_score,eon,epoch,era,period
tvJJX4UBvD7uFsw9L2x4,timeless-test,1,Phanerozoic, Pliocene,Cenozoic,Neogene
t_JJX4UBvD7uFsw9L2x4,timeless-test,1,Phanerozoic, Holocene,Cenozoic,Quaternary
@@ -11,7 +11,7 @@ u_JJX4UBvD7uFsw9L2x4,timeless-test,1,Proterozoic,-,Paleozoic,Permian
"
`;
-exports[`Reporting APIs CSV Generation from Saved Search ID export from non-timebased data view query stored in the saved search job response data is correct 1`] = `
+exports[`Reporting APIs CSV Generation from Saved Search ID export from non-timebased data view query stored in the discover view job response data is correct 1`] = `
Object {
"contentDisposition": "attachment; filename=*zoic.csv",
"contentType": "text/csv; charset=utf-8",
diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/csv_v2.ts b/x-pack/test/reporting_api_integration/reporting_and_security/csv_v2.ts
index 5b70c5db2fd8a..35f9e678dc983 100644
--- a/x-pack/test/reporting_api_integration/reporting_and_security/csv_v2.ts
+++ b/x-pack/test/reporting_api_integration/reporting_and_security/csv_v2.ts
@@ -38,7 +38,7 @@ export default ({ getService }: FtrProviderContext) => {
version: '8.7.0',
...params,
};
- log.info(`sending request for saved search: ${job.locatorParams[0].params.savedSearchId}`);
+ log.info(`sending request for discover view: ${job.locatorParams[0].params.savedSearchId}`);
const jobParams = rison.encode(job);
return await supertest
.post(`/api/reporting/generate/csv_v2`)
@@ -139,7 +139,7 @@ export default ({ getService }: FtrProviderContext) => {
});
});
- describe('query stored in the saved search', () => {
+ describe('query stored in the discover view', () => {
let response: request.Response;
let job: ReportApiJSON;
let path: string;
diff --git a/x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts b/x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts
index 8db27a6817a80..fd96224493357 100644
--- a/x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts
+++ b/x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts
@@ -60,7 +60,7 @@ export default function ({ getService }: FtrProviderContext) {
* NOTE: All timestamps in the documents are midnight UTC.
* "00:00:00.000" means the time is formatted in UTC timezone
*/
- describe('CSV saved search export', () => {
+ describe('CSV discover view export', () => {
const JOB_PARAMS_CSV_DEFAULT_SPACE =
`columns:!(order_date,category,customer_full_name,taxful_total_price,currency),objectType:search,searchSource:(fields:!((field:'*',include_unmapped:true))` +
`,filter:!((meta:(field:order_date,index:aac3e500-f2c7-11ea-8250-fb138aa491e7,params:()),query:(range:(order_date:(format:strict_date_optional_time,gte:'2019-06-02T12:28:40.866Z'` +
diff --git a/x-pack/test/reporting_functional/services/scenarios.ts b/x-pack/test/reporting_functional/services/scenarios.ts
index d1123cf2eab05..91489e0ccf584 100644
--- a/x-pack/test/reporting_functional/services/scenarios.ts
+++ b/x-pack/test/reporting_functional/services/scenarios.ts
@@ -63,7 +63,7 @@ export function createScenarios(
};
const openSavedSearch = async (title: string) => {
- log.debug(`Opening saved search: ${title}`);
+ log.debug(`Opening discover view: ${title}`);
await PageObjects.common.navigateToApp('discover');
await PageObjects.discover.loadSavedSearch(title);
};
diff --git a/x-pack/test/saved_object_tagging/functional/tests/discover_integration.ts b/x-pack/test/saved_object_tagging/functional/tests/discover_integration.ts
index 8258b4570ed9b..fea72b1e9df91 100644
--- a/x-pack/test/saved_object_tagging/functional/tests/discover_integration.ts
+++ b/x-pack/test/saved_object_tagging/functional/tests/discover_integration.ts
@@ -108,7 +108,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.header.waitUntilLoadingHasFinished();
});
- it('allows to select tags for a new saved search', async () => {
+ it('allows to select tags for a new discover view', async () => {
await PageObjects.discover.saveSearch('My New Search', undefined, {
tags: ['tag-1', 'tag-2'],
});
@@ -122,7 +122,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const searchName = 'search-with-new-tag';
// preventing an occasional flakiness when the saved object wasn't set and the form can't be submitted
await retry.waitFor(
- `saved search title is set to ${searchName} and save button is clickable`,
+ `discover view title is set to ${searchName} and save button is clickable`,
async () => {
const saveButton = await testSubjects.find('confirmSaveSavedObjectButton');
await testSubjects.setValue('savedObjectTitle', searchName);
@@ -161,7 +161,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.header.waitUntilLoadingHasFinished();
});
- it('allows to select tags for an existing saved search', async () => {
+ it('allows to select tags for an existing discover view', async () => {
await PageObjects.discover.loadSavedSearch('A Saved Search');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.saveSearch('A Saved Search', undefined, {
diff --git a/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/save_search_session_relative_time.ts b/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/save_search_session_relative_time.ts
index ad46f0a2add88..f1028b13b1cd1 100644
--- a/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/save_search_session_relative_time.ts
+++ b/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/save_search_session_relative_time.ts
@@ -87,7 +87,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await dashboardExpect.noErrorEmbeddablesPresent();
log.debug('Checking charts rendered');
await elasticChart.waitForRenderComplete(visualizationContainer ?? 'lnsVisualizationContainer');
- log.debug('Checking saved searches rendered');
+ log.debug('Checking discover viewes rendered');
await dashboardExpect.savedSearchRowCount(11);
log.debug('Checking input controls rendered');
await dashboardExpect.controlCount(3);
diff --git a/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/session_searches_integration.ts b/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/session_searches_integration.ts
index cffd9db8dd12b..3861378a40628 100644
--- a/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/session_searches_integration.ts
+++ b/x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/session_searches_integration.ts
@@ -43,7 +43,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await searchSessions.deleteAllSearchSessions();
});
- it('until session is saved search keepAlive is short, when it is saved, keepAlive is extended and search is saved into the session saved object, when session is extended, searches are also extended', async () => {
+ it('until session is discover view keepAlive is short, when it is saved, keepAlive is extended and search is saved into the session saved object, when session is extended, searches are also extended', async () => {
await PageObjects.dashboard.loadSavedDashboard('Not Delayed');
await PageObjects.dashboard.waitForRenderComplete();
await searchSessions.expectState('completed');
diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/creation.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/creation.cy.ts
index fe47cf3a538cb..6342375cb22d2 100644
--- a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/creation.cy.ts
+++ b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/creation.cy.ts
@@ -132,7 +132,7 @@ describe('Timelines', { tags: ['@ess', '@serverless'] }, (): void => {
cy.get(TIMELINE_STATUS).should('not.exist');
// Offsetting the extra save that is happening in the background
- // for the saved search object.
+ // for the discover view object.
cy.get(LOADING_INDICATOR).should('be.visible');
cy.get(LOADING_INDICATOR).should('not.exist');
@@ -154,7 +154,7 @@ describe('Timelines', { tags: ['@ess', '@serverless'] }, (): void => {
addNameToTimelineAndSave('First');
// Offsetting the extra save that is happening in the background
- // for the saved search object.
+ // for the discover view object.
cy.get(LOADING_INDICATOR).should('be.visible');
cy.get(LOADING_INDICATOR).should('not.exist');
diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/esql/discover_timeline_state_integration.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/esql/discover_timeline_state_integration.cy.ts
index eaa4fc2416db5..7f553ee48b460 100644
--- a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/esql/discover_timeline_state_integration.cy.ts
+++ b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/esql/discover_timeline_state_integration.cy.ts
@@ -174,8 +174,8 @@ describe(
});
});
- describe('Discover saved search state for ESQL tab', () => {
- it('should save esql tab saved search with `Security Solution` tag', () => {
+ describe('Discover discover view state for ESQL tab', () => {
+ it('should save esql tab discover view with `Security Solution` tag', () => {
const timelineSuffix = Date.now();
const timelineName = `SavedObject timeline-${timelineSuffix}`;
addDiscoverEsqlQuery(esqlQuery);
@@ -192,11 +192,11 @@ describe(
cy.get(BASIC_TABLE_LOADING).should('not.exist');
cy.get(SAVED_OBJECTS_ROW_TITLES).should(
'contain.text',
- `Saved search for timeline - ${timelineName}`
+ `Discover view for timeline - ${timelineName}`
);
});
- it('should rename the saved search on timeline rename', () => {
+ it('should rename the discover view on timeline rename', () => {
const initialTimelineSuffix = Date.now();
const initialTimelineName = `Timeline-${initialTimelineSuffix}`;
addDiscoverEsqlQuery(esqlQuery);
@@ -216,14 +216,14 @@ describe(
cy.get(BASIC_TABLE_LOADING).should('not.exist');
cy.get(SAVED_OBJECTS_ROW_TITLES).should(
'contain.text',
- `Saved search for timeline - ${renamedTimelineName}`
+ `Discover view for timeline - ${renamedTimelineName}`
);
});
});
// Issue for enabling below tests: https://github.com/elastic/kibana/issues/165913
context.skip('Advanced Settings', () => {
- it('rows per page in saved search should be according to the user selected number of pages', () => {});
+ it('rows per page in discover view should be according to the user selected number of pages', () => {});
it('rows per page in new search should be according to the value selected in advanced settings', () => {});
});
}
diff --git a/x-pack/test/stack_functional_integration/apps/ccs/ccs_discover.js b/x-pack/test/stack_functional_integration/apps/ccs/ccs_discover.js
index a3d226b36e7bc..9d072d6cc5be6 100644
--- a/x-pack/test/stack_functional_integration/apps/ccs/ccs_discover.js
+++ b/x-pack/test/stack_functional_integration/apps/ccs/ccs_discover.js
@@ -179,7 +179,7 @@ export default ({ getService, getPageObjects }) => {
});
});
- it('should reload the saved search with persisted query to show the initial hit count', async function () {
+ it('should reload the discover view with persisted query to show the initial hit count', async function () {
await PageObjects.discover.selectIndexPattern(
'ftr-remote:makelogs工程-*,local:makelogs工程-*'
);
diff --git a/x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts b/x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts
index 2d54d3ba0a52b..6091157a22f73 100644
--- a/x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts
+++ b/x-pack/test/upgrade/apps/dashboard/dashboard_smoke_tests.ts
@@ -58,7 +58,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.home.launchSampleDashboard('flights');
await PageObjects.header.waitUntilLoadingHasFinished();
await renderable.waitForRender();
- log.debug('Checking saved searches rendered');
+ log.debug('Checking discover viewes rendered');
await dashboardExpect.savedSearchRowCount(49);
log.debug('Checking input controls rendered');
if (semver.lt(process.env.ORIGINAL_VERSION!, '8.6.0-SNAPSHOT')) {
diff --git a/x-pack/test_serverless/functional/fixtures/kbn_archiver/reporting/logs.json b/x-pack/test_serverless/functional/fixtures/kbn_archiver/reporting/logs.json
index 05e92981916af..8d32dc1211649 100644
--- a/x-pack/test_serverless/functional/fixtures/kbn_archiver/reporting/logs.json
+++ b/x-pack/test_serverless/functional/fixtures/kbn_archiver/reporting/logs.json
@@ -441,7 +441,7 @@
]
],
"timeRestore": false,
- "title": "A saved search with match_phrase filter and no columns selected",
+ "title": "A discover view with match_phrase filter and no columns selected",
"usesAdHocDataView": false
},
"coreMigrationVersion": "8.7.0",
@@ -496,7 +496,7 @@
"to": "2015-11-01T01:39:01.782Z"
},
"timeRestore": true,
- "title": "A saved search with the time stored and a query",
+ "title": "A discover view with the time stored and a query",
"usesAdHocDataView": false
},
"coreMigrationVersion": "8.7.0",
@@ -538,7 +538,7 @@
]
],
"timeRestore": false,
- "title": "A saved search with a query",
+ "title": "A discover view with a query",
"usesAdHocDataView": false
},
"coreMigrationVersion": "8.7.0",
diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/embeddable/_saved_search_embeddable.ts b/x-pack/test_serverless/functional/test_suites/common/discover/embeddable/_saved_search_embeddable.ts
index 5b95dace01a6d..ab25343a1a8a8 100644
--- a/x-pack/test_serverless/functional/test_suites/common/discover/embeddable/_saved_search_embeddable.ts
+++ b/x-pack/test_serverless/functional/test_suites/common/discover/embeddable/_saved_search_embeddable.ts
@@ -21,7 +21,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'timePicker', 'discover']);
- describe('discover saved search embeddable', () => {
+ describe('discover discover view embeddable', () => {
before(async () => {
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data');
@@ -103,7 +103,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await cell.getVisibleText()).to.be('Sep 22, 2015 @ 23:50:13.253');
});
- it('should render duplicate saved search embeddables', async () => {
+ it('should render duplicate discover view embeddables', async () => {
await addSearchEmbeddableToDashboard();
await addSearchEmbeddableToDashboard();
const [firstGridCell, secondGridCell] = await dataGrid.getAllCellElements();
@@ -129,7 +129,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
});
- it('should replace a panel with a saved search', async () => {
+ it('should replace a panel with a discover view', async () => {
await dashboardAddPanel.addVisualization('Rendering Test: datatable');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.dashboard.waitForRenderComplete();
diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover.ts b/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover.ts
index 9768eb43e76ca..a09cb0cb67070 100644
--- a/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover.ts
+++ b/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover.ts
@@ -129,7 +129,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(isVisible).to.be(false);
});
- it('should reload the saved search with persisted query to show the initial hit count', async function () {
+ it('should reload the discover view with persisted query to show the initial hit count', async function () {
await PageObjects.timePicker.setDefaultAbsoluteRange();
await PageObjects.discover.waitUntilSearchingHasFinished();
// apply query some changes
diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts b/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts
index cf581ad3edb51..4d1c87688483b 100644
--- a/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts
+++ b/x-pack/test_serverless/functional/test_suites/common/discover/group1/_discover_histogram.ts
@@ -192,13 +192,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(canvasExists).to.be(true);
});
});
- it('should allow hiding the histogram, persisted in saved search', async () => {
+ it('should allow hiding the histogram, persisted in discover view', async () => {
const from = 'Jan 1, 2010 @ 00:00:00.000';
const to = 'Mar 21, 2019 @ 00:00:00.000';
const savedSearch = 'persisted hidden histogram';
await prepareTest({ from, to });
- // close chart for saved search
+ // close chart for discover view
await PageObjects.discover.toggleChartVisibility();
let canvasExists: boolean;
await retry.try(async () => {
@@ -214,13 +214,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.clickNewSearchButton();
await PageObjects.header.waitUntilLoadingHasFinished();
- // load saved search
+ // load discover view
await PageObjects.discover.loadSavedSearch(savedSearch);
await PageObjects.header.waitUntilLoadingHasFinished();
canvasExists = await elasticChart.canvasExists();
expect(canvasExists).to.be(false);
- // open chart for saved search
+ // open chart for discover view
await PageObjects.discover.toggleChartVisibility();
await retry.waitFor(`Discover histogram to be displayed`, async () => {
canvasExists = await elasticChart.canvasExists();
@@ -235,7 +235,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.clickNewSearchButton();
await PageObjects.header.waitUntilLoadingHasFinished();
- // load saved search
+ // load discover view
await PageObjects.discover.loadSavedSearch(savedSearch);
await PageObjects.header.waitUntilLoadingHasFinished();
canvasExists = await elasticChart.canvasExists();
@@ -299,7 +299,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await PageObjects.discover.isChartVisible()).to.be(true);
});
- it('should reset all histogram state when resetting the saved search', async () => {
+ it('should reset all histogram state when resetting the discover view', async () => {
await PageObjects.common.navigateToApp('discover');
await PageObjects.discover.waitUntilSearchingHasFinished();
await PageObjects.timePicker.setDefaultAbsoluteRange();
diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/group2/_adhoc_data_views.ts b/x-pack/test_serverless/functional/test_suites/common/discover/group2/_adhoc_data_views.ts
index 03dd58892e5cf..0e2edb88ffffe 100644
--- a/x-pack/test_serverless/functional/test_suites/common/discover/group2/_adhoc_data_views.ts
+++ b/x-pack/test_serverless/functional/test_suites/common/discover/group2/_adhoc_data_views.ts
@@ -186,7 +186,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(+second).to.equal(+first * 2);
});
- it('should open saved search by navigation to context from embeddable', async () => {
+ it('should open discover view by navigation to context from embeddable', async () => {
// navigate to context view
await dataGrid.clickRowToggle({ rowIndex: 0 });
const [, surrDocs] = await dataGrid.getRowActions({ rowIndex: 0 });
@@ -200,7 +200,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
}
await PageObjects.context.waitUntilContextLoadingHasFinished();
- // open saved search
+ // open discover view
// TODO: Clicking breadcrumbs works differently in Serverless
await PageObjects.svlCommonNavigation.breadcrumbs.clickBreadcrumb({ deepLinkId: 'discover' });
await PageObjects.header.waitUntilLoadingHasFinished();
diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/group3/_request_counts.ts b/x-pack/test_serverless/functional/test_suites/common/discover/group3/_request_counts.ts
index 8e373bae57ad6..d3382c470a91c 100644
--- a/x-pack/test_serverless/functional/test_suites/common/discover/group3/_request_counts.ts
+++ b/x-pack/test_serverless/functional/test_suites/common/discover/group3/_request_counts.ts
@@ -135,7 +135,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
- it('should send 2 requests for saved search changes', async () => {
+ it('should send 2 requests for discover view changes', async () => {
await setQuery(query1);
await queryBar.clickQuerySubmitButton();
await PageObjects.timePicker.setAbsoluteRange(
@@ -143,25 +143,25 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'Sep 23, 2015 @ 00:00:00.000'
);
await waitForLoadingToFinish();
- // TODO: Check why the request happens 4 times in case of opening a saved search
+ // TODO: Check why the request happens 4 times in case of opening a discover view
// https://github.com/elastic/kibana/issues/165192
- // creating the saved search
+ // creating the discover view
await expectSearches(type, savedSearchesRequests ?? 2, async () => {
await PageObjects.discover.saveSearch(savedSearch);
});
- // resetting the saved search
+ // resetting the discover view
await setQuery(query2);
await queryBar.clickQuerySubmitButton();
await waitForLoadingToFinish();
await expectSearches(type, 2, async () => {
await PageObjects.discover.revertUnsavedChanges();
});
- // clearing the saved search
+ // clearing the discover view
await expectSearches('ese', 2, async () => {
await testSubjects.click('discoverNewButton');
await waitForLoadingToFinish();
});
- // loading the saved search
+ // loading the discover view
// TODO: https://github.com/elastic/kibana/issues/165192
await expectSearches(type, savedSearchesRequests ?? 2, async () => {
await PageObjects.discover.loadSavedSearch(savedSearch);
diff --git a/x-pack/test_serverless/functional/test_suites/common/discover/group3/_unsaved_changes_badge.ts b/x-pack/test_serverless/functional/test_suites/common/discover/group3/_unsaved_changes_badge.ts
index 1f6f89a7bb33b..4d973cdf12e52 100644
--- a/x-pack/test_serverless/functional/test_suites/common/discover/group3/_unsaved_changes_badge.ts
+++ b/x-pack/test_serverless/functional/test_suites/common/discover/group3/_unsaved_changes_badge.ts
@@ -8,8 +8,8 @@
import expect from '@kbn/expect';
import { FtrProviderContext } from '../../../../ftr_provider_context';
-const SAVED_SEARCH_NAME = 'test saved search';
-const SAVED_SEARCH_WITH_FILTERS_NAME = 'test saved search with filters';
+const SAVED_SEARCH_NAME = 'test discover view';
+const SAVED_SEARCH_WITH_FILTERS_NAME = 'test discover view with filters';
export default function ({ getService, getPageObjects }: FtrProviderContext) {
const esArchiver = getService('esArchiver');
@@ -53,7 +53,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.waitUntilSearchingHasFinished();
});
- it('should not show the badge initially nor after changes to a draft saved search', async () => {
+ it('should not show the badge initially nor after changes to a draft discover view', async () => {
await testSubjects.missingOrFail('unsavedChangesBadge');
await PageObjects.unifiedFieldList.clickFieldListItemAdd('bytes');
@@ -64,7 +64,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await testSubjects.missingOrFail('unsavedChangesBadge');
});
- it('should show the badge only after changes to a persisted saved search', async () => {
+ it('should show the badge only after changes to a persisted discover view', async () => {
await PageObjects.discover.saveSearch(SAVED_SEARCH_NAME);
await PageObjects.discover.waitUntilSearchingHasFinished();
@@ -81,7 +81,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await testSubjects.missingOrFail('unsavedChangesBadge');
});
- it('should not show a badge after loading a saved search, only after changes', async () => {
+ it('should not show a badge after loading a discover view, only after changes', async () => {
await PageObjects.discover.loadSavedSearch(SAVED_SEARCH_NAME);
await testSubjects.missingOrFail('unsavedChangesBadge');
diff --git a/x-pack/test_serverless/functional/test_suites/common/reporting/management.ts b/x-pack/test_serverless/functional/test_suites/common/reporting/management.ts
index 90be1b602441a..d6010241c5b77 100644
--- a/x-pack/test_serverless/functional/test_suites/common/reporting/management.ts
+++ b/x-pack/test_serverless/functional/test_suites/common/reporting/management.ts
@@ -55,7 +55,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const TEST_PASSWORD = config.get('servers.kibana.password');
before('initialize saved object archive', async () => {
- // add test saved search object
+ // add test discover view object
await kibanaServer.importExport.load(savedObjectsArchive);
});