From ee6ef81dd99d7f4ab0de709e74d7ecc6b46a30c0 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Sat, 5 Oct 2024 08:57:29 +1000
Subject: [PATCH] [8.x] [Core Rendering Styles] Fix bug with
 kibanaFullBodyHeight calculation (#193798) (#195146)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Core Rendering Styles] Fix bug with kibanaFullBodyHeight calculation
(#193798)](https://github.com/elastic/kibana/pull/193798)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tim
Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-04T21:00:57Z","message":"[Core
Rendering Styles] Fix bug with kibanaFullBodyHeight calculation
(#193798)\n\nA variable for the page height was not being calculated
correctly when\r\nthe Kibana chrome is invisible. This PR fixes the
issue by adding `px`\r\nas a unit to a variable used as input in the
calculation.\r\n\r\nUnblocks:
https://github.com/elastic/kibana/pull/193647\r\n\r\n## Testing\r\nIt
will help to test within
the\r\nhttps://github.com/elastic/kibana/pull/193647 PR branch. The
following\r\nscreenshots show the before and after effects of having
this
fix:\r\n\r\n**before**\r\n\r\n![ghjkgjghgkhjgjgkjg-1](https://github.com/user-attachments/assets/d684bc77-dcc0-40ef-9271-8ae198582eea)\r\n\r\n**after**\r\n\r\n![ghjkgjghgkhjgjgkjg-2](https://github.com/user-attachments/assets/5198cc43-b721-4ce8-92f0-0b2bac9f5eb5)\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Marco
Vettorello
<marco.vettorello@elastic.co>","sha":"1df458d2d605f5a3281c3b18bda9f433d41a7c05","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"[Core
Rendering Styles] Fix bug with kibanaFullBodyHeight
calculation","number":193798,"url":"https://github.com/elastic/kibana/pull/193798","mergeCommit":{"message":"[Core
Rendering Styles] Fix bug with kibanaFullBodyHeight calculation
(#193798)\n\nA variable for the page height was not being calculated
correctly when\r\nthe Kibana chrome is invisible. This PR fixes the
issue by adding `px`\r\nas a unit to a variable used as input in the
calculation.\r\n\r\nUnblocks:
https://github.com/elastic/kibana/pull/193647\r\n\r\n## Testing\r\nIt
will help to test within
the\r\nhttps://github.com/elastic/kibana/pull/193647 PR branch. The
following\r\nscreenshots show the before and after effects of having
this
fix:\r\n\r\n**before**\r\n\r\n![ghjkgjghgkhjgjgkjg-1](https://github.com/user-attachments/assets/d684bc77-dcc0-40ef-9271-8ae198582eea)\r\n\r\n**after**\r\n\r\n![ghjkgjghgkhjgjgkjg-2](https://github.com/user-attachments/assets/5198cc43-b721-4ce8-92f0-0b2bac9f5eb5)\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Marco
Vettorello
<marco.vettorello@elastic.co>","sha":"1df458d2d605f5a3281c3b18bda9f433d41a7c05"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193798","number":193798,"mergeCommit":{"message":"[Core
Rendering Styles] Fix bug with kibanaFullBodyHeight calculation
(#193798)\n\nA variable for the page height was not being calculated
correctly when\r\nthe Kibana chrome is invisible. This PR fixes the
issue by adding `px`\r\nas a unit to a variable used as input in the
calculation.\r\n\r\nUnblocks:
https://github.com/elastic/kibana/pull/193647\r\n\r\n## Testing\r\nIt
will help to test within
the\r\nhttps://github.com/elastic/kibana/pull/193647 PR branch. The
following\r\nscreenshots show the before and after effects of having
this
fix:\r\n\r\n**before**\r\n\r\n![ghjkgjghgkhjgjgkjg-1](https://github.com/user-attachments/assets/d684bc77-dcc0-40ef-9271-8ae198582eea)\r\n\r\n**after**\r\n\r\n![ghjkgjghgkhjgjgkjg-2](https://github.com/user-attachments/assets/5198cc43-b721-4ce8-92f0-0b2bac9f5eb5)\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Marco
Vettorello
<marco.vettorello@elastic.co>","sha":"1df458d2d605f5a3281c3b18bda9f433d41a7c05"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
---
 src/core/public/styles/rendering/_base.scss | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/core/public/styles/rendering/_base.scss b/src/core/public/styles/rendering/_base.scss
index 1bcfaab71ea17..259115f6a526a 100644
--- a/src/core/public/styles/rendering/_base.scss
+++ b/src/core/public/styles/rendering/_base.scss
@@ -67,7 +67,8 @@
 }
 
 .kbnBody--chromeHidden {
-  --euiFixedHeadersOffset: 0;
+  // stylelint-disable-next-line length-zero-no-unit
+  --euiFixedHeadersOffset: 0px;
 
   &.kbnBody--hasHeaderBanner {
     --euiFixedHeadersOffset: var(--kbnHeaderBannerHeight);