From e859b147110d265c587eb3df7733992acde671e4 Mon Sep 17 00:00:00 2001
From: Jill Guyonnet <jill.guyonnet@elastic.co>
Date: Tue, 21 Nov 2023 10:53:57 +0100
Subject: [PATCH] [Fleet] Enable agent upgrade tooltip (#168638)

## Summary

Followup to https://github.com/elastic/kibana/pull/167539.

Closes https://github.com/elastic/ingest-dev/issues/2568.

As the version on which agents will have upgrade details is not known
yet, we decided to defer showing the tooltip for agents that don't until
it is (cf.
https://github.com/elastic/kibana/pull/167539#discussion_r1354346944).

This PR sets the version to 8.12.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
---
 .../agent_list_page/components/agent_upgrade_status.test.tsx  | 3 +--
 .../agent_list_page/components/agent_upgrade_status.tsx       | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_upgrade_status.test.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_upgrade_status.test.tsx
index dffa4bc665bdb..1518a68fd6f0c 100644
--- a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_upgrade_status.test.tsx
+++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_upgrade_status.test.tsx
@@ -244,8 +244,7 @@ describe('AgentUpgradeStatus', () => {
       expect(results.queryAllByText('Info')).toEqual([]);
     });
 
-    // Unskip this test when minVersion is set.
-    it.skip('should render an icon with tooltip if the agent is upgrading', async () => {
+    it('should render an icon with tooltip if the agent is upgrading', async () => {
       const results = render({
         agentUpgradeStartedAt: '2023-10-03T14:34:12Z',
         agentUpgradedAt: null,
diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_upgrade_status.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_upgrade_status.tsx
index 572b86d62c73d..ab4835757f94d 100644
--- a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_upgrade_status.tsx
+++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_upgrade_status.tsx
@@ -225,7 +225,7 @@ export const AgentUpgradeStatus: React.FC<{
     [agentUpgradeStartedAt, agentUpgradedAt]
   );
   const status = useMemo(() => getStatusComponents(agentUpgradeDetails), [agentUpgradeDetails]);
-  const minVersion = undefined; // Change this to a string in order for a tooltip to render for upgrading agents with no upgrade details.
+  const minVersion = '8.12';
 
   if (isAgentUpgradable) {
     return (
@@ -249,7 +249,7 @@ export const AgentUpgradeStatus: React.FC<{
     );
   }
 
-  if (minVersion && isAgentUpgrading) {
+  if (isAgentUpgrading) {
     return (
       <EuiIconTip
         type="iInCircle"