diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details_route.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details_route.tsx index 116c97ef905d7..e195b12eea9e6 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details_route.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_details_route.tsx @@ -130,20 +130,22 @@ export const RuleDetailsRoute: React.FunctionComponent = return null; }; - return rule && ruleType && actionTypes ? ( - <> - {getLegacyUrlConflictCallout()} - - - ) : ( - - ); + if (rule && ruleType && actionTypes) { + return ( + <> + {getLegacyUrlConflictCallout()} + + + ); + } + + return ; }; export async function getRuleData( diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_route.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_route.tsx index f1df6af277549..2c7c5a7ac9267 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_route.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_route.tsx @@ -7,7 +7,7 @@ import { i18n } from '@kbn/i18n'; import { ToastsApi } from '@kbn/core/public'; -import React, { useState, useEffect, useRef, useCallback } from 'react'; +import React, { useState, useEffect, useRef, useCallback, Suspense } from 'react'; import { Rule, RuleSummary, RuleType } from '../../../../types'; import { ComponentOpts as RuleApis, @@ -76,17 +76,19 @@ export const RuleRoute: React.FunctionComponent = ({ ); return ruleSummary ? ( - + }> + + ) : ( ); diff --git a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts index b71f659b10baa..546ee11fd4ea8 100644 --- a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts +++ b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts @@ -319,9 +319,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { }); }); - // FLAKY: https://github.com/elastic/kibana/issues/172941 - // FLAKY: https://github.com/elastic/kibana/issues/173008 - describe.skip('Edit rule button', function () { + describe('Edit rule button', function () { const ruleName = uuidv4(); const updatedRuleName = `Changed Rule Name ${ruleName}`;