From dbbbde883781f130c0dcfd79fbea505970e231be Mon Sep 17 00:00:00 2001
From: Shahzad <shahzad31comp@gmail.com>
Date: Thu, 26 Sep 2024 23:10:35 +0200
Subject: [PATCH] [SLOs] Fix matching path for slo in observability nav !!
 (#194186)

## Summary

### Before

notice slo is not selected

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/08068de6-5b1d-4f37-b55d-aace8c56aa79">


### After
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/378d9141-3726-41e0-8256-10f2149b9eb2">
---
 .../observability_solution/observability/public/plugin.ts       | 2 +-
 .../public/rules/register_observability_rule_types.ts           | 2 +-
 .../slo/public/rules/register_burn_rate_rule_type.ts            | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/x-pack/plugins/observability_solution/observability/public/plugin.ts b/x-pack/plugins/observability_solution/observability/public/plugin.ts
index a4b0d8e57ce4b..5866a082556bb 100644
--- a/x-pack/plugins/observability_solution/observability/public/plugin.ts
+++ b/x-pack/plugins/observability_solution/observability/public/plugin.ts
@@ -382,7 +382,7 @@ export class Plugin
                         defaultMessage: 'SLOs',
                       }),
                       app: 'slo',
-                      path: '/',
+                      path: '',
                     },
                   ]
                 : [];
diff --git a/x-pack/plugins/observability_solution/observability/public/rules/register_observability_rule_types.ts b/x-pack/plugins/observability_solution/observability/public/rules/register_observability_rule_types.ts
index 0d296b19782c4..2fd8407f39a5f 100644
--- a/x-pack/plugins/observability_solution/observability/public/rules/register_observability_rule_types.ts
+++ b/x-pack/plugins/observability_solution/observability/public/rules/register_observability_rule_types.ts
@@ -56,7 +56,7 @@ const getDataViewId = (searchConfiguration?: SearchConfigurationWithExtractedRef
     ? searchConfiguration.index
     : searchConfiguration?.index?.title;
 
-export const registerObservabilityRuleTypes = async (
+export const registerObservabilityRuleTypes = (
   observabilityRuleTypeRegistry: ObservabilityRuleTypeRegistry,
   uiSettings: IUiSettingsClient,
   logsExplorerLocator?: LocatorPublic<LogsExplorerLocatorParams>
diff --git a/x-pack/plugins/observability_solution/slo/public/rules/register_burn_rate_rule_type.ts b/x-pack/plugins/observability_solution/slo/public/rules/register_burn_rate_rule_type.ts
index f14063b77463c..f843809543620 100644
--- a/x-pack/plugins/observability_solution/slo/public/rules/register_burn_rate_rule_type.ts
+++ b/x-pack/plugins/observability_solution/slo/public/rules/register_burn_rate_rule_type.ts
@@ -46,7 +46,7 @@ const sloBurnRateDefaultRecoveryMessage = i18n.translate(
   }
 );
 
-export const registerBurnRateRuleType = async (
+export const registerBurnRateRuleType = (
   observabilityRuleTypeRegistry: ObservabilityRuleTypeRegistry
 ) => {
   observabilityRuleTypeRegistry.register({