From d52cf928b2703e93b614227e5be031e4807afb69 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Tue, 9 Jul 2024 14:58:19 +0200
Subject: [PATCH] [8.15] [ML] Transform: Fix transform stats API call in the
 transform health alerting rule  (#187586) (#187617)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ML] Transform: Fix transform stats API call in the transform health
alerting rule (#187586)](https://github.com/elastic/kibana/pull/187586)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2024-07-05T07:08:08Z","message":"[ML]
Transform: Fix transform stats API call in the transform health alerting
rule (#187586)\n\n## Summary\r\n\r\nIn rare cases when the list of
continuous transform exceeds the allowed\r\nURL length, we fetch stats
for all transforms.\r\n\r\nThe elasticsearch client has `transform-id`
param as optional, but we\r\nactually have to pass `_all` or `*`. This
PR sets the `transform_id`\r\nparam explicitly in this case.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"1a8bacc5473534fe8ec254667d561b0bd3c739d5","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Transforms","Feature:Alerting/RuleTypes","Team:ML","v8.15.0","v8.16.0"],"title":"[ML]
Transform: Fix transform stats API call in the transform health alerting
rule
","number":187586,"url":"https://github.com/elastic/kibana/pull/187586","mergeCommit":{"message":"[ML]
Transform: Fix transform stats API call in the transform health alerting
rule (#187586)\n\n## Summary\r\n\r\nIn rare cases when the list of
continuous transform exceeds the allowed\r\nURL length, we fetch stats
for all transforms.\r\n\r\nThe elasticsearch client has `transform-id`
param as optional, but we\r\nactually have to pass `_all` or `*`. This
PR sets the `transform_id`\r\nparam explicitly in this case.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"1a8bacc5473534fe8ec254667d561b0bd3c739d5"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187586","number":187586,"mergeCommit":{"message":"[ML]
Transform: Fix transform stats API call in the transform health alerting
rule (#187586)\n\n## Summary\r\n\r\nIn rare cases when the list of
continuous transform exceeds the allowed\r\nURL length, we fetch stats
for all transforms.\r\n\r\nThe elasticsearch client has `transform-id`
param as optional, but we\r\nactually have to pass `_all` or `*`. This
PR sets the `transform_id`\r\nparam explicitly in this case.\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"1a8bacc5473534fe8ec254667d561b0bd3c739d5"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
---
 .../transform_health_rule_type/transform_health_service.test.ts  | 1 +
 .../transform_health_rule_type/transform_health_service.ts       | 1 +
 2 files changed, 2 insertions(+)

diff --git a/x-pack/plugins/transform/server/lib/alerting/transform_health_rule_type/transform_health_service.test.ts b/x-pack/plugins/transform/server/lib/alerting/transform_health_rule_type/transform_health_service.test.ts
index cbe68b096e09d..ff502c9fcdc2e 100644
--- a/x-pack/plugins/transform/server/lib/alerting/transform_health_rule_type/transform_health_service.test.ts
+++ b/x-pack/plugins/transform/server/lib/alerting/transform_health_rule_type/transform_health_service.test.ts
@@ -117,6 +117,7 @@ describe('transformHealthServiceProvider', () => {
     expect(esClient.transform.getTransformStats).toHaveBeenCalledTimes(1);
     expect(esClient.transform.getTransformStats).toHaveBeenNthCalledWith(1, {
       basic: true,
+      transform_id: '_all',
     });
 
     const notStarted = result[0];
diff --git a/x-pack/plugins/transform/server/lib/alerting/transform_health_rule_type/transform_health_service.ts b/x-pack/plugins/transform/server/lib/alerting/transform_health_rule_type/transform_health_service.ts
index 7ad2fdde6057d..939d4e01a6f1d 100644
--- a/x-pack/plugins/transform/server/lib/alerting/transform_health_rule_type/transform_health_service.ts
+++ b/x-pack/plugins/transform/server/lib/alerting/transform_health_rule_type/transform_health_service.ts
@@ -122,6 +122,7 @@ export function transformHealthServiceProvider({
             await esClient.transform.getTransformStats({
               // @ts-expect-error `basic` query option not yet in @elastic/elasticsearch
               basic: true,
+              transform_id: '_all',
             })
           ).transforms as TransformStats[]
         ).filter((t) => transformIds.has(t.id));