From cf243290ab0fb87e7f95be205a5619c0e57345dd Mon Sep 17 00:00:00 2001
From: Georgii Gorbachev <georgii.gorbachev@elastic.co>
Date: Fri, 23 Feb 2024 16:17:20 +0100
Subject: [PATCH] [8.13] [Security Solution] Enable per field diffs feature
 (#177495) (#177708)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Security Solution] Enable per field diffs feature
(#177495)](https://github.com/elastic/kibana/pull/177495)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Georgii
Gorbachev","email":"georgii.gorbachev@elastic.co"},"sourceCommit":{"committedDate":"2024-02-23T12:28:22Z","message":"[Security
Solution] Enable per field diffs feature (#177495)\n\n**Addresses:**
https://github.com/elastic/kibana/issues/166489\r\n\r\n##
Summary\r\n\r\nTurns on the `perFieldPrebuiltRulesDiffingEnabled`
feature flag by\r\ndefault.\r\n\r\nThis will enable the `Updates` tab
containing per-field rule diffs in\r\nthe rule upgrade flyout. The
feature will be enabled in `8.13.0` and\r\nServerless. See more info in
the related ticket.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"61b7f67bda066d57455f5ca2ed69fd4e61657ffb","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","ci:cloud-deploy","ci:project-deploy-security","v8.13.0","v8.14.0"],"number":177495,"url":"https://github.com/elastic/kibana/pull/177495","mergeCommit":{"message":"[Security
Solution] Enable per field diffs feature (#177495)\n\n**Addresses:**
https://github.com/elastic/kibana/issues/166489\r\n\r\n##
Summary\r\n\r\nTurns on the `perFieldPrebuiltRulesDiffingEnabled`
feature flag by\r\ndefault.\r\n\r\nThis will enable the `Updates` tab
containing per-field rule diffs in\r\nthe rule upgrade flyout. The
feature will be enabled in `8.13.0` and\r\nServerless. See more info in
the related ticket.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"61b7f67bda066d57455f5ca2ed69fd4e61657ffb"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177495","number":177495,"mergeCommit":{"message":"[Security
Solution] Enable per field diffs feature (#177495)\n\n**Addresses:**
https://github.com/elastic/kibana/issues/166489\r\n\r\n##
Summary\r\n\r\nTurns on the `perFieldPrebuiltRulesDiffingEnabled`
feature flag by\r\ndefault.\r\n\r\nThis will enable the `Updates` tab
containing per-field rule diffs in\r\nthe rule upgrade flyout. The
feature will be enabled in `8.13.0` and\r\nServerless. See more info in
the related ticket.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"61b7f67bda066d57455f5ca2ed69fd4e61657ffb"}}]}]
BACKPORT-->
---
 .../common/experimental_features.ts           | 59 ++++++++++---------
 1 file changed, 30 insertions(+), 29 deletions(-)

diff --git a/x-pack/plugins/security_solution/common/experimental_features.ts b/x-pack/plugins/security_solution/common/experimental_features.ts
index 5a2e2f50237f4..7c54093898f7a 100644
--- a/x-pack/plugins/security_solution/common/experimental_features.ts
+++ b/x-pack/plugins/security_solution/common/experimental_features.ts
@@ -21,6 +21,7 @@ export const allowedExperimentalValues = Object.freeze({
   kubernetesEnabled: true,
   chartEmbeddablesEnabled: true,
   donutChartEmbeddablesEnabled: false, // Depends on https://github.com/elastic/kibana/issues/136409 item 2 - 6
+
   /**
    * This is used for enabling the end-to-end tests for the security_solution telemetry.
    * We disable the telemetry since we don't have specific roles or permissions around it and
@@ -70,7 +71,7 @@ export const allowedExperimentalValues = Object.freeze({
    */
   responseActionUploadEnabled: true,
 
-  /*
+  /**
    * Enables Automated Endpoint Process actions
    */
   automatedProcessActionsEnabled: true,
@@ -84,18 +85,20 @@ export const allowedExperimentalValues = Object.freeze({
    * Enables top charts on Alerts Page
    */
   alertsPageChartsEnabled: true,
+
   /**
    * Enables the alert type column in KPI visualizations on Alerts Page
    */
   alertTypeEnabled: false,
+
   /**
    * Enables expandable flyout in create rule page, alert preview
    */
   expandableFlyoutInCreateRuleEnabled: true,
-  /*
+
+  /**
    * Enables new Set of filters on the Alerts page.
-   *
-   **/
+   */
   alertsPageFiltersEnabled: true,
 
   /**
@@ -103,23 +106,20 @@ export const allowedExperimentalValues = Object.freeze({
    */
   assistantModelEvaluation: false,
 
-  /*
+  /**
    * Enables the new user details flyout displayed on the Alerts table.
-   *
-   **/
+   */
   newUserDetailsFlyout: true,
 
-  /*
+  /**
    * Enables the Managed User section inside the new user details flyout.
    * To see this section you also need newUserDetailsFlyout flag enabled.
-   *
-   **/
+   */
   newUserDetailsFlyoutManagedUser: false,
 
-  /*
+  /**
    * Enables the new host details flyout displayed on the Alerts table.
-   *
-   **/
+   */
   newHostDetailsFlyout: true,
 
   /**
@@ -159,7 +159,7 @@ export const allowedExperimentalValues = Object.freeze({
    */
   alertSuppressionForIndicatorMatchRuleEnabled: false,
 
-  /*
+  /**
    * Enables experimental Experimental S1 integration data to be available in Analyzer
    */
   sentinelOneDataInAnalyzerEnabled: true,
@@ -169,12 +169,12 @@ export const allowedExperimentalValues = Object.freeze({
    */
   sentinelOneManualHostActionsEnabled: true,
 
-  /*
+  /**
    * Enables experimental Crowdstrike integration data to be available in Analyzer
    */
   crowdstrikeDataInAnalyzerEnabled: false,
 
-  /*
+  /**
    * Enables experimental "Updates" tab in the prebuilt rule upgrade flyout.
    * This tab shows the JSON diff between the installed prebuilt rule
    * version and the latest available version.
@@ -186,26 +186,27 @@ export const allowedExperimentalValues = Object.freeze({
    * Expires: on Feb 20, 2024
    */
   jsonPrebuiltRulesDiffingEnabled: true,
-  /*
-   * Disables discover esql tab within timeline
-   *
-   */
-  timelineEsqlTabDisabled: false,
-
-  /*
-   * Disables date pickers and sourcerer in analyzer if needed.
-   *
-   */
-  analyzerDatePickersAndSourcererDisabled: false,
 
   /**
    * Enables per-field rule diffs tab in the prebuilt rule upgrade flyout
    *
    * Ticket: https://github.com/elastic/kibana/issues/166489
    * Owners: https://github.com/orgs/elastic/teams/security-detection-rule-management
-   * Added: on Feb 12, 2023 in https://github.com/elastic/kibana/pull/174564
+   * Added: on Feb 12, 2024 in https://github.com/elastic/kibana/pull/174564
+   * Turned: on Feb 23, 2024 in https://github.com/elastic/kibana/pull/177495
+   * Expires: on Apr 23, 2024
    */
-  perFieldPrebuiltRulesDiffingEnabled: false,
+  perFieldPrebuiltRulesDiffingEnabled: true,
+
+  /**
+   * Disables discover esql tab within timeline
+   */
+  timelineEsqlTabDisabled: false,
+
+  /**
+   * Disables date pickers and sourcerer in analyzer if needed.
+   */
+  analyzerDatePickersAndSourcererDisabled: false,
 });
 
 type ExperimentalConfigKeys = Array<keyof ExperimentalFeatures>;