From c7fa004d30602fc68f627ef181b3f7cbb9434a90 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Fri, 11 Oct 2024 05:07:23 +1100
Subject: [PATCH] [8.x] [Index Management] Fix filter index list by lifecycle
 status (#195350) (#195803)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Index Management] Fix filter index list by lifecycle status
(#195350)](https://github.com/elastic/kibana/pull/195350)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jusheng
Huang","email":"117657272+viajes7@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-10T16:05:23Z","message":"[Index
Management] Fix filter index list by lifecycle status (#195350)\n\n##
Summary\r\n\r\nFixes #180970 \r\n\r\nIn `indexLifecycleDataEnricher`,
add `only_managed: true` query\r\nparameter to fetch lifecycle
data.\r\n\r\nIt causes the `ilm` property to be empty in the response.
And\r\n`EuiSearchBar` `field_value_selection` doesn't support filtering
a\r\n`undefined` filed value.\r\n\r\nSo, maybe `only_managed: true`
should be removed.\r\n\r\nBefore:\r\n\r\n<img width=\"733\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2472127d-c050-4ffb-bb76-f3e80e780cb3\">\r\n\r\nAfter:
\r\n\r\n<img width=\"511\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/da38f437-58f4-43b2-8d6b-54873e01f79b\">\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Elena
Stoeva
<59341489+ElenaStoeva@users.noreply.github.com>","sha":"52148775b1ff4b4379f0049cc2332fb27e405a07","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","💝community","v9.0.0","backport:prev-minor"],"title":"[Index
Management] Fix filter index list by lifecycle
status","number":195350,"url":"https://github.com/elastic/kibana/pull/195350","mergeCommit":{"message":"[Index
Management] Fix filter index list by lifecycle status (#195350)\n\n##
Summary\r\n\r\nFixes #180970 \r\n\r\nIn `indexLifecycleDataEnricher`,
add `only_managed: true` query\r\nparameter to fetch lifecycle
data.\r\n\r\nIt causes the `ilm` property to be empty in the response.
And\r\n`EuiSearchBar` `field_value_selection` doesn't support filtering
a\r\n`undefined` filed value.\r\n\r\nSo, maybe `only_managed: true`
should be removed.\r\n\r\nBefore:\r\n\r\n<img width=\"733\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2472127d-c050-4ffb-bb76-f3e80e780cb3\">\r\n\r\nAfter:
\r\n\r\n<img width=\"511\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/da38f437-58f4-43b2-8d6b-54873e01f79b\">\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Elena
Stoeva
<59341489+ElenaStoeva@users.noreply.github.com>","sha":"52148775b1ff4b4379f0049cc2332fb27e405a07"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195350","number":195350,"mergeCommit":{"message":"[Index
Management] Fix filter index list by lifecycle status (#195350)\n\n##
Summary\r\n\r\nFixes #180970 \r\n\r\nIn `indexLifecycleDataEnricher`,
add `only_managed: true` query\r\nparameter to fetch lifecycle
data.\r\n\r\nIt causes the `ilm` property to be empty in the response.
And\r\n`EuiSearchBar` `field_value_selection` doesn't support filtering
a\r\n`undefined` filed value.\r\n\r\nSo, maybe `only_managed: true`
should be removed.\r\n\r\nBefore:\r\n\r\n<img width=\"733\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2472127d-c050-4ffb-bb76-f3e80e780cb3\">\r\n\r\nAfter:
\r\n\r\n<img width=\"511\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/da38f437-58f4-43b2-8d6b-54873e01f79b\">\r\n\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>\r\nCo-authored-by: Elena
Stoeva
<59341489+ElenaStoeva@users.noreply.github.com>","sha":"52148775b1ff4b4379f0049cc2332fb27e405a07"}}]}]
BACKPORT-->

Co-authored-by: Jusheng Huang <117657272+viajes7@users.noreply.github.com>
---
 .../server/plugin.ts                          |  1 -
 .../index_management/data_enrichers/ilm.ts    | 22 +++++++++++++++----
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/x-pack/plugins/index_lifecycle_management/server/plugin.ts b/x-pack/plugins/index_lifecycle_management/server/plugin.ts
index 0d88acbaaa4ff..a5002cd36da44 100644
--- a/x-pack/plugins/index_lifecycle_management/server/plugin.ts
+++ b/x-pack/plugins/index_lifecycle_management/server/plugin.ts
@@ -27,7 +27,6 @@ const indexLifecycleDataEnricher = async (
 
   const { indices: ilmIndicesData } = await client.asCurrentUser.ilm.explainLifecycle({
     index: '*,.*',
-    only_managed: true,
   });
   return indicesList.map((index: Index) => {
     return {
diff --git a/x-pack/test/api_integration/apis/management/index_management/data_enrichers/ilm.ts b/x-pack/test/api_integration/apis/management/index_management/data_enrichers/ilm.ts
index 234a1518a9c59..3ae9b554bf3ee 100644
--- a/x-pack/test/api_integration/apis/management/index_management/data_enrichers/ilm.ts
+++ b/x-pack/test/api_integration/apis/management/index_management/data_enrichers/ilm.ts
@@ -55,16 +55,17 @@ export default function ({ getService }: FtrProviderContext) {
   const testAlias = 'test_alias';
   const testIlmPolicy = 'test_policy';
   describe('GET indices with data enrichers', () => {
-    before(async () => {
+    beforeEach(async () => {
       await createIndex(testIndex);
-      await createIlmPolicy('test_policy');
-      await addPolicyToIndex(testIlmPolicy, testIndex, testAlias);
     });
-    after(async () => {
+    afterEach(async () => {
       await esDeleteAllIndices([testIndex]);
     });
 
     it(`ILM data is fetched by the ILM data enricher`, async () => {
+      await createIlmPolicy('test_policy');
+      await addPolicyToIndex(testIlmPolicy, testIndex, testAlias);
+
       const { body: indices } = await supertest
         .get(`${API_BASE_PATH}/indices`)
         .set('kbn-xsrf', 'xxx')
@@ -75,5 +76,18 @@ export default function ({ getService }: FtrProviderContext) {
       const { ilm } = index;
       expect(ilm.policy).to.eql(testIlmPolicy);
     });
+
+    it(`ILM data is not empty even if the index unmanaged`, async () => {
+      const { body: indices } = await supertest
+        .get(`${API_BASE_PATH}/indices`)
+        .set('kbn-xsrf', 'xxx')
+        .expect(200);
+
+      const index = indices.find((item: Index) => item.name === testIndex);
+
+      const { ilm } = index;
+      expect(ilm.index).to.eql(testIndex);
+      expect(ilm.managed).to.eql(false);
+    });
   });
 }