From a38343966ae269a21ff98e8beca90dd3f7645814 Mon Sep 17 00:00:00 2001
From: Matthew Kime <matt@mattki.me>
Date: Tue, 24 Sep 2024 12:13:26 -0500
Subject: [PATCH] [7.17] [data views] Remove regex for creating dot notation
 (#193795) (#193811)

# Backport

This will backport the following commits from `main` to `7.17`:
- [[data views] Remove regex for creating dot notation
(#193795)](https://github.com/elastic/kibana/pull/193795)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2024-09-24T00:30:52Z","message":"[data
views] Remove regex for creating dot notation (#193795)\n\n##
Summary\r\n\r\nUse basic string and array functions instead of regex to
create short\r\ndot field
names.","sha":"ab9459ca4358451614c3b4fb09380af9841e7a66","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Data
Views","release_note:skip","v9.0.0","Team:DataDiscovery","backport:all-open"],"number":193795,"url":"https://github.com/elastic/kibana/pull/193795","mergeCommit":{"message":"[data
views] Remove regex for creating dot notation (#193795)\n\n##
Summary\r\n\r\nUse basic string and array functions instead of regex to
create short\r\ndot field
names.","sha":"ab9459ca4358451614c3b4fb09380af9841e7a66"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193795","number":193795,"mergeCommit":{"message":"[data
views] Remove regex for creating dot notation (#193795)\n\n##
Summary\r\n\r\nUse basic string and array functions instead of regex to
create short\r\ndot field
names.","sha":"ab9459ca4358451614c3b4fb09380af9841e7a66"}},{"url":"https://github.com/elastic/kibana/pull/193808","number":193808,"branch":"8.15","state":"OPEN"},{"url":"https://github.com/elastic/kibana/pull/193809","number":193809,"branch":"8.x","state":"OPEN"}]}]
BACKPORT-->
---
 .../data_views/common/fields/utils.test.ts      |  6 +++---
 src/plugins/data_views/common/fields/utils.ts   | 17 +++++++++++++----
 2 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/src/plugins/data_views/common/fields/utils.test.ts b/src/plugins/data_views/common/fields/utils.test.ts
index 0f2ff280eb61b..e7d84f4dc6f0a 100644
--- a/src/plugins/data_views/common/fields/utils.test.ts
+++ b/src/plugins/data_views/common/fields/utils.test.ts
@@ -16,8 +16,8 @@ describe('shortenDottedString', () => {
   test('should ignore non-string values', () => {
     const obj = { key: 'val' };
 
-    expect(shortenDottedString(true)).toBe(true);
-    expect(shortenDottedString(123)).toBe(123);
-    expect(shortenDottedString(obj)).toBe(obj);
+    expect(shortenDottedString(true as unknown as string)).toBe(true);
+    expect(shortenDottedString(123 as unknown as string)).toBe(123);
+    expect(shortenDottedString(obj as unknown as string)).toBe(obj);
   });
 });
diff --git a/src/plugins/data_views/common/fields/utils.ts b/src/plugins/data_views/common/fields/utils.ts
index adb5057798b1c..a75d0b9f6a0e7 100644
--- a/src/plugins/data_views/common/fields/utils.ts
+++ b/src/plugins/data_views/common/fields/utils.ts
@@ -25,16 +25,25 @@ export const isMultiField = isDataViewFieldSubtypeMulti;
 export const getFieldSubtypeMulti = getDataViewFieldSubtypeMulti;
 export const getFieldSubtypeNested = getDataViewFieldSubtypeNested;
 
-const DOT_PREFIX_RE = /(.).+?\./g;
-
 /**
  * Convert a dot.notated.string into a short
  * version (d.n.string)
  *
  * @return {any}
  */
-export function shortenDottedString(input: any) {
-  return typeof input !== 'string' ? input : input.replace(DOT_PREFIX_RE, '$1.');
+
+export function shortenDottedString(input: string): string {
+  if (typeof input === 'string') {
+    const split = input.split('.');
+    return split.reduce((acc, part, i) => {
+      if (i === split.length - 1) {
+        return acc + part;
+      }
+      return acc + part[0] + '.';
+    }, '');
+  }
+
+  return input;
 }
 
 // Note - this code is duplicated from @kbn/es-query