From 933cbc0d2aa7115833dacdb0f0fa9a6a127debfd Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Mon, 21 Oct 2024 23:40:53 +1100
Subject: [PATCH] [8.x] [Cases][Flaky Test] Memoize test provider  (#195088)
 (#197008)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cases][Flaky Test] Memoize test provider
(#195088)](https://github.com/elastic/kibana/pull/195088)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julian
Gernun","email":"17549662+jcger@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-21T08:55:45Z","message":"[Cases][Flaky
Test] Memoize test provider (#195088)\n\n## Summary\r\n\r\n- Memo as
much as possible in the common component that mocks providers\r\nfor the
component tests in cases.\r\n- Also fixes an issue with fake jest timers
in
`utility_bar.test`","sha":"498da89e272b01fa33bf31998d65de2254c9c56c","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor"],"title":"[Cases][Flaky
Test] Memoize test provider
","number":195088,"url":"https://github.com/elastic/kibana/pull/195088","mergeCommit":{"message":"[Cases][Flaky
Test] Memoize test provider (#195088)\n\n## Summary\r\n\r\n- Memo as
much as possible in the common component that mocks providers\r\nfor the
component tests in cases.\r\n- Also fixes an issue with fake jest timers
in
`utility_bar.test`","sha":"498da89e272b01fa33bf31998d65de2254c9c56c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195088","number":195088,"mergeCommit":{"message":"[Cases][Flaky
Test] Memoize test provider (#195088)\n\n## Summary\r\n\r\n- Memo as
much as possible in the common component that mocks providers\r\nfor the
component tests in cases.\r\n- Also fixes an issue with fake jest timers
in
`utility_bar.test`","sha":"498da89e272b01fa33bf31998d65de2254c9c56c"}}]}]
BACKPORT-->

Co-authored-by: Julian Gernun <17549662+jcger@users.noreply.github.com>
---
 .../public/common/mock/test_providers.tsx     | 46 +++++++++----------
 .../components/all_cases/utility_bar.test.tsx | 10 ++++
 2 files changed, 31 insertions(+), 25 deletions(-)

diff --git a/x-pack/plugins/cases/public/common/mock/test_providers.tsx b/x-pack/plugins/cases/public/common/mock/test_providers.tsx
index aef1024cc8afc..257ac4b1f8293 100644
--- a/x-pack/plugins/cases/public/common/mock/test_providers.tsx
+++ b/x-pack/plugins/cases/public/common/mock/test_providers.tsx
@@ -89,22 +89,20 @@ const TestProvidersComponent: React.FC<TestProviderProps> = ({
   });
 
   const getFilesClient = mockGetFilesClient();
+  const casesProviderValue = {
+    externalReferenceAttachmentTypeRegistry,
+    persistableStateAttachmentTypeRegistry,
+    features,
+    owner,
+    permissions,
+    getFilesClient,
+  };
 
   return (
     <KibanaRenderContextProvider i18n={coreStart.i18n} theme={coreStart.theme}>
       <KibanaContextProvider services={services}>
         <MemoryRouter>
-          <CasesProvider
-            value={{
-              externalReferenceAttachmentTypeRegistry,
-              persistableStateAttachmentTypeRegistry,
-              features,
-              owner,
-              permissions,
-              getFilesClient,
-            }}
-            queryClient={queryClient}
-          >
+          <CasesProvider value={casesProviderValue} queryClient={queryClient}>
             <FilesContext client={createMockFilesClient()}>{children}</FilesContext>
           </CasesProvider>
         </MemoryRouter>
@@ -170,23 +168,20 @@ export const createAppMockRenderer = ({
   });
 
   const getFilesClient = mockGetFilesClient();
-
+  const casesProviderValue = {
+    externalReferenceAttachmentTypeRegistry,
+    persistableStateAttachmentTypeRegistry,
+    features,
+    owner,
+    permissions,
+    releasePhase,
+    getFilesClient,
+  };
   const AppWrapper: React.FC<{ children: React.ReactNode }> = ({ children }) => (
     <KibanaRenderContextProvider i18n={coreStart.i18n} theme={coreStart.theme}>
       <KibanaContextProvider services={services}>
         <MemoryRouter>
-          <CasesProvider
-            value={{
-              externalReferenceAttachmentTypeRegistry,
-              persistableStateAttachmentTypeRegistry,
-              features,
-              owner,
-              permissions,
-              releasePhase,
-              getFilesClient,
-            }}
-            queryClient={queryClient}
-          >
+          <CasesProvider value={casesProviderValue} queryClient={queryClient}>
             {children}
           </CasesProvider>
         </MemoryRouter>
@@ -195,10 +190,11 @@ export const createAppMockRenderer = ({
   );
 
   AppWrapper.displayName = 'AppWrapper';
+  const memoizedAppWrapper = React.memo(AppWrapper);
 
   const render: UiRender = (ui, options) => {
     return reactRender(ui, {
-      wrapper: AppWrapper,
+      wrapper: memoizedAppWrapper,
       ...options,
     });
   };
diff --git a/x-pack/plugins/cases/public/components/all_cases/utility_bar.test.tsx b/x-pack/plugins/cases/public/components/all_cases/utility_bar.test.tsx
index bd72a460c8c71..63d8cd2e5faab 100644
--- a/x-pack/plugins/cases/public/components/all_cases/utility_bar.test.tsx
+++ b/x-pack/plugins/cases/public/components/all_cases/utility_bar.test.tsx
@@ -41,7 +41,17 @@ describe('Severity form field', () => {
     showClearFiltersButton: false,
   };
 
+  beforeAll(() => {
+    jest.useFakeTimers();
+  });
+
+  afterAll(() => {
+    jest.useRealTimers();
+    sessionStorage.removeItem(localStorageKey);
+  });
+
   beforeEach(() => {
+    jest.useFakeTimers();
     // Workaround for timeout via https://github.com/testing-library/user-event/issues/833#issuecomment-1171452841
     user = userEvent.setup({
       advanceTimers: jest.advanceTimersByTime,