From 92b97196d2a1c95c53b9fae32856d8a653c7bfb8 Mon Sep 17 00:00:00 2001
From: machadoum <pablo.nevesmachado@elastic.co>
Date: Tue, 12 Nov 2024 13:55:52 +0100
Subject: [PATCH] Add Risk score missing privileges callout to enablement
 flyout

---
 .../components/dashboard_panels.tsx           | 58 +++++++++----------
 .../components/enablement_modal.tsx           | 24 ++++++--
 2 files changed, 46 insertions(+), 36 deletions(-)

diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
index d70eb9fe34b51..cdc947512aee0 100644
--- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
+++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
@@ -200,37 +200,35 @@ const EntityStoreDashboardPanelsComponent = () => {
         </>
       )}
 
-      {(entityStore.status === 'not_installed' || entityStore.status === 'stopped') &&
-        !isRiskScoreAvailable && (
-          // TODO: Move modal inside EnableEntityStore component, eliminating the onEnable prop in favour of forwarding the riskScoreEnabled status
-          <EnableEntityStore
-            enablements="both"
-            onEnable={() => setModalState({ visible: true })}
-            loadingRiskEngine={riskEngineInitializing}
-          />
-        )}
+      {entityStore.status === 'not_installed' && !isRiskScoreAvailable && (
+        // TODO: Move modal inside EnableEntityStore component, eliminating the onEnable prop in favour of forwarding the riskScoreEnabled status
+        <EnableEntityStore
+          enablements="both"
+          onEnable={() => setModalState({ visible: true })}
+          loadingRiskEngine={riskEngineInitializing}
+        />
+      )}
 
-      {(entityStore.status === 'not_installed' || entityStore.status === 'stopped') &&
-        isRiskScoreAvailable && (
-          <>
-            <EuiFlexItem>
-              <EnableEntityStore
-                enablements="store"
-                onEnable={() =>
-                  setModalState({
-                    visible: true,
-                  })
-                }
-              />
-            </EuiFlexItem>
-            <EuiFlexItem>
-              <EntityAnalyticsRiskScores riskEntity={RiskScoreEntity.user} />
-            </EuiFlexItem>
-            <EuiFlexItem>
-              <EntityAnalyticsRiskScores riskEntity={RiskScoreEntity.host} />
-            </EuiFlexItem>
-          </>
-        )}
+      {entityStore.status === 'not_installed' && isRiskScoreAvailable && (
+        <>
+          <EuiFlexItem>
+            <EnableEntityStore
+              enablements="store"
+              onEnable={() =>
+                setModalState({
+                  visible: true,
+                })
+              }
+            />
+          </EuiFlexItem>
+          <EuiFlexItem>
+            <EntityAnalyticsRiskScores riskEntity={RiskScoreEntity.user} />
+          </EuiFlexItem>
+          <EuiFlexItem>
+            <EntityAnalyticsRiskScores riskEntity={RiskScoreEntity.host} />
+          </EuiFlexItem>
+        </>
+      )}
 
       <EntityStoreEnablementModal
         visible={modal.visible}
diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/enablement_modal.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/enablement_modal.tsx
index 6c2528620eb4c..19bd176b80deb 100644
--- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/enablement_modal.tsx
+++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/enablement_modal.tsx
@@ -30,6 +30,8 @@ import {
 } from '../translations';
 import { useEntityEnginePrivileges } from '../hooks/use_entity_engine_privileges';
 import { MissingPrivilegesCallout } from './missing_privileges_callout';
+import { useMissingRiskEnginePrivileges } from '../../../hooks/use_missing_risk_engine_privileges';
+import { RiskEnginePrivilegesCallOut } from '../../risk_engine_privileges_callout';
 
 export interface Enablements {
   riskScore: boolean;
@@ -61,7 +63,9 @@ export const EntityStoreEnablementModal: React.FC<EntityStoreEnablementModalProp
     riskScore: !!riskScore.checked,
     entityStore: !!entityStore.checked,
   });
-  const { data: privileges, isLoading: isLoadingPrivileges } = useEntityEnginePrivileges();
+  const { data: entityEnginePrivileges, isLoading: isLoadingEntityEnginePrivileges } =
+    useEntityEnginePrivileges();
+  const riskEnginePrivileges = useMissingRiskEnginePrivileges();
 
   if (!visible) {
     return null;
@@ -88,15 +92,22 @@ export const EntityStoreEnablementModal: React.FC<EntityStoreEnablementModalProp
                 />
               }
               checked={enablements.riskScore}
-              disabled={riskScore.disabled || false}
+              disabled={
+                riskScore.disabled ||
+                (!riskEnginePrivileges.isLoading && !riskEnginePrivileges?.hasAllRequiredPrivileges)
+              }
               onChange={() => setEnablements((prev) => ({ ...prev, riskScore: !prev.riskScore }))}
             />
           </EuiFlexItem>
+          {!riskEnginePrivileges.isLoading && !riskEnginePrivileges.hasAllRequiredPrivileges && (
+            <EuiFlexItem>
+              <RiskEnginePrivilegesCallOut privileges={riskEnginePrivileges} />
+            </EuiFlexItem>
+          )}
           <EuiFlexItem>
             <EuiText>{ENABLEMENT_DESCRIPTION_RISK_ENGINE_ONLY}</EuiText>
           </EuiFlexItem>
           <EuiHorizontalRule margin="none" />
-
           <EuiFlexItem>
             <EuiFlexGroup justifyContent="flexStart">
               <EuiSwitch
@@ -108,7 +119,8 @@ export const EntityStoreEnablementModal: React.FC<EntityStoreEnablementModalProp
                 }
                 checked={enablements.entityStore}
                 disabled={
-                  entityStore.disabled || (!isLoadingPrivileges && !privileges?.has_all_required)
+                  entityStore.disabled ||
+                  (!isLoadingEntityEnginePrivileges && !entityEnginePrivileges?.has_all_required)
                 }
                 onChange={() =>
                   setEnablements((prev) => ({ ...prev, entityStore: !prev.entityStore }))
@@ -119,9 +131,9 @@ export const EntityStoreEnablementModal: React.FC<EntityStoreEnablementModalProp
               </EuiToolTip>
             </EuiFlexGroup>
           </EuiFlexItem>
-          {!privileges || privileges.has_all_required ? null : (
+          {!entityEnginePrivileges || entityEnginePrivileges.has_all_required ? null : (
             <EuiFlexItem>
-              <MissingPrivilegesCallout privileges={privileges} />
+              <MissingPrivilegesCallout privileges={entityEnginePrivileges} />
             </EuiFlexItem>
           )}
           <EuiFlexItem>