From 8b44bc2560673fe2ecc6f2c62774dbe7efeaa82b Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Mon, 2 Dec 2024 23:54:36 +1100
Subject: [PATCH] [8.x] [Dataset Quality] Fix tests for degraded fields flyout
 (#202288) (#202432)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dataset Quality] Fix tests for degraded fields flyout
(#202288)](https://github.com/elastic/kibana/pull/202288)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2024-12-02T11:04:48Z","message":"[Dataset
Quality] Fix tests for degraded fields flyout (#202288)\n\n## 📓
Summary\r\n\r\nCloses #198849 \r\nCloses #200287 \r\nCloses #201273
\r\nCloses #201975 \r\n\r\nThe above issues were raised with similar
conditions which converged in\r\nthe following assumptions:\r\n- They
are raised due to timeout identifying a visual element on
the\r\ndegraded fields flyout.\r\n- They are raised due to a missing UI
element, which is part of a common\r\nsub-tree conditionally rendered
when the data analysis is completed.\r\n- They are raised in serverless
tests, where the latency might be\r\nrandomly higher.\r\n\r\nGiven the
nature of these tests, which locally always pass correctly\r\ngiven the
fastest nature of a local setup, I assume these random\r\nfailures are
due to latency on the common request gating the rendering\r\nof these
sections.\r\n\r\nAs a fix, I added a wait on the global loading
indicator before the\r\nassertions, which should wait for the data
loading to be completed\r\nbefore running the assertions on the UI
elements.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"d13904eb6596edd51e4d52aa74c24c070be3ce5c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-logs"],"title":"[Dataset
Quality] Fix tests for degraded fields
flyout","number":202288,"url":"https://github.com/elastic/kibana/pull/202288","mergeCommit":{"message":"[Dataset
Quality] Fix tests for degraded fields flyout (#202288)\n\n## 📓
Summary\r\n\r\nCloses #198849 \r\nCloses #200287 \r\nCloses #201273
\r\nCloses #201975 \r\n\r\nThe above issues were raised with similar
conditions which converged in\r\nthe following assumptions:\r\n- They
are raised due to timeout identifying a visual element on
the\r\ndegraded fields flyout.\r\n- They are raised due to a missing UI
element, which is part of a common\r\nsub-tree conditionally rendered
when the data analysis is completed.\r\n- They are raised in serverless
tests, where the latency might be\r\nrandomly higher.\r\n\r\nGiven the
nature of these tests, which locally always pass correctly\r\ngiven the
fastest nature of a local setup, I assume these random\r\nfailures are
due to latency on the common request gating the rendering\r\nof these
sections.\r\n\r\nAs a fix, I added a wait on the global loading
indicator before the\r\nassertions, which should wait for the data
loading to be completed\r\nbefore running the assertions on the UI
elements.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"d13904eb6596edd51e4d52aa74c24c070be3ce5c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202288","number":202288,"mergeCommit":{"message":"[Dataset
Quality] Fix tests for degraded fields flyout (#202288)\n\n## 📓
Summary\r\n\r\nCloses #198849 \r\nCloses #200287 \r\nCloses #201273
\r\nCloses #201975 \r\n\r\nThe above issues were raised with similar
conditions which converged in\r\nthe following assumptions:\r\n- They
are raised due to timeout identifying a visual element on
the\r\ndegraded fields flyout.\r\n- They are raised due to a missing UI
element, which is part of a common\r\nsub-tree conditionally rendered
when the data analysis is completed.\r\n- They are raised in serverless
tests, where the latency might be\r\nrandomly higher.\r\n\r\nGiven the
nature of these tests, which locally always pass correctly\r\ngiven the
fastest nature of a local setup, I assume these random\r\nfailures are
due to latency on the common request gating the rendering\r\nof these
sections.\r\n\r\nAs a fix, I added a wait on the global loading
indicator before the\r\nassertions, which should wait for the data
loading to be completed\r\nbefore running the assertions on the UI
elements.\r\n\r\nCo-authored-by: Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"d13904eb6596edd51e4d52aa74c24c070be3ce5c"}}]}]
BACKPORT-->

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
---
 .../dataset_quality/degraded_field_flyout.ts  | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts b/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts
index 9fb1f74cbae0e..eebf6bcb90373 100644
--- a/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts
+++ b/x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts
@@ -22,6 +22,7 @@ import { logsNginxMappings } from './custom_mappings/custom_integration_mappings
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const PageObjects = getPageObjects([
     'common',
+    'header',
     'navigationalSearch',
     'observabilityLogsExplorer',
     'datasetQuality',
@@ -452,6 +453,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'test_field',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           await retry.tryForTime(5000, async () => {
             const fieldIgnoredMessageExists = await PageObjects.datasetQuality.doesTextExist(
               'datasetQualityDetailsDegradedFieldFlyoutFieldValue-cause',
@@ -469,6 +472,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'test_field',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           await retry.tryForTime(5000, async () => {
             const testFieldValue1Exists = await PageObjects.datasetQuality.doesTextExist(
               'datasetQualityDetailsDegradedFieldFlyoutFieldValue-values',
@@ -491,6 +496,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'test_field',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           await retry.tryForTime(5000, async () => {
             const limitValueExists = await PageObjects.datasetQuality.doesTextExist(
               'datasetQualityDetailsDegradedFieldFlyoutFieldValue-characterLimit',
@@ -508,6 +515,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'test_field',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           // Possible Mitigation Section should exist
           await testSubjects.existOrFail(
             'datasetQualityDetailsDegradedFieldFlyoutPossibleMitigationTitle'
@@ -567,6 +576,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'test_field',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
           await PageObjects.datasetQuality.waitUntilPossibleMitigationsLoaded();
 
           // Possible Mitigation Section should exist
@@ -632,6 +642,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'cloud',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           await retry.tryForTime(5000, async () => {
             const fieldLimitMessageExists = await PageObjects.datasetQuality.doesTextExist(
               'datasetQualityDetailsDegradedFieldFlyoutFieldValue-cause',
@@ -649,6 +661,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'cloud',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           await retry.tryForTime(5000, async () => {
             const limitExists = await PageObjects.datasetQuality.doesTextExist(
               'datasetQualityDetailsDegradedFieldFlyoutFieldValue-mappingLimit',
@@ -666,6 +680,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'cloud',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           await testSubjects.existOrFail(
             PageObjects.datasetQuality.testSubjectSelectors
               .datasetQualityDetailsDegradedFieldFlyoutIssueDoesNotExist
@@ -680,6 +696,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'cloud.project.id',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           // Field Limit Mitigation Section should exist
           await testSubjects.existOrFail(
             'datasetQualityDetailsDegradedFieldFlyoutFieldLimitMitigationAccordion'
@@ -710,6 +728,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'cloud.project',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           // Field Limit Mitigation Section should exist
           await testSubjects.existOrFail(
             'datasetQualityDetailsDegradedFieldFlyoutFieldLimitMitigationAccordion'
@@ -732,6 +752,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'cloud.project.id',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           // Should display current field limit
           await testSubjects.existOrFail('datasetQualityIncreaseFieldMappingCurrentLimitFieldText');
 
@@ -782,6 +804,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'cloud.project.id',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           // Should not allow values less than current limit of 44
           await testSubjects.setValue(
             'datasetQualityIncreaseFieldMappingProposedLimitFieldText',
@@ -816,6 +840,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'cloud.project.id',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           await retry.tryForTime(5000, async () => {
             const applyButton = await testSubjects.find(
               'datasetQualityIncreaseFieldMappingLimitButtonButton'
@@ -835,6 +861,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             expandedDegradedField: 'cloud.project.id',
           });
 
+          await PageObjects.header.waitUntilLoadingHasFinished();
+
           const applyButton = await testSubjects.find(
             'datasetQualityIncreaseFieldMappingLimitButtonButton'
           );