From 8a52c06e05aa574b358d99c37f1cc6fa683e9849 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Sat, 2 Nov 2024 00:58:38 +1100
Subject: [PATCH] [8.16] [SecuritySolution] Fix dashboard page when the entity
 store state is stopped (#198645) (#198659)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[SecuritySolution] Fix dashboard page when the entity store state is
stopped (#198645)](https://github.com/elastic/kibana/pull/198645)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2024-11-01T11:58:01Z","message":"[SecuritySolution]
Fix dashboard page when the entity store state is stopped
(#198645)\n\n## Summary\r\n\r\nFix the dashboard page when the entity
store state is stopped\r\nPreviously, the EntityStoreDashboardPanels
component didn't account for\r\nthe installed but disabled state
(stopped).\r\n\r\nI made the minimum changes necessary to fix the bug,
but this component\r\nneeds to be refactored, unit-tested, and written
in a storybook with all\r\npossible states. Technical debt
Issue:\r\nhttps://github.com/elastic/security-team/issues/11035","sha":"34aab05595115289ed7b7f8c1fad7f282292a25b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:
SecuritySolution","Theme: entity_analytics","Feature:Entity
Analytics","Team:Entity
Analytics","v8.16.0","backport:version","v8.17.0"],"title":"[SecuritySolution]
Fix dashboard page when the entity store state is
stopped","number":198645,"url":"https://github.com/elastic/kibana/pull/198645","mergeCommit":{"message":"[SecuritySolution]
Fix dashboard page when the entity store state is stopped
(#198645)\n\n## Summary\r\n\r\nFix the dashboard page when the entity
store state is stopped\r\nPreviously, the EntityStoreDashboardPanels
component didn't account for\r\nthe installed but disabled state
(stopped).\r\n\r\nI made the minimum changes necessary to fix the bug,
but this component\r\nneeds to be refactored, unit-tested, and written
in a storybook with all\r\npossible states. Technical debt
Issue:\r\nhttps://github.com/elastic/security-team/issues/11035","sha":"34aab05595115289ed7b7f8c1fad7f282292a25b"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198645","number":198645,"mergeCommit":{"message":"[SecuritySolution]
Fix dashboard page when the entity store state is stopped
(#198645)\n\n## Summary\r\n\r\nFix the dashboard page when the entity
store state is stopped\r\nPreviously, the EntityStoreDashboardPanels
component didn't account for\r\nthe installed but disabled state
(stopped).\r\n\r\nI made the minimum changes necessary to fix the bug,
but this component\r\nneeds to be refactored, unit-tested, and written
in a storybook with all\r\npossible states. Technical debt
Issue:\r\nhttps://github.com/elastic/security-team/issues/11035","sha":"34aab05595115289ed7b7f8c1fad7f282292a25b"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
---
 .../components/dashboard_panels.tsx           | 59 ++++++++++---------
 1 file changed, 31 insertions(+), 28 deletions(-)

diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
index 99e2475f95a78..63ffcf7b9eae1 100644
--- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
+++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/dashboard_panels.tsx
@@ -141,6 +141,7 @@ const EntityStoreDashboardPanelsComponent = () => {
     );
   }
 
+  // TODO Rename variable because the Risk score could be installed but disabled
   const isRiskScoreAvailable =
     riskEngineStatus.data &&
     riskEngineStatus.data.risk_engine_status !== RiskEngineStatusEnum.NOT_INSTALLED;
@@ -199,35 +200,37 @@ const EntityStoreDashboardPanelsComponent = () => {
         </>
       )}
 
-      {entityStore.status === 'not_installed' && !isRiskScoreAvailable && (
-        // TODO: Move modal inside EnableEntityStore component, eliminating the onEnable prop in favour of forwarding the riskScoreEnabled status
-        <EnableEntityStore
-          enablements="both"
-          onEnable={() => setModalState({ visible: true })}
-          loadingRiskEngine={riskEngineInitializing}
-        />
-      )}
+      {(entityStore.status === 'not_installed' || entityStore.status === 'stopped') &&
+        !isRiskScoreAvailable && (
+          // TODO: Move modal inside EnableEntityStore component, eliminating the onEnable prop in favour of forwarding the riskScoreEnabled status
+          <EnableEntityStore
+            enablements="both"
+            onEnable={() => setModalState({ visible: true })}
+            loadingRiskEngine={riskEngineInitializing}
+          />
+        )}
 
-      {entityStore.status === 'not_installed' && isRiskScoreAvailable && (
-        <>
-          <EuiFlexItem>
-            <EnableEntityStore
-              enablements="store"
-              onEnable={() =>
-                setModalState({
-                  visible: true,
-                })
-              }
-            />
-          </EuiFlexItem>
-          <EuiFlexItem>
-            <EntityAnalyticsRiskScores riskEntity={RiskScoreEntity.user} />
-          </EuiFlexItem>
-          <EuiFlexItem>
-            <EntityAnalyticsRiskScores riskEntity={RiskScoreEntity.host} />
-          </EuiFlexItem>
-        </>
-      )}
+      {(entityStore.status === 'not_installed' || entityStore.status === 'stopped') &&
+        isRiskScoreAvailable && (
+          <>
+            <EuiFlexItem>
+              <EnableEntityStore
+                enablements="store"
+                onEnable={() =>
+                  setModalState({
+                    visible: true,
+                  })
+                }
+              />
+            </EuiFlexItem>
+            <EuiFlexItem>
+              <EntityAnalyticsRiskScores riskEntity={RiskScoreEntity.user} />
+            </EuiFlexItem>
+            <EuiFlexItem>
+              <EntityAnalyticsRiskScores riskEntity={RiskScoreEntity.host} />
+            </EuiFlexItem>
+          </>
+        )}
 
       <EntityStoreEnablementModal
         visible={modal.visible}