From 60431164a2f0f0c5d7926e0ee73b53049171ae15 Mon Sep 17 00:00:00 2001
From: Kyle Pollich <kyle.pollich@elastic.co>
Date: Wed, 20 Nov 2024 14:46:23 -0500
Subject: [PATCH] [Fleet] Remove output columns from agent list table (#201001)

## Summary

Closes https://github.com/elastic/kibana/issues/200914

Removes the output columns from the agent list table, as they can't be
filtered or sorted meaningfully without performance concerns.
---
 .../components/agent_list_table.tsx           | 50 +------------------
 1 file changed, 2 insertions(+), 48 deletions(-)

diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx
index d70ed67247207..deb8402af5bea 100644
--- a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx
+++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx
@@ -24,16 +24,14 @@ import { isAgentUpgradeable, ExperimentalFeaturesService } from '../../../../ser
 import { AgentHealth } from '../../components';
 
 import type { Pagination } from '../../../../hooks';
-import { useAgentVersion, useGetListOutputsForPolicies } from '../../../../hooks';
+import { useAgentVersion } from '../../../../hooks';
 import { useLink, useAuthz } from '../../../../hooks';
 
 import { AgentPolicySummaryLine } from '../../../../components';
 import { Tags } from '../../components/tags';
-import type { AgentMetrics, OutputsForAgentPolicy } from '../../../../../../../common/types';
+import type { AgentMetrics } from '../../../../../../../common/types';
 import { formatAgentCPU, formatAgentMemory } from '../../services/agent_metrics';
 
-import { AgentPolicyOutputsSummary } from './agent_policy_outputs_summary';
-
 import { AgentUpgradeStatus } from './agent_upgrade_status';
 
 import { EmptyPrompt } from './empty_prompt';
@@ -45,8 +43,6 @@ const AGENTS_TABLE_FIELDS = {
   METRICS: 'metrics',
   VERSION: 'local_metadata.elastic.agent.version',
   LAST_CHECKIN: 'last_checkin',
-  OUTPUT_INTEGRATION: 'output_integrations',
-  OUTPUT_MONITORING: 'output_monitoring',
 };
 
 function safeMetadata(val: any) {
@@ -128,14 +124,6 @@ export const AgentListTable: React.FC<Props> = (props: Props) => {
       : [];
   }, [agents, isAgentSelectable, showUpgradeable, totalAgents]);
 
-  // get the policyIds of the agents shown on the page
-  const policyIds = useMemo(() => {
-    return agentsShown.map((agent) => agent?.policy_id ?? '');
-  }, [agentsShown]);
-  const allOutputs = useGetListOutputsForPolicies({
-    ids: policyIds,
-  });
-
   const noItemsMessage =
     isLoading && isCurrentRequestIncremented ? (
       <FormattedMessage
@@ -305,40 +293,6 @@ export const AgentListTable: React.FC<Props> = (props: Props) => {
       render: (lastCheckin: string) =>
         lastCheckin ? <FormattedRelative value={lastCheckin} /> : undefined,
     },
-    {
-      field: AGENTS_TABLE_FIELDS.OUTPUT_INTEGRATION,
-      sortable: true,
-      truncateText: true,
-      name: i18n.translate('xpack.fleet.agentList.integrationsOutputTitle', {
-        defaultMessage: 'Output for integrations',
-      }),
-      width: '180px',
-      render: (outputs: OutputsForAgentPolicy[], agent: Agent) => {
-        if (!agent?.policy_id) return null;
-
-        const outputsForPolicy = allOutputs?.data?.items.find(
-          (item) => item.agentPolicyId === agent?.policy_id
-        );
-        return <AgentPolicyOutputsSummary outputs={outputsForPolicy} />;
-      },
-    },
-    {
-      field: AGENTS_TABLE_FIELDS.OUTPUT_MONITORING,
-      sortable: true,
-      truncateText: true,
-      name: i18n.translate('xpack.fleet.agentList.monitoringOutputTitle', {
-        defaultMessage: 'Output for monitoring',
-      }),
-      width: '180px',
-      render: (outputs: OutputsForAgentPolicy[], agent: Agent) => {
-        if (!agent?.policy_id) return null;
-
-        const outputsForPolicy = allOutputs?.data?.items.find(
-          (item) => item.agentPolicyId === agent?.policy_id
-        );
-        return <AgentPolicyOutputsSummary outputs={outputsForPolicy} isMonitoring={true} />;
-      },
-    },
     {
       field: AGENTS_TABLE_FIELDS.VERSION,
       sortable: true,