From 54a51ca5b3806747190570523a2243abbbe92d42 Mon Sep 17 00:00:00 2001
From: jpdjere <jpdjeredjian@gmail.com>
Date: Tue, 23 Aug 2022 09:28:40 +0200
Subject: [PATCH] Update Cypress test

---
 .../detection_rules/prebuilt_rules.spec.ts    | 27 ++++++++-----------
 1 file changed, 11 insertions(+), 16 deletions(-)

diff --git a/x-pack/plugins/security_solution/cypress/integration/detection_rules/prebuilt_rules.spec.ts b/x-pack/plugins/security_solution/cypress/integration/detection_rules/prebuilt_rules.spec.ts
index 005fc2b8973b0..ed5f5629985ae 100644
--- a/x-pack/plugins/security_solution/cypress/integration/detection_rules/prebuilt_rules.spec.ts
+++ b/x-pack/plugins/security_solution/cypress/integration/detection_rules/prebuilt_rules.spec.ts
@@ -15,9 +15,8 @@ import {
   RULE_SWITCH,
   RULES_MONITORING_TABLE,
   SELECT_ALL_RULES_ON_PAGE_CHECKBOX,
-  RULES_TABLE,
+  RULE_NAME,
 } from '../../screens/alerts_detection_rules';
-import type { Rule } from '../../../public/detections/containers/detection_engine/rules/types';
 import {
   deleteFirstRule,
   deleteSelectedRules,
@@ -47,13 +46,7 @@ describe('Prebuilt rules', () => {
 
   describe('Alerts rules, prebuilt rules', () => {
     it('Loads prebuilt rules', () => {
-      cy.intercept('/api/detection_engine/rules/_find*', {
-        data: rawRules,
-        page: 1,
-        perPage: 10000,
-        total: rawRules.length,
-      }).as('findRules');
-      const rowsPerPage = 20;
+      const rowsPerPage = 100;
       const expectedNumberOfRules = totalNumberOfPrebuiltRules;
       const expectedNumberOfPages = Math.ceil(totalNumberOfPrebuiltRules / rowsPerPage);
       const expectedElasticRulesBtnText = `Elastic rules (${expectedNumberOfRules})`;
@@ -64,16 +57,18 @@ describe('Prebuilt rules', () => {
 
       cy.get(ELASTIC_RULES_BTN).should('have.text', expectedElasticRulesBtnText);
 
-      // Assert that first page of rules is loaded with rules returned by the API
-      cy.wait('@findRules').then(({ response }) => {
-        const rules = response?.body.data.slice(0, rowsPerPage);
-        rules.forEach((rule: Rule) => {
-          cy.get(RULES_TABLE).should('contain', rule.name);
+      changeRowsPerPageTo(rowsPerPage);
+
+      cy.request({ url: '/api/detection_engine/rules/_find' }).then(({ body }) => {
+        // Assert the total number of loaded rules equals the expected number of in-memory rules
+        expect(body.total).to.equal(rawRules.length);
+        // Assert the table was refreshed with the rules returned by the API request
+        const ruleNames = rawRules.map((rule) => rule.name);
+        cy.get(RULE_NAME).each(($item) => {
+          expect($item.text()).to.be.oneOf(ruleNames);
         });
       });
 
-      changeRowsPerPageTo(rowsPerPage);
-
       cy.get(pageSelector(expectedNumberOfPages)).should('exist');
     });