From 460084bc128459952a84fd7d9522c3cc1ab5c722 Mon Sep 17 00:00:00 2001 From: rshen91 Date: Thu, 19 Sep 2024 09:32:14 -0600 Subject: [PATCH] code review feedback --- .../dashboard/public/dashboard_app/dashboard_app.test.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/plugins/dashboard/public/dashboard_app/dashboard_app.test.tsx b/src/plugins/dashboard/public/dashboard_app/dashboard_app.test.tsx index d0bd70afd69af..3f186bb087575 100644 --- a/src/plugins/dashboard/public/dashboard_app/dashboard_app.test.tsx +++ b/src/plugins/dashboard/public/dashboard_app/dashboard_app.test.tsx @@ -60,6 +60,7 @@ describe('Dashboard App', () => { render(); await waitFor(() => { + expect(expandPanelSpyInRouter).not.toHaveBeenCalled(); // this value should be undefined by default expect(mockDashboard.expandedPanelId.getValue()).toBe(undefined); // history should not be called @@ -87,6 +88,7 @@ describe('Dashboard App', () => { // simulate minimizing a panel mockDashboard.expandedPanelId.next(undefined); + await waitFor(() => { expect(mockDashboard.expandedPanelId.getValue()).toBe(undefined); expect(historySpy).toHaveBeenCalledTimes(1);