From 3e6889ddbf32a6572eedfec147343c30aaa3eaf8 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Tue, 22 Oct 2024 23:31:29 +1100
Subject: [PATCH] [8.x] [Create visualization modal] change documentation link
 in footer (#196997) (#197207)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Create visualization modal] change documentation link in footer
(#196997)](https://github.com/elastic/kibana/pull/196997)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Oyelola
Victoria","email":"123843734+VriaA@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-22T10:44:14Z","message":"[Create
visualization modal] change documentation link in footer (#196997)\n\n##
Summary\r\n\r\nFixes #196286 \r\n\r\nUpdated the documentation link in
the footer of the create visualization\r\nmodal.\r\n\r\nThe
`getDocLinks` guide link under \"visualize\" previously pointed
to\r\ndashboard.html, it's now corrected to
_panels_and_visualizations.html.\r\n\r\nThis also affected a
documentation link elsewhere, as seen in
the\r\nscreenshot.\r\n\r\n![visualize_library_documentation](https://github.com/user-attachments/assets/18d32942-063e-492e-85d8-274585eedb75)\r\n\r\nReverted
it back using the \"dashboard\" guide link which also points
to\r\ndashboard.html since the issue specified changing only the
create\r\nvisualization modal doc
link.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/af6a4993-aac3-446f-8228-d0fe89d97cb2\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<4283304+mbondyra@users.noreply.github.com>","sha":"92b145bcd739af9e132be158c08ba2f3c8cd43d1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","💝community","v9.0.0","backport:prev-minor"],"title":"[Create
visualization modal] change documentation link in
footer","number":196997,"url":"https://github.com/elastic/kibana/pull/196997","mergeCommit":{"message":"[Create
visualization modal] change documentation link in footer (#196997)\n\n##
Summary\r\n\r\nFixes #196286 \r\n\r\nUpdated the documentation link in
the footer of the create visualization\r\nmodal.\r\n\r\nThe
`getDocLinks` guide link under \"visualize\" previously pointed
to\r\ndashboard.html, it's now corrected to
_panels_and_visualizations.html.\r\n\r\nThis also affected a
documentation link elsewhere, as seen in
the\r\nscreenshot.\r\n\r\n![visualize_library_documentation](https://github.com/user-attachments/assets/18d32942-063e-492e-85d8-274585eedb75)\r\n\r\nReverted
it back using the \"dashboard\" guide link which also points
to\r\ndashboard.html since the issue specified changing only the
create\r\nvisualization modal doc
link.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/af6a4993-aac3-446f-8228-d0fe89d97cb2\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<4283304+mbondyra@users.noreply.github.com>","sha":"92b145bcd739af9e132be158c08ba2f3c8cd43d1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196997","number":196997,"mergeCommit":{"message":"[Create
visualization modal] change documentation link in footer (#196997)\n\n##
Summary\r\n\r\nFixes #196286 \r\n\r\nUpdated the documentation link in
the footer of the create visualization\r\nmodal.\r\n\r\nThe
`getDocLinks` guide link under \"visualize\" previously pointed
to\r\ndashboard.html, it's now corrected to
_panels_and_visualizations.html.\r\n\r\nThis also affected a
documentation link elsewhere, as seen in
the\r\nscreenshot.\r\n\r\n![visualize_library_documentation](https://github.com/user-attachments/assets/18d32942-063e-492e-85d8-274585eedb75)\r\n\r\nReverted
it back using the \"dashboard\" guide link which also points
to\r\ndashboard.html since the issue specified changing only the
create\r\nvisualization modal doc
link.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/af6a4993-aac3-446f-8228-d0fe89d97cb2\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<4283304+mbondyra@users.noreply.github.com>","sha":"92b145bcd739af9e132be158c08ba2f3c8cd43d1"}}]}]
BACKPORT-->

Co-authored-by: Oyelola Victoria <123843734+VriaA@users.noreply.github.com>
---
 packages/kbn-doc-links/src/get_doc_links.ts                 | 2 +-
 .../public/wizard/group_selection/group_selection.test.tsx  | 4 ++--
 .../public/wizard/group_selection/group_selection.tsx       | 2 +-
 .../visualizations/public/wizard/new_vis_modal.test.tsx     | 6 +++---
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/packages/kbn-doc-links/src/get_doc_links.ts b/packages/kbn-doc-links/src/get_doc_links.ts
index 46b21e71a8d57..4160e4a94f5ad 100644
--- a/packages/kbn-doc-links/src/get_doc_links.ts
+++ b/packages/kbn-doc-links/src/get_doc_links.ts
@@ -581,7 +581,7 @@ export const getDocLinks = ({ kibanaBranch, buildFlavor }: GetDocLinkOptions): D
       alertingRules: `${ELASTICSEARCH_DOCS}transform-alerts.html`,
     },
     visualize: {
-      guide: `${KIBANA_DOCS}dashboard.html`,
+      guide: `${KIBANA_DOCS}_panels_and_visualizations.html`,
       lens: `${ELASTIC_WEBSITE_URL}what-is/kibana-lens`,
       lensPanels: `${KIBANA_DOCS}lens.html`,
       maps: `${ELASTIC_WEBSITE_URL}maps`,
diff --git a/src/plugins/visualizations/public/wizard/group_selection/group_selection.test.tsx b/src/plugins/visualizations/public/wizard/group_selection/group_selection.test.tsx
index 2c1411a82028e..1df7925ba28e5 100644
--- a/src/plugins/visualizations/public/wizard/group_selection/group_selection.test.tsx
+++ b/src/plugins/visualizations/public/wizard/group_selection/group_selection.test.tsx
@@ -83,11 +83,11 @@ describe('GroupSelection', () => {
 
   const docLinks = {
     links: {
-      dashboard: {
+      visualize: {
         guide: 'test',
       },
     },
-  };
+  } as unknown as DocLinksStart;
 
   beforeAll(() => {
     Object.defineProperty(window, 'location', {
diff --git a/src/plugins/visualizations/public/wizard/group_selection/group_selection.tsx b/src/plugins/visualizations/public/wizard/group_selection/group_selection.tsx
index b730798124d5a..32a59fd56c1e5 100644
--- a/src/plugins/visualizations/public/wizard/group_selection/group_selection.tsx
+++ b/src/plugins/visualizations/public/wizard/group_selection/group_selection.tsx
@@ -95,7 +95,7 @@ function GroupSelection({
   visTypesRegistry,
   ...props
 }: GroupSelectionProps) {
-  const visualizeGuideLink = props.docLinks.links.dashboard.guide;
+  const visualizeGuideLink = props.docLinks.links.visualize.guide;
   const promotedVisGroups = useMemo(
     () =>
       orderBy(
diff --git a/src/plugins/visualizations/public/wizard/new_vis_modal.test.tsx b/src/plugins/visualizations/public/wizard/new_vis_modal.test.tsx
index adf36745b991b..7f73addb93116 100644
--- a/src/plugins/visualizations/public/wizard/new_vis_modal.test.tsx
+++ b/src/plugins/visualizations/public/wizard/new_vis_modal.test.tsx
@@ -78,11 +78,11 @@ describe('NewVisModal', () => {
   const uiSettings: any = { get: settingsGet };
   const docLinks = {
     links: {
-      dashboard: {
+      visualize: {
         guide: 'test',
       },
     },
-  };
+  } as unknown as DocLinksStart;
 
   const contentManagement = contentManagementMock.createStartContract();
 
@@ -108,7 +108,7 @@ describe('NewVisModal', () => {
           addBasePath={addBasePath}
           uiSettings={uiSettings}
           application={{} as ApplicationStart}
-          docLinks={docLinks as DocLinksStart}
+          docLinks={docLinks}
           contentClient={contentManagement.client}
           {...propsOverrides}
         />