From 308c9b892b8ca85e6a27be04d7da08a19555020e Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Fri, 23 Feb 2024 13:19:20 -0500
Subject: [PATCH] [8.13] Change key for Select Connector component from
 serviceType to name (#177729) (#177737)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

# Backport

This will backport the following commits from `main` to `8.13`:
- [Change key for Select Connector component from serviceType to name
(#177729)](https://github.com/elastic/kibana/pull/177729)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Artem
Shelkovnikov","email":"artem.shelkovnikov@elastic.co"},"sourceCommit":{"committedDate":"2024-02-23T16:28:30Z","message":"Change
key for Select Connector component from serviceType to name
(#177729)\n\n## Summary\r\n\r\nFixing a problem with Select Connector
component being broken due to\r\nelements with duplicate
ids.\r\n\r\nConfluence Data Center and Jira Data Center tiles were added
with\r\nduplicate service_type (by design). Because of that, the
component\r\nbroke, as it uses service_type as an unique key when
rendering the\r\ntable.\r\n\r\nSee for example this log message with an
error:\r\n\r\n```\r\n2react-dom.development.js:67 Warning: Encountered
two children with the same key, `confluence`. Keys should be unique so
that components maintain their identity across updates. Non-unique keys
may cause children to be duplicated and/or omitted — the behavior is
unsupported and could change in a future version.\r\n```\r\n\r\nThis PR
changes the unique key field from `service_type` to `name` -\r\nthis way
the table is rendered correctly and works as expected.\r\n\r\nBefore:
\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/12238374/81da28b6-06b6-46de-80ac-ba4c529ffd97\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/12238374/447ad868-b296-4eef-8813-46cc65bddf7c\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"982a3eeb59492c28102cac3ab3e100be3a73e1b3","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.13.0","v8.14.0"],"title":"Change
key for Select Connector component from serviceType to
name","number":177729,"url":"https://github.com/elastic/kibana/pull/177729","mergeCommit":{"message":"Change
key for Select Connector component from serviceType to name
(#177729)\n\n## Summary\r\n\r\nFixing a problem with Select Connector
component being broken due to\r\nelements with duplicate
ids.\r\n\r\nConfluence Data Center and Jira Data Center tiles were added
with\r\nduplicate service_type (by design). Because of that, the
component\r\nbroke, as it uses service_type as an unique key when
rendering the\r\ntable.\r\n\r\nSee for example this log message with an
error:\r\n\r\n```\r\n2react-dom.development.js:67 Warning: Encountered
two children with the same key, `confluence`. Keys should be unique so
that components maintain their identity across updates. Non-unique keys
may cause children to be duplicated and/or omitted — the behavior is
unsupported and could change in a future version.\r\n```\r\n\r\nThis PR
changes the unique key field from `service_type` to `name` -\r\nthis way
the table is rendered correctly and works as expected.\r\n\r\nBefore:
\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/12238374/81da28b6-06b6-46de-80ac-ba4c529ffd97\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/12238374/447ad868-b296-4eef-8813-46cc65bddf7c\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"982a3eeb59492c28102cac3ab3e100be3a73e1b3"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177729","number":177729,"mergeCommit":{"message":"Change
key for Select Connector component from serviceType to name
(#177729)\n\n## Summary\r\n\r\nFixing a problem with Select Connector
component being broken due to\r\nelements with duplicate
ids.\r\n\r\nConfluence Data Center and Jira Data Center tiles were added
with\r\nduplicate service_type (by design). Because of that, the
component\r\nbroke, as it uses service_type as an unique key when
rendering the\r\ntable.\r\n\r\nSee for example this log message with an
error:\r\n\r\n```\r\n2react-dom.development.js:67 Warning: Encountered
two children with the same key, `confluence`. Keys should be unique so
that components maintain their identity across updates. Non-unique keys
may cause children to be duplicated and/or omitted — the behavior is
unsupported and could change in a future version.\r\n```\r\n\r\nThis PR
changes the unique key field from `service_type` to `name` -\r\nthis way
the table is rendered correctly and works as expected.\r\n\r\nBefore:
\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/12238374/81da28b6-06b6-46de-80ac-ba4c529ffd97\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/12238374/447ad868-b296-4eef-8813-46cc65bddf7c\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [ ] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"982a3eeb59492c28102cac3ab3e100be3a73e1b3"}}]}]
BACKPORT-->

Co-authored-by: Artem Shelkovnikov <artem.shelkovnikov@elastic.co>
---
 .../components/new_index/select_connector/select_connector.tsx  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/new_index/select_connector/select_connector.tsx b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/new_index/select_connector/select_connector.tsx
index a06238810c9a8..92158b7ae94bb 100644
--- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/new_index/select_connector/select_connector.tsx
+++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/new_index/select_connector/select_connector.tsx
@@ -319,7 +319,7 @@ export const SelectConnector: React.FC = () => {
           <EuiSpacer size="s" />
           <EuiFlexGrid columns={3}>
             {filteredConnectors.map((connector) => (
-              <EuiFlexItem key={connector.serviceType} grow>
+              <EuiFlexItem key={connector.name} grow>
                 <ConnectorCheckable
                   showNativePopover={(!hasNativeAccess && useNativeFilter) ?? false}
                   showLicensePopover={connector.platinumOnly && !hasPlatinumLicense && !isCloud}