From 18a08a653350688ace44695dd16cc6ba9404de65 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Fri, 25 Oct 2024 01:57:48 +1100
Subject: [PATCH] [8.x] chore(o11y): add missing access options to routes
 (#197511) (#197637)

# Backport

This will backport the following commits from `main` to `8.x`:
- [chore(o11y): add missing access options to routes
(#197511)](https://github.com/elastic/kibana/pull/197511)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T13:15:05Z","message":"chore(o11y):
add missing access options to routes
(#197511)","sha":"b3d5c4b46e2f9df7a28bcc3b5b61a132ffdcc0f1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"title":"chore(o11y):
add missing access options to
routes","number":197511,"url":"https://github.com/elastic/kibana/pull/197511","mergeCommit":{"message":"chore(o11y):
add missing access options to routes
(#197511)","sha":"b3d5c4b46e2f9df7a28bcc3b5b61a132ffdcc0f1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197511","number":197511,"mergeCommit":{"message":"chore(o11y):
add missing access options to routes
(#197511)","sha":"b3d5c4b46e2f9df7a28bcc3b5b61a132ffdcc0f1"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
---
 .../annotations/register_annotation_apis.ts    | 18 ++++++++++++++++++
 .../server/routes/assistant/route.ts           |  1 +
 .../observability/server/routes/rules/route.ts |  1 +
 3 files changed, 20 insertions(+)

diff --git a/x-pack/plugins/observability_solution/observability/server/lib/annotations/register_annotation_apis.ts b/x-pack/plugins/observability_solution/observability/server/lib/annotations/register_annotation_apis.ts
index 8af247721acb9..59ae964ce8831 100644
--- a/x-pack/plugins/observability_solution/observability/server/lib/annotations/register_annotation_apis.ts
+++ b/x-pack/plugins/observability_solution/observability/server/lib/annotations/register_annotation_apis.ts
@@ -98,6 +98,9 @@ export function registerAnnotationAPIs({
       validate: {
         body: unknowns,
       },
+      options: {
+        access: 'public',
+      },
     },
     wrapRouteHandler(t.type({ body: createAnnotationRt }), ({ data, client }) => {
       return client.create(data.body);
@@ -110,6 +113,9 @@ export function registerAnnotationAPIs({
       validate: {
         body: unknowns,
       },
+      options: {
+        access: 'public',
+      },
     },
     wrapRouteHandler(t.type({ body: updateAnnotationRt }), ({ data, client }) => {
       return client.update(data.body);
@@ -122,6 +128,9 @@ export function registerAnnotationAPIs({
       validate: {
         params: unknowns,
       },
+      options: {
+        access: 'public',
+      },
     },
     wrapRouteHandler(t.type({ params: deleteAnnotationRt }), ({ data, client }) => {
       return client.delete(data.params);
@@ -134,6 +143,9 @@ export function registerAnnotationAPIs({
       validate: {
         params: unknowns,
       },
+      options: {
+        access: 'public',
+      },
     },
     wrapRouteHandler(t.type({ params: getAnnotationByIdRt }), ({ data, client }) => {
       return client.getById(data.params);
@@ -146,6 +158,9 @@ export function registerAnnotationAPIs({
       validate: {
         query: unknowns,
       },
+      options: {
+        access: 'public',
+      },
     },
     wrapRouteHandler(t.type({ query: findAnnotationRt }), ({ data, client }) => {
       return client.find(data.query);
@@ -158,6 +173,9 @@ export function registerAnnotationAPIs({
       validate: {
         query: unknowns,
       },
+      options: {
+        access: 'public',
+      },
     },
     wrapRouteHandler(t.type({}), ({ client }) => {
       return client.permissions();
diff --git a/x-pack/plugins/observability_solution/observability/server/routes/assistant/route.ts b/x-pack/plugins/observability_solution/observability/server/routes/assistant/route.ts
index e6e04704971d2..f5c6c393371c5 100644
--- a/x-pack/plugins/observability_solution/observability/server/routes/assistant/route.ts
+++ b/x-pack/plugins/observability_solution/observability/server/routes/assistant/route.ts
@@ -13,6 +13,7 @@ const getObservabilityAlertDetailsContextRoute = createObservabilityServerRoute(
   endpoint: 'GET /internal/observability/assistant/alert_details_contextual_insights',
   options: {
     tags: [],
+    access: 'internal',
   },
   params: t.type({
     query: alertDetailsContextRt,
diff --git a/x-pack/plugins/observability_solution/observability/server/routes/rules/route.ts b/x-pack/plugins/observability_solution/observability/server/routes/rules/route.ts
index c33f58f6ea75f..909b11cb713a9 100644
--- a/x-pack/plugins/observability_solution/observability/server/routes/rules/route.ts
+++ b/x-pack/plugins/observability_solution/observability/server/routes/rules/route.ts
@@ -13,6 +13,7 @@ const alertsDynamicIndexPatternRoute = createObservabilityServerRoute({
   endpoint: 'GET /api/observability/rules/alerts/dynamic_index_pattern 2023-10-31',
   options: {
     tags: [],
+    access: 'public',
   },
   params: t.type({
     query: t.type({